This PR was merged into the 4.4 branch.
Discussion
----------
[DependencyInjection] Support for intersection types
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | #41552
| License | MIT
| Doc PR | N/A
Commits
-------
d28cf24258 [DependencyInjection] Support for intersection types
This PR was merged into the 4.4 branch.
Discussion
----------
[VarDumper] Support for intersection types
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | #41552
| License | MIT
| Doc PR | N/A
Commits
-------
3cf105766a [VarDumper] Support for intersection types
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Cache] Support decorated Dbal drivers in PdoAdapter
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Explanation in this PR
| License | MIT
Doctrine v3 supports middleware for Drivers. Upon creating the Connection, `middleware->wrap(Driver): Driver` [is called](https://github.com/doctrine/dbal/blob/3.1.x/src/DriverManager.php#L210), in which the middleware can wrap/decorate the Driver class. So that it can perform tracing [for example](https://github.com/getsentry/sentry-symfony/blob/master/src/Tracing/Doctrine/DBAL/TracingDriverMiddleware.php#L37).
When this happens, the Driver class inside the Connection is no longer one of Doctrine's well known Driver classes. The `PdoAdapter ` uses this class to determine the database platform. Which breaks once the Driver is decorated and no longer one of the classes [listed](https://github.com/symfony/symfony/blob/5.4/src/Symfony/Component/Cache/Adapter/PdoAdapter.php#L452) in the `PdoAdapter`.
Since Dbal exposes this middleware as a feature, I think it would be nice for the `PdoAdapter` to support this.
To solve this, the `getDatabasePlatform` can be used. This returns a `Doctrine\DBAL\Platforms\AbstractPlatform` which defines the abstract method `getName`. This returns a value very similar to the list in the `PdoAdapter`. The names don't match exactly, so therefor a small mapping is done to get right the name used in the adapter. As far as a I know, there'd be no other implications with this change.
Related: https://github.com/getsentry/sentry-symfony/issues/530
Commits
-------
58d74e30be [Cache] Support decorated Dbal drivers in PdoAdapter
This PR was merged into the 4.4 branch.
Discussion
----------
[GHA] Clarify some bits in the deps=high script
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix -
| License | MIT
| Doc PR |
I had some difficulty understanding how flipped tests worked. Luckily, `@nicolas`-grekas was available to answer some questions. However, I'm sure that I've forgotten the logic in about a week time, so I think it's worth clarifying the code a bit (but feel free to close if it's just me).
Commits
-------
ff08dcaca6 [GHA] Clarify some bits in the deps=high script
This PR was merged into the 4.4 branch.
Discussion
----------
Add 5.3 in github PR template
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Right time now :)
Commits
-------
327014b104 Add 5.3 in github PR template
Christian Flothmann
Nicolas Grekas
Tobias Schultze
Jeroeny
Alexander M. Turek
Fabien Potencier
Wouter de Jong
Jérémy Derussé
Tobias Nyholm
Robin Chalas
Antoine Makdessi
Jakub Zalas