Commit Graph

16824 Commits

Author SHA1 Message Date
Fabien Potencier 71dc07ce08 feature #10466 [Debug] add a screaming mode to ErrorHandler (nicolas-grekas)
This PR was merged into the 2.5-dev branch.

Discussion
----------

[Debug] add a screaming mode to ErrorHandler

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

Collect and display silenced PHP errors in the debug toolbar.

Commits
-------

5cc817d [Debug] add a screaming mode to ErrorHandler
2014-03-17 16:55:06 +01:00
Fabien Potencier 02088bc62f fixed CS 2014-03-17 16:43:11 +01:00
Fabien Potencier 433a13aef7 minor #10470 [server:run] [#10461] Add docs about custom environment (WouterJ)
This PR was merged into the 2.3 branch.

Discussion
----------

[server:run] [#10461] Add docs about custom environment

| Q             | A
| ------------- | ---
| Fixed tickets | #10461, https://github.com/symfony/symfony-docs/issues/3688
| License       | MIT

It's better to document this specific usecase in the command help.

Commits
-------

6871a61 [#10461] Add docs about custom environment
2014-03-17 16:42:55 +01:00
Fabien Potencier c152ccb5b6 minor #10469 fix doc block and namespace by @insekticide (cordoval)
This PR was merged into the 2.5-dev branch.

Discussion
----------

fix doc block and namespace by @insekticide

|Q            |A     |
|---          |---   |
|Bug Fix?     |yes   |
|New Feature? |no    |
|BC Breaks?   |no    |
|Deprecations?|no    |
|Tests Pass?  |yes   |
|Fixed Tickets|#10464|
|License      |MIT   |
|Doc PR       |      |

Commits
-------

89bde6e fix class namespace by @insekticid and doc block fix
2014-03-17 16:29:53 +01:00
Wouter J 6871a614b9 [#10461] Add docs about custom environment 2014-03-17 16:16:17 +01:00
Nicolas Grekas 5cc817d1bd [Debug] add a screaming mode to ErrorHandler 2014-03-17 14:44:56 +00:00
Luis Cordova 89bde6e03b fix class namespace by @insekticid and doc block fix 2014-03-17 07:23:37 -07:00
Fabien Potencier 2193f3db39 minor #10460 Typo fix at UploadedFile.php documentation (jbruni)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #10460).

Discussion
----------

Typo fix at UploadedFile.php documentation

Commits
-------

ced3f04 Typo fix at UploadedFile.php documentation
2014-03-16 09:02:28 +01:00
J Bruni d02e2aa7e8 Typo fix at UploadedFile.php documentation 2014-03-16 09:02:27 +01:00
Fabien Potencier 48c9985e73 feature #10451 [TwigBundle] Add possibility to generate absolute assets urls (romainneutron)
This PR was merged into the 2.5-dev branch.

Discussion
----------

[TwigBundle] Add possibility to generate absolute assets urls

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/3683

This is another approach of #7722

 - [x] Add unit tests
 - [x] Update doc

Commits
-------

76b8851 [TwigBundle] Add possibility to generate absolute assets urls
2014-03-15 09:47:57 +01:00
Fabien Potencier 5d25c8dd4e bug #10455 [2.3][Process] Fix random failures in test suite on TravisCI (romainneutron)
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3][Process] Fix random failures in test suite on TravisCI

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

783e377 [Process] Avoid failures because of slow IOs
238565e [Process] Avoid failure because of a slow process
173f8c5 [Process] Avoid failure when calling Process::stop in edge cases
2014-03-15 09:46:55 +01:00
Fabien Potencier a635c4f9a3 bug #10456 [Process] Handle idle timeout and disabled output conflict (romainneutron)
This PR was merged into the 2.5-dev branch.

Discussion
----------

[Process] Handle idle timeout and disabled output conflict

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10453
| License       | MIT
| Doc PR        | WIP (a note should be added in the doc)

Commits
-------

ae84810 [Process] Increase tests speed
40c08c6 [Process] Handle idle timeout and disable output conflict
2014-03-15 09:40:48 +01:00
Romain Neutron 783e377eed [Process] Avoid failures because of slow IOs
See example of failure here https://travis-ci.org/symfony/symfony/jobs/20701462
2014-03-14 19:58:01 +01:00
Romain Neutron ae8481038e [Process] Increase tests speed 2014-03-14 19:46:29 +01:00
Romain Neutron 40c08c640e [Process] Handle idle timeout and disable output conflict 2014-03-14 19:08:20 +01:00
Romain Neutron 238565e93a [Process] Avoid failure because of a slow process
See example of failure here https://travis-ci.org/symfony/symfony/jobs/20761834.
2014-03-14 18:34:18 +01:00
Romain Neutron 173f8c5fd2 [Process] Avoid failure when calling Process::stop in edge cases
See https://travis-ci.org/symfony/symfony/jobs/20664994 for an example of failure.
2014-03-14 18:34:18 +01:00
Romain Neutron 76b88511a6 [TwigBundle] Add possibility to generate absolute assets urls 2014-03-14 14:43:21 +01:00
Fabien Potencier 123dcac063 minor #10436 Update DefaultAuthenticationSuccessHandler.php (ureimers)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #10436).

Discussion
----------

Update DefaultAuthenticationSuccessHandler.php

[Security] [Http] [Authentication] Fixed class description of DefaultAuthenticatioNSuccessHander

| Q             | A
| ------------- | ---
| Fixed tickets | none
| License       | MIT

Commits
-------

b458551 Update DefaultAuthenticationSuccessHandler.php
2014-03-14 13:21:43 +01:00
ureimers 7fc0c5f1fd Update DefaultAuthenticationSuccessHandler.php 2014-03-14 13:21:43 +01:00
Fabien Potencier 1e973b2a9a feature #10404 [Security] Match request based on HTTP methods in firewall config (danez)
This PR was submitted for the 2.4 branch but it was merged into the 2.5-dev branch instead (closes #10404).

Discussion
----------

[Security] Match request based on HTTP methods in firewall config

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#3681

For an api I had to work on, I was in the need to have different firewalls for different HTTP Methods. I started building my own ```RequestMatcher``` until I discovered, that the regular RequestMatcher is able to handle HTTP Methods. The only thing that is missing is the possibility to configure it in the firewall section of the configuration. (For access_control it is already possible)

With this PR it is possible to do things like this:
```yaml
security:
    firewalls:
        api_options:
            pattern:    ^/
            methods:    [OPTIONS]
            security:   false
        api:
            pattern:    ^/
            some_auth:  true
```

I think this integrates quite nicely. Or is there any downside you can think of?

If it is good to go, I'll open a PR for the docs.

Commits
-------

2878757 Make it possible to match the request based on HTTP methods in the firewall configuration
2014-03-14 12:27:42 +01:00
Daniel Tschinder a8e9ed5cf1 Make it possible to match the request based on HTTP methods in the firewall configuration 2014-03-14 12:27:42 +01:00
Fabien Potencier f0c0c2c99d tweaked sentence 2014-03-14 12:08:56 +01:00
Fabien Potencier fe91a2ca62 bug #10448 [2.3][Process] Fix quoted arguments escaping (romainneutron)
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3][Process] Fix quoted arguments escaping

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This PR replaces #8972

Commits
-------

de681cb [Process] Add tests on ProcessUtils::escapeArgument
85fb495 [Process] Fix: Arguments including space and quote are not correctly escaped (win)
2014-03-14 12:05:38 +01:00
Fabien Potencier 79e92f95d6 bug #10444 [DomCrawler] Fixed incorrect value name conversion in getPhpValues() and getPhpFiles() (romainneutron)
This PR was merged into the 2.3 branch.

Discussion
----------

[DomCrawler] Fixed incorrect value name conversion in getPhpValues() and getPhpFiles()

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6908
| License       | MIT

This PR replaces #10193

Commits
-------

89c599e [DomCrawler] Add tests for recursive cases of getPhpValues() and getPhpFiles()
e961f57 [DomCrawler] Fixed incorrect value name conversion in getPhpValues() and getPhpFiles()
2014-03-14 12:04:24 +01:00
Fabien Potencier bdddf3ab8c fixed typo 2014-03-14 11:12:00 +01:00
Romain Neutron de681cbf5c [Process] Add tests on ProcessUtils::escapeArgument 2014-03-14 10:50:34 +01:00
Michal Gebauer 85fb495a30 [Process] Fix: Arguments including space and quote are not correctly escaped (win)
Bad
`"bin" "command" \""bin"\"" "\""another command"\"`

Better
`"bin" "command" "\"bin" \"another command\""`
2014-03-14 10:10:26 +01:00
Fabien Potencier 9213a821d5 minor #10447 [Config][Loader] Code style fix (kdauzickas)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #10447).

Discussion
----------

[Config][Loader] Code style fix

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

6d84c04 Minor style fix
2014-03-14 08:52:52 +01:00
Karolis Daužickas a8fcc416b8 Minor style fix 2014-03-14 08:52:52 +01:00
Fabien Potencier c2c048edf1 minor #10445 [2.4][HttpFoundation] Add dev-dependency on Symfony Expression-Language for unit tests (romainneutron)
This PR was merged into the 2.4 branch.

Discussion
----------

[2.4][HttpFoundation] Add dev-dependency on Symfony Expression-Language for unit tests

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This component is needed to test ExpressionRequestMatcher.
This PR replaces #10440

Commits
-------

5d704d9 [HttpFoundation] Add dev-dependency on Symfony Expression-Language for unit tests
2014-03-13 19:11:45 +01:00
Romain Neutron 5d704d906b [HttpFoundation] Add dev-dependency on Symfony Expression-Language for unit tests
This component is needed to test ExpressionRequestMatcher
2014-03-13 17:54:12 +01:00
Romain Neutron 89c599e5b7 [DomCrawler] Add tests for recursive cases of getPhpValues() and getPhpFiles() 2014-03-13 17:35:57 +01:00
Fabien Potencier 120a7e99d7 bug #10443 [FrameworkBundle] Use DIC parameter as default host value if available (romainneutron)
This PR was merged into the 2.5-dev branch.

Discussion
----------

[FrameworkBundle] Use DIC parameter as default host value if available

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

This follows #10439

Commits
-------

85a2fbf [FrameworkBundle] Use DIC parameter as default host value if available
2014-03-13 17:31:53 +01:00
Robbert Klarenbeek e961f570b1 [DomCrawler] Fixed incorrect value name conversion in getPhpValues() and getPhpFiles() 2014-03-13 17:06:21 +01:00
Romain Neutron 85a2fbf27c [FrameworkBundle] Use DIC parameter as default host value if available 2014-03-13 16:54:59 +01:00
Fabien Potencier b7c158a831 feature #10439 [FrameworkBundle] Add posibility to specify method and host in router:match command (romainneutron)
This PR was merged into the 2.5-dev branch.

Discussion
----------

[FrameworkBundle] Add posibility to specify method and host in router:match command

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Replaces #9340

Commits
-------

acc66b9 [FrameworkBundle] Add posibility to specify method and host in router:match command
2014-03-13 14:44:14 +01:00
pmartelletti acc66b9d72 [FrameworkBundle] Add posibility to specify method and host in router:match command 2014-03-13 14:26:26 +01:00
Fabien Potencier 172bbb1c73 updated LICENSE year 2014-03-13 07:25:45 +01:00
Fabien Potencier 1d19ca2395 Merge branch '2.3' into 2.4
* 2.3:
  [Config] made a condition more explicit
  convertDomElementToArray should handle zero values
  prefixed http:// to url output on server:run command in order to make it clickable
  Fixed data in pipe being truncated if not read before process termination
2014-03-13 06:40:32 +01:00
Fabien Potencier c14d67c11d [SecurityBundle] changed a hardcoded string to its constant equivalent 2014-03-13 06:12:30 +01:00
Fabien Potencier ea0598ae78 minor #10390 [Security] Add constants for access decision strategies (c960657)
This PR was merged into the 2.5-dev branch.

Discussion
----------

[Security] Add constants for access decision strategies

I suggest adding constants for the three access decision strategies (affirmative, consensus, unanimous).

They are difficult to spell, and without constants they are difficult to identify when reading the code.

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

5d6ef00 Add class constants for access decision strategies.
2014-03-13 06:11:00 +01:00
Fabien Potencier cbc2f9fd36 [Config] made a condition more explicit 2014-03-13 06:07:25 +01:00
Fabien Potencier 5368066a5a bug #10423 [Config] XmlUtils::convertDomElementToArray does not handle '0' (bendavies)
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes #10423).

Discussion
----------

[Config] XmlUtils::convertDomElementToArray does not handle '0'

`XmlUtils::convertDomElementToArray` does not handle `0` as a value of a text node, and interprets it as `null`.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | maybe? (if someone is depending on the previous behaviour.)
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT

Commits
-------

e56ac59 convertDomElementToArray should handle zero values
2014-03-13 06:06:04 +01:00
Ben Davies 34720c921e convertDomElementToArray should handle zero values 2014-03-13 06:06:04 +01:00
Fabien Potencier 1e0fea61e8 minor #10432 clean up framework bundle commands (cordoval)
This PR was merged into the 2.5-dev branch.

Discussion
----------

clean up framework bundle commands

|Q            |A  |
|---          |---|
|Bug Fix?     |no |
|New Feature? |no |
|BC Breaks?   |no |
|Deprecations?|no |
|Tests Pass?  |yes|
|Fixed Tickets|   |
|License      |MIT|
|Doc PR       |na |

Commits
-------

0984313 clean up commands from framework bundle
2014-03-13 06:03:27 +01:00
Luis Cordova 09843131ba clean up commands from framework bundle 2014-03-12 23:58:17 -05:00
Fabien Potencier e8dadd5398 minor #10431 adding http:// to server:run output to make it clickable (cordoval)
This PR was merged into the 2.3 branch.

Discussion
----------

adding http:// to server:run output to make it clickable

|Q            |A  |
|---          |---|
|Bug Fix?     |yes  |
|New Feature? |n  |
|BC Breaks?   |n  |
|Deprecations?|n  |
|Tests Pass?  |n  |
|Fixed Tickets| #10430  |
|License      |MIT|
|Doc PR       |  no |

Commits
-------

6498518 prefixed http:// to url output on server:run command in order to make it clickable
2014-03-13 05:50:58 +01:00
Luis Cordova 6498518925 prefixed http:// to url output on server:run command in order to make it clickable 2014-03-12 20:16:46 -05:00
Fabien Potencier 3d0913464d bug #10153 [Process] Fixed data in pipe being truncated if not read before process termination (astephens25)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Fixed data in pipe being truncated if not read before process termination

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #9409
| License       | MIT
| Doc PR        | N/A

This is a repeat of the botched pull request #9630.

Commits
-------

7e51913 Fixed data in pipe being truncated if not read before process termination
2014-03-12 19:39:04 +01:00