This PR was merged into the 5.0-dev branch.
Discussion
----------
[FrameworkBundle] Added type declarations where possible
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #32179
| License | MIT
| Doc PR | N/A
Commits
-------
377f5ed8ba [FrameworkBundle] Added type declarations where possible.
This PR was merged into the 5.0-dev branch.
Discussion
----------
[DoctrineBridge] add parameter type declarations where possible
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | part of #32179
| License | MIT
| Doc PR |
Commits
-------
26634645d3 add parameter type declarations where possible
This PR was merged into the 4.4 branch.
Discussion
----------
[Messenger][Profiler] Attempt to give more useful source info when using HandleTrait
| Q | A
| ------------- | ---
| Branch? | 4.4 <!-- see below -->
| Bug fix? | no
| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | N/A
### Before
<img width="1052" alt="Capture d’écran 2019-07-25 à 15 02 03" src="https://user-images.githubusercontent.com/2211145/61883193-3e318300-aefa-11e9-9179-a40c7c5aac93.png">
### After
<img width="1054" alt="Capture d’écran 2019-07-25 à 14 59 27" src="https://user-images.githubusercontent.com/2211145/61883192-3d98ec80-aefa-11e9-8f29-df9c417e8025.png">
which works for both examples using the trait in https://symfony.com/doc/current/messenger/handler_results.html
Commits
-------
9ac7e4223c [Messenger][Profiler] Attempt to give more useful source info when using HandleTrait
This PR was merged into the 4.4 branch.
Discussion
----------
[Messenger][Profiler] Collect the stamps at the end of dispatch
| Q | A
| ------------- | ---
| Branch? | 4.4 <!-- see below -->
| Bug fix? | no
| New feature? | yes <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | N/A
Currently, only the stamps added before dispatching the message are shown in the profiler.
This PR adds a section to show stamps after dispatch (`HandledStamp`, `SentStamp`, ...).
![Capture d’écran 2019-07-23 à 15 44 04](https://user-images.githubusercontent.com/2211145/61717102-bb28f500-ad60-11e9-93ec-bb2875d176ce.png)
Commits
-------
ee68b1dfa7 [Messenger][Profiler] Collect the stamps at the end of dispatch
This PR was merged into the 5.0-dev branch.
Discussion
----------
[Form] remove the deprecated scale option of the IntegerType
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
47881a6c35 remove the deprecated scale option of the IntegerType
This PR was merged into the 4.2 branch.
Discussion
----------
[DoctrineBridge] add parameter type declarations to private methods
| Q | A
| ------------- | ---
| Branch? | 4.2
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
8157db4522 add parameter type declarations to private methods
This PR was merged into the 4.4 branch.
Discussion
----------
[VarDumper] added support for Imagine/Image
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
---
![image](https://user-images.githubusercontent.com/408368/61811135-19c5a000-ae41-11e9-88f1-9f5823e9ca80.png)
Commits
-------
c8d420ddff [VarDumper] added support for Imagine/Image
This PR was merged into the 4.3 branch.
Discussion
----------
[Inflector] Fix pluralizing words ending with "son"
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #32713
| License | MIT
| Doc PR | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/roadmap):
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against branch 4.4.
- Legacy code removals go to the master branch.
-->
Commits
-------
bf608aaf3c Fix pluralizing "season"
This PR was merged into the 5.0-dev branch.
Discussion
----------
[Yaml] add some missing type declarations
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
f2a4a199b2 add some missing type declarations
This PR was submitted for the master branch but it was merged into the 4.4 branch instead (closes#32736).
Discussion
----------
[Console] avoid using huge amount of memory when formatting long exception
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | none
| License | MIT
When formatting exceptions, `preg_split('//u')` is used to iterate over utf8 characters. When the exception is long, the amount of memory used is huge and can reach `memory_limit`.
This PR uses a `Generator` to iterate over the string instead of splitting it, thus reducing the amount of memory.
Commits
-------
47ffbad82d Avoid using huge amount of memory when formatting long exception
* 4.4:
[VarDumper] Add missing changelog entry for VarDumperTestTrait::setUpVarDumper()
[Mailer] Make transport factory test case public
Typo in variable name
use a reference date to handle times during DST
This PR was merged into the 4.4 branch.
Discussion
----------
[Mailer] Make transport factory test case public
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes, failures looks like irrelevant
| Fixed tickets | -
| License | MIT
| Doc PR | -
`TransportFactoryTestCase` could be useful when you adding custom transport and need cover their transport factory with tests.
Commits
-------
5d64009ae0 [Mailer] Make transport factory test case public
This PR was merged into the 4.4 branch.
Discussion
----------
Typo in variable name
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR |
Refs #32587
Commits
-------
784d1d0 Typo in variable name
This PR was merged into the 4.4 branch.
Discussion
----------
[Form] use a reference date to handle times during DST
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | #18366
| License | MIT
| Doc PR |
Commits
-------
39c98b9a08 use a reference date to handle times during DST
This PR was squashed before being merged into the 5.0-dev branch (closes#32714).
Discussion
----------
[TwigBundle] Add missing CHANGELOG entries and remove deprecated templates
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Follow up https://github.com/symfony/symfony/pull/32696,
Require merge 4.4 into master after https://github.com/symfony/symfony/pull/32695 to make WebProfilerBundle work properly in master.
Commits
-------
02228605d0 [TwigBundle] Add missing CHANGELOG entries and remove deprecated templates
This PR was merged into the 4.4 branch.
Discussion
----------
[WebProfilerBundle] Rename the new exception controller and mark it as internal
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/32695#discussion_r306965799
| License | MIT
| Doc PR | -
I missed some important details in https://github.com/symfony/symfony/pull/32695
Commits
-------
ba24a51ea4 Rename the new exception controller and mark it as internal
This PR was merged into the 4.4 branch.
Discussion
----------
[TwigBundle] Update tests inline with master version
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/32714#discussion_r306945146
| License | MIT
| Doc PR | -
Preparing to remove the `Resources/views` for TwigBundle in master branch
https://github.com/symfony/symfony/pull/32714
/cc @Tobion
Commits
-------
28a7ab8048 [TwigBundle] Update tests inline with master version
This PR was squashed before being merged into the 4.4 branch (closes#32637).
Discussion
----------
[ErrorHandler] Decouple from ErrorRenderer component
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | part of https://github.com/symfony/symfony/issues/32605
| License | MIT
| Doc PR | -
built on top of https://github.com/symfony/symfony/pull/32636 (See 2nd commit only)
Commits
-------
8f13fc013d [ErrorHandler] Decouple from ErrorRenderer component
This PR was squashed before being merged into the 4.4 branch (closes#32609).
Discussion
----------
[Mailer][DX][RFC] Rename mailer bridge transport classes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yno
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
During working on #31946 I realized how painful to work with multiple classes which has same name. [Nice article](https://www.tomasvotruba.cz/blog/2019/05/02/alias-as-a-code-smell/) by @TomasVotruba with explanation of problems with such approach.
~Built on top of #32608 , so only [2nd commit](bbf7e99e89) is actual.~
Also I've changed namespaces to make bridge structure much simpler and be linear. All classes located on same level now. See how [bridge](bbf7e99e89/src/Symfony/Component/Mailer/Bridge/Amazon) looks like now.
Now in RFC state to get approve for such king of changes and update all other bridges.
Commits
-------
eda4f01e0e [Mailer][DX][RFC] Rename mailer bridge transport classes
* 4.4:
relax some assertions to make tests forward compatible
skip updated ChoiceType tests on older versions
fix typo
make tests forward compatible with DI 4.4
fix test
fix expected exception message regex
Fix multiSelect ChoiceQuestion when answers have spaces