This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10841).
Discussion
----------
[DomCrawler] Fixed image input case sensitive
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? |
| Fixed tickets |
| License | MIT
| Doc PR |
I'm currently testing the payment workflow in a project. The problem is that when I reach the credit card type selection (CB, VISA ...) I cannot submit the desired one because its name is in uppercase (take a look at the screenshot).
![](http://s22.postimg.org/oz5cm3fwh/example.png)
Commits
-------
ab1198f [DomCrawler] Fixed image input case sensitive
This PR was merged into the 2.3 branch.
Discussion
----------
Lower mbstring dep, remove it for Yaml and CssSelector components
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Commits
-------
a4b805d Lower mbstring dep, remove it for Yaml and CssSelector components
This PR was squashed before being merged into the 2.3 branch (closes#10714).
Discussion
----------
[Console]Improve formatter for double-width character
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | yes for one that expecting current broken output
| Deprecations? | no
| Fixed tickets |
| Tests pass? | yes
| License | MIT
| Doc PR |
EDIT: fixed the table above not to remove irrelevant line
As mb_strlen just returns "how many chars in the string",
formatting with double-width character is bit broken.
The test I add is skipped when mbstring extension is not loaded.
I'm afraid if some of you cannot properly display japanese string.
(表示するテキスト just means "Some text to display")
Commits
-------
a52f41d [Console]Improve formatter for double-width character
This PR was merged into the 2.3 branch.
Discussion
----------
[Form] Fixed TrimListenerTest as of PHP 5.5
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
b0bc83d [Form] Fixed TrimListenerTest as of PHP 5.5
This PR was merged into the 2.3 branch.
Discussion
----------
[BrowserKit] Allow URLs that don't contain a path when creating a cookie from a string
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The Cookie class doesn't require a path, but the `fromString()` static method does, so when URL given is something like http://www.example.com (ie no trailing slash) it currently throws an exception. This PR removes the requirement.
Commits
-------
fc1223f Allow URLs that don't contain a path
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10863).
Discussion
----------
[Security] Add check for supported attributes in AclVoter
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Couldn't get the tests to pass but the issues where unrelated to change.
This fixes issues with Attribute containing ExpressionLanguage instance when using allow_if.
Commits
-------
a605a3d [Security] Add check for supported attributes in AclVoter
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10856).
Discussion
----------
Added more IDE links
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/issues/3835
Commits
-------
239b738 Added more IDE links
This PR was merged into the 2.3 branch.
Discussion
----------
DependencyInjection] Fix parameter description in ConfigurationExtensionInterface
| Q | A
| ------------- | ---
| Fixed tickets | #10845
| License | MIT
This fixes the description of parameter `array $config` in file [ConfigurationExtensionInterface.php](https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/DependencyInjection/Extension/ConfigurationExtensionInterface.php) by removing the extra `$config`.
Commits
-------
93544aa [DependencyInjection] Fix parameter description in ConfigurationExtensionInterface
| Q | A
| ------------- | ---
| Fixed tickets | #10845
| License | MIT
This fixes the description of parameter `array $config` in file ConfigurationExtensionInterface.php by removing the extra `$config`.
This PR was merged into the 2.3 branch.
Discussion
----------
[TwigBridge][Transchoice] set %count% from the current context.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | [no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8408
| License | MIT
Commits
-------
8f7b2cc [TwigBridge][Transchoice] set %count% from the current context.
This PR was merged into the 2.3 branch.
Discussion
----------
Finder typehint fix
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
f3b0ef1 [Finder] fixed typehint of the Finder::addAdapter() method
This PR was merged into the 2.3 branch.
Discussion
----------
Fix a test that was ambiguous
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | see #9634 for a discussion of this and #9383 for the report
| License | MIT
| Doc PR | n/a
This PR fixes a test that was always passing as the exception catch was catching the PHP notice but also the exception sent by `fail`, so it was useless. That said, I'm not even convinced that this test is useful at all.
Commits
-------
a94b4e0 [Validator] fixed wrong test
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3] Fix phpunit test suite on travis #2
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10821
| License | MIT
This is a second approach to solve #10821.
Something is weird: `Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest` passes when using PHPUnit as phar and fails when using a composer global install
Commits
-------
32e5f67 [DependencyInjection] Fix travis unit tests
c7befd5 Update PHPUnit before run
This PR was merged into the 2.3 branch.
Discussion
----------
[WebProfilerBundle] Fixed profiler seach/homepage with empty token
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10806
| License | MIT
| Doc PR | none
Commits
-------
16dd0e5 [WebProfilerBundle] added test case for #107735b91e70 [WebProfilerBundle] fixed profiler homepage, fixed#108067b425d2 [WebProfilerBundle] Added test case for #10806
This PR was merged into the 2.3 branch.
Discussion
----------
changed travis to run on the nightly builds of HHVM until everything gets stable
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
As HHVM is not stable enough yet to run Symfony, let's test on the HHVM nightly builds. It will allow us to get a better feeling of the remaining problems with HHVM. ping @deguif
Commits
-------
e93cbd7 changed travis to run on the nightly builds of HHVM until everything gets stable
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10815).
Discussion
----------
Fixed issue #5427
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5427
| License | MIT
Commits
-------
f308f52 Fixed issue #5427
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] fix#10313: FlattenException not found
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10313
| License | MIT
| Doc PR | none
Note that this patch should be ignored while merging into 2.5/master (it will conflict because 2.5/master has a much stronger workaround, not suitable for a minor release IMHO).
Commits
-------
b147cfa [Debug] fix#10313: FlattenException not found because of https://bugs.php.net/42098
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] fix ErrorHandlerTest when context is not an array
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Commits
-------
988a5dc [Debug] fix ErrorHandlerTest when context is not an array
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Allow File instance to be passed to BinaryFileResponse
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10608
| License | MIT
| Doc PR |
See https://github.com/symfony/symfony/issues/10608 for discussion and reasoning.
The docblocks get rather long with this change. The File class does extend SplFileObject so technically it could be left out of the docblock if that is more desirable.
Commits
-------
fc04ad2 Allow File instance to be passed to BinaryFileResponse
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#10644).
Discussion
----------
Add upgrade instructions for the LoggerInterface that changed in Symfony 2.2
Commits
-------
6daa295 Add upgrade instructions for the LoggerInterface
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10643).
Discussion
----------
[TwigBridge] Removed strict check when found variables inside a translation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no?
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10638
| License | MIT
Commits
-------
074191e Removed strict check when found variables inside a translation
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] Fixed the rendering of exceptions on HHVM with a terminal width
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
If ``getTerminalWidth`` returns a big integer (which is the case in Behat 2.5 which overwrites the method to return ``PHP_INT_MAX`` to avoid limiting the width), the fix done in #10000 for HHVM would be needed as well. So this moves it after the condition rather than having it only for the default.
Commits
-------
6e57380 [Console] Fixed the rendering of exceptions on HHVM with a terminal width