Commits
-------
a9d8197 Removing the security_factories.xml file - not needed after sha: 413756c103
Discussion
----------
Removing the security_factories.xml file - not needed after sha: 413756c...
Hi guys!
This is just a left-over file. See sha: 413756c103
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Thanks!
Commits
-------
e509e6f Skip PDOSessionHandlerTest if PDO SQLite is not available
Discussion
----------
Skip PDOSessionHandlerTest if PDO SQLite is not available
Commits
-------
128ac26 Added missing '%' in DI component README
Discussion
----------
Added missing '%' in DI component README
---------------------------------------------------------------------------
by ruian at 2012-04-21T10:37:12Z
@fabpot PR ok
Commits
-------
4a9a9d6 fixed typo
167597c removed unused use statement
Discussion
----------
typo fixes
---------------------------------------------------------------------------
by ruian at 2012-04-21T10:24:04Z
@fabpot this one is Ok just some typos and a useless Namespace using
Commits
-------
ffc074b [Profiler] Fixed IE7 JavaScript errors
Discussion
----------
[Profiler] Fixed IE7 JavaScript errors
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Requires merge of another [PR](https://github.com/doctrine/DoctrineBundle/pull/61) available on the `doctrine/DoctrineBundle` repository (compatibility changes to `db.html.twig`).
---------------------------------------------------------------------------
by fabpot at 2012-04-20T14:15:22Z
That does not work for me.
Commits
-------
7ddc8cb [FrameworkBundle] Monitor added/removed translations files in dev (fix#3653)
Discussion
----------
[FrameworkBundle] Monitor added/removed translations files in dev
fix#3653
---------------------------------------------------------------------------
by Koc at 2012-04-20T14:09:55Z
maybe you also can fix#971 ?
Commits
-------
3937561 [FrameworkBundle] Look for translations in %kernel.root_dir%/Resources/%bundle%/translations (fix#4018)
Discussion
----------
[FrameworkBundle] Look for translations in %kernel.root_dir%/Resources/%...
...bundle%/translations (fix#4018)
I will submit a PR to the docs.
Commits
-------
a72d7ef ignore composer.phar
ddca4bb Update CHANGELOG-2.1.md
Discussion
----------
[Global] ignore composer.phar
for running unit tests the external dependencies are managed using composer (since aa055dfd98), so it's necessary to download composer.phar to install them. We don't want composer.phar to be comitted to the codebase so it's necessary to ignore it.
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
---------------------------------------------------------------------------
by Seldaek at 2012-04-20T13:19:29Z
I agree it should be ignored, but you also probably should install it somewhere globally on your machine and put that in the PATH so you have it everywhere and don't need 300 copies of it. Incidentally it would also not require you to gitignore it since it would be outside of the git dirs.
---------------------------------------------------------------------------
by tonypiper at 2012-04-20T13:24:56Z
I was going to revise the documentation for running tests and your approach would, of course, be best but I thought a belt-and-braces approach wouldn't hurt...
Commits
-------
01ca0ad [Propel1] Added security layer
Discussion
----------
[Propel1] Added security layer
Fixed the security layer for Propel 1.6, and Symfony2 2.1.
The PropelBundle is ready to go: https://github.com/propelorm/PropelBundle/pull/139
Unit tests are part of the PropelBundle at the moment, as it requires to setup a quick builder.
Commits
-------
70a6de9 [EventDispatcher] Remove data property
4ff92b9 [EventDispatcher] Added generic event class.
Discussion
----------
[EventDispatcher] Added generic event class.
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
Provides a ready to go all purpose event object.
---------------------------------------------------------------------------
by Koc at 2012-04-04T17:53:41Z
What use case of this?
---------------------------------------------------------------------------
by drak at 2012-04-04T17:57:46Z
It generically fits observer pattern use for those who do not want to make a specific event class for each and every little thing. This is akin to EventArgs + a subject.
---------------------------------------------------------------------------
by fabpot at 2012-04-20T07:55:05Z
This is basically what we had in symfony 1.x.
Some comments:
* I would remove the `data` as it makes things more complex and more difficult to understand (as arguments is an array, you can put your data there too);
* I would use the standard `set`, `get`, `all`, ... methods for the `arguments` related methods
---------------------------------------------------------------------------
by drak at 2012-04-20T08:11:31Z
OK, I'll rework the class. Thank you for your consideration.
---------------------------------------------------------------------------
by drak at 2012-04-20T08:56:53Z
@fabpot - I did some work on the class, but it seemed strange to not use get/setArgument because there is another property, the subject. This is mentioned in the conventions guide:
```
For many relations where the convention does not apply, the following methods must be used instead (where XXX is the name of the related thing):
```
If you still want me to change it, let me know.
Commits
-------
496878c [Propel1] Removed useless require in autoload.php.dist
Discussion
----------
[Propel1] Removed useless require in autoload.php.dist
Since we have Composer, and a classmap, no need to trigger the Propel's autoloader
Commits
-------
9447b84 [Propel1] Allowed PropelObjectCollection only in CollectionToArrayTransformer
e43d0fa reverse transform into PropelObjectCollection
Discussion
----------
Propel transformer
Prefer this PR over #3966
Commits
-------
218813c [Finder] contains(), notContains()
33e119a Merge branch 'master' of https://github.com/symfony/symfony into finder_search_by_contents
082d86e [Finder] content(), notContent() methods
Discussion
----------
[Finder] search by contents
Bug fix: no
Feature addition: yes
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
Sometimes I need to search for files containing some text:
```
$finder
->content('lorem')->notContent('ipsum')
->content('/^Begining/m')->notContent('/the end$/m');
```
I don't know how to tests exceptions thrown by `file_get_contents()` calls.
---------------------------------------------------------------------------
by gajdaw at 2012-04-19T15:53:05Z
To keep it as close as possible to `name` and `notName`.
Commits
-------
94bee7a [Filesystem] symlink() creates target directories
Discussion
----------
[Filesystem] symlink() creates target directories
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes [](http://travis-ci.org/michal-pipa/symfony)
Fixes the following tickets: #3967
Todo: -
Changed symlink() method behavior to recursively create target directory if it does not exist. It makes Filesystem component methods more consistent since copy() does the same. It is also more convenient.
Also mirror() fails to create symlink in non-existent directory (if we don't want to change symlink(), than we need to fix mirror()).
Fixes: #3967
