Commit Graph

2361 Commits

Author SHA1 Message Date
Fabien Potencier
25c3fee1f2 [FrameworkBundle] removed obsolete code 2011-06-09 22:15:58 +02:00
Fabien Potencier
852a4c9c6a [Form] removed the file upload temporary storage feature
The current implementation is not ready for inclusion in 2.0. It has several
known problems (security, not possible to disable it, not "cloud-compatible",
...) and it's not a must have feature anyway.

Some references:

 * Security issue in FileType: https://github.com/symfony/symfony/issues/1001
 * Validation fails on file, still stored in TemporaryStorage: https://github.com/symfony/symfony/issues/908
 * Add a size argument & ability to configure TemporaryStorage: https://github.com/symfony/symfony/pull/748

This feature should be reworked and discussed for inclusion in 2.1.
2011-06-09 12:44:36 +02:00
Hugo Hamon
6e96accf3a [DoctrineBundle] fixed MetadataFactory::getMetadataForClass() to always return a ClassMetadataCollection object instead of NULL. 2011-06-09 11:13:42 +02:00
Fabien Potencier
d528b7481f fixed typo 2011-06-08 15:20:37 +02:00
Fabien Potencier
566511e9e7 moved some FormView methods to FormUtil where they really belongs 2011-06-08 14:07:04 +02:00
Fabien Potencier
1aabc5da64 fixed CS 2011-06-08 12:16:48 +02:00
Fabien Potencier
62e4342a86 fixed CS 2011-06-08 12:12:55 +02:00
Fabien Potencier
12dd52b00b [FrameworkBundle] removed the --without-debug option for cache:clear (it now inherits the debug flag from the parent Kernel) 2011-06-08 10:16:10 +02:00
Benjamin Eberlei
2a5449dcb0 [DoctrineBundle] added tests for registry 2011-06-08 08:48:49 +02:00
Fabien Potencier
879242cdf5 moved some Doctrine classes from the bundle to the bridge 2011-06-08 08:41:44 +02:00
Fabien Potencier
fbf36957e6 refactored Doctrine Bridge
* added a RegistryInterface

 * changed all classes to depend on the Registry instead of a specific EntityManager

This is more consistent as the validator already took the registry and this allows
to use any entity manager in Forms.
2011-06-08 08:35:48 +02:00
Fabien Potencier
84b25b1626 Merge remote branch 'beberlei/AsseticDirectoryResource'
* beberlei/AsseticDirectoryResource:
  [Assetic] Make AsseticExtension::createDirectoryResourceDefinition public, so that third party bundels can easilycreate definitions to search for assetic formulae in additional directories. LiipThemeBundle needs this to make the app/Resources/themes and Bundle/Resources/themes folder searchable. Without this change the whole method would need to be copy pasted. Since the method has no side-effects at all (only factory, not pushing into the container) this change is justifyable imho.
2011-06-07 23:04:57 +02:00
Benjamin Eberlei
d4e47a305b [Assetic] Make AsseticExtension::createDirectoryResourceDefinition public, so that third party bundels can easilycreate definitions to search for assetic formulae in additional directories. LiipThemeBundle needs this to make the app/Resources/themes and Bundle/Resources/themes folder searchable. Without this change the whole method would need to be copy pasted. Since the method has no side-effects at all (only factory, not pushing into the container) this change is justifyable imho. 2011-06-07 22:38:09 +02:00
Fabien Potencier
adc7904c33 [FrameworkBundle] fixed phpdoc 2011-06-07 19:49:03 +02:00
Fabien Potencier
aaf1300a20 merged hhamon/controller_getrequest_method 2011-06-07 19:48:40 +02:00
Fabien Potencier
97a745e973 Merge remote branch 'vicb/form-rendering-fix'
* vicb/form-rendering-fix:
  [Form] Fix accessibility for file inputs
  [FrameworkBundle] Fix the FormHelper phpDoc
  [FrameworkBundle][Form] Add some phpDoc for the FormHelper class
  [FrameworkBundle][Form] Fix label rendering
  [FrameworkBundle][Form] Fix rendering search inputs in PHP
  [Form] FormType labels should never have a for attribute
  [Form] Never render a view again
2011-06-07 19:46:20 +02:00
Fabien Potencier
74fbdc2fe2 Merge remote branch 'hhamon/typo_fix'
* hhamon/typo_fix:
  [FrameworkBundle] some typo fixes in phpdoc.
2011-06-07 19:39:03 +02:00
Fabien Potencier
2286452cc8 [DoctrineBundle] added a few aliases 2011-06-07 18:26:28 +02:00
Fabien Potencier
89f544afb6 moved Twig form templates to the Twig bridge 2011-06-07 16:38:23 +02:00
Fabien Potencier
1363068686 [FrameworkBundle] fixed phpdoc 2011-06-07 16:13:08 +02:00
Hugo Hamon
1c96ee672a [FrameworkBundle] some typo fixes in phpdoc. 2011-06-07 15:35:03 +02:00
Hugo Hamon
37b2df25bf [FrameworkBundle] Introduced a new Controller::getRequest() method to get the Request service from a controller. 2011-06-07 15:33:20 +02:00
Fabien Potencier
6737bd36bd [TwigBundle] made table_layout.html.twig useable as a trait 2011-06-07 13:52:58 +02:00
Fabien Potencier
41242dcc00 [DoctrineBundle] made XML/YAML mapping drivers more BC with their Doctrine counterparts
The ultimate goal is to move back these mapping dirvers to the Doctrine project.
2011-06-07 12:14:46 +02:00
Fabien Potencier
116e004f7d [DoctrineBundle] removed doctrine:generate:proxies as this command is never needed in a Symfony2 context 2011-06-07 12:01:07 +02:00
Fabien Potencier
b51d839ab8 removed duplicated test 2011-06-07 11:57:48 +02:00
Fabien Potencier
35c85a1547 added missing change from previous commit (sorry :() 2011-06-07 11:57:30 +02:00
Fabien Potencier
a17478ff74 tweaked previous commit 2011-06-07 11:48:08 +02:00
Fabien Potencier
96fc666454 simplified cache warmers
Here are the new simplified rules:

 * Required cache warmers are *always* executed when the Kernel boots for the first time;
 * Optional cache warmers are *only* executed from the CLI via cache:warmup

These new rules means that all the configuration settings for the cache
warmers have been removed. So, if you want the best performance, remember to
warmup the cache when going to production.

This also fixed quite a few bugs.
2011-06-07 11:42:27 +02:00
Fabien Potencier
5be0bafe7f removed TemplateReferenceInterface::getSignature() (replaced by the existing getLogicalName() which already acts as a unique identifier) 2011-06-07 10:12:38 +02:00
Fabien Potencier
5af7c7fffd moved TemplateFinder to CacheWarmer as it is only useful in this context 2011-06-07 09:39:41 +02:00
Fabien Potencier
125df3ab3b [DoctrineBundle] removed unneeded use statement 2011-06-07 09:06:58 +02:00
Fabien Potencier
22428b8b14 [DoctrineBundle] refactored Doctrine proxy cache warmer
* removed the dependency on the Container
* the proxy cache is now get from each entity manager configuration
2011-06-07 09:03:40 +02:00
Fabien Potencier
1c3fa20685 [DoctrineBundle] added Registry::getEntityManagers() 2011-06-07 08:53:04 +02:00
Fabien Potencier
85a381d048 [DoctrineBundle] added Registry::getConnections() 2011-06-07 08:53:03 +02:00
Fabien Potencier
2a5d7687b7 fixed Router cache warmer 2011-06-07 08:53:01 +02:00
Fabien Potencier
8618a27bf7 [DoctrineBundle] tweaked phpdoc 2011-06-07 08:44:59 +02:00
Victor Berchet
8d2974ce90 [Form] Fix accessibility for file inputs 2011-06-06 21:00:07 +02:00
Victor Berchet
c0355038cf [FrameworkBundle] Fix the FormHelper phpDoc 2011-06-06 21:00:07 +02:00
Victor Berchet
1196eb8e51 [FrameworkBundle][Form] Add some phpDoc for the FormHelper class 2011-06-06 20:12:37 +02:00
Victor Berchet
5044a7b56d [FrameworkBundle][Form] Fix label rendering
The label should not include the view 'id' attribute as it is used by the view widget.
2011-06-06 20:12:03 +02:00
Victor Berchet
61721e3fd4 [FrameworkBundle][Form] Fix rendering search inputs in PHP 2011-06-06 18:17:22 +02:00
Fabien Potencier
cb3390e9ae Merge remote branch 'gordonslondon/http-foundation/response'
* gordonslondon/http-foundation/response:
  [HttpFoundation] merge Response::isRedirected() with Response::isRedirect() - Response::isRedirected() has been removed
2011-06-06 18:06:51 +02:00
Victor Berchet
60c463d184 [Form] FormType labels should never have a for attribute 2011-06-06 18:04:07 +02:00
Victor Berchet
b12b11c131 [Form] Never render a view again
If some of the nested views are rendered individually they should not be rendered again when calling form_rest.
A typical would be when some nested file views are rendered, form_rest should not render them again.

It is still possible to render a label once the widget has been rendered. This is for checkboxes and radios
where the widget is typically rendered before the label.
2011-06-06 18:01:03 +02:00
Fabien Potencier
c3bf2037df Merge remote branch 'vicb/form-collection-rendering'
* vicb/form-collection-rendering:
  [Form] Fix collection rendering
2011-06-06 14:56:16 +02:00
Fabien Potencier
48733b927d [Swiftmailer] added the swiftmailer.plugin tag to automatically register Swiftmailer plugins 2011-06-06 14:48:42 +02:00
Fabien Potencier
a5daf4706a [SwiftmailerBundle] updated XSD 2011-06-06 14:43:36 +02:00
Victor Berchet
ef8cb967f5 Merge branch 'master' into form-collection-rendering 2011-06-06 14:39:18 +02:00
Fabien Potencier
b83aa9d006 [SwiftmailerBundle] fixed previous merge 2011-06-06 14:25:17 +02:00