This PR was submitted for the 4.3 branch but it was squashed and merged into the 4.4 branch instead (closes#32543).
Discussion
----------
[FrameworkBundle] add config translator cache_dir
| Q | A
| ------------- | ---
| Branch? | 4.4 (be careful when merging)
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #32542
| License | MIT
Now the parameter cache_dir of Translator constructor can be change or disable on config
```yaml
#framework.yaml
framework:
...
translator:
cache_dir: null #(cache disable)
...
```
Commits
-------
7613c7d1de [FrameworkBundle] add config translator cache_dir
This PR was merged into the 4.4 branch.
Discussion
----------
[Yaml] Add flag to dump NULL as ~
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/12071
This PR adds the ability to dump `null` as `~` by a new Flag `Yaml::DUMP_NULL_AS_TILDE`:
```diff
- foo: null
+ foo: ~
```
Todos:
- [x] Fix/add tests
Commits
-------
749c11d94c [Yaml] Add flag to dump NULL as ~
This PR was merged into the 3.4 branch.
Discussion
----------
[HttpFoundation] Revert getClientIp @return docblock
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/roadmap):
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against branch 4.4.
- Legacy code removals go to the master branch.
-->
This PR reverts https://github.com/symfony/symfony/pull/22418, see the comment https://github.com/symfony/symfony/pull/22418#issuecomment-513256687
Commits
-------
7568d3452d [HttpFoundation] Revert getClientIp @return docblock
* 4.3:
Fix tests on console
cs fix
Fix path to phpunit binary
[Yaml] PHP-8: Uncaught TypeError: abs() expects parameter 1 to be int or float, string given
* 3.4:
Fix tests on console
cs fix
Fix path to phpunit binary
[Yaml] PHP-8: Uncaught TypeError: abs() expects parameter 1 to be int or float, string given
This PR was merged into the 3.4 branch.
Discussion
----------
[Console] Fix tests not executed
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | NA
| License | MIT
| Doc PR | NA
Commits
-------
bfd5d4e362 Fix tests on console
This PR was merged into the 3.4 branch.
Discussion
----------
[Yaml] PHP-8: Uncaught TypeError: abs() expects parameter 1 to be int or float, string given
[Yaml] PHP-8: Uncaught TypeError: abs() expects parameter 1 to be int or float, string given
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? |no
| BC breaks? | no
| Deprecations? |no
| Tests pass? | yes
| License | MIT
In additional for PR: https://github.com/symfony/symfony/pull/32862
Commits
-------
faef73888e [Yaml] PHP-8: Uncaught TypeError: abs() expects parameter 1 to be int or float, string given
This PR was merged into the 3.4 branch.
Discussion
----------
[travis] Fix path to phpunit binary
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | NA
| License | MIT
| Doc PR | NA
Phpunit cache path change in 4.4 branch. This PR fixes it path
Commits
-------
3b3582eeaf Fix path to phpunit binary
This PR was merged into the 3.4 branch.
Discussion
----------
[PhpUnitBridge] Remove use of ForwardCompatTrait
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #32844
| License | MIT
| Doc PR | NA
With #32882 the ForwardCompatibilityTrait is injected in TestCase which now act as a true polyfill
Commits
-------
ac6242f36b Remove use of ForwardCompatTrait
This PR was merged into the 4.4 branch.
Discussion
----------
[PhpUnitBridge] Inject ForwardCompatibiliy in TestCase
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | not yet
| Fixed tickets | #32844
| License | MIT
| Doc PR | NA
This PR replace the previous trait `ForwardCompatTestTrait` by injecting forward compatibility code in phpunit itself which allow to use the polyfill methods in tests without changing the code.
when using `simple_phpunit` the env variable `$PHPUNIT_REMOVE_RETURN_TYPEHINT=1` (default 0) removes the `: void` typehint in public and protected methods (allow to use 7.4 8 in 3.4 branch)
note: once merged, all tests have to be fixed. see #32889
Commits
-------
016bd8dd91 Inject ForwardCompatibiliy in TestCase
This PR was submitted for the 4.3 branch but it was squashed and merged into the 3.4 branch instead (closes#32870).
Discussion
----------
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| Tests pass? | yes
| Fixed tickets | #32853
| License | MIT
Commits
-------
7cf9ed613b#32853 Check if $this->parameters is array.
This PR was merged into the 4.4 branch.
Discussion
----------
[Mailer] Add debug info on HTTP transport exceptions
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Same as #32896 but for HTTP transports.
Commits
-------
4cfb4b95d6 [Mailer] added debug info on HTTP transport exceptions
This PR was merged into the 4.4 branch.
Discussion
----------
[PhpUnitBridge] added polyfill for assertStringContainsString*()
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #32844
| License | MIT
| Doc PR | -
this PR provides a polyfill for methods assertStringContainsString and assertStringContainsStringIgnoringCase in preparation for the PHPUnit 9 deprecations.
PR follows the pattern of [this PR](https://github.com/symfony/symfony/pull/32869), hence the PR to master
Commits
-------
1602441b22 [PhpUnitBridge] added polyfill for assertStringContainsString*()
This PR was merged into the 3.4 branch.
Discussion
----------
[PhpUnitBridge] Use PHPUnit75Migration in CS fixer
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes (not yet) need #32882, #32886, #32893
| Fixed tickets | #32844
| License | MIT
| Doc PR | NA
Bump php-cs-fixer rule to PHPUnit75Migration:risky which add
- php_unit_dedicate_assert_internal_type
- php_unit_expectation
- php_unit_mock
- php_unit_no_expectation_annotation
which are (or will be) all polyfillyed
- [x] need to polyfill `createPartialMock`
Commits
-------
9fb1c421f3 Adopt `@PHPUnit55Migration:risky` rule of php-cs-fixer
This PR was merged into the 4.4 branch.
Discussion
----------
[PhpUnitBridge] Add polyfill for methods assertNan, assertFinite and assertInfinite
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #32844
| License | MIT
| Doc PR | NA
Provide pollyfile for methods `assertFinite`, `assertInfinite` and `assertNan`
Commits
-------
3450c1705e [PhpUnitBridge] Add polyfill for methods assertNan, assertFinite and assertInfinite
This PR was merged into the 4.3 branch.
Discussion
----------
[Mailer] fix wrong error message when connection closes unexpectedly
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
When the initial connection to the SMTP is closed immediately by the server, the error is now more explicit.
Commits
-------
887f27d513 [Mailer] fixed wrong error message when connection closes unexpectedly