This PR was merged into the master branch.
Discussion
----------
[Console] Improved searching commands
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
I was very annoyed when I typed the command ``app/console a:d`` and I saw this exception ``The namespace "a" is ambiguous (assets, assetic)``. However, the shortcut ``a:d`` is unambiguous (``assets:install`` vs ``assetic:dump``).
Commits
-------
0beec8a [Console] Improved searching commands
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8804).
Discussion
----------
Exclude little words of 'ee' to 'oo' plural transformation
The plural form of 'bee' and 'fee' are not 'foo' and 'boo'. In general words smaller than 3 letters doesn't change to a 'oo' form.
Commits
-------
0ffdb11 Exclude little words of 'ee' to 'oo' plural transformation
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8782).
Discussion
----------
[SecurityBundle] Fix typo in the check_path validator
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #3005, #2954
| License | MIT
Actually, validator of `check_path` value is broken by #3005. It doesn't throw any exception even if `check_path` is an URI.
I've faced with wrong tests class hierarchy: `SecurityExtensionTest` is abstract test and I have to create the same test configuration for every format: PHP, XML, YAML. It looks like we test `Dependency Injection` and `Yaml` components. Issue with `check_path` does not depend on format, but such class hierarchy leaves me no choice. And I can't put test case into `ConfigurationTest`, because it doesn't know anything about security factories.
It looks like it's better to create new class for `SecurityExtension` tests.
Commits
-------
155dca0 [SecurityBundle] Fix typo in the check_path validator
This PR was merged into the 2.3 branch.
Discussion
----------
Include untrusted host in the exception message
`Invalid *` error message without the actual value that triggered them are really unhelpful to debug issues.
Commits
-------
fd2f633 Include untrusted host in the exception message
This PR was merged into the 2.2 branch.
Discussion
----------
[Process] fix for Process:isSuccessful()
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | []
| License | MIT
| Doc PR | []
This is a rebase of https://github.com/symfony/symfony/pull/8801
If you call isSuccessful() on a running process you would get true because of 0 == null. I think that is not the expected behavior and that is not what phpdoc @return block said so.
Commits
-------
262879d fix for Process:isSuccessful()
* 2.3:
[Process] Use a consistent way to reset data of the process latest run
CS fix
[HttpFoundation] Fixed removing a nonexisting namespaced attribute.
[Validation] Fixed IdentityTranslator to pass correct Locale to MessageSelector
SwiftMailerHandler in Monolog bridge now able to react to kernel.terminate event
Conflicts:
src/Symfony/Component/Process/Process.php
* 2.2:
[Process] Use a consistent way to reset data of the process latest run
CS fix
[HttpFoundation] Fixed removing a nonexisting namespaced attribute.
[Validation] Fixed IdentityTranslator to pass correct Locale to MessageSelector
SwiftMailerHandler in Monolog bridge now able to react to kernel.terminate event
Conflicts:
src/Symfony/Component/Process/Process.php
This PR was merged into the 2.2 branch.
Discussion
----------
[MonologBridge] Allow SwiftMailerHandler to listen to kernel.terminate.event
This PR accompanies symfony/MonologBundle#51. Both are intended to fixsymfony/symfony-standard#425.
MonologBundle configures SwiftMailerHandler as a Monolog handler and injects the proper transport service.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | 425
| License | MIT
| Doc PR | 2905
Commits
-------
62238b8 CS fix
c6ecd83 SwiftMailerHandler in Monolog bridge now able to react to kernel.terminate event
This PR was merged into the 2.2 branch.
Discussion
----------
[2.2][Process] Use a consistent way to reset data of the process latest run
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
It is actually useful when cloning or running again a process.
Commits
-------
0723c10 [Process] Use a consistent way to reset data of the process latest run
As Composer is now widely used in the PHP world, having to run composer
install before running the test suite is expected. This also has the
nice benefit of removing a bunch of code, making things easier to
maintain (there is only one place to declare a dev dependency), and
probably more.
This PR was merged into the 2.2 branch.
Discussion
----------
[Validation] Fixed IdentityTranslator to pass correct Locale to MessageSelector
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This PR fixes the following case:
```php
\Locale::setDefault('en');
$translator = new IdentityTranslator(new MessageSelector());
echo $translator->transChoice('There is one apple|There are %count% apples', 10, array('%count' => 10));
```
Result before PR:
```
There are 1 apples
```
Result after PR:
```
There is one apple
```
The reason for the current behavior is that the locale `null` is passed to `MessageSelector`, but `MessageSelector` is not programmed to accept `null` values.
Commits
-------
191d320 [Validation] Fixed IdentityTranslator to pass correct Locale to MessageSelector
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8776).
Discussion
----------
{HttpFoundation] [Session] fixed session compatibility with memcached/re...
...dis session storage
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no (no new failng/errors introduced)
| Fixed tickets | 7380
| License | MIT
Per https://bugs.php.net/bug.php?id=61470, and in fixing #7380, the following error occurs when using a Memcache or Redis session store w/ Symfony security: "Authentication exception occurred; redirecting to authentication entry point (A Token was not found in the SecurityContext.)". This patch applies the first fix only if the session store is "files"
Commits
-------
eb8d8eb {HttpFoundation] [Session] fixed session compatibility with memcached/redis session storage
Per https://bugs.php.net/bug.php?id=61470, and in fixing #7380, the following error occurs when using a Memcache or Redis session store w/ Symfony security: "Authentication exception occurred; redirecting to authentication entry point (A Token was not found in the SecurityContext.)". This patch applies the first fix only if the session store is "files"
{HttpFoundation] [Session] fixed session compatibility with memcached/redis session storage
Per https://bugs.php.net/bug.php?id=61470, and in fixing #7380, the following error occurs when using a Memcache or Redis session store w/ Symfony security: "Authentication exception occurred; redirecting to authentication entry point (A Token was not found in the SecurityContext.)". This patch applies the first fix only if the session store is "files"
This PR was submitted for the 2.3 branch but it was merged into the 2.2 branch instead (closes#8768).
Discussion
----------
[Console] Fixes for hasParameterOption and getParameterOption methods of ArgvInput
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
7ca9340 Fixes for hasParameterOption and getParameterOption methods of ArgvInput
This PR was submitted for the master branch but it was merged into the 2.2 branch instead (closes#8767).
Discussion
----------
Added sleep() workaround for windows php rename bug
For more info see links in issue #8766
Commits
-------
b3c815b Added sleep() workaround for windows php rename bug
This PR was squashed before being merged into the 2.3 branch (closes#8756).
Discussion
----------
[Process] Fix for #8754 (Timed-out processes are successful)
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8754
| License | MIT
Commits
-------
fa01e6b [Process] Fix for #8754 (Timed-out processes are successful)
* 2.3:
[Process] Revert change
[Process] Fix#8746 : slowness added in unit tests since #8741
[Process] Fix#8742 : Signal-terminated processes are not successful
corrected English grammar (s/does not exists/does not exist)
[Process] Add more precision to Process::stop timeout
[Process] Avoid zombie process in case of unit tests failure
[Process] Fix#8739
[Process] Add failing test for #8739
[Process] Fix CS
[TwigBridge] removed superflous ; when rendering form_enctype() (closes#8660)
Fixed documentation grammar for AuthenticationManagerInterface::authenticate()
[Validator] fixed the wrong isAbstract() check against the class (fixed#8589)
[TwigBridge] Prevent code extension to display warning
Fix internal sub-request creation
[FrameworkBundle] made code more generic
[Form] Moved auto_initialize option to the BaseType
Use strstr instead of strpos
Make sure ContextErrorException is loaded during compile time errors
Fix empty process argument escaping on Windows
Ignore null value in comparison validators
Conflicts:
src/Symfony/Component/Debug/Tests/ErrorHandlerTest.php
src/Symfony/Component/HttpKernel/Tests/Fragment/InlineFragmentRendererTest.php
src/Symfony/Component/Process/Process.php
This PR was merged into the master branch.
Discussion
----------
removed legacy artifact from Component/Routing/Router
Hey,
while using the ConfigCache component I noticed that there is a wrong call of isFresh() in Symfony\Component\Routing\Router. ConfigCache->isFresh() doesn't accept any parameters anymore.
cheers,
Daniel
Commits
-------
8b11ae7 removed legacy artifact from Component/Routing/Router
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix#8742 : Signal-terminated processes are not successful
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | require #8741 to be merged to pass tests
| Fixed tickets | #8742
| License | MIT
Commits
-------
909fab6 [Process] Fix#8742 : Signal-terminated processes are not successful
This PR was merged into the 2.2 branch.
Discussion
----------
[Process] Fix#8746 : slowness added in unit tests since #8741
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8746
| License | MIT
Commits
-------
8c4bae3 [Process] Revert change
8d9c7c6 [Process] Fix#8746 : slowness added in unit tests since #8741
Fabien Potencier
David Marín
sumbobyboys
Nikita Konstantinov
Tóth Gábor
Jordi Boggiano
Romain Neutron
Martin Hasoň
Philipp Kräutli
Jakub Zalas
Bernhard Schussek
Tom Avery
Vasily Khayrulin
Christian Morgan