Commit Graph

39714 Commits

Author SHA1 Message Date
Nicolas Grekas
94a143011a [Routing] fix dumping same-path routes with placeholders 2018-12-09 19:25:55 +00:00
Roland Franssen
5e59d7fe54 [WebProfilerBundle][TwigBundle] CSS fixes 2018-12-09 19:33:16 +01:00
Nicolas Grekas
c600de0715 Merge branch '3.4' into 4.1
* 3.4:
  [Validator] Added IBAN format for Vatican City State
  filter out invalid Intl values
  [Validator] Fixed grouped composite constraints
  [Form] Filter arrays out of scalar form types
2018-12-09 17:21:08 +00:00
Robin Chalas
41e2638d22 minor #29515 Add a docblock for FormFactoryInterface (chindit)
This PR was submitted for the master branch but it was squashed and merged into the 4.2 branch instead (closes #29515).

Discussion
----------

Add a docblock for FormFactoryInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #
| License       | MIT
| Doc PR        | None

Added a docblock for FormFactoryInterface so it will be shown in `debug:autowiring` command

#SymfonyConHackday2018

Commits
-------

a51b516 Add a docblock for FormFactoryInterface
2018-12-09 17:12:44 +01:00
David
a51b516997 Add a docblock for FormFactoryInterface 2018-12-09 17:12:38 +01:00
Enrico Schultz
21c3030092 [Security] defer log message in guard authenticator
prevent an unneccessary log message if the guard authenticator does not support the current request
2018-12-09 17:00:22 +01:00
Fabien Potencier
02b3510a11 bug #29531 [Validator] Added IBAN format for Vatican City State (raulfraile)
This PR was squashed before being merged into the 3.4 branch (closes #29531).

Discussion
----------

[Validator] Added IBAN format for Vatican City State

IBAN for Vatican City State was added to [IBAN registry](https://www.swift.com/sites/default/files/resources/iban_registry.pdf) recently. This PR adds support for this new format in the `Iban` validator.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

5f0261429a [Validator] Added IBAN format for Vatican City State
2018-12-09 11:02:06 +01:00
Raul Fraile
5f0261429a [Validator] Added IBAN format for Vatican City State 2018-12-09 11:01:50 +01:00
Fabien Potencier
09cec57127 minor #29398 [FrameworkBundle][Controller] Use interface from Contracts to remove deprecation arnings (tomtomau)
This PR was merged into the 4.2 branch.

Discussion
----------

[FrameworkBundle][Controller] Use interface from Contracts to remove deprecation arnings

| Q             | A
| ------------- | ---
| Branch?       | 4.2?
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | I don't think so     <!-- see https://symfony.com/bc -->
| Deprecations? | no - removing some :) <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | n/a   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | n/a

When we installed 4.2, we hit issues in our qa tools with [vimeo/psalm](https://github.com/vimeo/psalm) reporting that all of our controllers were implementing a deprecated interface (by extending the AbstractController).

This pr simply updates the AbstractController to use the interface provided in `symfony/contracts`

I'm not sure if there was any other reason for not including this in the 4.2 release (bc?), so apologies if I've overstepped this.

Commits
-------

f10227df3d [FrameworkBundle][Controller] Use interface from Contracts to remove deprecation warnings
2018-12-08 21:50:46 +01:00
knuch
ceb7a68efa merge conflicts 2018-12-08 17:39:48 +00:00
Nicolas Grekas
bcee8d91ac bug #29501 [Form] filter out invalid language values (xabbuh)
This PR was merged into the 4.1 branch.

Discussion
----------

[Form] filter out invalid language values

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23679
| License       | MIT
| Doc PR        |

Commits
-------

ed97568b8a filter out invalid language values
2018-12-08 16:43:38 +00:00
Nicolas Grekas
aca0b84637 bug #29307 [Form] Filter arrays out of scalar form types (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Filter arrays out of scalar form types

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/4102
| License       | MIT
| Doc PR        | -

Replaces fix https://github.com/symfony/symfony/pull/20935

Commits
-------

000e4aab5e [Form] Filter arrays out of scalar form types
2018-12-08 16:42:09 +00:00
Nicolas Grekas
7a46c98f00 bug #29500 [Form] filter out invalid Intl values (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] filter out invalid Intl values

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23679
| License       | MIT
| Doc PR        |

Commits
-------

a2d694009f filter out invalid Intl values
2018-12-08 16:20:02 +00:00
Christophe Coevoet
43c04461ae minor #29523 [Hackday][DependencyInjection] Doc block for ContainerBagInterface and ParameterBagInterface (gyszucs)
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #29523).

Discussion
----------

[Hackday][DependencyInjection] Doc block for ContainerBagInterface and ParameterBagInterface

| Q             | A
| ------------- | ---
| Branch?       | master for features
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Added proper doc to `ContainerBagInterface` and `ParameterBagInterface` so `bin//console debug:autowiring` can show it.

#SymfonyConHackday2018

Commits
-------

88c9fc6f45 Added docblock to ContainerBagInterface and ParameterBagInterface
2018-12-08 16:34:14 +01:00
Gyula Szucs
88c9fc6f45 Added docblock to ContainerBagInterface and ParameterBagInterface 2018-12-08 16:34:07 +01:00
Christophe Coevoet
fc8dc91d2d bug #29499 [Validator] Fixed grouped composite constraints (HeahDude)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Fixed grouped composite constraints

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17675, #25888, #23480
| License       | MIT
| Doc PR        | ~

From Lisbon :). Thanks @stof, @xabbuh for your help to finally fix this old issue.

Commits
-------

b53d9112ca [Validator] Fixed grouped composite constraints
2018-12-08 16:29:49 +01:00
Christian Flothmann
a2d694009f filter out invalid Intl values 2018-12-08 12:28:29 +00:00
Christian Flothmann
3411e91e86 Merge branch '4.1' into 4.2
* 4.1:
  change timezone to fix tests on Windows
  bumped Symfony version to 4.1.10
  updated VERSION for 4.1.9
  updated CHANGELOG for 4.1.9
  bumped Symfony version to 3.4.21
  updated VERSION for 3.4.20
  update CONTRIBUTORS for 3.4.20
  updated CHANGELOG for 3.4.20
2018-12-08 12:13:24 +00:00
Christian Flothmann
23e5e45e78 Merge branch '3.4' into 4.1
* 3.4:
  change timezone to fix tests on Windows
  bumped Symfony version to 3.4.21
  updated VERSION for 3.4.20
  update CONTRIBUTORS for 3.4.20
  updated CHANGELOG for 3.4.20
2018-12-08 12:11:43 +00:00
Nicolas Grekas
6f5356c6fa minor #29502 [Serializer] change timezone to fix tests on Windows (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] change timezone to fix tests on Windows

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

As I understand the failing tests timezones have changed in Russia in 2016, but this is not reflected in the timezone database used on AppVeyor. Since the tests do not depend on a particular timezone (it's
only important for it to be different from UTC) we should safely be able to switch to another timezone.

Commits
-------

01a27e577c change timezone to fix tests on Windows
2018-12-08 12:07:26 +00:00
Christian Flothmann
01a27e577c change timezone to fix tests on Windows
As I understand the failing tests timezones have changed in Russia in
2016, but this is not reflected in the timezone database used on
AppVeyor. Since the tests do not depend on a particular timezone (it's
only important for it to be different from UTC) we should safely be able
to switch to another timezone.
2018-12-07 15:51:05 +00:00
Christian Flothmann
ed97568b8a filter out invalid language values 2018-12-07 15:34:22 +00:00
Jules Pietri
b53d9112ca [Validator] Fixed grouped composite constraints 2018-12-07 14:48:19 +00:00
Nicolas Grekas
000e4aab5e [Form] Filter arrays out of scalar form types 2018-12-07 08:49:47 +00:00
Fabien Potencier
1ebca577a5 bumped Symfony version to 4.2.2 2018-12-06 17:41:46 +00:00
Fabien Potencier
cadb4e8e3c
Merge pull request #29493 from fabpot/release-4.2.1
released v4.2.1
2018-12-06 17:40:08 +00:00
Fabien Potencier
267db0287c updated VERSION for 4.2.1 2018-12-06 17:39:52 +00:00
Fabien Potencier
45b611aa37 updated CHANGELOG for 4.2.1 2018-12-06 17:39:47 +00:00
Fabien Potencier
9455c0b233 bumped Symfony version to 4.1.10 2018-12-06 17:39:00 +00:00
Fabien Potencier
9993cdc7e9
Merge pull request #29492 from fabpot/release-4.1.9
released v4.1.9
2018-12-06 17:35:17 +00:00
Fabien Potencier
c48d883794 updated VERSION for 4.1.9 2018-12-06 17:34:50 +00:00
Fabien Potencier
7e1a7b6426 updated CHANGELOG for 4.1.9 2018-12-06 17:34:44 +00:00
Fabien Potencier
9e84e0ff98 bumped Symfony version to 3.4.21 2018-12-06 15:57:52 +00:00
Fabien Potencier
f6b8ddc362
Merge pull request #29488 from fabpot/release-3.4.20
released v3.4.20
2018-12-06 15:24:36 +00:00
Fabien Potencier
b09cb1e8e6 updated VERSION for 3.4.20 2018-12-06 14:59:33 +00:00
Fabien Potencier
4386fb48b1 update CONTRIBUTORS for 3.4.20 2018-12-06 14:59:29 +00:00
Fabien Potencier
cf0583a2a0 updated CHANGELOG for 3.4.20 2018-12-06 14:59:19 +00:00
Nicolas Grekas
54fe82d1c2 Merge branch '4.1' into 4.2
* 4.1:
  fix CI
2018-12-06 11:52:06 +00:00
Nicolas Grekas
3d664a6a2f Merge branch '3.4' into 4.1
* 3.4:
  fix CI
2018-12-06 11:52:00 +00:00
Nicolas Grekas
ffe49fd160 Merge branch '2.8' into 3.4
* 2.8:
  fix CI
2018-12-06 11:51:10 +00:00
Nicolas Grekas
c8389f788d Merge branch '2.7' into 2.8
* 2.7:
  fix CI
2018-12-06 11:51:03 +00:00
Nicolas Grekas
9b10db2207 fix CI 2018-12-06 11:49:24 +00:00
Nicolas Grekas
95e4edba92 Merge branch '4.1' into 4.2
* 4.1:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:36:58 +00:00
Nicolas Grekas
34f6a4066d Merge branch '3.4' into 4.1
* 3.4:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:26:33 +00:00
Nicolas Grekas
3aaa5aba1b Merge branch '2.8' into 3.4
* 2.8:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:25:03 +00:00
Nicolas Grekas
410ed830c5 Merge branch '2.7' into 2.8
* 2.7:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:12:46 +00:00
Nicolas Grekas
f27dd4b5be security #cve-2018-19790 [Security\Http] detect bad redirect targets using backslashes (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[Security\Http] detect bad redirect targets using backslashes

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #76
| License       | MIT
| Doc PR        |

Commits
-------

99a0cec0a6 [Security\Http] detect bad redirect targets using backslashes
2018-12-06 11:09:35 +00:00
Nicolas Grekas
b65e6f1a47 security #cve-2018-19789 [Form] Filter file uploads out of regular form types (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Filter file uploads out of regular form types

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR filters uploaded files out of the data processed by any form type except `FileType`.

Commits
-------

205a44ea7d [Form] Filter file uploads out of regular form types
2018-12-06 11:08:15 +00:00
Nicolas Grekas
15fefd8cd5 Merge branch '4.1' into 4.2
* 4.1:
  [Cache] Fixed Memcached adapter doClear()to call flush()
2018-12-06 11:00:08 +00:00
Nicolas Grekas
5fc7d5ec81 Merge branch '3.4' into 4.1
* 3.4:
  [Cache] Fixed Memcached adapter doClear()to call flush()
2018-12-06 10:58:36 +00:00