This PR was merged into the 3.4 branch.
Discussion
----------
Typo in web profiler
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | no ticket
| License | MIT
| Doc PR | N/A
Fixes typo in web profiler. (NB: Despite the branch being created using the GitHub web editor, I have tested this on my machine with a real project.)
Commits
-------
84b3359adc Typo in web profiler
This PR was merged into the 3.4 branch.
Discussion
----------
[PropertyAccess] Fix PropertyAccessorCollectionTest
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
In https://github.com/symfony/symfony/pull/32627, I (a script actually) removed 2 fixtures classes from this test class. They are actually used but by tests that don't fail without them 😁 (because they were mocked and it's possible to mock non existing classes).
This PR restores those 2 classes and remove the unneeded mocks so the tests use the real classes and are actually useful.
Commits
-------
a310bac624 [PropertyAccess] Fix PropertyAccessorCollectionTest
This PR was merged into the 3.4 branch.
Discussion
----------
[Intl] relax some date parser patterns
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
While debugging the failures in #31374 I realised that the `IntlDateFormatter` from the Intl component parses dates more strictly than PHP's `IntlDateFormatter` class does.
Commits
-------
7d0793a944 relax some date parser patterns
This PR was merged into the 3.4 branch.
Discussion
----------
[Debug][ExceptionHandler] Add tests for custom handlers
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
In https://github.com/symfony/symfony/pull/31694 I mixed many things but the whole PR was closed. I wrote some tests for custom handlers + the handle tests don't use mock anymore
I think they are useful even if the `ExceptionHandler` will disappear in the new component because it will still exists in 4.4 for the next 3 years.
Commits
-------
c53e25332a [Debug][ExceptionHandler] Add tests for custom handlers
This PR was squashed before being merged into the 3.4 branch (closes#32625).
Discussion
----------
[FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
FrameworkBundle & SecurityBundle each had 2 classes called WebTestCase,
one of which is only meant for internal tests. To avoid confusion the internal
class has been renamed to AbstractWebTestCase and made abstract.
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | no
| BC breaks? | no (or, yes, but internal class)
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #32577
| License | MIT
This PR is to ease integration, as not all test classes are present in all currently
maintained branches.
See https://github.com/symfony/symfony/pull/32617
Commits
-------
775d970927 [FrameworkBundle] [SecurityBundle] Rename internal WebTestCase to avoid confusion
This PR was squashed before being merged into the 3.4 branch (closes#32632).
Discussion
----------
[HttpFoundation] Fix URLs
| Q | A
| ------------- | ---
| Branch? | 3.4 <!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | N/A <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/roadmap):
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against branch 4.4.
- Legacy code removals go to the master branch.
-->
Commits
-------
be53c593dc [HttpFoundation] Fix URLs
This PR was merged into the 3.4 branch.
Discussion
----------
[VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4)
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #31135
| License | MIT
| Doc PR | -
Prepare for PHP 7.4: use ReflectionReference in VarCloner
Commits
-------
40f24ef676 [VarDumper] finish PHP 7.4 support and add tests
e99a6b85b8 [VarDumper] Use \ReflectionReference for determining if a key is a reference (php >= 7.4)
This PR was merged into the 3.4 branch.
Discussion
----------
Ignore missing translation dependency in FrameworkBundle
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
This applies the fix from #31156 to the validator.xml file. The error came up a couple of times in the test suite for DoctrineBundle. When using `symfony/framework-bundle` with `symfony/validator` installed but without `symfony/translation`, the call to `setTranslator` will error out because of the missing `translator` service. Thus, the call to `setTranslator` needs to ignore a missing translator dependency to support this scenario.
I don't know how to best test this since the translation component is present in the `require-dev` directive of FrameworkBundle's `composer.json`. If you have any suggestions how to achieve this, please let me know.
Commits
-------
19eb90d8cf Ignore missing translation dependency in FrameworkBundle
When using symfony/framework-bundle with symfony/validator installed but without symfony/translation, the call to setTranslator will error out because of the missing translator service. Thus, the call to setTranslator needs to ignore a missing translator dependency to support this scenario.
This PR was merged into the 3.4 branch.
Discussion
----------
Remove more dead tests fixtures
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Continuation of https://github.com/symfony/symfony/pull/32623
I am sorry but I detected a few more cases.
Commits
-------
a1fb54d900 Remove more dead tests fixtures
This PR was merged into the 3.4 branch.
Discussion
----------
Remove dead tests fixtures
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Once this is merged up to 4.2, I will check 4.2.
Commits
-------
f7e24c2c80 Remove dead tests fixtures
This PR was squashed before being merged into the 3.4 branch (closes#32485).
Discussion
----------
[Validator] Added support for validation of giga values
As described in issue #32479
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | just tested on my presta and it works. if further tests are necessary, it would be great if someone could help!
| Fixed tickets | #32479
| License | MIT
| Doc PR |
The validation(function normalizeBinaryFormat) in symfony/src/Symfony/Component/Validator/Constraints/File.php doesn't work with gigabyte values in php.ini.
In the PHP documentation it says "PHP allows shortcuts for byte values, including K (kilo), M (mega) and G (giga). " so in my opinion these values should work.
Thanks to @kijamve for the fix.
Commits
-------
969f2c4a81 [Validator] Added support for validation of giga values
This PR was merged into the 3.4 branch.
Discussion
----------
Bump minimum version of symfony/phpunit-bridge
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Before those versions, PHPUnit was downloaded directly on github (on `https://github.com/sebastianbergmann/phpunit/archive/$PHPUNIT_VERSION.zip`), not installed with composer.
However, this behavior is not working (anymore ?) because https://github.com/sebastianbergmann/phpunit/archive/6.5.zip is a 404 (`Warning: fopen(https://github.com/sebastianbergmann/phpunit/archive/6.5.zip): failed to open stream: HTTP request failed! HTTP/1.1 404 Not Found`).
When installing lowest dependencies to run tests in local, you encounter this problem and you cannot launch the tests unless you set the `SYMFONY_PHPUNIT_VERSION` to `6.5.14`. But IMHO, it should work by default.
Commits
-------
04e0f3c575 Bump minimum version of symfony/phpunit-bridge
This PR was merged into the 3.4 branch.
Discussion
----------
[Serializer] XmlEncoder: don't cast padded strings
| Q | A
| ------------- | ---
| Branch? | 3.4 <!-- see below -->
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| Fixed tickets | https://github.com/symfony/symfony/pull/23122#discussion_r121886667 <!-- #-prefixed issue number(s), if any -->
| License | MIT
| Doc PR | N/A
This was a suggestion of @nicolas-grekas in #23122. Which seems to have been forgotten.
But shouldn't we also avoid casting something like `.18`, `+18`, `-18`?
Commits
-------
c1bfaa1de4 [Serializer] XmlEncoder: don't cast padded strings
This PR was merged into the 3.4 branch.
Discussion
----------
[Config] Do not use absolute path when computing the vendor freshness
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
When one uses Docker with a different mounting point between CLI & FPM,
the cache keeps regenerating because the ComposerResource class see a
different path for each SAPI. For example `/home/app/app/vendor` vs
`/var/www/app/vendor`.
So if you hit FPM, then the CLI, then FPM, each time a new cache is
generated. So the application is quite slow in dev env. And for people
on MacOSX (with docker) is a big pain! And obvisouly, this never
stabilizes !
This occurs a lot when you have a worker, that crash and reboot in the
background, and you browse the web interface. Or when you have something
that hit your API every X secondes, and you are working on a worker.
Commits
-------
2d2e2742c8 [Config] Do not use absolute path when computing the vendor freshness
This PR was merged into the 3.4 branch.
Discussion
----------
[Debug] Use mocks before replacing the error handler
| Q | A
| ------------- | ---
| Branch? | 3.4,
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
We want the bridge to mute the php 7.4 deprecations triggered when building mocks.
Commits
-------
f6e0b01f7c Use mocks before replacing the error handler
When one uses Docker with a different mounting point between CLI & FPM,
the cache keeps regenerating because the ComposerResource class see a
different path for each SAPI. For example `/home/app/app/vendor` vs
`/var/www/app/vendor`.
So if you hit FPM, then the CLI, then FPM, each time a new cache is
generated. So the application is quite slow in dev env. And for people
on MacOSX (with docker) is a big pain! And obvisouly, this never
stabilizes !
This occurs a lot when you have a worker, that crash and reboot in the
background, and you browse the web interface. Or when you have something
that hit your API every X secondes, and you are working on a worker.
This PR was merged into the 3.4 branch.
Discussion
----------
Container*::getServiceIds() should return strings
| Q | A
| ------------- | ---
| Branch? | 4.3
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | o
| Tests pass? | yes
| Fixed tickets | #32549
| License | MIT
Cast services ids to string in `Container*::getServiceIds()`
Commits
-------
9c88caad31 Container*::getServiceIds() should return an array of string
This PR was merged into the 3.4 branch.
Discussion
----------
[Config][ReflectionClassResource] Use ternary instead of null coalescing operator
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
`??` cannot be on 3.4, tests are failing because of this.
Commits
-------
4db953f40c [Config][ReflectionClassResource] Use ternary instead of null coaelscing operator
This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] Update Spanish translation for Range validator
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | Part of #31503
| License | MIT
| Doc PR | -
Commits
-------
b5a96409b7 Update validators.es.xlf
This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] Add missing Russian and Ukrainian translations
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
~~Some of this translations could be missing in 4.2 also, but [support of Symfony 4.2](https://symfony.com/roadmap/4.2) ends in two weeks, so I think nobody cares about missing translations in it.~~
@peter-gribanov , @vudaltsov , @insidestyles, @stfalcon please, check also provided translations
Commits
-------
fae418f7cb [Validator] Add missing Russian and Ukrainian translations
This PR was merged into the 3.4 branch.
Discussion
----------
[Debug][DebugClassLoader] Don't check class if the included file doesn't exist
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Follow up to https://github.com/symfony/symfony/pull/32500.
If the included file doesn't exist, we need to return or the execution continues (if warnings are not thrown as exceptions) and then an invalid exception is thrown when the class is checked.
For example : "The autoloader expected class "App\Foo\Bar" to be defined in file "/var/www/html/vendor/composer/../../src/Foo/Bar.php". The file was found but the class was not in it, the class name or namespace probably has a typo".
Commits
-------
0185527297 [Debug][DebugClassLoader] Don't check class if the included file don't exist
This PR was squashed before being merged into the 3.4 branch (closes#32536).
Discussion
----------
[Translation] Use HTTPS and fix a url
| Q | A
| ------------- | ---
| Branch? | 3.4 <!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks? | no <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass? | yes <!-- please add some, will be required by reviewers -->
| License | MIT
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/roadmap):
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against branch 4.4.
- Legacy code removals go to the master branch.
-->
Commits
-------
e346ee6888 [Translation] Use HTTPS and fix a url