This PR was merged into the 4.4 branch.
Discussion
----------
[HttpFoundation] Request::getProtocolVersion may return null
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| License | MIT
This is just a minor PHPDoc fix, but we stumbled on it in https://github.com/getsentry/sentry-symfony/pull/495, and static analysis complains about our fix.
Basically, `SERVER_PROTOCOL` may not be set, even if it shouldn't be missing according to [RFC 3875 (GCI spec)](https://tools.ietf.org/html/rfc3875#section-4.1.16). In our case, the user reported the issue because the request was issued interally by a pod health check inside Kubernetes.
Commits
-------
99aadb31ff getProtocolVersion may return null
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Security] Missing translations pt_BR
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#38729
| License | MIT
Commits
-------
8c61c2273f [Security] Missing translations pt_BR
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Added translations for pt security file.
| Q | A
| ------------- | ---
| Branch? | 4.4<!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#41062 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | - <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
22aad3962c Added translations for pt security file.
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Inflector][String] Fixed singularize `edges` > `edge`
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| License | MIT
I noticed that calling `$inflector->singularize('edges');` returned `['edg', 'edges']`.
It should be `edge`, only. See https://en.wiktionary.org/wiki/edge
Commits
-------
ebfb0c9944 [Inflector][String] Fixed singularize `edges` > `edge`
This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.
Discussion
----------
[Security] Update Czech translations
| Q | A
| ------------- | ---
| Branch? | 5.x for features
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? |no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#41040
| License | MIT
Closes#41040
The translations are not perfect for some %minutes% values as the pluralization is more complicated in Czech than in English. (See: https://github.com/symfony/symfony/issues/40863#issuecomment-823928594)
Commits
-------
076310cfe3 [Security] Update Czech translations
This PR was merged into the 4.4 branch.
Discussion
----------
[Lock] Expand `LockConflictedException` docs
The goal of this is to reduce the chance of bad assumptions about lock acquisition behaviour. Fixes#40969
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40969
| License | MIT
| Doc PR | N/A
The goal of this tweak is to reduce the chance of bad assumptions about lock acquisition behaviour.
As per #40970 with suggested fixes, except now targeting the correct branch.
Commits
-------
2e4335fc70 Expand `LockConflictedException` docs
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Security] Add missing German translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41045
| License | MIT
| Doc PR | N/A
Commits
-------
31bba079c3 [Security] Add missing German translations
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Add missing Dutch translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41042
| License | MIT
Sorry screwed up my previous branch while rebasing and amending the author name of the commits.
Commits
-------
e30eb8f555 [Security] Add missing Dutch translations
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Security] Update Security Arabic Translations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41028
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
Related to #41028
Commits
-------
68c10337cc [Security] Update Security Arabic Translations
This PR was merged into the 4.4 branch.
Discussion
----------
Update Romanian Translation based on English
| Q | A
| ------------- | ---
| Branch ? | 4.4
| Bug fix ? | yes
| New feature ? | no
| Deprecations ? | no
| Tickets | Fix#41063
| License | MIT
| Doc PR | NiL
Commits
-------
d2b38fa54a Update Romanian Translation based on English
This PR was submitted for the 5.x branch but it was merged into the 4.4 branch instead.
Discussion
----------
[Security] Add missing Vietnamese translations
| Q | A
| ------------- | ---
| Branch? | 4.4<!-- see below -->
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | - <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | - <!-- required for new features -->
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
3703010b1b add missing vietnamese translations
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Add missing French translations for logging throttling
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40863 (at least for French)
| License | MIT
| Doc PR | N/A
Note: this PR replaces #40889 as somehow force-push closed the other PR.
Also this one targets 4.4 branch directly :)
Commits
-------
b64efd2848 [Security] Add missing French translations for logging throttling
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpFoundation] Small phpdoc improvement
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
I have been looking for a way to emulate `$_REQUEST` in Symfony, and I always thought the `get` method is useless for that, because it only looks at some custom routing stuff, GET and whatever BODY might be. Only today I actually looked at the source code and found out that it's actually (almost) doing what I was looking for, i.e. check `$_GET`, and then `$_POST`. So I figured it would be good to be a bit more explicit in the phpdoc (analoguous to the phpdoc for `$request->request`, which says "Request body parameters ($_POST).").
Commits
-------
a53f256b4b Small phpdoc imporvement
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] [Security/Core] fix checking for bcrypt
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Spotted while working on #40920
Because of the logic in the constructor, if bcrypt is used, it's not cast to string.
Commits
-------
f01ea99254 [Security/Core] fix checking for bcrypt
This PR was merged into the 4.4 branch.
Discussion
----------
[Mime] DataPart: remove confusing fix-me comment
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I don't think this comment is correct? There is an exception thrown [below](https://github.com/symfony/symfony/blob/4.4/src/Symfony/Component/Mime/Part/DataPart.php#L60).
Commits
-------
72493c6acf [Mime] DataPart: remove confusing fix-me comment
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[CI] Make sure to restore default locale
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | F
| License | MIT
| Doc PR |
Whenever we have a test that do `\Locale::setDefault()` we must make sure to restore it to the original value.
Commits
-------
a5afe47ccf [CI] Make sure to restore default locale
