Bernhard Schussek
1ef18360fa
[Form] Made name immutable in FormBuilder to avoid synchronization problems with name and property path
2011-03-31 13:48:06 +02:00
Fabien Potencier
30f26ed091
[Form] changed DefaultFormFactory to be more 'useable'
2011-03-31 07:35:43 +02:00
Fabien Potencier
c7ccb6643b
[Form] removed unused constructor argument from Type\FieldType (themeFactory and template)
2011-03-31 07:34:04 +02:00
Fabien Potencier
a1fc882fad
[Form] fixed DefaultFormFactory
2011-03-30 23:38:40 +02:00
Bernhard Schussek
53838abf3f
Merge remote branch 'symfony/master' into experimental
...
Conflicts:
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/money_field.html.php
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/percent_field.html.php
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-28 22:52:15 +02:00
Fabien Potencier
52c3a1d53d
fixed typo
2011-03-28 22:48:18 +02:00
Bernhard Schussek
e2198b0dc6
[Form] Fixed a few references to AssertTrue/AssertFalse
2011-03-28 17:45:11 +02:00
Bernhard Schussek
e7df781c34
[Form] Fixed calls to ThemeRenderer::renderPart()
2011-03-28 11:22:27 +02:00
Bernhard Schussek
65f58c9fd1
[Form] Introduced generic RendererInterface
2011-03-27 23:43:14 +02:00
Bernhard Schussek
1fa004ceb2
[Form] Simplified the interface names of the Renderer subnamespace
2011-03-27 23:39:01 +02:00
Bernhard Schussek
4ec6ba8674
[Form] Fixed: set data is treated as string except if a transformer is set
2011-03-27 23:09:46 +02:00
Bernhard Schussek
cfaa03eeec
[Form] Fixed: empty objects are only created upon binding forms with empty data
2011-03-27 23:07:30 +02:00
Bernhard Schussek
8a981dd047
[Form] Removed unused variable
2011-03-27 17:37:42 +02:00
Bernhard Schussek
58b8555cb6
[Form] Removed unused use-statements
2011-03-27 15:59:35 +02:00
Bernhard Schussek
edfae73cd4
[Form] Moved PropertyPath, PropertyPathIterator and VirtualFormAwareIterator to subnamespace Util
2011-03-27 15:37:13 +02:00
Bernhard Schussek
29d412c15a
[Form] Changed name of VirtualFormIterator to VirtualFormAwareIterator
2011-03-27 15:33:04 +02:00
Bernhard Schussek
b180319371
[Form] Moved creation of empty data to Form to clean up DataMapperInterface
2011-03-27 15:12:35 +02:00
Bernhard Schussek
5ac979b043
[Form] Fixed default value of 'validation_groups' option, removed duplicate definition
2011-03-27 14:52:03 +02:00
Bernhard Schussek
80116be577
[Form] Removed unused 'template' option
2011-03-27 14:42:44 +02:00
Bernhard Schussek
6588a47ba7
[Form] Removed FormBuilder::setDataClass(). Use the FieldType option "data_class" instead.
...
The problem was that "data_class" was used in two places: FormBuilder::build() and PropertyPathMapper.
PropertyPathMapper was already constructed during FormType::buildForm(), so any data class changes made to the FormBuilder wouldn't affect the data class of the PropertyPathMapper anymore and so lead to an inconsistent state.
2011-03-27 14:34:48 +02:00
Bernhard Schussek
364b0f5208
[Form] Fixed: FormBuilder::add() accepts FormTypeInterface instances
2011-03-27 14:05:06 +02:00
Bernhard Schussek
dc38eeffe3
[Form] Changed the default value of the 'property_path' option to NULL. Explicitely set it to '' or false to disable mapping for a field/form
2011-03-27 14:02:24 +02:00
Bernhard Schussek
67d85c6bc7
[Form] Fixed signature of FormThemeInterface::render()
2011-03-27 13:48:38 +02:00
Bernhard Schussek
b21929423e
[Form] Completely removed the fields variable in the renderer. The renderer itself supports ArrayAccess and Traversable
2011-03-27 13:48:36 +02:00
Bernhard Schussek
eaff9c641e
[Form] Fixed: the default template is only set on the root renderer and reused by children
2011-03-26 19:39:31 +01:00
Bernhard Schussek
89361d036f
[Form] Renamed FormType::configure() to FormType::buildForm()
2011-03-26 18:52:24 +01:00
Bernhard Schussek
a58cfab37d
[Form] Removed form.type.loader tag and according compiler pass to simplify configuration. Custom types that are not in the DIC can be instantiated manually and passed wherever a type is desired.
2011-03-26 18:48:55 +01:00
Bernhard Schussek
9ff91dc997
Merge remote branch 'beberlei/FormsCollectionPrototype' into beberlei-merge
2011-03-26 18:39:20 +01:00
Bernhard Schussek
fae319e77a
[Form] Renderers are now created explicitely using FormFactory::createRenderer(). This improves performance on requests where a form does not need to be rendered
2011-03-26 16:03:34 +01:00
Bernhard Schussek
8c7a93c90c
[Form] Added FormTypeInterface::buildRendererBottomUp() which is called after children are initialized
2011-03-26 16:03:34 +01:00
Bernhard Schussek
c786fac303
[Form] Sample fix implementation of renderers
2011-03-26 16:03:34 +01:00
Johannes M. Schmitt
7887f04dc2
removed Assert prefix from all constraints, renamed annotation namespace to assert
2011-03-26 15:26:05 +01:00
Benjamin Eberlei
f9e2864030
[Form] Set prototype to true by default.
2011-03-26 14:56:59 +01:00
Benjamin Eberlei
d87651b6a2
[Form] Add option "prototype" defaulting to true.
2011-03-26 14:52:03 +01:00
Bernhard Schussek
41c3aea668
Merge remote branch 'beberlei/FormRendererItrator' into beberlei-merge
2011-03-26 13:43:33 +01:00
Benjamin Eberlei
f882a511a0
[Form] Initialize on iterator access.
2011-03-26 12:28:46 +01:00
Benjamin Eberlei
cd1ce86aee
[Form] Iterator support for ThemeRenderer
2011-03-26 12:25:47 +01:00
Benjamin Eberlei
73d8470a76
[Form] Fix children implementation, setChildren() is not used, the attribute "fields" is.
2011-03-26 09:42:45 +01:00
Bernhard Schussek
7585dce8dd
[Form] Added options validation to field creation
2011-03-25 15:30:33 +01:00
Bernhard Schussek
0ace068a52
[Form] PropertyPathMapper now only maps if the form data is synchronized to avoid duplicate form errors ('invalid'+'NotNull', for example)
2011-03-25 11:27:22 +01:00
Bernhard Schussek
6825ea2489
[Form] Improved test coverage of PropertyPathMapper
2011-03-25 11:27:20 +01:00
Bernhard Schussek
e3ac248617
[Form] Errors are mapped to subforms correctly and bubble up again if necessary
2011-03-25 10:53:36 +01:00
Bernhard Schussek
4f360109ed
[Form] Fixed validation.xml (now really)
2011-03-25 10:41:18 +01:00
Bernhard Schussek
7b412cc762
[Form] Removed FormFactory::addGuessers() and moved guessers to constructor arg instead
2011-03-25 02:26:14 +01:00
Bernhard Schussek
9b1b8cbffa
[Form] Replaced various occurences of 'field' by 'form'
2011-03-25 02:12:01 +01:00
Bernhard Schussek
3c412ffba0
[Form] Moved Form::validateData() to DelegatingValidator::validateFormData()
2011-03-25 01:59:28 +01:00
Bernhard Schussek
ec38901572
Merge branch 'rename-execute' into experimental
...
Conflicts:
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 01:49:17 +01:00
Bernhard Schussek
71230a094b
[Form] Fixed validation.xml
2011-03-25 01:46:05 +01:00
Bernhard Schussek
729438fdea
Merge branch 'rename-execute' into experimental
...
Conflicts:
src/Symfony/Component/Form/FileField.php
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 01:38:49 +01:00
Bernhard Schussek
9c6a6e13bf
[Validator] Renamed Execute constraint to Callback
2011-03-25 01:34:35 +01:00
Bernhard Schussek
4c43aa07ea
[Form] Fixed: Elements are removed from collections when a 'collection' field is sized down
2011-03-25 01:15:33 +01:00
Bernhard Schussek
770d403a52
[Form] Improved error mapping in DelegatingValidator
2011-03-25 00:57:35 +01:00
Bernhard Schussek
d2b07058f4
[Form] CSRF token is now only validated for root form
2011-03-25 00:19:00 +01:00
Bernhard Schussek
4372bd5dc8
[Form] Fixed: Bubbling errors are caught correctly
2011-03-25 00:18:58 +01:00
Bernhard Schussek
d84d167b71
[Form] Fixed display of enctype for file fields in Twig theme
2011-03-25 00:16:30 +01:00
Bernhard Schussek
66ba0c3a73
[Form] Fixed: vars are initialized when ThemeRenderer::getVars() is accessed
2011-03-25 00:16:23 +01:00
Bernhard Schussek
262bdcb21d
[Form] Fixed validation
2011-03-25 00:16:21 +01:00
Bernhard Schussek
ef334dbc4a
Merge remote branch 'beberlei/AttributeSupport' into beberlei-merge
2011-03-24 22:53:39 +01:00
Bernhard Schussek
3f390aa271
[Form] Removed EntityType from DefaultTypeLoader
2011-03-24 22:50:39 +01:00
Benjamin Eberlei
ee96ad0e81
[Form] [DoctrineBridge] Move EntityType and DoctrineTypeLoader into Doctrine Bridge
2011-03-24 22:43:00 +01:00
Bernhard Schussek
1ff6906608
[Form] Simplified ArrayTypeLoader and used it as base class of DefaultTypeLoader
2011-03-24 22:30:49 +01:00
Benjamin Eberlei
8d6dd2b9af
[Form] Add Arbitrary Attribute Support to Form Rendering.
2011-03-24 22:08:08 +01:00
Benjamin Eberlei
6bcc04905c
[Form] Introduce ArrayTypeLoader, Remove EntityManager and FormFactory interface from DefaultTypeLoader
2011-03-24 20:00:17 +01:00
Bernhard Schussek
15d5259eb8
[Form] Forms now remember the types used during their construction
2011-03-24 16:16:31 +01:00
Bernhard Schussek
0b4c3c0cb8
[Form] Fixed coding conventions
2011-03-24 15:26:17 +01:00
Bernhard Schussek
2faa47d03b
[Form] Added fallback templates to TwigThemeFactory
2011-03-24 15:11:43 +01:00
Bernhard Schussek
1211d77f49
[Form] Introduced renderer theme factories so that themes can be changed during runtime
2011-03-24 14:27:21 +01:00
Bernhard Schussek
5b41810b6d
Revert "[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'"
...
This reverts commit 1efd680b68
.
2011-03-24 10:55:12 +01:00
Bernhard Schussek
5078a63c74
Revert "[Form] Fixed more naming of themes and theme engines"
...
This reverts commit 1aa34b7240
.
2011-03-24 10:54:47 +01:00
Aurelijus
2ee47f3c69
get originalName before move call
2011-03-24 10:39:42 +02:00
Bernhard Schussek
9b6722222f
[Form] Improved internal structore of PropertyPathMapper
2011-03-24 00:15:59 +01:00
Bernhard Schussek
1aa34b7240
[Form] Fixed more naming of themes and theme engines
2011-03-23 22:51:37 +01:00
Bernhard Schussek
1efd680b68
[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'
2011-03-23 22:34:58 +01:00
Bernhard Schussek
f71ae03143
[Form] AbstractType::getParent() returns 'form' by default now
2011-03-23 21:51:50 +01:00
Bernhard Schussek
c01419d856
Merge remote branch 'johnwards/renderer_tests' into renderer-tests-merge
2011-03-23 21:13:36 +01:00
Bernhard Schussek
08a09240f6
[Form] Fixed order of input and output timezone to a more natural one
2011-03-23 17:12:04 +01:00
Bernhard Schussek
a880f8d0d1
[Form] Fixed coding conventions
2011-03-23 16:14:53 +01:00
Bernhard Schussek
9e025440ca
Merge remote branch 'johnwards/configuration' into configurable-merge
2011-03-23 16:05:16 +01:00
John Wards
85701b65af
[Form] Missing methods from interfaces
2011-03-22 22:20:14 +00:00
John Wards
1a014d130e
[Form] Tests for Renderer Plugins
2011-03-22 22:19:51 +00:00
John Wards
37f12f68da
[Form] The declaration and initialization (constructor) of the variables should be in the same class.
2011-03-22 20:54:15 +00:00
John Wards
e54973b5d4
[Form] Refactoring Types to use new DataTransfomer interface
2011-03-22 15:40:52 +00:00
Bernhard Schussek
ea0e5bb2d6
[Form] Renamed FieldTypeInterface to FormTypeInterface
2011-03-22 12:36:41 +01:00
Bernhard Schussek
270a98e413
[Form] Added support for types that are not registered in the DIC. These are identified by their FQ class name.
2011-03-22 12:33:15 +01:00
John Wards
5a5fdd0529
Merge remote branch 'bernhard/experimental' into configuration
2011-03-22 07:43:47 +00:00
Bernhard Schussek
33692eae4a
[Form] Renamed Form::isTransformationSuccessful() to isSynchronized(). This method now indicates whether the data in the different representations is synchronized. Moved 'invalid' error to DefaultValidator
2011-03-22 02:03:22 +01:00
Bernhard Schussek
09da126464
[Form] Fixed validation.xml
2011-03-22 01:45:40 +01:00
Bernhard Schussek
16d65f6f16
[Form] Moved previously skipped tests from FormTypeTest to FormTest and fixed them
2011-03-22 01:40:02 +01:00
Bernhard Schussek
577e106361
[Form] Implemented custom mapping of data errors to form fields
2011-03-22 01:15:48 +01:00
John Wards
b4406f254d
[Form] Removing Configurable from DataTransformers
2011-03-21 23:01:10 +00:00
John Wards
7d7c36a178
[Form] More sensible constructor variable order
2011-03-21 21:42:34 +00:00
Bernhard Schussek
87665bc380
[Form] Decoupled FormBuilder from CSRF protection
2011-03-21 22:41:19 +01:00
John Wards
714f2173be
[Form] Coding conventions and use of the new variables
2011-03-21 21:39:59 +00:00
John Wards
3c80bc37df
[Form] Removing use of old class
2011-03-21 21:20:57 +00:00
John Wards
d8287a6dff
Merge remote branch 'bernhard/experimental' into experimental
2011-03-21 21:18:04 +00:00
John Wards
002a22df04
[Form] Refactoring DateTimeToStringTranformer not to use Configuration
2011-03-21 21:16:20 +00:00
Bernhard Schussek
c1abf08d9c
[Form] Implemented error bubbling
2011-03-21 22:13:02 +01:00
Bernhard Schussek
255eda5238
[Form] Renamed RecursiveFieldIterator to RecursiveFormIterator
2011-03-21 21:19:36 +01:00
Bernhard Schussek
3985522b9b
[Form] Removed obsolete classes Error and DataError
2011-03-21 21:19:31 +01:00
Bernhard Schussek
01a47457d0
[Form] Improved naming of various interfaces. Renamed DefaultRenderer to ThemeRenderer
2011-03-21 20:57:38 +01:00
Bernhard Schussek
321d40b21a
[Form] Decoupled FormBuilder from ThemeInterface
2011-03-21 20:46:43 +01:00
Bernhard Schussek
acaa9c9058
[Form] Fixed signature of Form::addError()
2011-03-20 15:23:36 +01:00
Bernhard Schussek
6c9ff0a2a3
[Form] Improved naming of data conversion methods in Form and made them private
2011-03-20 15:22:37 +01:00
Bernhard Schussek
119866e06d
[Form] Renamed FormBuilder::getInstance() to getForm()
2011-03-20 15:17:25 +01:00
Bernhard Schussek
2dbb41714a
[Form] Merged Field and Form. Merged FieldBuilder and FormBuilder. After the refactoring, the distinction between the two concepts is small enough to merge them
2011-03-20 13:35:19 +01:00
Bernhard Schussek
fc7281bcab
[Form] Extracted validation logic of form. Fields can now contain multiple validators
2011-03-20 12:00:19 +01:00
Bernhard Schussek
cb599f417e
[Form] Renamed field option 'disabled' to 'read_only'. How to render read-only fields is now the responsibility of the renderer
2011-03-20 10:35:16 +01:00
Bernhard Schussek
b5656f1290
[Form] Renamed ObjectMapper to PropertyPathMapper
2011-03-20 10:29:23 +01:00
Bernhard Schussek
295d01745b
[Form] Renamed StripTagsFilter to StripTagsListener until we have better conventions
2011-03-20 10:26:38 +01:00
Bernhard Schussek
2c6c89d898
Merge remote branch 'beberlei/forms' into beberlei-merge
2011-03-20 10:15:59 +01:00
Benjamin Eberlei
b43318ee3e
[Form] Add tests for untested classes.
2011-03-19 22:03:49 +01:00
Benjamin Eberlei
d62213662e
Merge branch 'experimental' of git://github.com/bschussek/symfony into forms
2011-03-19 20:36:56 +01:00
Benjamin Eberlei
864a3ec45f
[Form] Add StripTagsFilter EventListener
2011-03-19 20:36:49 +01:00
Bernhard Schussek
a1c3d21d0e
[Form] Added comment
2011-03-19 19:56:18 +01:00
Bernhard Schussek
e9cb19721a
[Form] Optimized code in Form to remove one event listener
2011-03-19 19:53:39 +01:00
Bernhard Schussek
fb2db58801
[Form] Added fluid interface for inline adding of sub-builders to a builder
2011-03-19 19:44:45 +01:00
Bernhard Schussek
6793bcd698
[Form] Removed magic from method signature of add()
2011-03-19 19:20:55 +01:00
Bernhard Schussek
c4b7a77ece
Merge remote branch 'beberlei/forms' into beberlei-merge
...
Conflicts:
src/Symfony/Component/Form/Type/Loader/DefaultTypeLoader.php
2011-03-19 19:01:57 +01:00
Bernhard Schussek
3586268bc2
[Form] Renamed field types. They are now always the name of the type with a 'Type' suffix
2011-03-19 18:31:24 +01:00
Bernhard Schussek
65353bd81e
[Form] Fixed failing choice field tests
2011-03-19 18:22:08 +01:00
Benjamin Eberlei
c05b3c440d
[Form] Add DefaultFormFactory for convenience usage outside of a DIC context.
2011-03-19 18:14:15 +01:00
Benjamin Eberlei
39c2d3f166
[Form] Add PhpTheme that relies on no Template Engine, generalize tests to use for PhpTheme and PhpEngineTheme. Fixed some bugs
2011-03-19 17:47:18 +01:00
Bernhard Schussek
43a24fa931
[Form] Renamed events to match terminology in Field
2011-03-19 16:59:23 +01:00
Bernhard Schussek
0259d4da1e
[Form] Moved namespace DataValidator to Validator
2011-03-19 16:54:07 +01:00
Bernhard Schussek
7f9284105d
[Form] Moved namespace FieldGuesser to Type\Guesser
2011-03-19 16:46:03 +01:00
Benjamin Eberlei
af60ddf8ad
Moved PhpTheme to FrameworkBundle and renamed to PhpEngineTheme
2011-03-19 15:27:39 +01:00
Benjamin Eberlei
32e1a7c8f9
Merge bschussek/experimental into branch forms.
2011-03-19 15:18:52 +01:00
Bernhard Schussek
d2210a2e79
[Form] Removed unused Form::isCsrfTokenValid()
2011-03-19 15:09:11 +01:00
Bernhard Schussek
3e17b26105
[Form] Moved CSRF protection into separate field
2011-03-19 15:06:54 +01:00
Benjamin Eberlei
3e2b8e5f12
Fix some missing use statements and small bugs.
2011-03-19 14:31:25 +01:00
Benjamin Eberlei
bb8c2a9b9d
Rename this to renderer to be able to use it in Php Templating
2011-03-19 11:54:46 +01:00
Benjamin Eberlei
d44e2264ba
Merge branch 'experimental' of git://github.com/bschussek/symfony into forms
2011-03-19 09:36:30 +01:00
Bernhard Schussek
b66b8326a8
[Form] Fixed undefined variable in DefaultRenderer
2011-03-18 17:03:12 +01:00
Bernhard Schussek
6bc79a1a12
[Form] Renamed different kinds of data transformers within a field for better clarity
2011-03-18 16:59:34 +01:00
Bernhard Schussek
1c85daa56b
[Form] Split FieldBuilder into FieldBuilder and FormBuilder to make creation of classes deterministic
2011-03-18 16:34:54 +01:00
Bernhard Schussek
2a1e394352
[Form] Renamed field configs to types. Everywhere else, we are referring to the name of the type as 'type' now (was 'identifier')
2011-03-18 16:20:00 +01:00
Bernhard Schussek
0b929ee342
[Form] Renamed ValueTransformers to DataTransformers to fit with DataMapper and DataValidator
2011-03-18 16:01:06 +01:00
Bernhard Schussek
f86ecec403
[Form] Extracted data validation logic into DataValidatorInterface
2011-03-18 15:58:22 +01:00
Bernhard Schussek
97d0183d84
[Form] Moved properties propertyPath, modifyByReference, validationGroups and virtual to generic attributes because they are specific to the used data validator/mapper implementations
2011-03-18 15:26:02 +01:00
Bernhard Schussek
700c96e7fa
[Form] Moved FieldFactoryTest to FormFactoryTest and fixed it
2011-03-18 14:37:54 +01:00
Bernhard Schussek
4cb76c0045
[Form] Moved error distribution logic to validation listener
2011-03-18 13:07:06 +01:00
Bernhard Schussek
9caaf0f3a3
[Form] Introduced FieldBuilder for field/form creation and made Field/Form mostly immutable
2011-03-18 12:50:26 +01:00
Benjamin Eberlei
76b0041d1b
[Form] Implemented first PhpTheme attempt
2011-03-17 22:47:19 +01:00
Bernhard Schussek
a51321c264
[Form] Moved validation logic to ValidationListener
2011-03-17 21:47:12 +01:00
Bernhard Schussek
0799662361
[Form] Extracted data mapping logic from Form into ObjectMapperListener
2011-03-17 21:23:59 +01:00
Benjamin Eberlei
3bc825bbd4
Merge branch 'experimental' of git://github.com/bschussek/symfony into forms
2011-03-17 19:05:59 +01:00
Benjamin Eberlei
85b61fe1e2
First attempt of PhpTheme.
2011-03-17 19:05:48 +01:00
Bernhard Schussek
d00f1fa205
[Form] Removed unused method Form::deepArrayUnion()
2011-03-17 15:22:48 +01:00
Bernhard Schussek
8e41cc66fe
[Form] Moved form logic to event listeners
2011-03-17 15:22:10 +01:00
Bernhard Schussek
7a63b840f3
[Form] Renamed submit() to bind()
2011-03-17 14:55:26 +01:00