This PR was submitted for the 5.4 branch but it was merged into the 5.2 branch instead.
Discussion
----------
[SecurityBundle] Change information label from red to yellow
| Q | A
| ------------- | ---
| Branch? | 5.x
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | .
| License | MIT
| Doc PR | .
The red colour feels like an error, but being not authenticated is more like a warning (generally associated with yellow/orange) than an error (generally in red).
Feel free to close, cheers :)
Commits
-------
41ebc32373 [SecurityBundle] Change n/a information label from red to yellow
This PR was merged into the 4.4 branch.
Discussion
----------
[Validators] Add new translation in Hungarian
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41821
| License | MIT
| Doc PR | N/A
This PR adds missing Hungarian translations.
Commits
-------
78745133b3 Add new translation in Hungarian
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
* validators.(ru|lt).xlf - wrong trans-unit ids
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | https://github.com/symfony/symfony/issues/41867
| License | MIT
Hi, it is not a big issue, but validators.en.xlf vs validators.ru.xlf indexes not matched.
Commits
-------
9a20e25ba9 * validators.(ru|lt).xlf - wrong trans-unit ids
* 4.4:
[#41846] Revert change in closing tag
Closing tag typo
* validators.lt.xlf - added missing 100 message
[Validator] Add missing translations for Russian
[Validator] Add missing Czech translations
[Validator] Missing translations for Brazilian Portuguese (pt_BR)
Add missing translation for Polish
(#41826) missing translations for portuguese
Public responses without lifetime should not remove lifetime for the resulting response
[Security]Added missing translations for Armenian (hy)
This PR was submitted for the 5.3 branch but it was merged into the 4.4 branch instead.
Discussion
----------
[SecurityBundle] [5.3] Closing tag typo
| Q | A
| ------------- | ---
| Branch? | 5.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License | MIT
Quick fix, On code review the closing tag doesnt match the opening tag
```xml
<sec:config> ... </config>
```
Commits
-------
b91d488ce6 Closing tag typo
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Added missing translations for Armenian (hy)
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41029
| License | MIT
Add missing Armenian translations to Security component.
Commits
-------
9f6a9bbda2 [Security]Added missing translations for Armenian (hy)
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] (#41826) missing translations for portuguese
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41826
| License | MIT
Commits
-------
0c97c8ac84 (#41826) missing translations for portuguese
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Add missing translation for Polish
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix#41825 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | N/A
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
b244cc994e Add missing translation for Polish
This PR was merged into the 4.4 branch.
Discussion
----------
[HttpKernel] Keep max lifetime also when part of the responses don't set it
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
https://datatracker.ietf.org/doc/html/rfc7234#section-4.2.2 allows caches to assign a "heuristic expiration time" for responses that have no explicit expiration time set, but are explicitly marked as being cacheable by `public`. We can say that such responses are "more liberal" in what is allowed than a response with an explicit `max-age` or `s-maxage` header.
When merging responses in `ResponseCacheStrategy`, such `public` responses without explicit expiration time should not cause the `max-age` or `s-maxage` values being dropped on the final response. The most restrictive settings from all responses involved should be used, and any given expiration time is more strict than not setting one when being `public`.
Commits
-------
ad1f057ce2 Public responses without lifetime should not remove lifetime for the resulting response
