diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
6,097 Commits 24 Branches 563 Tags 228 MiB
3cb4b031b6
Commit Graph

6097 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Fabien Potencier
2ec35428d4 merged branch stloyd/patch-1 (PR #1592) 
Commits
-------

c1866e3 Profiler search typo

Discussion
----------

[WebProfiler] Search section typo
 2011-07-09 10:04:45 +02:00
Joseph Bielawski
c1866e3710 Profiler search typo 2011-07-09 00:42:37 -07:00
Fabien Potencier
4a7b7597d8 merged branch marcw/validator-choice (PR #1577) 
Commits
-------

df57e0f [Validator] Added strict option to ChoiceConstraint.

Discussion
----------

[Validator] Added strict option to ChoiceConstraint.

By default, ChoiceValidator was ensuring strict type when checking if value is present in choices. This behavior is a problem when you want to validate against integer values. As all data you will receive from a request will be typed as a string, you won't be able to validate these numeric values.
This patch solves this.

In order for being nice to developers, I've set "strict" to false by default.
 2011-07-09 09:19:08 +02:00
Fabien Potencier
2a5bf56a3a merged branch ornicar/redirectResponseIndentation (PR #1589) 
Commits
-------

6c736c9 Fix RedirectResponse HTML indentation and constructor phpDoc

Discussion
----------

Fix RedirectResponse HTML indentation and constructor phpDoc

Removes extra indents from the redirection response content.
 2011-07-09 09:15:20 +02:00
Fabien Potencier
130082ac73 merged branch alifity/indonesian_translations (PR #1590) 
Commits
-------

937af2f add indonesian translations

Discussion
----------

indonesian translations
 2011-07-09 09:12:45 +02:00
Alif Rachmawadi
937af2f7d2 add indonesian translations 2011-07-09 09:52:20 +07:00
ornicar
6c736c936f Fix RedirectResponse HTML indentation and constructor phpDoc 2011-07-08 18:14:45 -07:00
Fabien Potencier
aed87c50f0 merged branch aboks/dutch_translations (PR #1586) 
Commits
-------

45c2da7 [FrameworkBundle] Updated Dutch validator translations

Discussion
----------

[FrameworkBundle] Updated Dutch validator translations

Synchronized Dutch validator translations for some recent changes.
 2011-07-08 10:45:31 +02:00
Fabien Potencier
103e9d1c6e merged branch sortex/sk_translations (PR #1584) 
Commits
-------

d0258dd [FrameworkBundle]Slovak translations

Discussion
----------

Slovak translations

Slovak translations for framework bundle
 2011-07-08 10:45:14 +02:00
Arnout Boks
45c2da75cf [FrameworkBundle] Updated Dutch validator translations 2011-07-08 10:39:56 +02:00
Sortex
d0258dd483 [FrameworkBundle]Slovak translations 2011-07-08 09:23:39 +02:00
Fabien Potencier
11d5b00656 merged branch merk/patch-1 (PR #1583) 
Commits
-------

d736da6 Fixed styling for getName() BC note

Discussion
----------

Fixed styling for getName() BC note
 2011-07-08 09:17:19 +02:00
Tim Nagel
d736da6420 Fixed styling for getName() BC note 2011-07-08 00:15:34 -07:00
Fabien Potencier
8cba4903d8 [Process] removed workaround as it seems to not work anymore after the recent changes 2011-07-08 09:14:48 +02:00
Fabien Potencier
28be19461b updated Monolog to 1.0.0 2011-07-07 19:02:57 +02:00
Fabien Potencier
c85fd081c8 [FrameworkBundle] fixed _internal route when the path contains dots 2011-07-07 17:25:53 +02:00
marc.weistroff
df57e0fe9a [Validator] Added strict option to ChoiceConstraint. 2011-07-07 15:11:36 +02:00
Fabien Potencier
0753f86dc1 [Translation] fixed CS 2011-07-07 12:27:49 +02:00
Fabien Potencier
d184b33bff merged branch stealth35/patch-8 (PR #1576) 
Commits
-------

bb1b480 [Translation][Loader] CSV controls for CsvFileLoader

Discussion
----------

[Translation][Loader] CSV controls for CsvFileLoader
 2011-07-07 12:26:16 +02:00
Fabien Potencier
0b0356f348 [HttpKernel] fixed exception handler when an exception is thrown during handling 2011-07-07 12:24:58 +02:00
stealth35
bb1b48046d [Translation][Loader] CSV controls for CsvFileLoader 2011-07-07 02:46:07 -07:00
Fabien Potencier
4f9060c929 [Routing] added back a comment that were deleted previously 2011-07-07 11:11:30 +02:00
Fabien Potencier
c061b4576b merged branch Seldaek/urlgen (PR #1573) 
Commits
-------

ac1448f [Routing] Revert to rawurlencode + whitelisting of '/'

Discussion
----------

[Routing] Revert to rawurlencode + whitelisting of '/'

After more discussion on 761724ae57 - sorry you merged too fast for once ;)
 2011-07-07 11:08:08 +02:00
Fabien Potencier
cce2bc59a8 fixed CS 2011-07-07 11:07:02 +02:00
Fabien Potencier
9b3c2ca3d3 merged branch vicb/uploaded-file/max-size (PR #1574) 
Commits
-------

6786e81 [HttpFoundation] code factorization in UploadedFile

Discussion
----------

[HttpFoundation] code factorization in UploadedFile

As both #1542 and #1544 have been merged.
 2011-07-07 11:06:29 +02:00
Fabien Potencier
76a5816d60 [HttpKernel] fixed recursion when flattenning an exception stack trace 2011-07-07 10:59:18 +02:00
Victor Berchet
6786e81f61 [HttpFoundation] code factorization in UploadedFile 2011-07-07 10:47:10 +02:00
Jordi Boggiano
ac1448f573 [Routing] Revert to rawurlencode + whitelisting of '/' 2011-07-07 10:44:17 +02:00
Fabien Potencier
2ec4b04547 merged branch Seldaek/urlgen (PR #1569) 
Commits
-------

6039569 [Routing] Add # and ? to escaped chars

Discussion
----------

[Routing] Add # and ? to escaped chars

See comments on 761724ae57
 2011-07-07 09:44:11 +02:00
Fabien Potencier
59870bfe02 fixed typo 2011-07-07 09:42:47 +02:00
Fabien Potencier
3a5d508766 [Console] replaced fgets by stream_get_line in DialogHelper 
Problem with fgets is that false means two things: an error or the end of the stream.
That's ok for STDIN, but it becomes a problem when using another stream (in a unit test for instance).
 2011-07-07 09:41:45 +02:00
Jordi Boggiano
603956979c [Routing] Add # and ? to escaped chars 2011-07-07 09:38:15 +02:00
Fabien Potencier
7eec2ca7b3 [Form] added a form type name validator 2011-07-07 09:16:13 +02:00
Fabien Potencier
db415db0af [HttpFoundation] tweaked previous merge 2011-07-07 07:41:40 +02:00
Fabien Potencier
c41da9d447 merged branch ktomk/patch-1 (PR #1558) 
Commits
-------

db37bbb HTTP 1.1 / RFC 2616 - Make Redirect response HTTP body having a HTML body.

Discussion
----------

[HttpFoundation] Redirect response is missing a HTML body

HTTP 1.1 / RFC 2616 - Make Redirect response HTTP body having a HTML body as "...the entity of the response SHOULD contain a short hypertext note with a hyperlink to the new URI(s)." (unless HEAD request, see response codes 301, 302, 303 and 307).

See [10.3 Redirection 3xx *in* Hypertext Transfer Protocol -- HTTP/1.1 (RFC 2616 Fielding, et al.)](http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.3) and [9.3 Redirection 3xx *in* Hypertext Transfer Protocol -- HTTP/1.0](http://tools.ietf.org/html/rfc1945#section-9.3).

---------------------------------------------------------------------------

by stloyd at 2011/07/06 10:50:50 -0700

As we allow changing protocol version, and by [default](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/Response.php#L88) use 1.0 this should have an use also `$this->getProtocolVersion()`.

---------------------------------------------------------------------------

by ktomk at 2011/07/06 10:57:48 -0700

(Updated the original comment and linked the HTTP 1.0 specs in there)

Just have reviewed the RFCs and the processing inside `[HttpFoundation]`.  The response class [identifies the following status codes as redirects](db37bbb189/src/Symfony/Component/HttpFoundation/Response.php (L741)): `201`, `301`, `302`, `303` and `307`. That's quite the same list I compiled above where I did only check for 3xx codes. In HTTP/1.0 (symfony default) the 201 response can contain the new location in it's entity (body) of the response (in contrast, [RFC 1945 is *not* talking about the location header explicitly](http://tools.ietf.org/html/rfc1945#section-9.2); see as well [10.11  Location](http://tools.ietf.org/html/rfc1945#section-10.11), that's [in HTTP/1.1 done](http://www.w3.org/Protocols/rfc2616/rfc2616-sec10.html#sec10.2.2), compare [14.30 Location](http://www.w3.org/Protocols/rfc2616/rfc2616-sec14.html#sec14.30)).

So I would say HTTP 1.0 is properly reflected with the changes as well and the concrete Response object [is already taking care for protocol validity](db37bbb189/src/Symfony/Component/HttpFoundation/RedirectResponse.php (L41)).
 2011-07-07 07:37:39 +02:00
Fabien Potencier
bb5075d820 [HttpFoundation] prevented Response headers to be sent twice 
This change allows for more flexibility if the developer wants to flush
the Response content early (the drawback being that Response listeners
won't be able to tweak the HTTP headers anymore).

There is another benefit: avoid the infamous
"Fatal error: Exception thrown without a stack frame in Unknown on line 0".

Here is a small scenario when this can happen (thanks dtee for identifying this issue):

* Call flush() in controller to output html early, then throw exception
* ExceptionHandler triggers handle() function and return new Response object to output...
* Because the header is sent (flush() call in Controller), php's E_WARNING error get raised, which gets handled by ErrorHandler->handle() and it throws new ErrorException()
* PHP fatals to prevent Exception loop: "Fatal error: Exception thrown without a stack frame in Unknown on line 0"
 2011-07-07 07:34:35 +02:00
Fabien Potencier
6645cb44c7 merged branch dlsniper/romanian-validation (PR #1568) 
Commits
-------

8a6ac0c Added Romanian translations for validators

Discussion
----------

[Validator] Added Romanian translations

Added all strings up to commit SHA: d58ba34246
 2011-07-07 07:10:20 +02:00
Fabien Potencier
430b5cdfa9 merged branch lenar/validator-et (PR #1567) 
Commits
-------

b4cdecd Additional et translations

Discussion
----------

[Validator] Additional Estonian translations
 2011-07-07 07:09:45 +02:00
Fabien Potencier
a30a2c9707 merged branch jdreesen/validator-translation-update (PR #1566) 
Commits
-------

39d3a90 Sync German translation with commit: d58ba34246

Discussion
----------

[Validator] Sync German translation

Sync German translation with commit: d58ba34246
 2011-07-07 07:09:16 +02:00
Florin Patan
8a6ac0ce4e Added Romanian translations for validators 2011-07-06 18:59:43 -04:00
lenar
b4cdecd423 Additional et translations 2011-07-07 00:24:48 +03:00
jdreesen
39d3a90b6c Sync German translation with commit: d58ba34246 2011-07-06 22:55:00 +02:00
lenar
f7d0f651a3 RFC2616 changes 2011-07-06 23:50:37 +03:00
Lenar Lõhmus
b9a218a5c1 [HttpFoundation] set Content-Length header to the length of content 2011-07-06 23:47:40 +03:00
Fabien Potencier
3e3979a7a8 merged branch mweimerskirch/patch-3 (PR #1565) 
Commits
-------

c76d2b5 Fix error message

Discussion
----------

[Form] Fix error message
 2011-07-06 22:14:30 +02:00
Michel Weimerskirch
c76d2b5807 Fix error message 2011-07-06 12:54:57 -07:00
Fabien Potencier
7c5008a79c merged branch mweimerskirch/patch-2 (PR #1563) 
Commits
-------

a582231 Complete Luxembourgish translation

Discussion
----------

[Validator] Complete Luxembourgish translation
 2011-07-06 21:45:35 +02:00
Michel Weimerskirch
a5822314eb Complete Luxembourgish translation 2011-07-06 12:41:51 -07:00
Fabien Potencier
38d0239f70 merged branch stloyd/patch-2 (PR #1559) 
Commits
-------

23ec119 Revert copy&paste
7a95330 Sync polish translation with commit: d58ba34246

Discussion
----------

[Validator] Sync polish translation

Sync polish translation with commit: d58ba34246
 2011-07-06 19:30:46 +02:00
Joseph Bielawski
23ec11949e Revert copy&paste 2011-07-06 10:25:12 -07:00