This PR was merged into the 5.2 branch.
Discussion
----------
[Form] Remove duplicated array entry
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
This PR cleans the DateTimeTypeTest test class from a duplicated array entry.
Commits
-------
86ccfa71a1 Remove duplicated array entry
This PR was submitted for the 5.4 branch but it was merged into the 4.4 branch instead.
Discussion
----------
[Workflow] qa: add missing type-hints to workflow `Transition`
| Q | A
| ------------- | ---
| Branch? | 5.4
| Bug fix? | not really
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License | MIT
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Hey there, I am using the `Workflow` component and realized that `Transition` lacks method type-hints. I've added a PHPDoc to reflect the return types.
If this is considered a bug fix, I can rebase against 5.3. If anything else is missing, please let me know.
Commits
-------
660037858f qa: add missing type-hints to workflow `Transition`
This PR was submitted for the 5.4 branch but it was merged into the 5.2 branch instead.
Discussion
----------
Use PHP_OS_FAMILY if possible
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This constant was introduced in PHP 7.2: https://www.php.net/manual/en/reserved.constants.php#constant.php-os-family
~This is not a bug, so if you decide to merge, it should be in 5.4 branch I guess.~
Commits
-------
0d107cf2c0 Use PHP_OS_FAMILY if possible
* 4.4:
Fix tests
Fix minor typos
[WebProfilerBundle] Fix the values of some CSS properties
[Yaml] Fixed an exception message
Fix ctype_digit deprecation
Add a Special Case for Translating Choices in en_US_POSIX
This PR was merged into the 4.4 branch.
Discussion
----------
Add a Special Case for Translating Choices in en_US_POSIX
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix https://github.com/symfony/symfony/issues/42036 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | n/a <!-- required for new features -->
This adds a special case similar to `pt_BR` for handling `en_US_POSIX`
which is set as the default locale on some operating systems.
~Two tests here might be over the top, not sure.~
Not over the top! One of them caught the same issue in the translation component itself 🎉
Commits
-------
f0bb7a36c5 Add a Special Case for Translating Choices in en_US_POSIX
This PR was merged into the 4.4 branch.
Discussion
----------
Fix ctype_digit deprecation
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
Running the Yaml unit tests on PHP 8.1 built: Jul 12 2021 00:22:13 results in the following PHP Notices:
```
Testing /Users/alex/dev/symfony/src/Symfony/Component/Yaml/Tests
............................................................... 63 / 689 ( 9%)
............................................................... 126 / 689 ( 18%)
............................................................... 189 / 689 ( 27%)
............................................................... 252 / 689 ( 36%)
............................................................... 315 / 689 ( 45%)
............................................................... 378 / 689 ( 54%)
............................................................... 441 / 689 ( 64%)
............................................................... 504 / 689 ( 73%)
............................................................... 567 / 689 ( 82%)
............................................................... 630 / 689 ( 91%)
........................................................... 689 / 689 (100%)
Time: 00:00.336, Memory: 20.00 MB
OK (689 tests, 984 assertions)
Unsilenced deprecation notices (131)
109x: ctype_digit(): Argument of type int will be interpreted as string in the future
53x in DumperTest::testSpecifications from Symfony\Component\Yaml\Tests
21x in DumperTest::testInlineLevel from Symfony\Component\Yaml\Tests
16x in InlineTest::testDump from Symfony\Component\Yaml\Tests
7x in DumperTest::testDumpingArrayObjectInstancesWithNumericKeysInlined from Symfony\Component\Yaml\Tests
7x in DumperTest::testDumpingArrayObjectInstancesWithNumericKeysRespectsInlineLevel from Symfony\Component\Yaml\Tests
3x in DumperTest::testIndentationInConstructor from Symfony\Component\Yaml\Tests
1x in DumperTest::testObjectSupportEnabled from Symfony\Component\Yaml\Tests
1x in DumperTest::testObjectSupportDisabledButNoExceptions from Symfony\Component\Yaml\Tests
22x: ctype_digit(): Argument of type float will be interpreted as string in the future
15x in DumperTest::testSpecifications from Symfony\Component\Yaml\Tests
6x in InlineTest::testDump from Symfony\Component\Yaml\Tests
1x in InlineTest::testDumpNumericValueWithLocale from Symfony\Component\Yaml\Tests
```
Commits
-------
5c57324117 Fix ctype_digit deprecation
This PR was merged into the 4.4 branch.
Discussion
----------
[Yaml] Fixed an exception message
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I'd prefer to group tiny fixes like this in a single PR, but they are for different branches.
Commits
-------
7036f2f561 [Yaml] Fixed an exception message
This PR was merged into the 4.4 branch.
Discussion
----------
[WebProfilerBundle] Fix the values of some CSS properties
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
You can check the valid values of these properties at:
* https://developer.mozilla.org/en-US/docs/Web/CSS/max-width
* https://developer.mozilla.org/en-US/docs/Web/CSS/min-height
Commits
-------
e335c28d44 [WebProfilerBundle] Fix the values of some CSS properties
This PR was submitted for the 5.3 branch but it was squashed and merged into the 5.2 branch instead.
Discussion
----------
[Messenger] [Redis] Make `auth` option works
| Q | A
| ------------- | ---
| Branch? | 5.3
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Considering this configuration:
```yaml
framework:
messenger:
transports:
queue:
dsn: '%env(MESSENGER_TRANSPORT_DSN)%'
options:
stream: 'cms'
delete_after_ack: false
auth: 'pa$$word'
serializer: !php/const Redis::SERIALIZER_JSON
```
It results to this error:
```
In Connection.php line 510:
NOAUTH Authentication required.
```
Because the `auth` option was never read from the options, only from the parsed DSN.
This fix allows users to use `auth` option from the configuration.
I target 5.3, as 5.2 is going to be unmaintained at the end of July
Commits
-------
7dfdd383c9 [Messenger] [Redis] Make `auth` option works
See https://github.com/symfony/symfony/issues/42036
This adds a special case similar to `pt_BR` for handling `en_US_POSIX`
which is set as the default locale on some operating systems (Alpine
Linux, for instance).
This PR was merged into the 5.2 branch.
Discussion
----------
[FrameworkBundle] Make AbstractDataCollector extend DataCollector to reduce boilerplate
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Partially fixes#41577 (part 1)
| License | MIT
This PR makes `AbstractDataCollector` extend the base `DataCollector` in order to make it even easier to create the data collectors. Currently, developers must implement `__sleep()`, `__wakeup()`, `cloneVar()` etc on their own if they want to use `AbstractDataCollector` instead of the good old `DataCollector` which makes the "boilerplate" even bigger than just adding the `getName()`, `reset()` and `getTemplate()`, making this class less useful than the old one.
Commits
-------
c8ec05d424 make AbstractDataCollector extend DataCollector to reduce boilerplate
* 4.4:
[DoctrineBridge] fix setting default mapping type to attribute/annotation on php 8/7 respectively
do not render the same label id attribute twice
This PR was merged into the 4.4 branch.
Discussion
----------
[DoctrineBridge] fix setting default mapping type to attribute/annotation on php 8/7 respectively
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
This PR fixes a DX issue with the default recipe: right now, the mapping type has to be explicitly defined. This forces [the default recipe](https://github.com/symfony/recipes/blob/master/doctrine/doctrine-bundle/2.4/config/packages/doctrine.yaml#L15) to stick to "annotation", while the world is moving to "attribute".
Commits
-------
f06f85fbd8 [DoctrineBridge] fix setting default mapping type to attribute/annotation on php 8/7 respectively
This PR was squashed before being merged into the 5.2 branch.
Discussion
----------
[Messenger] Fixed BC layer for RedeliveryStamp
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | yes
| Tickets | Related to https://github.com/symfony/symfony/pull/41319#discussion_r640725265
| License | MIT
| Doc PR | n/a
In Symfony 6, the second argument to RedeliveryStamp's constructor will be a DateTimeInterface. We should already allow people to instantiate this object with the Symfony 6 way.
Commits
-------
ac3c4d7429 [Messenger] Fixed BC layer for RedeliveryStamp
This PR was merged into the 4.4 branch.
Discussion
----------
[TwigBridge] do not render the same label id attribute twice
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40562
| License | MIT
| Doc PR |
Commits
-------
ceee81e33d do not render the same label id attribute twice
This PR was merged into the 4.4 branch.
Discussion
----------
clean up remaining event mocks
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
f09bd17ba1 clean up remaining event mocks
* 4.4:
do not mock the Request class
do not mock event classes
recover from failed deserializations
[ErrorHandle] Remove a link from the exception page
[Validator] Added Ukrainian translations
[GHA] Clarify some bits in the deps=high script
This PR was merged into the 4.4 branch.
Discussion
----------
do not mock the Request class
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
968809c2f1 do not mock the Request class
This PR was merged into the 4.4 branch.
Discussion
----------
do not mock event classes
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
8da1969afc do not mock event classes
This PR was merged into the 5.2 branch.
Discussion
----------
[Messenger] Fix use_notify default value for PostgreSqlConnection
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
I tried to use the use_notify in my DSN with Doctrine and stumbled upon an error. I investigated and from what I see, the option isn't allowed in a DSN due to this line missing in the PostgreSqlConnection class.
Commits
-------
b2aad4f666 Fix use_notify default value for PostgreSqlConnection
Alexander M. Turek
Yoann Renard
Maximilian Bösing
Nicolas Grekas
Javier Eguiluz
Robin Chalas
Mathieu Santostefano
Alex Pott
Christopher Davis
Nyholm
Fabien Potencier
Christian Flothmann
Titouan Galopin