Commit Graph

3364 Commits

Author SHA1 Message Date
Antoine Hérault
d9f00ca7be Simplify conditional block 2011-06-07 15:19:16 +02:00
Antoine Hérault
fb051b2f98 [Command] Fix array option parsing 2011-06-07 14:58:11 +02:00
Fabien Potencier
3422c140b8 [Templating] fixed cache loader as the logical name can contain characters not valid on some OSes 2011-06-07 13:35:55 +02:00
Fabien Potencier
96fc666454 simplified cache warmers
Here are the new simplified rules:

 * Required cache warmers are *always* executed when the Kernel boots for the first time;
 * Optional cache warmers are *only* executed from the CLI via cache:warmup

These new rules means that all the configuration settings for the cache
warmers have been removed. So, if you want the best performance, remember to
warmup the cache when going to production.

This also fixed quite a few bugs.
2011-06-07 11:42:27 +02:00
Fabien Potencier
b76eec73b9 [HttpKernel] changed cache warmup to be executed even in the CLI 2011-06-07 10:41:30 +02:00
Fabien Potencier
5be0bafe7f removed TemplateReferenceInterface::getSignature() (replaced by the existing getLogicalName() which already acts as a unique identifier) 2011-06-07 10:12:38 +02:00
Fabien Potencier
2a5d7687b7 fixed Router cache warmer 2011-06-07 08:53:01 +02:00
Christophe Coevoet
f3031251c5 Added the support of the locale in the login path and the check path 2011-06-06 21:44:53 +02:00
Fabien Potencier
cb3390e9ae Merge remote branch 'gordonslondon/http-foundation/response'
* gordonslondon/http-foundation/response:
  [HttpFoundation] merge Response::isRedirected() with Response::isRedirect() - Response::isRedirected() has been removed
2011-06-06 18:06:51 +02:00
Derek ROTH
9013e3639b Changed load_resource_bundle() to use ResourceBundle::create() method instead of constructor 2011-06-06 08:45:12 -07:00
Lukas Kahwe Smith
34ac2fe200 fixed a typo 2011-06-06 17:29:50 +02:00
Fabien Potencier
78b91a017e Merge remote branch 'DerekRoth/patch-1'
* DerekRoth/patch-1:
  A constructor returning null is counter-intuitive. BTW, isn't this a intl bug ?
2011-06-06 14:52:24 +02:00
Derek ROTH
7837d328bf A constructor returning null is counter-intuitive. BTW, isn't this a intl bug ? 2011-06-06 03:32:25 -07:00
Victor Berchet
eed54c137e [Form] Fix the FormView::isRendered() method 2011-06-06 12:31:30 +02:00
Fabien Potencier
a98046dd44 [Config] added a guard against circular references 2011-06-05 10:52:57 +02:00
Fabien Potencier
87fefcae62 [Form] removed obsolete comment 2011-06-05 08:49:06 +02:00
Fabien Potencier
dd5f088abb Merge remote branch 'jwage/master'
* jwage/master:
  Revert back to using gmmktime and use day 15 instead of 1 to avoid edge case
  Use mktime instead of gmmaketime. On the 1st of every month the following options are generated:
2011-06-05 08:47:49 +02:00
Fabien Potencier
c72537da6b [Routing] fixed route matching when the prefix contains variables 2011-06-04 19:45:54 +02:00
Fabien Potencier
c561f4f0c0 [Routing] changed HTTP method to always be uppercased (to be consistent with HttpFoundation/Request) 2011-06-04 19:06:39 +02:00
Fabien Potencier
cb1f2c7e69 Merge remote branch 'kriswallsmith/templating/packages-rework'
* kriswallsmith/templating/packages-rework:
  [FrameworkBundle] updated for templating changes, added http/ssl logic
  [Templating] reworked asset helper and packages
2011-06-04 18:25:52 +02:00
Fabien Potencier
06804d3f1d [Console] added mb_detect_encoding when needed 2011-06-04 18:20:20 +02:00
Fabien Potencier
18c3049fad Merge remote branch 'brikou/console_formatter_helper'
* brikou/console_formatter_helper:
  added mb_detect_encoding when formatting block (usefull when mb_internal_encoding is not properly set)
2011-06-04 18:19:11 +02:00
Pascal Borreli
404c452c0b [Various] Phpdoc & typos 2011-06-04 15:30:56 +00:00
Fabien Potencier
8e6166fd32 Merge remote branch 'stloyd/is_null'
* stloyd/is_null:
  Remove all `is_null` alias calls.
2011-06-04 13:54:33 +02:00
Fabien Potencier
33b47b22db Merge remote branch 'schmittjoh/security'
* schmittjoh/security:
  [SecurityBundle] exposed setting in the configuration
  [Security/Http] removed irrelevant code
2011-06-04 13:52:18 +02:00
Fabien Potencier
f9ffdf5b33 [Routing] added proper support for the HEAD method 2011-06-04 12:47:38 +02:00
Fabien Potencier
9eae7e54ca [Routing] removed unneeded code in the dumper Apache rules 2011-06-04 12:46:19 +02:00
Fabien Potencier
7780c4deda [HttpKernel] removed Response content when Request method is HEAD as per RFC2616 2011-06-04 11:56:12 +02:00
Fabien Potencier
df81296443 [Routing] fixed generation when a default value is null 2011-06-03 22:57:26 +02:00
Fabien Potencier
79c6dc7937 [Console] fixed nested styles 2011-06-03 22:48:04 +02:00
Matthieu Vachon
954bdb5813 [Form] Updated DateTimeType to accept a custom date pattern for the DateType child
* Added a test also about this change
2011-06-03 11:05:11 -04:00
Matthieu Vachon
e7e744f00a [Form] Synced changes in this branch with current Symfony master branch 2011-06-03 10:51:08 -04:00
Matthieu Vachon
436cb95223 [Form] Changed to a CreateException when the 'format' option is invalid
* Updated DateTypeTest also
2011-06-03 10:47:00 -04:00
Matthieu Vachon
a8152326fb [Form] The IntlDateFormatter pattern can now be passed via the format option
* Also changed the default value of the calendar paramter to \IntlDateFormatter:GREGORIAN
   in DateTimeToLocalizedStringTransformer which is the same as the default value in
   StubIntlDateFormatter
2011-06-03 10:46:58 -04:00
Amal Raghav
52a1e1d281 moved date_pattern to IntlDateFormatter
added code to use custom date_pattern
2011-06-03 10:46:55 -04:00
Amal Raghav
dd104bc8c0 added code to use custom date_pattern 2011-06-03 10:46:54 -04:00
Johannes M. Schmitt
672cf78816 [Security/Http] removed irrelevant code 2011-06-03 14:02:57 +02:00
stloyd
4e03db63d7 Remove all is_null alias calls. 2011-06-03 11:16:32 +02:00
Christophe Coevoet
f84ee37ae0 [HttpKernel] Fixed the test about the availability of the logger 2011-06-03 00:00:41 +02:00
Jonathan H. Wage
611dbf1bfe Revert back to using gmmktime and use day 15 instead of 1 to avoid edge case 2011-06-02 13:47:58 -07:00
Brikou CARRE
597a646347 added mb_detect_encoding when formatting block (usefull when mb_internal_encoding is not properly set) 2011-06-02 13:20:51 +02:00
Katsuhiro OGAWA
790284f2a8 [Form] Fixed FixRadioInputListener to not ignore 0. 2011-06-02 19:19:43 +09:00
Katsuhiro OGAWA
5893874ed5 [Form] Fixed single expanded choice type to set checked attribute when passed boolean value 2011-06-02 19:19:42 +09:00
Jonathan H. Wage
cd99d2a07d Use mktime instead of gmmaketime. On the 1st of every month the following options are generated:
<select id="filter_start_date_month" name="filter[start][date][month]">
<option value="1">Dec</option>
<option value="2">Jan</option>
<option value="3">Feb</option>
<option value="4">Mar</option>
<option value="5">Apr</option>
<option value="6" selected="selected">May</option>
<option value="7">Jun</option>
<option value="8">Jul</option>
<option value="9">Aug</option>
<option value="10">Sep</option>
<option value="11">Oct</option>
<option value="12">Nov</option>
</select>

I do not totally understand the problem but using mktime instead of gmmktime fixes the issue.
2011-06-01 12:09:28 -05:00
Johannes M. Schmitt
6f8871d2d7 [SecurityBundle] added validation for check paths 2011-06-01 13:05:34 +02:00
Johannes M. Schmitt
90b63ca346 [Security/Core] added missing method to interface 2011-06-01 11:48:19 +02:00
Fabien Potencier
c8034c04a8 Merge remote branch 'vicb/form-rendering'
* vicb/form-rendering:
  [Form] The variable stack should not persist between section rendering (fixes #1157)
  [Twig][Form] Tweak form extension phpDoc and code
  [Form] Tweak phpDoc
  [FormView] fix phpDoc
  [Form] Some tweaks
2011-06-01 10:32:40 +02:00
Kris Wallsmith
2642b0012f [Templating] reworked asset helper and packages
Added support for a configurable format string used to apply version to a path (defaults to '%s?%s').

Moved base url/base path logic to packages.
2011-05-31 06:46:30 -07:00
Fabien Potencier
f70c7e7c1c [HttpKernel] added Filesystem::isAbsolutePath() 2011-05-31 11:04:23 +02:00
Fabien Potencier
65200aa86a added missing license headers 2011-05-31 10:57:06 +02:00
Fabien Potencier
839c332438 moved all listener classes under a common EventListener sub-namespace 2011-05-31 10:43:20 +02:00
Fabien Potencier
7d999acd0b fixed previous commit 2011-05-31 09:31:09 +02:00
Fabien Potencier
28527c7c91 renamed some UniversalClassLoader for better consistency 2011-05-31 09:28:32 +02:00
Fabien Potencier
02605f3481 merged origin/master 2011-05-31 08:34:05 +02:00
Fabien Potencier
3ca5780486 [HttpKernel] added a NullLogger 2011-05-31 08:02:17 +02:00
Fabien Potencier
d1ca577e3f removed Logger::getDebugLogger() as the method is not part of any interface 2011-05-31 08:02:14 +02:00
Fabien Potencier
79e709cdc9 removed the ON_ prefix for Form event names 2011-05-31 07:19:18 +02:00
Fabien Potencier
514bf9af5d [Security] fixed wrong function call 2011-05-30 22:52:35 +02:00
Fabien Potencier
988355993a refactored Profiler class 2011-05-30 22:25:25 +02:00
Benjamin Eberlei
5808715df2 [Translation] Add Qt Translation component with tests 2011-05-30 16:12:18 +02:00
Fabien Potencier
a2163f39ff [EventDispatcher] re-added the cache layer 2011-05-30 16:00:29 +02:00
Fabien Potencier
a3403e492e [EventDispatcher] removed unneeded code 2011-05-30 15:56:06 +02:00
Victor Berchet
cbfc146ac8 [Form] Tweak phpDoc 2011-05-30 15:21:15 +02:00
Fabien Potencier
c8f9904ac8 merged origin/master 2011-05-30 15:00:41 +02:00
Fabien Potencier
4f7484b946 [HttpFoundation] moved dir creation just before writing to disk 2011-05-30 14:59:02 +02:00
Victor Berchet
99bf22c464 [Form] Some tweaks 2011-05-30 14:57:33 +02:00
Fabien Potencier
9181e5dd0c merged origin/master 2011-05-30 14:28:54 +02:00
Johannes M. Schmitt
971ff8175f [Security] fixes a possible bug when username is an integer 2011-05-30 14:09:16 +02:00
Fabien Potencier
71411ba368 fixed typos 2011-05-30 13:53:50 +02:00
Fabien Potencier
d7220f0c1a [Security] fixed event names 2011-05-30 13:53:47 +02:00
Johannes M. Schmitt
bac3ee86f9 [Security] fixes a regression in the AclVoter 2011-05-30 10:04:46 +02:00
Johannes M. Schmitt
8837ce0e57 Merge branch 'master' of http://github.com/symfony/symfony into security 2011-05-30 10:00:07 +02:00
Fabien Potencier
9b7e14dd10 [Form] converted code to the new event dispatcher 2011-05-30 09:37:42 +02:00
Fabien Potencier
0ce22f6bbe [Security] removed obsolete use statements 2011-05-30 09:36:59 +02:00
Fabien Potencier
90ca8e0404 fixed more unit tests 2011-05-30 09:19:01 +02:00
Fabien Potencier
c171142c01 renamed constants to upper cased 2011-05-30 09:04:37 +02:00
Fabien Potencier
f6b481a9ee [EventDispatcher] simplified code and fixed unit tests 2011-05-30 08:59:28 +02:00
Fabien Potencier
09a6e6759a [EventDispatcher] fixed notices 2011-05-30 08:59:22 +02:00
Fabien Potencier
5059559035 Merge remote branch 'Seldaek/events' into events1
* Seldaek/events:
  [EventDispatcher] Removed temporary code
  [FrameworkBundle] Improved code readability
  [FrameworkBundle] Clarified code and fixed regression
  Update Core and Security events to latest model
  [EventDispatcher] Allow registration of arbitrary callbacks
  [EventDispatcher] Remove useless code
  [EventDispatcher] Minor memory optimization to getListeners()
  [FrameworkBundle] Small optimization, remove some function calls
2011-05-30 08:58:49 +02:00
Pascal Borreli
824e48efa7 [Various] Fixed phpdoc 2011-05-29 23:33:36 +00:00
Pascal Borreli
50d5e3e007 [Various] Fixed typos 2011-05-29 22:24:32 +00:00
Fabien Potencier
6301728383 Merge remote branch 'pborreli/fixed-typos'
* pborreli/fixed-typos:
  [Various] Fixed typo
  [FrameworkBundle] Fixed css
2011-05-29 20:54:38 +02:00
Ryan Weaver
4f0214eff4 [Routing] Fixing a bug where the current directory was set too late in the PhpFileLoader 2011-05-29 11:26:36 -05:00
Pascal Borreli
46cdf02750 [Various] Fixed typo 2011-05-29 14:19:02 +00:00
GordonsLondon
ef9dc7c623 [HttpFoundation] merge Response::isRedirected() with Response::isRedirect() - Response::isRedirected() has been removed 2011-05-29 15:34:02 +02:00
Johannes M. Schmitt
88becfe3f8 [HttpFoundation] allow locale in RequestMatcher path 2011-05-28 22:37:43 +02:00
Johannes Schmitt
1f91e2e618 Revert "revert exception message"
This reverts commit b637a3190d.
2011-05-28 18:06:47 +02:00
Fabien Potencier
40b84320d6 [Form] tweaked comment 2011-05-28 18:06:11 +02:00
Fabien Potencier
3b0089967f Merge remote branch 'stloyd/patch-11'
* stloyd/patch-11:
  [Form] Force hidden fields to not have "required" attribute (#1091)
2011-05-28 18:05:27 +02:00
Fabien Potencier
1548a049e1 Merge remote branch 'mvrhov/single_text_option_rename'
* mvrhov/single_text_option_rename:
  Added a note about BC break for DateType into UPDATE.md file
  DateType single-text should be single_text
2011-05-28 18:02:36 +02:00
Johannes Schmitt
edbf4ea691 Merge branch 'security' of github.com:schmittjoh/symfony into security 2011-05-28 17:09:32 +02:00
Johannes Schmitt
f37386e336 Merge branch 'master' of git://github.com/symfony/symfony into security 2011-05-28 17:07:16 +02:00
Arnout Boks
a0397f99f5 [DependencyInjection] Fixed bug where anonymous services from two different xml-files (with the same basename) could collide 2011-05-28 10:29:32 +02:00
kaiwa
cdf4b6aa77 Checked log levels 2011-05-27 20:29:51 +02:00
Miha Vrhovnik
b8144c62ad DateType single-text should be single_text 2011-05-27 16:23:59 +02:00
Fabien Potencier
af2f9207be [Console] fixed typo 2011-05-27 15:34:13 +02:00
Joseph Bielawski
4b476ad267 [Form] Force hidden fields to not have "required" attribute (#1091) 2011-05-27 04:48:14 -07:00
Fabien Potencier
4de930b000 [HttpFoundation] added some phpdoc 2011-05-27 07:55:37 +02:00
Ryan Weaver
bad1cb61d0 [Security] Adding tests and then fixing bug where ContextListener did no logging 2011-05-26 15:08:19 -05:00
Fabien Potencier
9aa8083cb4 [Routing] fixed previous merge 2011-05-26 18:28:42 +02:00
Fabien Potencier
5911fb946d [Routing] fixed CS 2011-05-26 18:27:18 +02:00
Fabien Potencier
1c0dfad979 Merge remote branch 'Chekote/xmlfileloader_overload_refactor'
* Chekote/xmlfileloader_overload_refactor:
  Refactored the processing of each individual node into it's own method, enabling easier overloading of behavior for Bundles such as FriendsOfSymfony/RestBundle
2011-05-26 18:25:53 +02:00
Fabien Potencier
6507eeff3c Merge remote branch 'CodeMeme/1058-fix-radio-input-listener'
* CodeMeme/1058-fix-radio-input-listener:
  Fix for RadioInputListener's empty value erroneously becoming extra data Refs #1058
  Added test for RadioInputListener bug treating no data as extra data
2011-05-26 17:31:09 +02:00
Fabien Potencier
1a109c8bcd [BrowserKit] fixed CS 2011-05-26 17:07:51 +02:00
Fabien Potencier
eb90427e92 Merge remote branch 'danielholmes/cookie_fixes'
* danielholmes/cookie_fixes:
  [BrowserKit] fixed explicit cookie params being overriden by url
2011-05-26 17:07:13 +02:00
Fabien Potencier
c19d6c07d2 [HttpFoundation] simplified code 2011-05-26 15:02:40 +02:00
Fabien Potencier
1f369ed1ed Merge remote branch 'zerosanity/master'
* zerosanity/master:
  Added missing space.
  Fixed broken logic in Request::getHttpHost(). It was ignoring HTTP_HOST completely.
2011-05-26 15:01:53 +02:00
Fabien Potencier
699ecfcf90 Merge remote branch 'stloyd/validators_refactoring'
* stloyd/validators_refactoring:
  Refactor validators constraints: - remove need for defining "getTargets()" method as 95% of validators use same one - replace abstract "Constraint::getTargets()" with one that use 95% of validators - add additional tests for "Constraint::getTargets()" method - remove unused "use" statement in Constraint\Valid
2011-05-26 14:58:24 +02:00
Fabien Potencier
43817de633 Merge remote branch 'maoueh/date_type_dead_code'
* maoueh/date_type_dead_code:
  [Form] Removed dead code in the buildForm method of DateType.php  * With the introduction of the getAllowedOptionValues mechanics, the check    is performed prior to the buildForm call. There is no more needs to check    it again in DateType.
2011-05-26 14:57:54 +02:00
Fabien Potencier
67118f7878 Merge remote branch 'sonata-project/change_self_to_static'
* sonata-project/change_self_to_static:
  change self to static so the parent class can have access to the child constant
2011-05-26 12:55:15 +02:00
Fabien Potencier
be95bff7ca [Routing] tweaked error messages 2011-05-26 12:54:21 +02:00
Fabien Potencier
5b6f15b661 Merge remote branch 'gimler/master'
* gimler/master:
  use param names in exception not the index
2011-05-26 12:53:26 +02:00
Fabien Potencier
3bdb7c2b57 [DependencyInjection] fixed regression when a parameter contains an escaped %
Notice that this is still not perfect, but I don't see how to fix the remaining
potential problems.
2011-05-26 12:47:50 +02:00
Jordi Boggiano
ba8758b4c2 [EventDispatcher] Removed temporary code 2011-05-26 11:56:59 +02:00
Jordi Boggiano
af0bd8a136 Update Core and Security events to latest model
The main benefit is that in XML/YML files we have common syntax (i.e. core.controller, form.pre_bind) that properly namespaces event names (before: onCoreController was ok, preBind was not).
On the other hand in PHP land we also have namespaced events, CoreEvents::controller, FormEvents::preBind, before it was Events::onCoreController, Events::onPreBind, we now have more context.
2011-05-26 11:55:07 +02:00
Jordi Boggiano
1246503e55 [EventDispatcher] Allow registration of arbitrary callbacks
This in effect removes the direct link between event name and the method name on the handler.
Any callback can be given as a handler and the event name becomes an arbitrary string. Allowing for easier namespacing (see next commit)
2011-05-26 11:54:06 +02:00
Jordi Boggiano
000229dbd0 [EventDispatcher] Remove useless code 2011-05-26 11:54:02 +02:00
Jordi Boggiano
9816b6adc3 [EventDispatcher] Minor memory optimization to getListeners() 2011-05-26 11:54:00 +02:00
Jordi Boggiano
48d6a95803 [FrameworkBundle] Small optimization, remove some function calls 2011-05-26 11:53:58 +02:00
Fabien Potencier
ce79fa9ba2 [DependencyInjection] fixed typo 2011-05-26 08:22:16 +02:00
Daniel Holmes
3c372d3773 [BrowserKit] fixed explicit cookie params being overriden by url 2011-05-26 15:28:51 +10:00
Eric Clemmons
c06a157759 Fix for RadioInputListener's empty value erroneously becoming extra data
Refs #1058
2011-05-25 22:24:49 -07:00
Joshua Nye
3832a7a33d Added missing space. 2011-05-25 17:22:32 -04:00
Joshua Nye
f019541716 Fixed broken logic in Request::getHttpHost(). It was ignoring HTTP_HOST completely. 2011-05-25 16:02:16 -04:00
Eric Clemmons
c13cdd34c5 FormError when not synchronized tells you the form name for easier debugging 2011-05-25 12:50:34 -07:00
Gordon Franke
60527574d9 use param names in exception not the index 2011-05-25 21:02:01 +02:00
Fabien Potencier
ce19cc0698 Merge remote branch 'Seldaek/domcrawler'
* Seldaek/domcrawler:
  [DomCrawler] Uppercase http methods
2011-05-25 18:27:12 +02:00
Jordi Boggiano
08e7629fb4 [DomCrawler] Uppercase http methods 2011-05-25 15:45:23 +02:00
stealth35
956f58733c SQLite -> SQLite3 2011-05-25 05:51:48 -07:00
Fabien Potencier
66064cc8fc fixed CS 2011-05-25 11:35:29 +02:00
stloyd
db28beb395 Simplify RegexValidator 2011-05-25 11:08:13 +02:00
stloyd
3ea2a32c53 Refactor validators constraints:
- remove need for defining "getTargets()" method as 95% of validators use same one
- replace abstract "Constraint::getTargets()" with one that use 95% of validators
- add additional tests for "Constraint::getTargets()" method
- remove unused "use" statement in Constraint\Valid
2011-05-25 10:51:35 +02:00
Fabien Potencier
462f222319 [DependencyInjection] changed \LogicException to RuntimeException to be more consistent 2011-05-25 09:59:38 +02:00
Fabien Potencier
2438a73c7b [DependencyInjection] added a check for circular references in parameter definitions 2011-05-25 09:57:38 +02:00
Fabien Potencier
456eb53eb8 [DependencyInjection] renamed CircularReferenceException to ServiceCircularReferenceException 2011-05-25 09:48:49 +02:00
Fabien Potencier
6c409cac84 [DependencyInjection] refactored parameter bag parameter replacements (removed duplicated code) 2011-05-25 09:35:51 +02:00
Fabien Potencier
179864414e [Form] fixed CS 2011-05-25 08:03:21 +02:00
hlecorche
cc49cd9498 Merge remote-tracking branch 'remotes/symfony/master' 2011-05-24 23:25:58 +02:00
Fabien Potencier
05778c719f [BrowserKit] fixed CS 2011-05-24 20:37:52 +02:00
Fabien Potencier
e0bf310b55 Merge remote branch 'hnw/cookie-raw-value'
* hnw/cookie-raw-value:
  added test for Cookie#getRawValue and CookieJar#AllRawValues
  fixed doc comment
  [BrowserKit] dealing with raw value for cookies
2011-05-24 20:20:57 +02:00
Fabien Potencier
aa356e7288 [BrowserKit] fixed cookie management (see RFC 2109) 2011-05-24 20:08:11 +02:00
Thomas Rabaix
be2c427053 change self to static so the parent class can have access to the child constant 2011-05-24 18:25:28 +02:00
Kai
dca09fd53f Changed log level of "Using Controller ..." message from info to debug 2011-05-24 15:25:54 +02:00
Johannes M. Schmitt
decac13331 added a few finals 2011-05-24 15:08:22 +02:00
Johannes M. Schmitt
0f9767a49e Merge remote branch 'origin/master' into security 2011-05-24 14:58:41 +02:00
hlecorche
400de9c541 IntegerToLocalizedStringTransformer must return "null" if input value is null 2011-05-24 10:52:28 +02:00
Fabien Potencier
754a0771f3 Merge remote branch 'everzet/builder-private-services-fix'
* everzet/builder-private-services-fix:
  [DependencyInjection] create inlined private service from it's definition
  [DependencyInjection] added failing private service user test-case
2011-05-24 10:32:48 +02:00
Fabien Potencier
0dab2de6da Merge remote branch 'craue/patch-1'
* craue/patch-1:
  removed unnecessary semicolon
2011-05-24 09:57:41 +02:00
Fabien Potencier
68aa0f46a4 Merge remote branch 'jdhoek/master'
* jdhoek/master:
  Add missing {} around @inheritDoc to fix this class in SF beta2.
  Add missing {} around @inheritDoc to fix this class in SF beta2.
2011-05-24 09:53:18 +02:00
Fabien Potencier
674ec1a476 Merge remote branch 'jdhoek/patch-4'
* jdhoek/patch-4:
  Add missing {} around @inheritDoc to fix this class in SF beta2.
2011-05-24 09:53:14 +02:00
Fabien Potencier
465be3d94c Merge remote branch 'jdhoek/patch-3'
* jdhoek/patch-3:
  Add {} around @inheritDoc.
2011-05-24 09:53:10 +02:00
Fabien Potencier
d2570b18f8 Merge remote branch 'jdhoek/patch-2'
* jdhoek/patch-2:
  Add {} around @inheritDoc
2011-05-24 09:53:04 +02:00
jdhoek
67cace5d21 Add missing {} around @inheritDoc to fix this class in SF beta2. 2011-05-24 00:40:39 -07:00
jdhoek
7e4419368e Add missing {} around @inheritDoc to fix this class in SF beta2. 2011-05-24 00:38:15 -07:00
jdhoek
42d33489c5 Add {} around @inheritDoc. 2011-05-24 00:36:03 -07:00
jdhoek
cda87bef23 Add {} around @inheritDoc 2011-05-24 00:33:56 -07:00
jdhoek
c6172e0f96 Add {} around @inheritDoc annotation to fix this class in SF beta2 2011-05-24 00:29:42 -07:00
Christian Raue
0306be6888 removed unnecessary semicolon 2011-05-23 14:39:25 -07:00
everzet
b6ce137e2d [DependencyInjection] create inlined private service from it's definition 2011-05-23 23:00:38 +03:00
Fabien Potencier
15bede5a63 [Console] refactored style management
The current code was broken when a style was defined inline:

  <bg=black>Foo</bg=black>

When creatin a new style formatter, it's better to let the formatter
apply the style to the text.
2011-05-23 16:54:36 +02:00
Florin Patan
06f74f8a39 Fix problem with searching files while the open_basedir is in use 2011-05-23 12:54:22 +00:00
Fabien Potencier
7ab3fdeb83 [Finder] added a way to ignore all 'hidden' files 2011-05-23 11:05:58 +02:00
Fabien Potencier
d88f6b9c24 Merge remote branch 'brikou/phpdoc_request'
* brikou/phpdoc_request:
  removed docblock for isNoCache
  fixed the description of isNoCache method
  fixed description for isNoCache method
  added missing method's docblock
2011-05-23 10:39:34 +02:00
Brikou CARRE
9908d51da8 removed docblock for isNoCache 2011-05-23 01:37:10 -07:00
Brikou CARRE
2648ff273e fixed the description of isNoCache method 2011-05-23 09:35:41 +02:00
Brikou CARRE
12bf94c7ff fixed description for isNoCache method 2011-05-23 08:44:08 +02:00
Miha Vrhovnik
e8326aa650 Renamed attributes to attr to be consistent with templating. 2011-05-23 08:10:03 +02:00
Fabien Potencier
60b811947b [Form] fixed error message (closes #1034) 2011-05-23 08:06:43 +02:00
Miha Vrhovnik
c7074672ba Added support for additional attributes in Form types that list field as their parent. 2011-05-22 22:59:00 +02:00
Yoshio HANAWA
120898f81a fixed doc comment 2011-05-23 05:43:45 +09:00
Yoshio HANAWA
2cecc95d9e [BrowserKit] dealing with raw value for cookies 2011-05-23 04:49:01 +09:00
Matthieu Vachon
87176e39d1 [Form] Removed dead code in the buildForm method of DateType.php
* With the introduction of the getAllowedOptionValues mechanics, the check
   is performed prior to the buildForm call. There is no more needs to check
   it again in DateType.
2011-05-22 13:51:00 -04:00
Pascal Borreli
7f089c0b05 [Process] Fixed namespace typo and windows test 2011-05-22 14:57:37 +00:00
Brikou CARRE
e018e6ce44 added missing method's docblock 2011-05-22 09:13:03 +02:00
Fabien Potencier
a2a1a88291 Merge remote branch 'schmittjoh/annotations'
* schmittjoh/annotations:
  removed obsolete compiler pass
  fixed some more tests
  fixed tests
  removed unused vendor
  some cleanups
  updated to latest changes
  [WebProfilerBundle] removed @ignorePhpDoc annotations
  [FrameworkBundle] fixed default
  [FrameworkBundle] updated configuration
  [Validator] updated fixtures
  updated UPDATE file
  updated Annotations integration
  [Routing] updated to changes
  [FrameworkBundle] added framework-wide annotation reader, updated validator tests
  [WebProfilerBundle] fixed controllers
  fixed unit tests
  added Annotations library
2011-05-22 08:45:24 +02:00
Fabien Potencier
ac1bde9003 Merge remote branch 'beberlei/YamlRoutingLoader'
* beberlei/YamlRoutingLoader:
  [Routing] Remove exception condition in YamlFileLoader::load() as its duplicating a check that is done in parseRoute() anyways. This changes allows to extend the YamlFileLoader without having to duplicate the whole method.
2011-05-22 08:32:12 +02:00
Fabien Potencier
2d2de7e8b0 Merge remote branch 'vicb/form-field'
* vicb/form-field:
  [Form] Tweak the field type
2011-05-22 08:29:54 +02:00
Fabien Potencier
17d9c97a77 Merge remote branch 'pminnieur/patch-1'
* pminnieur/patch-1:
  fixed wrong usage of `supportsDenormalization()` (@see NormalizerInterface)
2011-05-22 08:22:25 +02:00
Fabien Potencier
2c85a59599 Merge remote branch 'vicb/form-rendered'
* vicb/form-rendered:
  [Form] Fix for nested forms getting erroneously set as rendered
2011-05-22 08:16:24 +02:00
Fabien Potencier
5429593459 Merge remote branch 'kertz/datetime_single_text'
* kertz/datetime_single_text:
  added missing single-text option
2011-05-22 08:14:35 +02:00
Fabien Potencier
b042366353 Merge remote branch 'stfalcon/patch-2'
* stfalcon/patch-2:
  Small refact. Without this I get a php Notice and Warnig if try getFlash() after clearing the session:
2011-05-22 08:08:28 +02:00
Pierre Minnieur
8bc13b9cdd fixed wrong usage of supportsDenormalization() (@see NormalizerInterface) 2011-05-21 05:48:27 -07:00
Amal Raghav
517f95d8a4 added missing single-text option 2011-05-20 19:19:23 +05:30
Victor Berchet
e117613550 [Form] Fix for nested forms getting erroneously set as rendered 2011-05-20 15:48:55 +02:00
Victor Berchet
e0ff7d2613 [Form] Tweak the field type 2011-05-20 11:08:48 +02:00
Fabien Potencier
5ad2ff0595 [Console] added the possibility to pass a default value for DialodHelper::askAndValidate() 2011-05-20 08:24:54 +02:00
Johannes Schmitt
6c0b0449a6 Merge remote branch 'origin/master' into annotations
Conflicts:
	UPDATE.md
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
2011-05-19 22:49:59 +02:00
Johannes Schmitt
42fb34b647 fixed tests 2011-05-19 22:46:34 +02:00
Kris Wallsmith
fc5992495f [HttpFoundation] updated session to only save on destruct if started 2011-05-19 11:47:21 -07:00
Kris Wallsmith
ed8ecab7ea [HttpFoundation] fixed locale accessor after session clear 2011-05-19 11:45:12 -07:00
Kris Wallsmith
a538344b3b [HttpFoundation] removed unnecessary method 2011-05-19 11:44:15 -07:00
Benjamin Eberlei
ec22b03b1d [Routing] Remove exception condition in YamlFileLoader::load() as its duplicating a check that is done in parseRoute() anyways. This changes allows to extend the YamlFileLoader without having to duplicate the whole method. 2011-05-19 20:26:26 +02:00
Fabien Potencier
91b1becc7d Merge remote branch 'schniper/patch-2'
* schniper/patch-2:
  Fix process creation under Win7 Ultimate (app/console assetic:dump ./web): - Set the default $env to NULL, thus inheriting the system's environment settings (array() is no good). - Set bypass_shell to false, otherwise process creation will fail (I don't know if this should happen only on Win7)
2011-05-19 17:39:36 +02:00
Fabien Potencier
9714524b39 fixed a unit test and CS 2011-05-19 17:38:16 +02:00
jsor
fd6c254b47 [HttpFoundation] changed checking for deleted cookie to be conform with setcookie() 2011-05-19 17:14:03 +02:00
jsor
fc1a8cac35 [HttpFoundation] allow negative values for cookies expires timestamp 2011-05-19 17:14:02 +02:00
jsor
f9b6c8b74a [HttpFoundation] included cookie headers in string representation 2011-05-19 17:14:01 +02:00
jsor
e6d929aa71 [HttpFoundation] added __toString() method 2011-05-19 17:13:58 +02:00
Costin Bereveanu
5841f05f04 Fix process creation under Win7 Ultimate (app/console assetic:dump ./web):
- Set the default $env to NULL, thus inheriting the system's environment settings (array() is no good).
- Set bypass_shell to false, otherwise process creation will fail (I don't know if this should happen only on Win7)
2011-05-19 07:52:45 -07:00
Fabien Potencier
9fe1c3ae0e Merge remote branch 'bschussek/form'
* bschussek/form: (22 commits)
  Fix merge error (function "guess" was in there twice)
  [Form] Added test case for bf2f9d2a02
  [Form] Form::isBound() and Form::isValid() work correctly now for read-only forms
  [Locale] Improved error reporting and added stubs for intl_is_failure(), intl_get_error_code() and intl_get_error_message()
  [Form] Implemented fix for 361c67f54f
  [Form] Add test for the handling of array values in the constraint violation
  [Form] Further simplified PropertyPath code
  [Form] Added test for 6c337d1cc0
  [Form] Removed unused option "pattern" of date and time type
  [Form] Renamed view variable "name" to "full_name"
  [Form] Renamed collection option "type_options" to "options" to be consistent with the repeated type
  [Form] CSRF documentation and a few CS changes
  [Form] Move CSRF options from types to the CSRF extension
  [Form] Added a search form field type
  [Form] Optimization of PropertyPath
  [Form] replace assertEquals by assertFalse, assertTrue, assertNull
  [Form] fix file permissions to 644 again ;)
  [Form] add tests for type_options in collectionType
  fix file permissions to 644
  [Form] add type_options for CollectionType to be abble to set options to type
  ...
2011-05-19 16:25:30 +02:00
Fabien Potencier
c4232b11fa Merge remote branch 'beberlei/DoctrineUniqueValidator'
* beberlei/DoctrineUniqueValidator:
  [Doctrine] Fix default value to null for entity manager to make fluent integration with Doctrine Registry work
  [Doctrine] Add fields as default option and allow strings to be passed.
  [Doctrine] Add DoctrineBundle integration (DI Container registration) for the UniqueEntityValidator
  [Doctrine] Implement suggested changes by Stof, added functional test to verify unique validator works.
  [Doctrine] Add Unique Validator
2011-05-19 15:38:20 +02:00
Fabien Potencier
38baa85d46 Merge remote branch 'AurelC2G/fix-phpdoc'
* AurelC2G/fix-phpdoc:
  [Config] fixed phpdoc
2011-05-19 15:35:53 +02:00
Fabien Potencier
a75303029d Merge remote branch 'stealth35/patch-1'
* stealth35/patch-1:
  checkdnsrr exits for all PHP 5.3 version
2011-05-19 15:35:05 +02:00
Michel Weimerskirch
fd92105fa0 Fix merge error (function "guess" was in there twice) 2011-05-19 05:45:29 -07:00
stealth35
61b23a5a68 checkdnsrr exits for all PHP 5.3 version 2011-05-19 05:21:53 -07:00
Miha Vrhovnik
2e286073a4 Removed ability to override method from GET request 2011-05-19 14:08:34 +02:00
Miha Vrhovnik
65ed6f7763 Added support for request method overriding via X-HTTP-Method-Override
This type of override is supported by MS MVC3 and is recommended by Google.
Also added ability to override request method via ?_method= when
request is made via GET.
2011-05-19 09:33:08 +02:00
Aurélien Fredouelle
c0e8db18f9 [Config] fixed phpdoc 2011-05-19 08:05:27 +02:00
Bernhard Schussek
dcc61a9a98 Merge remote branch 'shieldo/search_field' into shieldo_merge 2011-05-19 01:41:59 +02:00
Bernhard Schussek
13a964ae6d [Form] Form::isBound() and Form::isValid() work correctly now for read-only forms 2011-05-19 01:24:28 +02:00
Bernhard Schussek
829aa4dc0b [Locale] Improved error reporting and added stubs for intl_is_failure(), intl_get_error_code() and intl_get_error_message() 2011-05-19 01:15:37 +02:00
Bernhard Schussek
c3e8569f73 Merge remote branch 'vicb/form-csrf' into vicb_merge 2011-05-18 23:56:11 +02:00
Bernhard Schussek
06f829ace5 [Form] Implemented fix for 361c67f54f 2011-05-18 23:51:39 +02:00
Bernhard Schussek
a7ff4f484a [Form] Further simplified PropertyPath code 2011-05-18 23:39:49 +02:00
Bernhard Schussek
857042458a Merge remote branch 'vicb/form-ppath-optim' into vicb_merge 2011-05-18 23:34:53 +02:00
Bernhard Schussek
af66beed76 [Form] Added test for 6c337d1cc0 2011-05-18 23:20:37 +02:00
Bernhard Schussek
a3d84bc681 Merge remote branch 'vicb/form-9731' into vicb_merge 2011-05-18 23:12:27 +02:00
Bernhard Schussek
216d7e415d Merge remote branch 'mweimerskirch/form_pattern_attribute' into mweimerskirch_merge
Conflicts:
	src/Symfony/Bundle/TwigBundle/Resources/views/Form/div_layout.html.twig
	src/Symfony/Component/Form/Extension/Core/Type/FieldType.php
	src/Symfony/Component/Form/Extension/Validator/ValidatorTypeGuesser.php
2011-05-18 22:49:27 +02:00
Bernhard Schussek
520e3761e9 [Form] Removed unused option "pattern" of date and time type 2011-05-18 22:34:34 +02:00
Bernhard Schussek
f467317bab [Form] Renamed view variable "name" to "full_name"
The variable "name" now contains the local, short name (equivalent to $form->getName()).
2011-05-18 22:16:16 +02:00
Bernhard Schussek
b39a21fbaf [Form] Renamed collection option "type_options" to "options" to be consistent with the repeated type 2011-05-18 21:52:59 +02:00
Bernhard Schussek
2711fbc418 Merge remote branch 'jaugustin/fix_form' into jaugustin_merge
Conflicts:
	src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
	src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php
2011-05-18 21:40:20 +02:00
Fabien Potencier
82686751dd [HttpCache] fixed typo 2011-05-18 18:40:36 +02:00
Fabien Potencier
f48699a706 [HttpKernel] reverted some unwanted changes from previous commit 2011-05-18 18:17:14 +02:00
Fabien Potencier
1f0ffca68e [HttpKernel] fixed empty ETags showing up in requests to the backend when using HttpCache 2011-05-18 17:06:05 +02:00
Johannes Schmitt
bd9bfafd9c [Security/Http] use deep parameter for CSRF parameter 2011-05-18 13:01:54 +02:00
Johannes Schmitt
0eb7564f7d Merge remote branch 'origin/master' into security
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/Listener/RequestAttributeInitializingListener.php
2011-05-18 12:54:47 +02:00
Johannes Schmitt
53f5c23c8f [Security/Acl] small voter refactoring 2011-05-18 12:48:50 +02:00
Victor Berchet
ebb0e83a7e [Form] CSRF documentation and a few CS changes 2011-05-18 12:45:01 +02:00
Victor Berchet
ba31b5acc5 [Form] Move CSRF options from types to the CSRF extension 2011-05-18 10:37:31 +02:00
Benjamin Eberlei
cfc2471109 [Doctrine] Add Unique Validator 2011-05-17 23:04:13 +02:00
Fabien Potencier
a965a5ce32 Merge remote branch 'kertz/PdoSessionStorage_mysql'
* kertz/PdoSessionStorage_mysql:
  [PdoSessionStorage] Added insert... on duplicate
2011-05-17 17:55:41 +02:00
Fabien Potencier
bb0b3efbf0 [Routing] renamed Exception interface to ExceptionInterface to follow CS 2011-05-17 17:04:08 +02:00
Fabien Potencier
0e65bc746e [DependencyInjection] renamed Exception interface to ExceptionInterface to follow CS 2011-05-17 16:57:31 +02:00
Fabien Potencier
2cd04547fd [Routing] renamed some exceptions 2011-05-17 16:52:02 +02:00
Fabien Potencier
0168241014 [DependencyInjection] renamed NonExistentParameterException and NonExistentServiceException to ParameterNotFoundException and ServiceNotFoundException 2011-05-17 16:26:08 +02:00
Fabien Potencier
eb202bb7b7 merged kriswallsmith/form/csrf-intention 2011-05-17 15:25:50 +02:00
alexandresalome
1d6b94189b [Routing] Use routing exceptions in the dumper and add tests. 2011-05-17 11:31:47 +02:00
Fabien Potencier
24d79f680f [Routing] changed visibility 2011-05-17 10:48:38 +02:00
Fabien Potencier
09cccf60c7 Merge remote branch 'stof/ParameterBagInterface'
* stof/ParameterBagInterface:
  [DependencyInjection] Removed the public keyword from interface
  [DependencyInjection] Added missing methods in the ParameterBagInterface
  [DependencyInjection] Fixed phpdoc
2011-05-17 10:29:19 +02:00
Fabien Potencier
b6a8f3a267 [Console] fixed typo 2011-05-17 10:27:02 +02:00
Fabien Potencier
6308f93c64 [Console] added some explanation on how DialogHelper::askAndValidate works 2011-05-17 10:26:33 +02:00
Fabien Potencier
02e77ec4e3 [Routing] moved Matcher exceptions 2011-05-17 10:11:27 +02:00
Fabien Potencier
51eb746925 Merge remote branch 'alexandresalome/feat-routing-exceptions'
* alexandresalome/feat-routing-exceptions:
  [Routing] Fix the exception inheritance + Add the LICENCE block in new files
  [Routing] Change the Exception namespacing + base class for every exception + update PHPDoc
  [Routing] Add specific exceptions for the UrlGenerator
2011-05-17 09:52:44 +02:00
Fabien Potencier
75f0ab5d40 Merge remote branch 'vicb/form-fluid'
* vicb/form-fluid:
  [Form] Fix the Form fluid interface
  [Form] Fix the fluid interface of FormBuilder
  [Form] Fix the fluid interface of FormBuilder
2011-05-17 09:45:29 +02:00
Fabien Potencier
1394183a68 Merge remote branch 'stloyd/patch-3'
* stloyd/patch-3:
  Fix for bug when using APC in version 3.1.4
2011-05-17 09:41:45 +02:00
Fabien Potencier
86a2d27da9 Merge remote branch 'stloyd/ipvalidator_fix'
* stloyd/ipvalidator_fix:
  Better comment about no test IP6 addresses for "FILTER_FLAG_NO_RES_RANGE"
  Refactoring of IpValidator to use native php filter extension, also adding additional flag support and test cover.
2011-05-17 09:25:04 +02:00
Fabien Potencier
d118e32783 Merge remote branch 'vicb/924-cosmetic'
* vicb/924-cosmetic:
  [Form] CS related changes
2011-05-17 09:19:41 +02:00
Fabien Potencier
d0b403b7e4 Merge remote branch 'vicb/924-real'
* vicb/924-real:
  [Form] Implement a fluid interface FormView
2011-05-17 09:19:39 +02:00
Fabien Potencier
a76c65e163 Merge remote branch 'kreischweide/master'
* kreischweide/master:
  [Process] Workaround for windows based stderr bug
  [Process] Wrong descriptor mode for stderr
  Fixed wrong descriptor mode for stderr
2011-05-17 09:14:50 +02:00
Johannes Schmitt
54ae90d36d some cleanups 2011-05-17 07:41:49 +02:00
Kris Wallsmith
b645278f8b [Security] updated with "intention" 2011-05-16 14:16:30 -07:00
Kris Wallsmith
914620f948 [Form] renamed CSRF page_id to intention 2011-05-16 14:16:29 -07:00
Johannes Schmitt
796d9af0c4 some updates 2011-05-16 22:26:24 +02:00
realmfoo
8519967796 Calling supportsClass from vote to find out if we can vote 2011-05-16 11:03:06 +04:00
Fabien Potencier
e7e5304876 forced all responses to have a Date header (RFC2616 - 14.18) 2011-05-16 08:46:36 +02:00
Fabien Potencier
5a38886b1d [HttpFoundation] fixed Request::getHttpHost() 2011-05-16 08:20:17 +02:00
Fabien Potencier
28f9b4f13e [HttpFoundation] force headers to be sorted in HeaderBag::__toString() 2011-05-15 22:40:14 +02:00
Victor Berchet
42698608cb [Form] CS related changes 2011-05-15 21:39:22 +02:00
Victor Berchet
39efc49da0 [Form] Implement a fluid interface FormView 2011-05-15 21:38:12 +02:00
Fabien Potencier
4c7adc2f12 [HttpFoundation] fixed a warning 2011-05-15 19:44:34 +02:00
Douglas Greenshields
bf2f9d2a02 [Form] Added a search form field type 2011-05-15 18:31:36 +01:00
Fabien Potencier
c1c9ad72f2 Merge remote branch 'vicb/form-phpdoc-2'
* vicb/form-phpdoc-2:
  [Form] phpDoc
2011-05-15 19:28:39 +02:00
Victor Berchet
971aad0593 Merge branch 'master' into form-phpdoc-2 2011-05-15 19:24:09 +02:00
Johannes Schmitt
8e5b11a226 Merge remote branch 'origin/master' into annotations 2011-05-15 18:35:25 +02:00
Fabien Potencier
11fa8d8698 [HttpFoundation] tweaked HeaderBag::__toString() to ease debugging 2011-05-15 12:43:05 +02:00
Fabien Potencier
e81b88c576 [HttpFoundation] added HeaderBag::__toString() 2011-05-15 12:38:12 +02:00
Fabien Potencier
dcb4ef6e23 [HttpFoundation] added Request::__toString() 2011-05-15 12:33:06 +02:00
Amal Raghav
ebc2f01e5b [PdoSessionStorage] Added insert... on duplicate 2011-05-15 15:48:29 +05:30
Fabien Potencier
62d09b8fb2 [HttpFoundation] ensures that path info always starts with a / 2011-05-15 11:28:38 +02:00
Fabien Potencier
d2525c9492 [Validator] fixed possible warning 2011-05-15 11:18:03 +02:00
Stepan Tanasiychuk
c6206f8faf Small refact. Without this I get a php Notice and Warnig if try getFlash() after clearing the session:
Notice: Undefined index: _flash in /var/www/test/symfony2/vendors/symfony/src/Symfony/Component/HttpFoundation/Session.php on line 231
Warning: array_key_exists() expects parameter 2 to be array, null given in /var/www/test/symfony2/vendors/symfony/src/Symfony/Component/HttpFoundation/Session.php on line 231
2011-05-14 14:23:14 -07:00
Amal Raghav
4fa0c4c3ea some cosmetic changes to PdoSessionStorage
aligned line 210
2011-05-14 23:45:13 +05:30
Fabien Potencier
4ef13b6d5c added exceptions when APC is not enabled 2011-05-14 17:43:25 +02:00
Fabien Potencier
fe4515bde3 Merge remote branch 'stloyd/patch-2'
* stloyd/patch-2:
  Throw an exception when APC is not loaded but cache is enabled in app config
2011-05-14 17:38:41 +02:00
Fabien Potencier
e1347e788e [Yaml] tweaked error message 2011-05-14 17:37:28 +02:00
Fabien Potencier
0bfb260f44 Merge remote branch 'usefulthink/issue913-yaml-utf8-checking'
* usefulthink/issue913-yaml-utf8-checking:
  CS fixes in unit-test
  [Yaml] added exceptions when non-utf8 encoding is detected
2011-05-14 17:35:56 +02:00
Adrian Rudnik
0c089d8fe3 [Process] Workaround for windows based stderr bug 2011-05-14 17:25:55 +02:00
Fabien Potencier
9c1bdc6ca4 Merge remote branch 'mvrhov/metadata_defaultgroup_fix'
* mvrhov/metadata_defaultgroup_fix:
  If there is no namespace in classname the 1st character was stripped off
2011-05-14 17:25:51 +02:00
Fabien Potencier
e46e53daa0 Merge remote branch 'stof/graphviz'
* stof/graphviz:
  [DependencyInjection] Fixed a property visibility in GraphvizDumper and removed a useless instanciation in the test
2011-05-14 17:23:50 +02:00
Fabien Potencier
e6766a3189 [Validator] fixed various bugs in previous merge 2011-05-14 17:18:23 +02:00
Johannes Schmitt
28bee92c75 [Security/Http] better error message when session times out, or cookies are disabled 2011-05-14 16:41:18 +02:00
Johannes Schmitt
0acffb1a1a [Security/Http] {_locale} can be used as placeholder in target path generation
fixes #861
2011-05-14 16:21:27 +02:00
Johannes Schmitt
48dc85dc43 [Security/Acl] fixes #853 2011-05-14 14:19:55 +02:00
Johannes Schmitt
b637a3190d revert exception message 2011-05-14 13:25:03 +02:00
Johannes Schmitt
2d8afd8dd6 Merge remote branch 'origin/master' into annotations
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
	src/Symfony/Bundle/FrameworkBundle/Resources/config/validator.xml
	src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
2011-05-14 12:51:05 +02:00
Joseph Bielawski
d235570653 Fix for bad regexp used in PHP <= 5.3.2. Closes #897 2011-05-14 03:43:46 -07:00
Deni
e75edf205d [Form] Fixed path mapping for DelegatingValidator 2011-05-14 13:38:34 +04:00
Fabien Potencier
dbdb3da6bf Merge remote branch 'vicb/form-misc-fix-2'
* vicb/form-misc-fix-2:
  [Form] fix calling closures
  [Form] Add a missing property delcaration in the ResizeFormListener
2011-05-14 11:04:50 +02:00
Fabien Potencier
0cf8ad1946 Merge remote branch 'Chekote/firefox_put_fix'
* Chekote/firefox_put_fix:
  Fixed content type for urlencoded forms being too specific. For example, this will now function will clients (such as Firefox) that append the charset to the content type header. Uses 0 === strpos() as per @kriswallsmith suggestion.
2011-05-14 11:03:21 +02:00
Fabien Potencier
9687d1661b Merge remote branch 'bschussek/form_validator'
* bschussek/form_validator:
  [Form] Renamed the value "text" of the "widget" option of the "date" type to "single-text"
  [Form] Implemented getAllowedOptionValues() for core types
  [Form] Removed unused option
  [Form] Added FormTypeInterface::getAllowedOptionValues() to better validate passed options
  [Form] Improved test coverage of FormFactory and improved error handling
  [Form] Added getType() to FormFactoryInterface
  [Validator] Refactoring DateTimeValidator and DateValidator
  [Validator] Date: check if the value is a DateTime instance
2011-05-14 10:59:02 +02:00
Chekote
41ed194a98 Fixed content type for urlencoded forms being too specific. For example, this will now function will clients (such as Firefox) that append the charset to the content type header. Uses 0 === strpos() as per @kriswallsmith suggestion. 2011-05-13 19:05:28 -05:00
Victor Berchet
3b9c1e3fee [Form] Optimization of PropertyPath 2011-05-13 19:29:41 +02:00
Bernhard Schussek
e0ff61949e [Form] Renamed the value "text" of the "widget" option of the "date" type to "single-text" 2011-05-13 19:17:28 +02:00
Bernhard Schussek
7570e04589 [Form] Implemented getAllowedOptionValues() for core types 2011-05-13 18:58:19 +02:00
Bernhard Schussek
da28f8e3b3 [Form] Added FormTypeInterface::getAllowedOptionValues() to better validate passed options 2011-05-13 18:44:03 +02:00
Fabien Potencier
2123006710 [Routing] fixed Route fluent interface 2011-05-13 18:40:40 +02:00
alexandresalome
5aaa78d9ca [Routing] Fix the exception inheritance + Add the LICENCE block in new files 2011-05-13 18:34:42 +02:00
Bernhard Schussek
21013b930c [Form] Improved test coverage of FormFactory and improved error handling 2011-05-13 18:29:18 +02:00
Fabien Potencier
48858cb95b [Routing] added missing Route::setOption() method 2011-05-13 18:17:57 +02:00
alexandresalome
07b7dc0c86 [Routing] Change the Exception namespacing + base class for every exception + update PHPDoc 2011-05-13 17:46:31 +02:00
Bernhard Schussek
fdd18250b3 [Form] Added getType() to FormFactoryInterface 2011-05-13 17:16:36 +02:00
Bernhard Schussek
f801c398eb Merge remote branch 'francisbesset/validators_date_datime' into francis_merge
Conflicts:
	src/Symfony/Component/Validator/Constraints/DateTimeValidator.php
	src/Symfony/Component/Validator/Constraints/DateValidator.php
2011-05-13 17:09:54 +02:00
alexandresalome
05d9e74293 [Routing] Add specific exceptions for the UrlGenerator
When generating URL, thrown exceptions are InvalidArgumentException and
distinction of errors is quite difficult. This modification brings different
exceptions for different cases
2011-05-13 16:59:37 +02:00
Miha Vrhovnik
cd7ab69a17 If there is no namespace in classname the 1st character was stripped off 2011-05-13 16:38:01 +02:00
Fabien Potencier
faab5e4452 [HttpKernel] moved the creation of logs/ and cache/ ealier to be sure that directories exist when extensions want to write something into them 2011-05-13 15:23:20 +02:00
Fabien Potencier
36d60a4a87 [HttpKernel] fixed previous commit 2011-05-13 14:18:58 +02:00
Fabien Potencier
07580335b0 [HttpKernel] changed ExceptionHandler to be more like ErrorHandler 2011-05-13 14:14:36 +02:00
Fabien Potencier
0b367b9489 [DependencyInjection] tweaked error messages 2011-05-13 12:52:44 +02:00
Christophe Coevoet
c2f074b7d5 [DependencyInjection] Fixed a property visibility in GraphvizDumper and removed a useless instanciation in the test 2011-05-13 12:18:09 +02:00
Victor Berchet
ae4bfbada4 [Form] fix calling closures 2011-05-13 11:01:31 +02:00
Victor Berchet
b2b3b190ef [Form] Add a missing property delcaration in the ResizeFormListener 2011-05-13 11:01:27 +02:00
Victor Berchet
87a6fd0f99 [Form] phpDoc 2011-05-13 11:00:04 +02:00
Fabien Potencier
23235d8513 Merge remote branch 'jmikola/patch-1'
* jmikola/patch-1:
  [Form] Refer to FormView explicitly in its own getParent() type-hint
2011-05-13 09:24:45 +02:00
Adrian Rudnik
90f5420ada [Process] Wrong descriptor mode for stderr 2011-05-13 03:08:55 +02:00
Adrian Rudnik
24216b4ee3 Fixed wrong descriptor mode for stderr 2011-05-13 02:22:14 +02:00
Chekote
88d94dd59f Fixed reference to $this, when not in object context 2011-05-12 16:21:13 -05:00
Martin Schuhfuss
571768b9b9 [Yaml] added exceptions when non-utf8 encoding is detected
encoding is detected using the `mb_detect_encoding()`-function
in strict-mode. Checking is done before the parsing starts.
Without this patch, the calls to `preg_replace()` using the
'u'-modifier would cause the non-utf8-string being processed
to be empty when parsing starts which makes the parsing return
no result.
2011-05-12 22:02:56 +02:00
Chekote
ebab0a3ac2 Refactored the processing of each individual node into it's own method, enabling easier overloading of behavior for Bundles such as FriendsOfSymfony/RestBundle 2011-05-12 10:55:14 -05:00
Fabien Potencier
8f426c0c77 [HttpKernel] added an exception handler to be used during boot time
This can be used as a PHP exception handler:

set_exception_handler(new DebugExceptionHandler());
2011-05-12 17:49:37 +02:00
Fabien Potencier
4adb4e9dc0 merged schmittjoh/removeExits 2011-05-12 17:47:59 +02:00
Joseph Bielawski
23b34749f9 Fix for bug when using APC in version 3.1.4 2011-05-12 07:50:47 -07:00
Joseph Bielawski
ec3ea65819 Throw an exception when APC is not loaded but cache is enabled in app config 2011-05-12 07:44:22 -07:00
lenar
2a09fe5e09 More information about exception when logging 2011-05-12 17:00:46 +03:00
Fabien Potencier
02a81de9d6 Merge remote branch 'fabpot/form-put'
* fabpot/form-put:
  [HttpFoundation] fixed typo
  [HttpFoundation] moved the PUT magic dance in createFromGlobals()
  added support for PUT method
2011-05-12 14:46:12 +02:00
Fabien Potencier
0848604ce1 [HttpFoundation] fixed typo 2011-05-12 14:45:39 +02:00
Fabien Potencier
08846af9e2 [HttpFoundation] moved the PUT magic dance in createFromGlobals() 2011-05-12 14:45:38 +02:00
Fabien Potencier
efd1f1358c added support for PUT method 2011-05-12 14:45:38 +02:00
Fabien Potencier
ae9ab29c0c Merge remote branch 'weaverryan/security_context_exception_improvement'
* weaverryan/security_context_exception_improvement:
  [Security] Improving the exception when the security context has no token
2011-05-12 14:41:31 +02:00
Fabien Potencier
aebc529e8e Merge remote branch 'jsor/response_tostring'
* jsor/response_tostring:
  [HttpFoundation] replaced LF by CRLF as per the spec
2011-05-12 14:36:36 +02:00
Fabien Potencier
0a3ff1c737 [HttpKernel] fixed default ESI cache strategy when the page does not contain ESIs 2011-05-12 13:54:48 +02:00
Beau Simensen
7adedf9ce9 [HttpKernel] Fix to disable busyTimeout if it does not exist. 2011-05-11 17:09:59 -07:00
jsor
d39c3be779 [HttpFoundation] replaced LF by CRLF as per the spec 2011-05-12 00:08:05 +02:00
Jeremy Mikola
61dc1af65b [Form] Refer to FormView explicitly in its own getParent() type-hint
Using "self" makes mocking impossible, as the type-hint would then refer to the extending class and make the declaration incompatible.
2011-05-11 14:11:43 -07:00
Ryan Weaver
1de34fde98 [Security] Improving the exception when the security context has no token
This either mostly - or always - means that no firewall is currently activated. This message tries to alert the user to this.

Reword
2011-05-11 15:09:36 -05:00
Victor Berchet
f68d16fdff [Form] Fix the Form fluid interface 2011-05-11 17:08:53 +02:00
Fabien Potencier
3ec3fa219b [HttpKernel] fixed a hardcoded variable 2011-05-11 16:43:00 +02:00
stloyd
5997b930a5 Refactoring of IpValidator to use native php filter extension, also adding additional flag support and test cover. 2011-05-11 13:19:03 +02:00
Jeremie Augustin
0077963584 fix file permissions to 644 2011-05-11 11:19:21 +02:00
Jeremie Augustin
b5277752b7 [Form] add type_options for CollectionType to be abble to set options to type 2011-05-11 11:19:21 +02:00
Victor Berchet
2db53b5e28 [Form] Order method according to their visibility to respect the CS 2011-05-11 11:00:32 +02:00
Victor Berchet
5536d41906 [Form] Add phpDoc for form builder and fix method declaration order to conform to the CS 2011-05-11 11:00:32 +02:00
Fabien Potencier
e2df25b43a made a slight change to the previous merge 2011-05-11 10:45:23 +02:00
Fabien Potencier
b7d64c5304 Merge remote branch 'danielholmes/functional_test_changes'
* danielholmes/functional_test_changes:
  [FrameworkBundle] fixed CS
  [FrameworkBundle][HttpKernel] added a default tearDown on the WebTestCase which will shut down the currently used kernel (if there is one) in Web functional tests
2011-05-11 10:33:23 +02:00
Fabien Potencier
1ae5ef6849 Merge remote branch 'vicb/form-padded-choice-list'
* vicb/form-padded-choice-list:
  [Form] Allow for arbitrary keys in PaddedChoiceList
2011-05-11 10:18:30 +02:00
Fabien Potencier
9abd53c2b4 merged Seldaek/serializer_fix 2011-05-11 10:16:15 +02:00
Fabien Potencier
a05b8fbb19 Merge remote branch 'schmittjoh/security'
* schmittjoh/security:
  [HttpFoundation] fixed php doc
  updated UPDATE file
  [Security] use deep flag when retrieving username + password
  [HttpFoundation] added $deep flag to Request::get()
  [HttpFoundation] removed getDeep(), added a boolean flag to get() instead
2011-05-11 10:14:15 +02:00
Fabien Potencier
b62cd109f0 Merge remote branch 'vicb/form-fixes'
* vicb/form-fixes:
  [Form] Make the PropertyPathMapper class use the UnexpectedTypeException
  [Form] Fix adding transformers in the FormBuilder
  [Form] Fix the ReversedTransform class
2011-05-11 10:13:24 +02:00
Fabien Potencier
9651175914 Merge remote branch 'vicb/form-transformers'
* vicb/form-transformers:
  [Form] Add argument type checking in BaseDateTimeTransformer
  [Form] Catch exceptions in DataTransformers
2011-05-11 10:12:23 +02:00
Fabien Potencier
723a8f2bf3 [Form] fixed CS 2011-05-11 10:09:27 +02:00
Fabien Potencier
534cf8fce7 Merge remote branch 'vicb/form-tz-choice-list'
* vicb/form-tz-choice-list:
  [Form] Make TimezoneChoiceList implement ChoiceListInterface rather than extend ArrayChoiceList
2011-05-11 10:07:35 +02:00
Victor Berchet
adef14f687 [Form] Make the PropertyPathMapper class use the UnexpectedTypeException 2011-05-10 20:25:46 +02:00
Victor Berchet
daccf9bc17 [Form] Fix adding transformers in the FormBuilder 2011-05-10 20:25:30 +02:00
Victor Berchet
486294b50b [Form] Fix the ReversedTransform class 2011-05-10 20:25:22 +02:00
Johannes Schmitt
7a6638ff8f [HttpFoundation] fixed php doc 2011-05-10 20:24:58 +02:00
Victor Berchet
2e68801ff3 [Form] Add argument type checking in BaseDateTimeTransformer 2011-05-10 20:21:02 +02:00
Victor Berchet
dac798c791 [Form] Catch exceptions in DataTransformers 2011-05-10 20:21:02 +02:00
Victor Berchet
aa71d16812 [Form] Make TimezoneChoiceList implement ChoiceListInterface rather than extend ArrayChoiceList 2011-05-10 20:14:11 +02:00
Amal Raghav
acb657b82c added busyTimeout 2011-05-10 23:43:11 +05:30
Victor Berchet
eca6453558 [Form] Fix the fluid interface of FormBuilder 2011-05-10 20:09:37 +02:00
Victor Berchet
75a499b0e2 [Form] Fix the fluid interface of FormBuilder 2011-05-10 20:09:28 +02:00
Fabien Potencier
9cc7aacf76 Merge remote branch 'usefulthink/phpdoc-containeraware'
* usefulthink/phpdoc-containeraware:
  removed obsolete use-statement
  [DependencyInjection] added phpdoc for property $container in ContainerAware
2011-05-10 19:09:55 +02:00
Fabien Potencier
f9fefd306d Merge remote branch 'vicb/form-phpdoc'
* vicb/form-phpdoc:
  [Form] Fix some phpDoc
  [Form] fix and add some phpDoc
2011-05-10 19:08:53 +02:00
Victor Berchet
2d62dfdf83 [Form] Fix some phpDoc 2011-05-10 16:55:05 +02:00
Martin Schuhfuss
9112d8c2d3 removed obsolete use-statement 2011-05-10 16:34:44 +02:00
Martin Schuhfuss
5387532ff2 [DependencyInjection] added phpdoc for property $container in ContainerAware
This should ease code-completion a little bit...
2011-05-10 16:30:58 +02:00
Victor Berchet
2a8f2d2bfa [Form] fix and add some phpDoc 2011-05-10 15:33:02 +02:00
Christophe Coevoet
a54d6b7e58 [DependencyInjection] Removed the public keyword from interface 2011-05-10 13:55:08 +02:00
John Wards
d96e2c5d79 [Validator] Adding support for Closure in CallbackValidator
Usage:
$formBuilder = $this->get('form.factory')
            ->createBuilder('form');
$formBuilder->setAttribute('validation_constraint', new Callback(array("methods"=>array(
    'validate' => function ($data, $context) use ($elements) {
       // logic to add violations depending on the elements
    }
))));
2011-05-10 12:12:18 +01:00
Johannes Schmitt
9408ab3010 [Security] use deep flag when retrieving username + password 2011-05-10 11:22:28 +02:00
Johannes Schmitt
411659bc07 [HttpFoundation] added $deep flag to Request::get() 2011-05-10 11:19:22 +02:00
Johannes Schmitt
89f60e04d1 [HttpFoundation] removed getDeep(), added a boolean flag to get() instead 2011-05-10 11:16:25 +02:00
Jordi Boggiano
9e19e772bc [Serializer] Restored docblocks from the deleted methods on SerializerInterface 2011-05-10 09:27:20 +02:00
Jordi Boggiano
457dc105bc [Serializer] minor optimization 2011-05-10 09:19:55 +02:00
Jordi Boggiano
99c67134fe [Serializer] Split decoder/encoder maps 2011-05-10 09:17:33 +02:00
Christophe Coevoet
1bb6b97c1c [DependencyInjection] Added missing methods in the ParameterBagInterface
The Container relies on the resolve() value which was not part of
the interface.
2011-05-10 02:34:02 +02:00
Christophe Coevoet
b6c36de134 [DependencyInjection] Fixed phpdoc 2011-05-10 02:33:34 +02:00
Fabien Potencier
9844685a40 [HttpKernel] tweaked the default ESI cache strategy 2011-05-09 19:28:36 +02:00
Fabien Potencier
80a5074746 [Form] tweaked code (closes #855) 2011-05-09 17:53:18 +02:00
Jordi Boggiano
e6a02482c7 [Serializer] Cleaned up SerializerAwareInterface 2011-05-09 17:43:50 +02:00
Victor Berchet
6c337d1cc0 [Form] Do not set the value attribute for file inputs 2011-05-09 17:00:19 +02:00
Fabien Potencier
05e75e2712 [Finder] made the Custom filter accept all PHP callbacks 2011-05-09 15:30:41 +02:00
Victor Berchet
e0f03471ae Merge branch 'master' into form-padded-choice-list 2011-05-09 15:30:04 +02:00
Fabien Potencier
e1c52764ce [Finder] refactored SortableIterator 2011-05-09 15:14:42 +02:00
Fabien Potencier
50c1cce014 Merge remote branch 'schmittjoh/security'
* schmittjoh/security:
  [HttpFoundation] added unit test
  [Security][HttpFoundation] splits Request::hasSession() into hasSession(), and hasPreviousSession()
  [SecurityBundle] added some tests
  add provider to configuration
  update DI to handle change in config and another provider
  separate dbal specific acl config
  add provider to configuration
  update DI to handle change in config and another provider
  separate dbal specific acl config
2011-05-09 14:26:36 +02:00
Fabien Potencier
4bb82451df Merge remote branch 'Seldaek/session_warn'
* Seldaek/session_warn:
  [HttpFoundation] Remove warnings when session id isn't given
2011-05-09 14:14:17 +02:00
Jordi Boggiano
f8447aa74c [Serializer] NormalizableInterface now takes a Serializer and make sure the is always optional 2011-05-09 13:59:54 +02:00
Deni
a15abc09bd [Form] Added missing import statement of namespaces. 2011-05-09 14:30:04 +04:00
Fabien Potencier
d7a97f441c Merge remote branch 'maoueh/acl_security_config_fix'
* maoueh/acl_security_config_fix:
  [Security\Acl] Fixed hardcoded table names  * Replaced hardcoded table names by acl configuration options
2011-05-09 08:59:43 +02:00
Fabien Potencier
7a509cd199 Merge remote branch 'pborreli/toString-fix'
* pborreli/toString-fix:
  [Validator] Fixing method_exists
2011-05-09 08:57:41 +02:00
Jordi Boggiano
3b88608d85 [Serializer] Fixed typo 2011-05-08 18:34:06 +02:00
Jordi Boggiano
9311b0a7e5 [Serializer] Removed properties argument 2011-05-08 18:32:22 +02:00
Jordi Boggiano
89e056bb8b [Serializer] Renamed AbstractEncoder/Normalizer to SerializerAwareEncoder/Normalizer 2011-05-08 18:20:53 +02:00
Jordi Boggiano
1f8defaeeb [Serializer] JsonEncoder doesn't need SerializerAware anymore 2011-05-08 18:17:42 +02:00
Jordi Boggiano
24dcfef33f [Serializer] Added NormalizationAwareInterface 2011-05-08 18:16:53 +02:00
Jordi Boggiano
c20b4a3950 [Serializer] Cleaned up NormalizerInterface 2011-05-08 18:15:00 +02:00
Jordi Boggiano
4104c7b073 [Serializer] Inlined back the logic from isStructuredType and removed the method 2011-05-08 18:14:44 +02:00
Jordi Boggiano
3ecc9602e4 [Serializer] Add checks for SerializerAwareInterface 2011-05-08 17:54:55 +02:00
Jordi Boggiano
01a104916b [Serializer] Implement SerializerAwareInterface 2011-05-08 17:53:37 +02:00
Jordi Boggiano
8263b09b5c [Serializer] Properly check for the DecoderInterface 2011-05-08 17:52:25 +02:00
Jordi Boggiano
fe7119da8a [Serializer] serialize shouldn't normalize since it's the encoder's job to do that when they require it 2011-05-08 15:17:42 +02:00
Johannes Schmitt
f7e03f2d87 Merge remote branch 'origin/master' into annotations
Conflicts:
	UPDATE.md
	src/Symfony/Bundle/DoctrineBundle/Resources/config/orm.xml
	src/Symfony/Bundle/DoctrineBundle/Tests/DependencyInjection/AbstractDoctrineExtensionTest.php
2011-05-08 07:28:23 +02:00
Matthieu Vachon
0da289cfbc [Security\Acl] Fixed hardcoded table names
* Replaced hardcoded table names by acl configuration options
2011-05-07 20:56:22 -04:00
Pascal Borreli
e60a68f2c6 [Validator] Fixing method_exists
see dea5b26c3f
2011-05-07 19:08:30 +00:00
Lukas Kahwe Smith
9f32345887 typo fix 2011-05-07 17:02:06 +02:00
Kris Wallsmith
f3b077a0dd [Form] removed a bunch of unused use statements 2011-05-06 14:07:16 -07:00
Drew Butler
dea5b26c3f Method exists does not work if you append the () to the method name, thus this never words for objects that actually have the __toString method. Removed the erroneous () so that this works as it appears to have been intended. 2011-05-06 13:20:29 -07:00
Fabien Potencier
c98bf4ff94 Merge remote branch 'Seldaek/serializer'
* Seldaek/serializer:
  [Serializer] CS fixes
  [Serializer] Split supports in supportsNormalization and supportsDenormalization
  [Serializer] Add support for Traversable objects
  Fixed docs typo
  [Serializer] updated SerializerInterface
2011-05-06 22:13:18 +02:00
Jordi Boggiano
b9a2eb66e9 [Serializer] CS fixes 2011-05-06 19:37:13 +02:00
Jordi Boggiano
ded30a2937 [Serializer] Split supports in supportsNormalization and supportsDenormalization 2011-05-06 19:36:56 +02:00
Jordi Boggiano
919f16a7d6 [Serializer] Add support for Traversable objects 2011-05-06 19:04:39 +02:00
Jordi Boggiano
7a06421cb1 Fixed docs typo 2011-05-06 19:04:22 +02:00
Jordi Boggiano
d6afe63d2a Merge branch 'serializerLight' of http://github.com/schmittjoh/symfony into serializer 2011-05-06 18:39:02 +02:00
Jordi Boggiano
36aa7b0d70 [HttpFoundation] Remove warnings when session id isn't given 2011-05-06 16:25:44 +02:00
Fabien Potencier
f1f379b031 [Finder] simplified code 2011-05-06 14:16:23 +02:00
Johannes Schmitt
ec1199eda7 [Serializer] updated SerializerInterface 2011-05-06 13:01:19 +02:00
Victor Berchet
68b3d0d5ac [Form] Allow for arbitrary keys in PaddedChoiceList 2011-05-06 10:31:51 +02:00
Johannes Schmitt
486ecdc6a6 [Config] some exception improvements 2011-05-05 19:43:08 +02:00
Fabien Potencier
3f69333acb [HttpKernel] refactored the ErrorHandler class 2011-05-05 08:53:16 +02:00
Fabien Potencier
0f0e5817b1 [HttpKernel] added a Kernel::init() method 2011-05-05 08:44:36 +02:00
Johannes Schmitt
362b7264d1 [Security][HttpFoundation] splits Request::hasSession() into hasSession(), and hasPreviousSession()
This closes #774, and fixes #772.
2011-05-05 08:38:07 +02:00
Fabien Potencier
aba8f1e180 [ClassLoader] added a debug class loader 2011-05-05 08:28:12 +02:00
Fabien Potencier
fe9ef5c68b [Routing] fixed deep nested route collections (closes #770) 2011-05-04 23:29:47 +02:00
Michel Weimerskirch
476644a92c [Form] Support for the HTML5 "pattern" attribute, see http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-pattern-attribute
If you use the MinLength validator with your entities, the ValidatorTypeGuesser gets the value, stored as "minlength". Then, the FormFactory generates a "pattern" attribute out of minlength and maxlength.
Modern browsers such as Chrome use this attribute to validate the form before submitting.
a "pattern" attribute is generated that validates the
2011-05-04 23:16:41 +02:00
Fabien Potencier
36bcfcc5ee Merge remote branch 'bschussek/form'
* bschussek/form:
  [Form] CSRF fields are not included in the children of a FormView anymore if the view is not the root
  [Form] FormView::offsetUnset() is now supported. It was possible anyway using getChildren() and setChildren().
  [Form] Split the option "modifiable" of the "collection" type into "allow_add" and "allow_delete"
  [Form] Added test for last commit by kriswallsmith and improved dealing with original names
  [Form] Fixed variable scope when entering nested form helpers
  [Form] Added tests for blocks/templates in the format _<ID>_(widget|row|label|...)
  [Form] updated listener to check that data is an array
2011-05-04 22:13:33 +02:00
Kris Wallsmith
ae46150bc8 [HttpFoundation] added support for X-Forwarded-Port request header 2011-05-04 09:56:34 -07:00
Bernhard Schussek
74cca63938 [Form] CSRF fields are not included in the children of a FormView anymore if the view is not the root 2011-05-04 18:27:20 +02:00
Bernhard Schussek
173beeba74 [Form] FormView::offsetUnset() is now supported. It was possible anyway using getChildren() and setChildren(). 2011-05-04 18:21:49 +02:00
Bernhard Schussek
3cc5d9f4cd [Form] Split the option "modifiable" of the "collection" type into "allow_add" and "allow_delete" 2011-05-04 17:29:59 +02:00
Bernhard Schussek
bf1dfbbe99 [Form] Added test for last commit by kriswallsmith and improved dealing with original names
The form component should now guarantee to always pass an UploadedFile object to your model. There you can call getOriginalName() to retrieve the original name of the uploaded file. For security reasons, the real file name is a generated hash value.
2011-05-04 17:04:44 +02:00
Bernhard Schussek
4c6f26f008 Merge remote branch 'kriswallsmith/form/fix-upload-fix' into kris_merge 2011-05-04 15:51:20 +02:00
Fabien Potencier
ba3785896f Merge remote branch 'schmittjoh/di'
* schmittjoh/di:
  [DependencyInjection] fixes a bug when requesting a definition that uses property injection
2011-05-04 12:05:06 +02:00
Fabien Potencier
6d334289ee [BrowserKit] fixed a weird behavior where a PHP process returns a successful exit code, but the PHP scripts actually died 2011-05-04 09:08:05 +02:00
Fabien Potencier
17aa0ed0ed changed the default httpOnly value for cookie for better security out of the box 2011-05-04 08:44:59 +02:00
Johannes Schmitt
2c287676fb [DependencyInjection] fixes a bug when requesting a definition that uses property injection 2011-05-03 23:46:02 +02:00
Fabien Potencier
c7fddca891 replaced some url..code by rawurl..code 2011-05-03 23:06:55 +02:00
Fabien Potencier
731993869c Merge remote branch 'Seldaek/exception_handling'
* Seldaek/exception_handling:
  [HttpKernel] Log non-http exceptions as critical as well
2011-05-03 14:53:38 +02:00
Fabien Potencier
27d02a7d4a [Routing] fixed regression (/ should not be matched by /{foo} when foo has no default value) 2011-05-03 14:48:08 +02:00
Jordi Boggiano
0ca4ed33fe [HttpKernel] Log non-http exceptions as critical as well 2011-05-03 14:43:22 +02:00
Johannes Schmitt
672c4ef122 Merge remote branch 'origin/master' into annotations
Conflicts:
	UPDATE.md
2011-05-03 14:38:51 +02:00
Fabien Potencier
036be03dff [HttpKernel] fixed a PHP notice 2011-05-03 13:55:00 +02:00
Fabien Potencier
d2a9b23c28 [Routing] fixed routing when a pattern has only one segment which is an optional variable 2011-05-03 08:54:33 +02:00
Daniel Holmes
9107ede18c [FrameworkBundle][HttpKernel] added a default tearDown on the WebTestCase which will shut down the currently used kernel (if there is one) in Web functional tests 2011-05-03 14:17:33 +10:00
Kris Wallsmith
4ea274244d [Form] updated listener to check that data is an array 2011-05-02 15:56:35 -07:00
Fabien Potencier
8746f7b902 Merge remote branch 'Seldaek/exception_logging'
* Seldaek/exception_logging:
  Fixed status code check
  [HttpKernel] Log 500+ errors as critical and not error
2011-05-02 22:58:19 +02:00
Jordi Boggiano
fd08f187c8 Fixed status code check 2011-05-02 21:50:21 +02:00
Jordi Boggiano
e0c12fa080 [HttpKernel] Removed log() from the LoggerInterface as the priority can not be safely determined across implementations 2011-05-02 19:04:49 +02:00
Jordi Boggiano
838853e58b [HttpKernel] Log 500+ errors as critical and not error
This allows people to filter easily between 404 type of responses (that are mostly for users) and real errors in their application (where they probably want to get an email notification
2011-05-02 18:49:30 +02:00
Kris Wallsmith
562d84a964 updated my email address 2011-05-02 05:59:56 -07:00
Fabien Potencier
0642b60079 Merge remote branch 'lsmith77/serializer'
* lsmith77/serializer:
  make it possible to read the normalizerCache when inheriting
2011-05-01 17:30:53 +02:00
Fabien Potencier
82e1713850 Merge remote branch 'hhamon/console_fix'
* hhamon/console_fix:
  [Console] fixed phpdoc for Command class.
2011-05-01 17:30:24 +02:00
Fabien Potencier
0b165e13b2 [DependencyInjection] added public attribute when dumping a container to XML 2011-05-01 17:21:19 +02:00
Fabien Potencier
6fec656239 [DependencyInjection] forced anonymous services to always be private 2011-05-01 17:21:18 +02:00
Fabien Potencier
8b0450083a [DependencyInjection] removed unused vars 2011-05-01 17:21:17 +02:00
Hugo Hamon
c6bd284ecd [Console] fixed phpdoc for Command class. 2011-04-30 22:17:30 +02:00
Fabien Potencier
d31c403bae Merge remote branch 'pborreli/tests-fix-typos'
* pborreli/tests-fix-typos:
  Various typos
  [WebProfilerBundle] Fixed typo
  [WebProfilerBundle] Adding unit tests
2011-04-30 21:53:15 +02:00
Pascal Borreli
391744719a Various typos 2011-04-30 19:40:15 +00:00
Johannes Schmitt
0d0c737630 Merge remote branch 'origin/master' into annotations
Conflicts:
	UPDATE.md
2011-04-30 10:55:43 +02:00
Fabien Potencier
158181d34b Merge remote branch 'danielholmes/request_context_routing'
* danielholmes/request_context_routing:
  [Routing] added setContext to RouterInterfaces as it is used on RouterInterface references
2011-04-30 07:26:04 +02:00
Daniel Holmes
b14db26062 [Routing] added setContext to RouterInterfaces as it is used on RouterInterface references 2011-04-30 13:56:40 +10:00
Lukas Kahwe Smith
3248f02067 make it possible to read the normalizerCache when inheriting
see https://github.com/FriendsOfSymfony/RestBundle/compare/lazy_normalizer_refactoring
2011-04-29 23:51:37 +02:00
Victor Berchet
dccac192d6 [HttpFoundation] Sanitize uploaded file original name 2011-04-29 19:27:53 +02:00
Johannes Schmitt
73b92db612 [Routing] updated to changes 2011-04-29 17:44:56 +02:00
Johannes Schmitt
7e26575bbd [FrameworkBundle] added framework-wide annotation reader, updated validator tests 2011-04-29 15:54:44 +02:00
Johannes Schmitt
d151d2d4b8 added Annotations library 2011-04-28 23:09:08 +02:00
Amal Raghav
26bfa43bfc fixed a typo 2011-04-28 23:37:40 +05:30
Eriksen Costa
12968f144c [Locale] updated ICU data, changes to note:
- The Indian Rupee sign was updated, few fonts supports it: http://en.wikipedia.org/wiki/Indian_rupee_sign
 - Updated LocaleTypeTest, zh_Hans_MO was removed from ICU
2011-04-28 11:57:55 -03:00
Fabien Potencier
4cbc33a785 removed the automatic loading of the compiled classes (should be done explicitely by the end user now) 2011-04-28 14:19:10 +02:00
Fabien Potencier
3fe385e4fb removed the autoloader map feature
This feature added complexity to the framework but wasn't used in the core anyway.
You can still use the Map class loader  in your application though. But most of the time, using the APC
autoloader is just better.
2011-04-28 13:38:22 +02:00
Fabien Potencier
05f1481c6a [Form] added the possibility to configure the CSRF field name and the disabling of the CSRF feature altogether 2011-04-28 11:28:44 +02:00
Fabien Potencier
2e9278993c added Definition::getArgument() (very useful when unit testing a Container) 2011-04-28 11:26:10 +02:00
Fabien Potencier
77f9daf374 [HttpKernel] allowed bundle names to have 'bundle' in their base name 2011-04-28 08:55:43 +02:00
Fabien Potencier
40d256e058 Merge remote branch 'kriswallsmith/kernel/bundle-extension'
* kriswallsmith/kernel/bundle-extension:
  [HttpKernel] added check of default extension alias convention
  [AsseticBundle] coding standard and comment tweaks
  [HttpKernel] added BundleInterface::getContainerExtension() which is implicitly loaded
2011-04-28 08:48:57 +02:00
Fabien Potencier
751eaab326 Merge remote branch 'mweimerskirch/form_fixes'
* mweimerskirch/form_fixes:
  Fix DateTimeType by adding missing default options
2011-04-28 08:18:28 +02:00
Fabien Potencier
f865a79742 [Form] fixed DateTimeToTimestampTransformer to use the proper exception class 2011-04-28 08:07:19 +02:00
Fabien Potencier
0007702321 Merge remote branch 'Seldaek/datetime'
* Seldaek/datetime:
  [Form] Use proper transformation exception in case of failure
2011-04-28 08:05:08 +02:00
Fabien Potencier
9e23189eb1 Merge remote branch 'Brouznouf/patch-2'
* Brouznouf/patch-2:
  [Serializer] [XmlEncoder] Add unit test for decoding / encoding root with attributes
  [Seriliazer] [XmlEncoder] Optimize conditions
  [Serializer] [XmlEncoder] Allow decoder to extract attributes in root element
2011-04-28 07:49:55 +02:00
Francis Besset
72c074a101 [Session] Used \Locale::setDefault() when the locale is setted 2011-04-28 00:03:32 +02:00
Stepan Tanasiychuk
411997dc59 fix wrong method name 2011-04-27 23:15:27 +03:00
Fabien Potencier
289d35a7ae Merge remote branch 'opensky/form-interface-use-statements'
* opensky/form-interface-use-statements:
  [Form] Remove unnecessary use statements in EventListeners
2011-04-27 18:23:04 +02:00
Jeremy Mikola
f59423626a [Form] Remove unnecessary use statements in EventListeners 2011-04-27 12:18:45 -04:00
Joel Wurtz
f11cc2de0b [Seriliazer] [XmlEncoder] Optimize conditions 2011-04-27 08:00:31 -07:00
sasezaki
3d85db8fbc fixed typoe on Exception message 2011-04-27 23:04:13 +09:00
Joel Wurtz
b6a9935314 [Serializer] [XmlEncoder] Allow decoder to extract attributes in root element 2011-04-27 06:34:41 -07:00
Joel Wurtz
a56e271025 [Serializer] Fix bug when denormalize a class in cache 2011-04-27 03:24:52 -07:00
Victor Berchet
d350e01e33 File & UploadedFile tweaks 2011-04-27 09:10:41 +02:00
Fabien Potencier
00bfd10ca9 [HttpFoundation] refactored File management to be safer 2011-04-27 08:50:33 +02:00
Fabien Potencier
b7cd7115d1 [HttpFoundation] removed protected methods that were not used 2011-04-27 08:04:10 +02:00
Fabien Potencier
5bb9da4b6d [HttpFoundation] renamed getDefaultExtension() to guessExtension()
The renamed method now returns null if it cannot guess the extension. It allows
the developper to know whether the extension has been guessed or not.
2011-04-27 08:03:19 +02:00
Fabien Potencier
a26de5ba58 [HttpFoundation] fixed CS 2011-04-27 08:03:15 +02:00
Fabien Potencier
854fbd7f68 [HttpFoundation] use realpath to ensure that there is no .. in file path (to match phpdoc) 2011-04-27 07:58:54 +02:00
Fabien Potencier
9f846997ef Merge remote branch 'Infranology/normalize-bools'
* Infranology/normalize-bools:
  capitalized 'boolean'
  replaced 'bool' with 'Boolean'
2011-04-27 07:48:12 +02:00
Eriksen Costa
164ce5210d capitalized 'boolean' 2011-04-27 02:35:10 -03:00
Eriksen Costa
4db0752894 replaced 'bool' with 'Boolean' 2011-04-27 02:35:03 -03:00
Fabien Potencier
aa3ec504ae removed File::getWebPath()
This has been removed for several reasons:

* the framework does not know where the document root is and should not care
* as the document root was static, it was impossible to have several document roots depending on some business rules (see next one)
* sometimes, the document root is not under the web root directory (so the logic of getWebPath() is not always correct)
* the feature was not used anywhere in the core
2011-04-27 06:49:05 +02:00
Francis Besset
886149fa00 [Validator] Refactoring DateTimeValidator and DateValidator 2011-04-27 00:14:31 +02:00
Francis Besset
c6d39ed61f [Validator] Date: check if the value is a DateTime instance 2011-04-27 00:09:57 +02:00
Kris Wallsmith
5dc1a9bb58 [Process] added optional argument for default executable 2011-04-26 07:45:16 -07:00
Kris Wallsmith
97f66e93ac [HttpKernel] added check of default extension alias convention 2011-04-26 07:17:45 -07:00
Jordi Boggiano
d11b7baa7e [Form] Use proper transformation exception in case of failure 2011-04-26 16:02:01 +02:00
Fabien Potencier
0ac679e73c Merge remote branch 'markchalloner/master'
* markchalloner/master:
  [Validator] Updated ContraintViolationList ArrayAccess setter to check equivalence to null instead of using is_null
  Implemented ArrayAccess interface
2011-04-26 15:34:47 +02:00
Fabien Potencier
e2741cefc4 [Process] changed ExecutableFinder to return false instead of throwing an exception when the executable is not found
I've made the change as the executable goal is to find the executable. The fact that it does not find it is
part of the contract and it is not exceptional.
2011-04-26 15:18:24 +02:00
Fabien Potencier
f12146d0ec Merge remote branch 'schmittjoh/process'
* schmittjoh/process:
  [Process] use component exception
  [Process][Assetic] refactored some code to allow for better executable defaults
2011-04-26 15:01:29 +02:00
Fabien Potencier
fe03671c2c Merge remote branch 'vicb/cast-array'
* vicb/cast-array:
  Make casting scalar to array consistent
2011-04-26 14:32:53 +02:00
Fabien Potencier
98e70f0963 [Routing] Route collection prefixes must start with a / and must not end with a / 2011-04-26 14:27:55 +02:00
Michel Weimerskirch
87c609b4a4 Fix DateTimeType by adding missing default options 2011-04-26 14:21:00 +02:00
Fabien Potencier
175f944f93 [DependencyInjection] added NonExistentParameterException that indicates where a non-existent parameter is being used 2011-04-26 12:36:25 +02:00
Victor Berchet
f83e92bf44 Make casting scalar to array consistent 2011-04-26 12:16:35 +02:00
Fabien Potencier
fefee0d5e5 [Routing] fixed URL generation when an optional variable value is 0 2011-04-26 09:50:57 +02:00
Kris Wallsmith
7dfe286897 [AsseticBundle] coding standard and comment tweaks 2011-04-26 00:18:22 -07:00
Fabien Potencier
035afc1f4e [Routing] fixed regression in Routing matching algorithm 2011-04-26 09:01:25 +02:00
Kris Wallsmith
7a7b448680 [HttpKernel] added BundleInterface::getContainerExtension() which is implicitly loaded 2011-04-25 21:12:35 -07:00
Artur Kotyrba
88e78e6f44 [Translation] removed unnecessary default parameter value 2011-04-25 22:58:23 +02:00
Artur Kotyrba
f9f02a9047 [HttpKernel] removed unused argument passed to ClosureLoader constructor 2011-04-25 22:58:23 +02:00
Artur Kotyrba
533e2d994b [BrowserKit] fixed typo 2011-04-25 22:58:23 +02:00
Artur Kotyrba
713e8c26a6 [Routing] removed redundant parameter in addRoute method 2011-04-25 22:58:23 +02:00
Fabien Potencier
944a98086e [Routing] optimized PHP route dumper 2011-04-25 17:45:59 +02:00
Fabien Potencier
7c95bda751 [Routing] simplified route compiler 2011-04-25 12:38:20 +02:00
Fabien Potencier
889c422d6e Merge remote branch 'igorw/ipv6'
* igorw/ipv6:
  [HttpFoundation] minor optimization
  minor adjustments suggested by vicb
  [HttpFoundation] IPv6 support for RequestMatcher
  [HttpFoundation] refactor RequestMatcherTest to use dataProvider
  [Validator] use full iPv6 regex
  [Validator] add IPv6 support to UrlValidator
  [HttpFoundation] add IPv6 support to Request
  [HttpFoundation] test Request::create with an IP as host name
  [HttpFoundation] refactor Request::getClientIp test
2011-04-24 22:04:25 +02:00
Fabien Potencier
36a63be0a5 Merge remote branch 'dustinwhittle/master'
* dustinwhittle/master:
  [Classloader] Added phpdoc with example usage + refactored unit tests fixtures
  [Classloader] Refactored ApcUniversalClassLoader to use setUp() to detect APC
  [Classloader] Fixed typo + coding standards in ApcUniversalClassLoader test
  [Classloader] Fixed APC class loader + added unit tests
2011-04-24 22:02:59 +02:00
Fabien Potencier
c0a160b5f9 partially reverted previous merge 2011-04-24 22:02:19 +02:00
Fabien Potencier
c6e0ccfdcd Merge remote branch 'pborreli/form-typo'
* pborreli/form-typo:
  [Form] Fixed typos
2011-04-24 21:56:47 +02:00
Fabien Potencier
f251eab92f Revert "[Form] added a way to register a Form extension after creation of the FormFactory"
This reverts commit 2b8c7f84b5.
2011-04-24 21:56:06 +02:00
Fabien Potencier
2f3ddb88ef Merge remote branch 'bschussek/form'
* bschussek/form:
  [Form] Automatically setting "data_class" option if objects are passed at the creation of a form
  [Form] Improved the way passed data is handled in FormFactory
  [Form] Simplified FileType code
  [HttpFoundation] TemporaryStorage automatically creates the directory if it doesn't exist yet
  [Form] Changed FormBuilder::build() to FormBuilder::create(). You hvae to pass the resulting builder to FormBuilder::add() manually now
  [Form] Added FieldTypeValidatorExtension and fixed FQCN of DelegatingValidator
2011-04-24 21:53:24 +02:00
Pascal Borreli
06b3c386d9 [Form] Fixed typos 2011-04-24 14:05:16 +00:00
Dustin Whittle
e8bb64c17c [Classloader] Added phpdoc with example usage + refactored unit tests fixtures 2011-04-24 07:00:27 -07:00
Dustin Whittle
dbb5ca459d [Classloader] Fixed APC class loader + added unit tests 2011-04-24 07:00:26 -07:00
Fabien Potencier
08bf2af455 fixed email 2011-04-24 13:59:46 +02:00
Bernhard Schussek
e790587dc2 [Form] Automatically setting "data_class" option if objects are passed at the creation of a form
$form = $this->get('form.factory')->create(new PostType(), $post);
2011-04-24 13:38:12 +02:00
Bernhard Schussek
d58c610833 [Form] Improved the way passed data is handled in FormFactory 2011-04-24 13:32:29 +02:00
Fabien Potencier
4ed8d4f6b5 [Routing] fixed URL generation when a non-optional variable is empty 2011-04-24 13:06:02 +02:00
Bernhard Schussek
335f7e776a [Form] Simplified FileType code 2011-04-24 12:08:56 +02:00
Bernhard Schussek
19073ae655 [HttpFoundation] TemporaryStorage automatically creates the directory if it doesn't exist yet 2011-04-24 12:08:56 +02:00
Bernhard Schussek
675e5ded9e [Form] Changed FormBuilder::build() to FormBuilder::create(). You hvae to pass the resulting builder to FormBuilder::add() manually now
$builder->add(
    $builder->create('child', 'form')
        ->add('foo', 'text')
        ->add('bar', 'text')
);
2011-04-24 12:08:50 +02:00
Fabien Potencier
8eb1dfc6a0 [Translation] forced translated id to strings 2011-04-24 09:42:41 +02:00
Fabien Potencier
b906cb59b8 Merge remote branch 'lsmith77/getAllPrevious'
* lsmith77/getAllPrevious:
  renamed getPreviouses() to getAllPrevious
2011-04-24 08:46:54 +02:00
Fabien Potencier
823be5d956 Merge remote branch 'ornicar/fixDelegatingValidatorNamespace'
* ornicar/fixDelegatingValidatorNamespace:
  [Form] Fix DelegatingValidator namespace
2011-04-24 08:45:50 +02:00
Fabien Potencier
27ae0a341d Merge remote branch 'weaverryan/form_tweaks'
* weaverryan/form_tweaks:
  [Form] Removing an unused variable in TimeType
  [Form] Throwing exception for invalid "input" type of DateType
  [Form] Removing unused private property and adding PHPDoc
  [Form] Fixing wrong variable name
  [Form] Tweak to FileTypeTest to avoid warning
  [Form] Adding an exception for an invalid widget option in DateType
2011-04-24 08:45:44 +02:00
Fabien Potencier
7d8a3f76bb [HttpKernel] made some minor tweaks 2011-04-24 08:44:29 +02:00
ornicar
b5055bb4fd [Form] Fix DelegatingValidator namespace 2011-04-23 23:20:56 -07:00
Ryan Weaver
181ef3cc08 [Form] Removing an unused variable in TimeType 2011-04-23 20:52:26 -05:00
Ryan Weaver
af8aad9c34 [Form] Throwing exception for invalid "input" type of DateType
Also fixed typo in test of previous commit
2011-04-23 20:36:40 -05:00
Ryan Weaver
f435ed7e7e [Form] Removing unused private property and adding PHPDoc 2011-04-23 20:14:12 -05:00
Ryan Weaver
0681e443d5 [Form] Fixing wrong variable name 2011-04-23 20:08:24 -05:00
Ryan Weaver
78b2062c5e [Form] Adding an exception for an invalid widget option in DateType 2011-04-23 19:42:40 -05:00
Lukas Kahwe Smith
fd97c0caca renamed getPreviouses() to getAllPrevious 2011-04-24 01:08:15 +02:00
Fabien Potencier
278223d950 Merge remote branch 'pborreli/phpdoc-fix'
* pborreli/phpdoc-fix:
  [Phpdoc] Cleaning/fixing
  [FrameworkBundle] Fixed typo in css
2011-04-23 21:50:16 +02:00
Fabien Potencier
8b74c6eb9c [DomCrawler] refactored URLs management in Link and Form 2011-04-23 21:45:44 +02:00
Pascal Borreli
8c0beea677 [Phpdoc] Cleaning/fixing 2011-04-23 15:18:47 +00:00
Fabien Potencier
50d3c92e22 tweaked TemporaryStorage directory creation 2011-04-23 15:19:30 +02:00
Fabien Potencier
8cc5caf1f3 changed the default directory for the upload temp dir, made the dir mandatory 2011-04-23 15:09:55 +02:00
Fabien Potencier
02c66e658c removed the nestingLevel configuration for file temporary storages 2011-04-23 15:06:07 +02:00
Lukas Kahwe Smith
d9491a743e removed support for interface injection as well as all relevant tests 2011-04-23 11:42:31 +02:00
Fabien Potencier
2b8c7f84b5 [Form] added a way to register a Form extension after creation of the FormFactory 2011-04-23 09:28:29 +02:00
Fabien Potencier
b69c5956d3 [Form] added missing use statement 2011-04-23 09:27:47 +02:00
Fabien Potencier
9a4da005a2 Merge remote branch 'bschussek/form-extensions'
* bschussek/form-extensions:
  [Form] Refactored code from CoreExtension to new ValidatorExtension
  [Form] Added FormTypeExtensionInterface
  [Form] Reorganized code into "form extensions"
2011-04-23 09:11:25 +02:00
Pascal Borreli
b5769c52d6 Fixed various typo 2011-04-22 23:12:50 +00:00
Igor Wiedler
041a2e9d83 [HttpFoundation] minor optimization 2011-04-22 22:20:12 +02:00
Bernhard Schussek
6f1bc356a8 [Form] Refactored code from CoreExtension to new ValidatorExtension
CoreExtension is now independent of the Symfony2 validator.
2011-04-22 19:38:21 +02:00
Bernhard Schussek
1ce2db87e2 [Form] Added FormTypeExtensionInterface
With implementations of this interface, existing types can be amended.
The Csrf extension, for example, now contains a class FormTypeCsrfExtension
that adds CSRF capabilities to the "form" type.

To register new type extensions in the DIC, tag them with "form.type_extension"
and the name of the extended type as alias.
2011-04-22 19:24:38 +02:00
Igor Wiedler
51d12758a0 minor adjustments suggested by vicb 2011-04-22 18:37:20 +02:00
Bernhard Schussek
54e66c518f [Form] Reorganized code into "form extensions"
The extension classes are now the only constructor argument of the FormFactory class. They replace the existing "type loader" classes.

    new FormFactory(array(
        new CoreExtension($validator, $storage),
        new CsrfExtension($csrfProvider),
        new DoctrineOrmExtension($em),
    ));

Together with a few upcoming commits this mechanism will make

 * extension of the form framework in bundles and
 * usage of the forms outside of Symfony2

much easier.
2011-04-22 17:41:21 +02:00
Igor Wiedler
9ae5023a70 [HttpFoundation] IPv6 support for RequestMatcher 2011-04-22 17:37:22 +02:00
Igor Wiedler
e5b923a0ec [Validator] use full iPv6 regex
it was taken from:
https://github.com/strattg/ipv6-address-test/blob/master/Tests/Rfc3986RegexTest.php
2011-04-22 17:07:44 +02:00
Igor Wiedler
afcdbf8b79 [Validator] add IPv6 support to UrlValidator 2011-04-22 17:07:44 +02:00
Igor Wiedler
82699c5a98 [HttpFoundation] add IPv6 support to Request 2011-04-22 17:07:44 +02:00
Fabien Potencier
417839345f Merge remote branch 'lsmith77/request_format_tweaks'
* lsmith77/request_format_tweaks:
  added text/html to default format mapping
  return "q" from splitHttpAcceptHeader() to enable more complex accept header negotiations
  added support for setting a custom default format in Request::getRequestFormat()
2011-04-22 15:33:01 +02:00
Fabien Potencier
fd05f02b23 [HttpFoundation] added logic to automatically add the charset when not present in the Content-Type for relevant Content-Types 2011-04-22 15:26:38 +02:00
Fabien Potencier
7644e86683 refactored session configuration
* made the options array only for "global" options that are valid for all session storages
 * changed the PDO session storage constructor signature to accept an array of options for DB configuration
 * changed the storage_id to be the full service id, instead of just part of it
 * removed the class parameter for session as it can be changed via the .class parameter (it was the only example in the framework)
 * removed the configuration for the PDO session storage for now
2011-04-22 13:34:57 +02:00
Bernhard Schussek
a97366fbcb [Form] Split signature of FormFactory::create() into create() and createNamed()
The data can now be passed to all creation methods:

    $form = $factory->create('form', $data);

By default, a form will receive the name of its type ("form" in above example). If you wish to pass a custom name, use createNamed():

    $form = $factory->createNamed('form', 'myform', $data);
2011-04-22 10:42:21 +02:00
Fabien Potencier
0069a70e42 Merge branch 'form'
* form: (291 commits)
  [FrameworkBundle] updated method call
  [Form] Removing excess option in the TimezoneType
  [FrameworkBundle] Adding check for invalid form type for better exception message
  [TwigBundle] Removing dbug text in form template
  [Form] Removed obsolete code in TextType
  [Form] fixed translations escaping
  [Form] Adding a check that the choice_list option on the ChoiceType implements the ChoiceListInterface.
  [Form] added support for groups in form validation (when using array data)
  [Form] fixed error bubbling for choices when expanded is true
  [Form] added a unit test
  [Form] Removed obsolete view variables
  [Form] Renamed ChoiceUtil to FormUtil and gave its methods more general names
  [Form] Changed separator for Twig blocks from double underscore to single underscore to match the PHP template separator
  [Form] Removed StripTagsListenerTest
  [Form] Removed StripTagsListener. Its implementation is insufficient and needs to be replaced by a better one.
  [Form] added a way to specify the form constraint when building the form (useful if you work with arrays instead of objects)
  [Form] Added test for 'email' type and fixed a few bugs
  [Form] Removed obsolete constraints from validation.xml
  Revert "[Form] removed validation.xml file (not used anymore)"
  Added html5 email input to the forms
  ...
2011-04-22 09:36:52 +02:00
Fabien Potencier
de8f10e236 Merge remote branch 'Infranology/framework-bundle-updated-method-call' into form
* Infranology/framework-bundle-updated-method-call: (91 commits)
  [FrameworkBundle] updated method call
  moved DoctrineMongoDBBundle to its own repository
  [AsseticBundle] fixed unit tests
  [FrameworkBundle] removed unneeded files in tests
  updated vendors
  [FrameworkBundle] removed the need to boot a Kernel in a unit test file
  [FrameworkBundle] removed the need to boot a Kernel in a unit test file
  [Routing] added getContext() accessor
  [HttpFoundation] fixed a potential security problem in Request
  updated vendors
  Added 201 to the possible status codes that indicate a response is a redirect.
  [FrameworkBundle] made ESI URL relative as allowed by the spec (no need to generate absolute URLs)
  [AsseticBundle] fixed router and controller
  [AsseticBundle] removed fake front controller from URL before creating route
  [AsseticBundle] updated twig integration to check debug mode at runtime rather than compile time since twig cannot vary its cache by debug mode
  [Routing] the global parameters must not be added in the QS when generating URLs
  removed the possibility to pass a message to the trans tag
  simplified exceptions as Twig is now smart enough to automatically add line information
  made the %count% variable automatically available when using the transchoice filter (similar to how the tag works)
  [Container] Added function array_unique on getServiceIds to return only one service name
  ...
2011-04-22 09:35:11 +02:00
Fabien Potencier
f626afcdef Merge remote branch 'weaverryan/validator_choice_message_changes'
* weaverryan/validator_choice_message_changes:
  [Validator] Modifying Choice message and adding a different multiple message
2011-04-22 08:40:08 +02:00
Eriksen Costa
9cf7fba913 Merge branch 'master' into fix-stub-locale-method-signature 2011-04-22 00:07:29 -03:00
Eriksen Costa
589b0ab4ed Merge branch 'master' into form-frameworkbundle-form-guessers-fix
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddFormGuessersPass.php
	src/Symfony/Component/Form/MoneyField.php
2011-04-21 23:03:40 -03:00
Ryan Weaver
1856601524 [Validator] Modifying Choice message and adding a different multiple message 2011-04-21 20:05:13 -05:00
Ryan Weaver
df50e2b161 [Form] Removing excess option in the TimezoneType 2011-04-21 19:57:53 -05:00
Fabien Potencier
8b2b8e16dc Merge remote branch 'schmittjoh/referenceValidation'
* schmittjoh/referenceValidation:
  [DependencyInjection] also check references of inlined services
  [DependencyInjection] adds emulation of "exception-on-invalid-reference" behavior
2011-04-21 22:44:20 +02:00
Fabien Potencier
813627bd4c [Routing] added getContext() accessor 2011-04-21 21:20:27 +02:00
Fabien Potencier
c5497c7c67 [HttpFoundation] fixed a potential security problem in Request 2011-04-21 20:00:27 +02:00
Fabien Potencier
a2ab05e9c2 Merge remote branch 'web-dev/master'
* web-dev/master:
  Added 201 to the possible status codes that indicate a response is a redirect.
2011-04-21 19:51:30 +02:00
Josiah
98e46a23fa Added 201 to the possible status codes that indicate a response is a redirect. 2011-04-21 10:36:25 -07:00
Fabien Potencier
9a2d4c77c3 Merge remote branch 'Garfield-fr/master'
* Garfield-fr/master:
  [Container] Added function array_unique on getServiceIds to return only one service name
2011-04-21 18:31:55 +02:00
Bernhard Schussek
c58b05a6d6 [Form] Removed obsolete code in TextType 2011-04-21 10:17:04 +02:00
Fabien Potencier
7e33159723 [Routing] the global parameters must not be added in the QS when generating URLs 2011-04-21 09:52:35 +02:00
Bertrand Zuchuat
7ed8ea25d8 [Container] Added function array_unique on getServiceIds to return only one service name 2011-04-20 23:45:36 +02:00
Fabien Potencier
071caeb0c8 Merge remote branch 'merk/file'
* merk/file:
  [HttpFoundation\File] Removed realpath()
2011-04-20 23:13:55 +02:00
Fabien Potencier
d721cbe1e2 Merge remote branch 'kriswallsmith/http/filesystem-session-fix'
* kriswallsmith/http/filesystem-session-fix:
  [HttpFoundation] fixed FilesystemSessionStorage
2011-04-20 23:09:04 +02:00
Fabien Potencier
ace5e26406 Merge remote branch 'schmittjoh/security'
* schmittjoh/security:
  [Security/Core] force implementations to accept null values
  [Security/Acl] some misc fixes
  [Security/Acl] removed Doctrine dependency from interfaces and moved them to the actual implementation
  [SecurityBundle] changed expected value for token_provider key in the rememberme section
2011-04-20 23:07:33 +02:00
Fabien Potencier
c6dcf0f8f3 [Routing] added a way to set default parameters that are applied when generating URLs 2011-04-20 23:01:05 +02:00
Fabien Potencier
f7d44148df [Routing] removed unused defaults variable 2011-04-20 22:55:23 +02:00
Johannes Schmitt
192592ec9b [Security/Core] force implementations to accept null values 2011-04-20 22:38:16 +02:00
Johannes Schmitt
f697fe3b26 [Security/Acl] some misc fixes 2011-04-20 22:35:17 +02:00
Johannes Schmitt
4d6e239f10 [Security/Acl] removed Doctrine dependency from interfaces and moved them to the actual implementation 2011-04-20 22:25:05 +02:00
Kris Wallsmith
30511d2965 [HttpFoundation] fixed FilesystemSessionStorage 2011-04-20 13:20:21 -07:00
Fabien Potencier
fd1636b324 [Routing] added RedirectableUrlMatcher 2011-04-20 15:54:48 +02:00
Ryan Weaver
967a42b797 [Form] Adding a check that the choice_list option on the ChoiceType implements the ChoiceListInterface.
Also removed an unused "use" statement.
2011-04-20 08:52:31 -05:00
Tim Nagel
03bb3580a6 [HttpFoundation\File] Removed realpath() 2011-04-20 23:52:17 +10:00
Fabien Potencier
9d2ea4ec31 Merge remote branch 'kriswallsmith/dic/method-renames'
* kriswallsmith/dic/method-renames:
  added method renames to UPDATE
  [DependencyInjection] renamed ContainerBuilder::remove() as removeDefinition() to be more consistent with other definition-related methods
  [DependencyInjection] renamed Definition::setArgument() as replaceArgument() to be more specific
2011-04-20 14:28:09 +02:00
Fabien Potencier
0dbfa18c46 [Routing] made a small optimization to the route dumper 2011-04-20 14:19:33 +02:00
Fabien Potencier
117321d3c6 replaced array for request context in Routing by a RequestContext class 2011-04-20 14:19:32 +02:00
Kris Wallsmith
470baaab9f [DependencyInjection] renamed ContainerBuilder::remove() as removeDefinition() to be more consistent with other definition-related methods 2011-04-20 04:48:19 -07:00
Kris Wallsmith
cdf706d357 [DependencyInjection] renamed Definition::setArgument() as replaceArgument() to be more specific 2011-04-20 04:47:44 -07:00
Fabien Potencier
07aae98495 [Routing] added support for _scheme requirement
The _scheme requirement can be used to force routes to always match one given scheme
and to always be generated with the given scheme.

So, if _scheme is set to https, URL generation will force an absolute URL if the
current scheme is http. And if you request the URL with http, you will be redirected
to the https URL.
2011-04-20 10:49:32 +02:00
Fabien Potencier
d993a9160a [HttpFoundation] fixed getScheme() method 2011-04-20 10:49:08 +02:00
Johannes M. Schmitt
c660fcd2f2 fixes a bug in the SwitchUserListener 2011-04-19 14:24:37 +02:00
Fabien Potencier
2014ff6856 merged lsmith77/url_generator_null_parameter 2011-04-19 14:21:14 +02:00
Fabien Potencier
e09a0f9f80 Merge remote branch 'brikou/coding_standards'
* brikou/coding_standards:
  removed empty lines/trailing spaces
2011-04-19 14:06:30 +02:00
Fabien Potencier
5ff67a8d54 made request data collector more robust when the user got the request content as a resource 2011-04-19 14:02:32 +02:00
Fabien Potencier
3ca5f513a4 [Form] added support for groups in form validation (when using array data) 2011-04-19 09:56:49 +02:00
Fabien Potencier
5242859920 [Form] fixed error bubbling for choices when expanded is true 2011-04-19 09:13:29 +02:00
Bernhard Schussek
d93e10160c [Form] Removed obsolete view variables 2011-04-18 15:47:18 +02:00
Lukas Kahwe Smith
1ecaade68d added support for parameters with default null 2011-04-18 15:35:05 +02:00
Bernhard Schussek
b93f5a372a [Form] Renamed ChoiceUtil to FormUtil and gave its methods more general names 2011-04-18 15:07:12 +02:00
Bernhard Schussek
abb0d0cde1 [Form] Removed StripTagsListener. Its implementation is insufficient and needs to be replaced by a better one.
The current implementation does not sanitize HTML properly. See [1] and [2] for more information.

[1] https://github.com/padraic/wibble
[2] http://blog.astrumfutura.com/?s=html+sanitising
2011-04-18 14:19:20 +02:00
Fabien Potencier
bee5d07d86 [Form] added a way to specify the form constraint when building the form (useful if you work with arrays instead of objects) 2011-04-18 14:09:29 +02:00
Bernhard Schussek
57722550de [Form] Added test for 'email' type and fixed a few bugs 2011-04-18 13:04:18 +02:00
Bernhard Schussek
23e9ad7a99 Merge remote branch 'mvrhov/email_type' into mvrhov_merge 2011-04-18 12:57:38 +02:00
Bernhard Schussek
eb21dc9fea [Form] Removed obsolete constraints from validation.xml 2011-04-18 12:57:19 +02:00
Bernhard Schussek
325049ac73 Revert "[Form] removed validation.xml file (not used anymore)"
This reverts commit 3e476e1c30.
2011-04-18 12:53:41 +02:00
Miha Vrhovnik
50011fa344 Added html5 email input to the forms 2011-04-18 11:17:41 +02:00
Miha Vrhovnik
43bcadbb80 Updating renamed event 2011-04-18 11:00:26 +02:00
Fabien Potencier
3a2ca3dd92 moved Doctrine2 Entity Type guesser to the Doctrine bridge 2011-04-18 08:44:37 +02:00
Fabien Potencier
4bfd5bf079 [Form] tweaked Date time transformer to allow fields with 0 as hour/minute/... 2011-04-17 22:50:22 +02:00
Fabien Potencier
3e476e1c30 [Form] removed validation.xml file (not used anymore) 2011-04-17 22:33:31 +02:00
Fabien Potencier
f4aae27904 Merge remote branch 'lsmith77/add_decoder_interface'
* lsmith77/add_decoder_interface:
  added a DecodeInterface (and SerializerAwareInterface) to make it easier to identify if an Encoder also supports decoding
2011-04-17 19:30:13 +02:00
Bernhard Schussek
be5738564f [Form] Improved regular expression in AbstractType::getName() and added unit tests 2011-04-17 18:01:22 +02:00
Bernhard Schussek
4905bfd285 Merge remote branch 'brikou/form' into form 2011-04-17 18:01:17 +02:00
Lukas Kahwe Smith
874c4b6e07 added a DecodeInterface (and SerializerAwareInterface) to make it easier to identify if an Encoder also supports decoding 2011-04-17 17:00:42 +02:00
Lukas Kahwe Smith
c2ac8304b0 added text/html to default format mapping 2011-04-17 14:39:07 +02:00
Lukas Kahwe Smith
4c3c6cdabf return "q" from splitHttpAcceptHeader() to enable more complex accept header negotiations 2011-04-17 14:38:33 +02:00
Lukas Kahwe Smith
53c7bcf3aa added support for setting a custom default format in Request::getRequestFormat() 2011-04-17 14:37:35 +02:00
Fabien Potencier
7a70236437 Merge remote branch 'schmittjoh/containerBaseClass'
* schmittjoh/containerBaseClass:
  [DependencyInjection] make base class of generated container configurable
2011-04-17 14:15:36 +02:00
Fabien Potencier
62737c2495 Merge remote branch 'hidenorigoto/feature/add-server-param-method'
* hidenorigoto/feature/add-server-param-method:
  [BrowserKit] added tests for setServerParameter/getServerParameter methods
  [BrowserKit] added getServerParameter method which makes setServerParameters/setServerParameter methods testable
  [BrowserKit] added the method to Client which enables to set single server parameter
2011-04-17 14:14:49 +02:00
Fabien Potencier
5861a1b962 Merge remote branch 'merk/security/phpdoc'
* merk/security/phpdoc:
  [Security] Added missing phpdoc
2011-04-17 14:11:49 +02:00
Johannes M. Schmitt
30bac46e1b [DependencyInjection] make base class of generated container configurable 2011-04-17 12:29:33 +02:00
hidenorigoto
1d85a3dcb1 [BrowserKit] added getServerParameter method which makes setServerParameters/setServerParameter methods testable 2011-04-17 11:22:59 +09:00
hidenorigoto
54c3d236c2 [BrowserKit] added the method to Client which enables to set single server parameter 2011-04-17 10:45:32 +09:00
Fabien Potencier
c6818d8bf7 [HttpKernel] added support for controllers as arrays and object with an __invoke method
Controllers can now be any valid PHP callable
2011-04-16 16:26:15 +02:00
Tobias Naumann
f6ce451e2c [Form] Made FormView implement Countable 2011-04-16 13:54:31 +02:00
Tim Nagel
ad86f9ff0d [Security] Added missing phpdoc 2011-04-16 16:21:04 +10:00
Brikou CARRE
e898445b94 removed empty lines/trailing spaces 2011-04-15 21:12:02 +02:00
Brikou CARRE
a83046f470 fixed regex (we don't need '?') 2011-04-15 19:04:53 +02:00
Brikou CARRE
28121e4a57 [Form] AbstractType::getName() improvement 2011-04-15 18:58:15 +02:00
Bernhard Schussek
30922d9375 [Form] Fixed: Checkboxes in an expanded choice field never have the 'required' HTML5 attribute. Closes http://trac.symfony-project.org/ticket/9588 2011-04-15 16:10:04 +02:00
Bernhard Schussek
9582221862 [Form] ResizeFormListener::preBind() now handles empty strings. Fixes https://github.com/symfony/symfony/pull/40 2011-04-15 15:43:02 +02:00
Bernhard Schussek
d0c572716a Merge remote branch 'henrikbjorn/form' into henrik_merge 2011-04-15 15:34:29 +02:00
Henrik Bjørnskov
e687685f98 [Form] change FormView::setVar,getVar,getVars,hasVar to set,get,all,has
[Form] Fixed {get,set,has}Var references in templating php

[Form] Added getVars to FormView to ease usage in Twig. Also added some phpdoc and cleaned up the get method by adding a default value

[Form] Fix

[Form] Delete file generated by test
2011-04-15 15:25:37 +02:00
Bernhard Schussek
e787d5dc22 [Form] PropertyPath now can handle elements with special characters 2011-04-15 15:25:19 +02:00
Bernhard Schussek
4f1ae660fa [Form] Fixed choice labels in expanded choice fields 2011-04-15 15:04:44 +02:00
Bernhard Schussek
41c6ab0ac7 [Form] Field labels can now be passed in the 'label' option 2011-04-15 15:03:10 +02:00
Bernhard Schussek
8fe21285ba [Form] Renamed Form::getView() to createView() to clearly indicate that each call returns a new object 2011-04-15 13:52:11 +02:00
Bernhard Schussek
276b23a344 [Form] Moved creation logic of FormView to Form class 2011-04-15 13:41:45 +02:00
Fabien Potencier
db8b118e8a Merge remote branch 'hidenorigoto/fix-methodname-case'
* hidenorigoto/fix-methodname-case:
  [HttpFoundation] fixed wrong method name
2011-04-15 12:53:37 +02:00
Bernhard Schussek
44fa9bbeaa [Form] Fixed: CSRF token is regenerated if validation fails to avoid stalled tokens. Closes https://github.com/symfony/symfony/pull/415 2011-04-15 12:50:50 +02:00
Bernhard Schussek
c9c8b5c98e [Form] Improved test coverage of MonthChoiceList and fixed timezone used in it. Fixes https://github.com/symfony/symfony/pull/433
Based on dfb93b1bcebf1f34d3a880d00f36acb2bcca0f08:

[FORM] Fixed DateField Month Choices

The month choices were calculated using the current day of the month with
gmmktime rather than the 1st of the month. Additionally, this provides a
UTC timestamp which is passed to the formatter (IntlDateFormatter) which
converts the timestamp using the current timezone. This means that the UTC
timestamp for 1st March was being converted for my timezone (EST) and giving
a date of 28th February, leading to Feb appearing again in the popup form
instead of Mar.
2011-04-15 12:26:07 +02:00
Fabien Potencier
7e58c3f976 [Routing] allowed default route variables to be null 2011-04-15 12:04:48 +02:00
hidenorigoto
1e78ec395c [HttpFoundation] fixed wrong method name 2011-04-15 19:04:00 +09:00
Fabien Potencier
ad112da5bc added the request content to the request data collector 2011-04-15 11:31:08 +02:00
Bernhard Schussek
77bea81ed5 [Form] Improved test coverage of ResizeFormListener. Fixed https://github.com/symfony/symfony/pull/493 2011-04-15 11:06:51 +02:00
Bernhard Schussek
fa457b1cc4 [Form] Renamed 'filter' listeners to 'on' to match naming conventions across the framework 2011-04-15 10:57:32 +02:00
Fabien Potencier
de390fd893 [DependencyInjection] removed timing info as it is useless 2011-04-15 10:42:56 +02:00
Fabien Potencier
0b563c32ac Merge remote branch 'schmittjoh/diLogging'
* schmittjoh/diLogging:
  [DependencyInjection] enable debug related passes only in debug environment
  [DependencyInjection] removed pass time
  [DependencyInjection] fixes a bug which might have occurred when using property injection under certain circumstances
  [DependencyInjection] fixed method name
  [FrameworkBundle] whitespace fix
  [DependencyInjection] refactored code a bit, added some more logging messages
  [DependencyInjection] dump a readable format
  [DependencyInjection] better logging
2011-04-15 10:38:54 +02:00
Johannes Schmitt
fd5caa9546 [DependencyInjection] also check references of inlined services 2011-04-15 08:47:28 +02:00
Johannes Schmitt
ff41541d45 [DependencyInjection] removed pass time 2011-04-15 08:19:28 +02:00
Fabien Potencier
067bd0009e Merge remote branch 'kriswallsmith/scalar-nodes'
* kriswallsmith/scalar-nodes:
  removed a lot of special normalization logic in the configuration by using xml values instead of attributes
2011-04-15 07:44:22 +02:00
Johannes Schmitt
6d7a9d752d [DependencyInjection] adds emulation of "exception-on-invalid-reference" behavior
This pass requires that all of references are valid at the end of
the compilation process.
2011-04-15 00:55:18 +02:00
Johannes M. Schmitt
1992c3b96d [DependencyInjection] fixes a bug which might have occurred when using property injection under certain circumstances 2011-04-14 21:29:46 +02:00
Johannes M. Schmitt
75ac0f5dc3 [DependencyInjection] fixed method name 2011-04-14 21:07:16 +02:00
Johannes M. Schmitt
6ea9fb16c7 [DependencyInjection] refactored code a bit, added some more logging messages 2011-04-14 21:01:37 +02:00
Bernhard Schussek
e3db366116 [Form] Passing FormFactory to FormBuilder in its constructor 2011-04-14 15:25:30 +02:00
Bernhard Schussek
44af72bbf4 Merge remote branch 'symfony/master' into experimental 2011-04-14 15:04:59 +02:00
Bernhard Schussek
72b17cd67c [Form] Renamed TemplateContext to FormView 2011-04-14 15:02:51 +02:00
Bernhard Schussek
ca6ae09779 [Form] Removed TemplateContext::create() 2011-04-14 14:42:17 +02:00
Fabien Potencier
9cc340a262 fixed inconsistencies in file locator classes 2011-04-14 12:52:22 +02:00
Bernhard Schussek
ce5f3073bd Fixed test suite and names of accessor methods in TemplateContext 2011-04-14 03:52:52 +02:00
Fabien Potencier
5316decd8c Merge remote branch 'hhamon/shared_maxage_fix'
* hhamon/shared_maxage_fix:
  [HttpFoundation] force Response to be "public" if setSharedMaxAge() is called.
2011-04-13 23:24:31 +02:00
Fabien Potencier
b32a7e935a simplified code 2011-04-13 23:18:28 +02:00
Fabien Potencier
ea84bb025b fixed session management in functional tests 2011-04-13 23:11:25 +02:00
Fabien Potencier
6957dae4f9 [HttpKernel] added support for cookies in Client 2011-04-13 20:25:35 +02:00
Fabien Potencier
e2c9fdf2c7 [HttpFoundation] fixed expiration time for Cookie (PHP wants a Unix timestamp) 2011-04-13 20:12:14 +02:00
Fabien Potencier
66c4bc727c [HttpFoundation] renamed Cookie::getExpire() to getExpiresTime() to be consistent with the DomCrawler component 2011-04-13 20:10:39 +02:00
Fabien Potencier
84dde4074a [HttpFoundation] changed default value of Cookie httponly argument to match PHP defaults 2011-04-13 20:07:31 +02:00
hhamon
053d83f557 [HttpFoundation] force Response to be "public" if setSharedMaxAge() is called. 2011-04-13 15:58:48 +02:00
Bernhard Schussek
8031ad77c8 Merge remote branch 'fabpot/form' into fabpot_merge 2011-04-13 15:58:15 +02:00
Kris Wallsmith
672291087c removed a lot of special normalization logic in the configuration by using xml values instead of attributes 2011-04-13 05:59:46 -07:00
Fabien Potencier
a6d790f89f Merge remote branch 'hhamon/http_cache_fix'
* hhamon/http_cache_fix:
  [HttpKernel] private $traces property was not initialized to an empty array. When using the getLog() method to debug traces, it led to a warning in the apache error log.
2011-04-13 14:38:32 +02:00
Fabien Potencier
fa6961bb91 Revert "Merge remote branch 'lsmith77/prevent_redundant_DI_method_calls'"
This reverts commit 0d61ae06b4, reversing
changes made to 8e3d125902.
2011-04-13 14:30:06 +02:00
Fabien Potencier
227c87404f Merge remote branch 'Funsational/master'
* Funsational/master:
  Update PDO session storage to check if any rows are updated when doing a session write. If no rows are udpated when performing a session write it generally means that we have created a new session id somewhere and we have not inserted into the database. This is the case for when calling regenerate_session_id() from the native session storage class. It will update the session id then call sessionWrite() to save the session but since the new session id does not exist in the DB, no rows are updated and any new session attributes such as security tokens are lost.
2011-04-13 14:27:16 +02:00
hhamon
facb67cbfa [HttpKernel] private $traces property was not initialized to an empty array. When using the getLog() method to debug traces, it led to a warning in the apache error log. 2011-04-13 14:24:53 +02:00
Fabien Potencier
0d61ae06b4 Merge remote branch 'lsmith77/prevent_redundant_DI_method_calls'
* lsmith77/prevent_redundant_DI_method_calls:
  do not add method calls from interface injection if a method call has already been set manually
2011-04-13 14:16:14 +02:00
Lukas Kahwe Smith
c9be18a79f do not add method calls from interface injection if a method call has already been set manually 2011-04-13 14:11:56 +02:00
Fabien Potencier
4e047b5e27 Merge remote branch 'vicb/event_debug'
* vicb/event_debug:
  [FrameworkBundle] Make some TraceableEventDispacther properties private
  [Event] Tweak phpDoc for consistency
  [FrameworkBundle] Add error detection to the TraceableEventDispatcher
2011-04-13 14:07:05 +02:00
George Giannoulopoulos
81e1d4f11d Refactoring, replace is_null() wuth null === 2011-04-13 13:56:15 +02:00
Bernhard Schussek
2a18be1c9f Merge remote branch 'symfony/master' into experimental 2011-04-13 13:53:20 +02:00
Fabien Potencier
7913d7978e [Form] removed DefaultFormFactory as it does not help that much and adds some confusion 2011-04-13 13:24:56 +02:00
Fabien Potencier
92f77cce97 Merge remote branch 'lsmith77/ResolveInvalidReferencesPass'
* lsmith77/ResolveInvalidReferencesPass:
  updated tests (aka removed exceptions handling)
  use synthetic services instead of special exceptions
2011-04-13 11:46:52 +02:00
Fabien Potencier
49dc836521 [Form] moved the template context creation to the Form class
Moving the template context creation makes sense and allows for simpler code for the end user:

Before:

        return array('post' => $post, 'form' => $this->get('form.factory')->createTemplateContext($form));

After:

        return array('post' => $post, 'form' => $form->getContext());
2011-04-13 09:31:13 +02:00
Fabien Potencier
94eed37a93 Merge remote branch 'schmittjoh/parameterBagEnhancement'
* schmittjoh/parameterBagEnhancement:
  [HttpFoundation] added some unit tests
  [HttpFoundation] allow to retrieve paths of arbitrary depths
2011-04-13 07:58:14 +02:00
Johannes Schmitt
2397bcbe94 [DependencyInjection] better logging 2011-04-13 00:51:32 +02:00
Fabien Potencier
d95a743d9f Merge remote branch 'Brouznouf/master'
* Brouznouf/master:
  [Serializer] Revert DOMElement to SimpleXmlElement
  [Serializer] Using DOMElement instead of SimpleXmlElement in XmlEncoder to permit some behavior
2011-04-12 13:02:35 +02:00
Fabien Potencier
e6fd8deb00 [Security] tweaked some exception messages 2011-04-12 11:41:39 +02:00
Brouznouf
86343b43ec [Serializer] Revert DOMElement to SimpleXmlElement 2011-04-12 11:18:17 +02:00
Brouznouf
b02c1d9f32 Merge remote branch 'upstream/master' 2011-04-12 11:17:09 +02:00
Fabien Potencier
41a1a75b92 [Process] made default options overridable 2011-04-12 11:04:35 +02:00
Fabien Potencier
7f911642e1 Merge remote branch 'pborreli/windows-process-fix'
* pborreli/windows-process-fix:
  [Process][Windows] Don't use cmd for launching process (fixing Sismo git.exe calling)
2011-04-12 11:04:02 +02:00
Fabien Potencier
d163a60f54 [Security] fixed URL 2011-04-12 10:49:22 +02:00
Lukas Kahwe Smith
a4b04c4add use synthetic services instead of special exceptions 2011-04-12 10:07:46 +02:00
Pascal Borreli
3e8874df75 Merge remote-tracking branch 'upstream/master' into windows-process-fix 2011-04-12 01:05:46 +00:00
Brouznouf
8e6233e9c2 [Serializer] Using DOMElement instead of SimpleXmlElement in XmlEncoder to permit some behavior 2011-04-12 00:58:21 +02:00
Fabien Potencier
aa26624161 Merge remote branch 'vicb/template_logical_name'
* vicb/template_logical_name:
  Display template logical names in exception messages
2011-04-11 18:35:51 +02:00
Kris Wallsmith
c5fe4c390d [Templating] cleaned up some anomalies in the engine 2011-04-11 09:20:47 -07:00
Fabien Potencier
7f2294395c [Form] reverted the templating part to be similar to what we have today 2011-04-11 16:42:51 +02:00
Pascal Borreli
46b4098907 [Process][Windows] Don't use cmd for launching process (fixing Sismo git.exe calling) 2011-04-09 17:31:26 +00:00
Victor Berchet
e254ff8cc6 Display template logical names in exception messages 2011-04-08 19:56:12 +02:00
Fabien Potencier
9ceec87eb8 [DomCrawler] fixed various bug with URIs 2011-04-08 17:52:43 +02:00
Fabien Potencier
a230090537 removed some json_encode() calls to use the new getLogicalName() method instead 2011-04-08 17:28:27 +02:00
Fabien Potencier
5558ee24c7 Merge remote branch 'hason/logicalname'
* hason/logicalname:
  [Templating] changed __toString method (synonym for getLogicalName method)
  [Templating] fixed phpdoc a test
  [FrameworkBundle] added getLogicalName() method to TemplateReference
  [Templating] added method to return the template logical name, added test
2011-04-08 17:22:11 +02:00
Johannes M. Schmitt
8132102237 [Process] use component exception 2011-04-08 14:27:03 +02:00
Johannes M. Schmitt
34beec2161 [Process][Assetic] refactored some code to allow for better executable defaults 2011-04-08 12:20:27 +02:00
Martin Hason
185144bc46 [Templating] changed __toString method (synonym for getLogicalName method) 2011-04-08 11:33:35 +02:00
Martin Hason
20c5db2197 [Templating] fixed phpdoc a test 2011-04-08 11:24:28 +02:00
Martin Hason
6b5d991685 [Templating] added method to return the template logical name, added test 2011-04-08 10:31:47 +02:00
Victor Berchet
ceb2c976de [HttpKernel] Fix the case where no resource is found 2011-04-08 08:52:03 +02:00
Fabien Potencier
dfa1da0416 [Form] removed unused use statement and fixed phpdoc 2011-04-07 09:00:01 +02:00
michaelwilliams
c4660418d2 Merge remote-tracking branch 'upstream/master' 2011-04-06 17:42:32 -07:00
Pascal Borreli
3dfbc08d73 [HttpKernel][Windows] Removed useless DIRECTORY_SEPARATOR conversion 2011-04-06 17:30:32 +00:00
Bernhard Schussek
67582c9a5c Merge remote branch 'symfony/master' into experimental
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/Debug/TraceableEventDispatcher.php
2011-04-06 16:06:26 +02:00
Bernhard Schussek
3482ff73b7 [Form] Fixed empty value in choice fields 2011-04-06 15:59:09 +02:00
Bernhard Schussek
e476231e8a [Form] Removed invalid tests, cleaned up some tests, added test coverage 2011-04-06 15:58:53 +02:00
Kris Wallsmith
3ff157c8a5 [Validator] switched to apc_exists() 2011-04-06 04:12:29 -07:00
Kris Wallsmith
9ff2ca7f1d [Validator] fixed apc cache 2011-04-06 04:07:37 -07:00
Fabien Potencier
ae218d202e Merge remote branch 'vicb/bundle_inheritance'
* vicb/bundle_inheritance:
  [Kernel] Fix bundle inheritance
2011-04-06 11:29:05 +02:00
Victor Berchet
745d144e79 [Event] Tweak phpDoc for consistency 2011-04-06 09:42:48 +02:00
Victor Berchet
7707c0f251 [Kernel] Fix bundle inheritance 2011-04-06 07:46:08 +02:00
Jordi Boggiano
e697224efa [Security] Remove unneeded and invalid use statement 2011-04-05 18:42:00 +02:00
Fabien Potencier
e3679ef44f [Routing] decoupled Routing from FrameworkBundle 2011-04-05 15:21:32 +02:00
Fabien Potencier
00c9539aaa Merge remote branch 'vicb/config_base'
* vicb/config_base:
  [Config] Add a note about the ConfigurationInterface interface in UPDATE.md
  [MonologBundle] Make The Configuration class implements the ConfigurationInterface
  [Config] Introduction of an ConfigurationInterface
2011-04-05 12:32:58 +02:00
Johannes Schmitt
6d4814c115 Merge branch 'acl-fix' of https://github.com/comfortablynumb/symfony into security 2011-04-05 12:25:24 +02:00
Gustavo Adrian
2e96f2c63d Fixed exception that was thrown while updating a field ACE 2011-04-05 13:05:20 -03:00
Fabien Potencier
372907ead1 [Routing] fixed CS 2011-04-05 12:13:47 +02:00
Fabien Potencier
7c0a39c353 [Routing] optimized the output of the PHP matcher dumper 2011-04-05 11:58:56 +02:00
Victor Berchet
b640fcb0f0 [Config] Introduction of an ConfigurationInterface 2011-04-05 11:26:28 +02:00
Johannes Schmitt
1ed73fb6e6 [HttpFoundation] allow to retrieve paths of arbitrary depths 2011-04-05 10:17:31 +02:00
Fabien Potencier
6faacdec27 [HttpKernel] fixed CS 2011-04-05 09:48:36 +02:00
Fabien Potencier
9bcd49683e Merge remote branch 'vicb/resource_path'
* vicb/resource_path:
  Update for Bundle names long again (= include the 'Bundle' suffix)
  [Kernel] Make locateResource() throws an exception when a resource from a Bundle hides a custom resource
  [Kernel] Make resources overriding consistent across bundle directories and resource directories
  [Kernel] Improve test semantic
  [Kernel] Update tests with shorter bundle names
  [Kernel] Restore the tests for the locateResource method
  Resource paths should use the full bundle name (with the 'Bundle' postfix)
2011-04-05 09:42:47 +02:00
Fabien Potencier
fe43e1b759 Merge remote branch 'lsmith77/default_namespace2'
* lsmith77/default_namespace2:
  added default implementation for getNamespace()
2011-04-04 18:46:30 +02:00
Bernhard Schussek
0cf8cc762a Merge remote branch 'symfony/master' into experimental
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/money_field.html.php
	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/percent_field.html.php
2011-04-04 15:16:08 +02:00
Fabien Potencier
1fd44ea736 Merge remote branch 'vicb/cache_template'
* vicb/cache_template:
  [FrameworkBundle] Fix the cache template loader
2011-04-04 11:49:13 +02:00
Victor Berchet
5317c96fef Update for Bundle names long again (= include the 'Bundle' suffix) 2011-04-04 11:39:41 +02:00
Victor Berchet
7ed18bf829 [Kernel] Make locateResource() throws an exception when a resource from a Bundle hides a custom resource 2011-04-04 11:24:51 +02:00
Victor Berchet
3cd3dd39ba [Kernel] Make resources overriding consistent across bundle directories and resource directories 2011-04-04 11:24:51 +02:00
Victor Berchet
8b7c857ef3 Resource paths should use the full bundle name (with the 'Bundle' postfix) 2011-04-04 11:24:51 +02:00
Fabien Potencier
f232b3cdda reverted Merge remote branch 'kriswallsmith/kernel/shorter-bundle-names' 2011-04-04 11:10:56 +02:00
Fabien Potencier
06c1e02bed Merge remote branch 'Seldaek/serializer'
* Seldaek/serializer:
  [Serializer] Some more privates
  [Serializer] Move private methods below protected ones
  [Serializer] Added @api annotations
  [Serializer] Added docblocks for NormalizableInterface
  [Serializer] add methods to the SerializerInterface
  [Serializer] Added docblock
  [Serializer] Switched most protected to private or final
2011-04-04 11:01:41 +02:00
Eriksen Costa
bc52107d07 [Locale] fixed method signature, removed default value for the $locale arg 2011-04-03 22:57:50 -03:00
Fabien Potencier
514133a6bb [Console] made ApplicationTester::getDisplay() work even in case of an error during execution and changed returned value of ApplicationTester to the command exit code 2011-04-03 23:46:08 +02:00
Fabien Potencier
dd158a2c99 [Console] made CommandTester::getDispaly() work even in case of an error during execution 2011-04-03 23:25:59 +02:00
Fabien Potencier
ad4a0bda1c [Console] changed returned value of CommandTester to the command exit code 2011-04-03 22:30:40 +02:00
Fabien Potencier
91a2f36850 [DomCrawler] fixed typo in phpdoc 2011-04-03 22:23:52 +02:00
Jordi Boggiano
7132f81d14 [Serializer] Some more privates 2011-04-03 16:24:25 +02:00
Jordi Boggiano
47733d08a1 [Serializer] Move private methods below protected ones 2011-04-03 16:21:53 +02:00
Jordi Boggiano
54ffb1fbc0 [Serializer] Added @api annotations 2011-04-03 15:49:40 +02:00
Jordi Boggiano
507f6269b5 [Serializer] Added docblocks for NormalizableInterface 2011-04-03 15:44:09 +02:00
Jordi Boggiano
76cab7deb9 [Serializer] add methods to the SerializerInterface 2011-04-03 15:15:53 +02:00
Jordi Boggiano
cb727dbde3 [Serializer] Added docblock 2011-04-03 15:14:07 +02:00
Jordi Boggiano
424a1dad27 [Serializer] Switched most protected to private or final 2011-04-03 15:13:21 +02:00
Victor Berchet
788ed5126b [FrameworkBundle] Fix the cache template loader 2011-04-02 19:18:32 +02:00
Fabien Potencier
5d143c4aac Merge remote branch 'weaverryan/prevent_exception_on_handle_exception'
* weaverryan/prevent_exception_on_handle_exception:
  [HttpKernel] Wrapping the end of handleException() in a try-catch to prevent response listeners from throwing another exception
2011-04-02 18:40:34 +02:00
Fabien Potencier
53274512e2 Merge remote branch 'weaverryan/better_import_exception_and_bug_fix'
* weaverryan/better_import_exception_and_bug_fix:
  [Config] Improving the exception when a resource cannot be imported
  [DependencyInjection] Fixing a bug where "ignore_errors" doesn't work in YAML and XML
2011-04-02 18:37:51 +02:00
Bernhard Schussek
72a41f8c94 [Form] Fixed: Booleans can be used as choice keys now 2011-04-02 18:26:28 +02:00
Bernhard Schussek
a5d0b3aea6 [Form] Changed FormBuilder::set(Client|Norm)Transformer to FormBuilder::prepend(Client|Norm)Transformer and FormBuilder::append(Client|Norm)Transformer to facilitate extension of types 2011-04-02 16:39:19 +02:00
Bernhard Schussek
be9ef42af9 [Form] Renamed choice transformers for better clarity 2011-04-02 16:11:20 +02:00
Bernhard Schussek
fc59936740 [Form] Fixed: ThemeRenderer::isChoiceSelected() works correctly for boolean choices 2011-04-02 16:00:46 +02:00
Bernhard Schussek
a4bbc40ac6 [Form] Cleaned up ChoiceListInterface 2011-04-02 15:41:43 +02:00
Bernhard Schussek
d3b7c4e8c1 [Form] Moved getLabel(), isChoiceSelected() and isChoiceGroup() from ChoiceListInterface to ThemeRenderer 2011-04-02 14:14:18 +02:00
Bernhard Schussek
94f2baa895 [Form] Fixed BooleanToStringTransformer::reverseTransform() to accept NULL values. Fixes ChoiceTypeTest 2011-04-02 13:00:19 +02:00
Bernhard Schussek
37e8e1270c [Form][FrameworkBundle][TwigBundle] Renamed view variable 'disabled' to 'read_only' to match with the according FormInterface methods 2011-04-02 12:18:43 +02:00
Bernhard Schussek
39b0aafc00 Merge remote branch 'symfony/master' into experimental
Conflicts:
	src/Symfony/Bundle/DoctrineBundle/Resources/config/orm.xml
2011-04-02 12:08:27 +02:00
Bernhard Schussek
35d9b7f800 [Form] Improved test coverage of Form. The emptyValue closure now receives the Form instance to use form data when constructing new objects 2011-04-02 12:00:19 +02:00
Bernhard Schussek
4f39234741 [Form] bind() is ignored if a form is read-only 2011-04-02 11:39:15 +02:00
Bernhard Schussek
ca20aef379 [Form] Improved test coverage of DelegatingValidator and fixed validation group inheritance 2011-04-02 11:35:58 +02:00
Bernhard Schussek
33b0011f86 [Form] Improved test coverage of Form 2011-04-02 11:22:29 +02:00
Fabien Potencier
1d4024c654 [Process] added some missing accessors/mutators 2011-04-02 10:08:01 +02:00
michaelwilliams
46b711c4a8 Update PDO session storage to check if any rows are updated when doing a session write. If no rows are udpated when performing a session write it generally means that we have created a new session id somewhere and we have not inserted into the database. This is the case for when calling regenerate_session_id() from the native session storage class. It will update the session id then call sessionWrite() to save the session but since the new session id does not exist in the DB, no rows are updated and any new session attributes such as security tokens are lost.
See http://www.php.net/manual/en/function.session-set-save-handler.php#103055 for more details
2011-04-01 18:14:27 -07:00
Ryan Weaver
b9883a3bad [Config] Improving the exception when a resource cannot be imported
This improves, for example, the exception one would receive if they tried to import a resource from a bundle that doesn't exist.
Previously, the deep "bundle is not activated" exception would be thrown. That has value, however there is no indication of where
the exception is actually occurring.

In this new implementation, we throw an exception that explains exactly which resource, and from which source resource, cannot be
loaded. The deeper exception is still thrown as a nested exception.

Two caveats:

  * The `HttpKernel::varToString` method was replicated
  * This introduces a new `Exception` class, which allows us to prevent lot's of exceptions from nesting into each other in the case
    that some deeply imported resource cannot be imported (each upstream import that fails doesn't add its own exception).
2011-04-01 18:59:54 -05:00
Ryan Weaver
65ac5ec7c0 [DependencyInjection] Fixing a bug where "ignore_errors" doesn't work in YAML and XML
Tests added, the arguments were simply mismatched.
2011-04-01 18:59:45 -05:00
Ryan Weaver
083b25b68c [HttpKernel] Wrapping the end of handleException() in a try-catch to prevent response listeners from throwing another exception 2011-04-01 18:01:36 -05:00
Fabien Potencier
54655104ca [Process] changed run() behavior to always populate getOutput() and getErrorOutput() 2011-04-01 18:08:54 +02:00
Fabien Potencier
10297d4eb5 Merge remote branch 'hason/frameworkbundle'
* hason/frameworkbundle:
  [HttpKernel] removed unused class
  [FrameworkBundle] fixed bugs
  [FrameworkBundle] fixed test on windows
  [FrameworkBundle] fixed CS
2011-04-01 15:45:13 +02:00
Kris Wallsmith
daccbf45bf [Routing] updated for DirectoryResource changes 2011-04-01 04:57:10 -07:00
Kris Wallsmith
c51b716180 [Config] simplified DirectoryResource to only allow one regex 2011-04-01 04:56:50 -07:00
Martin Hason
e43b53fea3 [HttpKernel] removed unused class 2011-04-01 10:50:12 +02:00
Fabien Potencier
a9160eee70 [Validator] made fields the default option for Collection constraint 2011-03-31 15:36:04 +02:00
Bernhard Schussek
c864d7fae1 [Form] Improved test coverage of Form class 2011-03-31 15:23:33 +02:00
Fabien Potencier
16a98cf104 [Validator] added a Metadata factory that can be used with ValidatorInterface::validateValue() 2011-03-31 15:05:18 +02:00
Lukas Kahwe Smith
ab93d40855 added default implementation for getNamespace() 2011-03-31 14:21:44 +02:00
Martin Hason
e21591e16e [Validator] fixed CS 2011-03-31 14:02:00 +02:00
Bernhard Schussek
1ef18360fa [Form] Made name immutable in FormBuilder to avoid synchronization problems with name and property path 2011-03-31 13:48:06 +02:00
Bernhard Schussek
bbeddf7789 Merge remote branch 'symfony/master' into experimental 2011-03-31 12:32:20 +02:00
Fabien Potencier
30f26ed091 [Form] changed DefaultFormFactory to be more 'useable' 2011-03-31 07:35:43 +02:00
Fabien Potencier
c7ccb6643b [Form] removed unused constructor argument from Type\FieldType (themeFactory and template) 2011-03-31 07:34:04 +02:00
Fabien Potencier
a1fc882fad [Form] fixed DefaultFormFactory 2011-03-30 23:38:40 +02:00
Fabien Potencier
8a7fa722ac [Validator] fixed property name 2011-03-30 23:23:26 +02:00
Fabien Potencier
07838c9612 [FrameworkBundle] removed the possibility to change the method name for validation static method loader (as it would break third-party bundles) 2011-03-30 23:21:17 +02:00
Fabien Potencier
f92055ce42 [Validator] renamed methods that do not follow CS
requiredOptions -> getRequiredOptions
targets -> getTargets
defaultOption -> getDefaultOption
2011-03-30 23:18:20 +02:00
Fabien Potencier
525702b5c6 [Validator] renamed method to follow CS 2011-03-30 23:10:30 +02:00
Fabien Potencier
702e6587ad Merge remote branch 'pborreli/windows-fix-mimetype'
* pborreli/windows-fix-mimetype:
  [HttpFoundation][Windows] Fixed filebinary guesser method.
2011-03-30 19:52:56 +02:00
Pascal Borreli
44a6f84855 [HttpFoundation][Windows] Fixed filebinary guesser method. 2011-03-30 17:38:42 +00:00
Fabien Potencier
f77b94074f [HttpFoundation] replaced the option argument of Session by defaultLocale 2011-03-30 17:26:13 +02:00
Bernhard Schussek
60f04860c9 Merge remote branch 'symfony/master' into experimental 2011-03-30 15:40:21 +02:00
Fabien Potencier
80c2944c6e [ClassLoader] removed ClassLoaderInterface
As the autoloader cannot autoload the interface, it makes things more complicated
for a very small benefit.
2011-03-30 11:17:34 +02:00
Bernhard Schussek
55c14680d3 Merge remote branch 'symfony/master' into experimental 2011-03-30 10:31:21 +02:00
Mark Challoner
1adbb763cb [Validator] Updated ContraintViolationList ArrayAccess setter to check equivalence to null instead of using is_null 2011-03-30 08:43:05 +01:00
Fabien Potencier
eded17adf2 [ClassLoader] added ClassLoaderInterface 2011-03-30 08:24:33 +02:00
Fabien Potencier
1ec2886546 [Console] fixed previous commit 2011-03-29 22:03:29 +02:00
Fabien Potencier
49d67645d7 [Console] moved Output constants to OutputInterface 2011-03-29 21:53:28 +02:00
Pascal Borreli
dbb18662d7 [HttpFoundation][Windows] Disabled FileBinaryMimeTypeGuesser for Windows OS 2011-03-29 14:32:20 +00:00
Johannes Schmitt
c3ab11f9db removed exit calls 2011-03-29 01:06:04 +02:00
Bernhard Schussek
53838abf3f Merge remote branch 'symfony/master' into experimental
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/money_field.html.php
	src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/percent_field.html.php
	src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-28 22:52:15 +02:00
Fabien Potencier
52c3a1d53d fixed typo 2011-03-28 22:48:18 +02:00
Fabien Potencier
3d44c44f9a Merge remote branch 'mbontemps/httpCache-fix'
* mbontemps/httpCache-fix:
  Add a public getter for the Esi instance
  Fix kernel access in HttpCache due to kernel attribute privatization
2011-03-28 19:50:12 +02:00
Fabien Potencier
49063a5314 Merge remote branch 'kriswallsmith/kernel/shorter-bundle-names'
* kriswallsmith/kernel/shorter-bundle-names:
  updated codebase to use shorter bundle names
  [HttpKernel] updated component to work with shorter bundle names
  [HttpKernel] updated Bundle::getName() to validate bundle class name and rtrim "Bundle"
2011-03-28 18:06:41 +02:00
Bernhard Schussek
e2198b0dc6 [Form] Fixed a few references to AssertTrue/AssertFalse 2011-03-28 17:45:11 +02:00
Fabien Potencier
786f165dae Merge remote branch 'bschussek/validator'
* bschussek/validator:
  removed Assert prefix from all constraints, renamed annotation namespace to assert
2011-03-28 17:05:22 +02:00
Mark Challoner
77ae8b5898 Implemented ArrayAccess interface 2011-03-28 13:54:37 +01:00
Matthieu Bontemps
8e4686787a Add a public getter for the Esi instance 2011-03-28 13:45:23 +02:00
Matthieu Bontemps
aba6363452 Fix kernel access in HttpCache due to kernel attribute privatization 2011-03-28 11:58:16 +02:00
Bernhard Schussek
e7df781c34 [Form] Fixed calls to ThemeRenderer::renderPart() 2011-03-28 11:22:27 +02:00
Bernhard Schussek
0fb95c18ad Merge remote branch 'symfony/master' into experimental 2011-03-27 23:44:04 +02:00
Bernhard Schussek
65f58c9fd1 [Form] Introduced generic RendererInterface 2011-03-27 23:43:14 +02:00
Bernhard Schussek
1fa004ceb2 [Form] Simplified the interface names of the Renderer subnamespace 2011-03-27 23:39:01 +02:00
Bernhard Schussek
4ec6ba8674 [Form] Fixed: set data is treated as string except if a transformer is set 2011-03-27 23:09:46 +02:00
Bernhard Schussek
cfaa03eeec [Form] Fixed: empty objects are only created upon binding forms with empty data 2011-03-27 23:07:30 +02:00
Fabien Potencier
33456e63dc Merge remote branch 'pborreli/windows-fix-process'
* pborreli/windows-fix-process:
  [Process] Better guess of php bin executable path
  [Process] Removed useless getenv
2011-03-27 22:28:26 +02:00
Pascal Borreli
ef447dc487 [Process] Better guess of php bin executable path
If PHP_PATH is not defined (default)
PHP_BINDIR is used to guess exe, but on windows this constant seems to be hardcoded and doesn't point to the good folder
So before to throw an error we check if PEAR is installed, most of the case it is, and it will have good php bin path for sure.
2011-03-27 21:11:22 +00:00
Pascal Borreli
1e69076d7a [Process] Removed useless getenv 2011-03-27 21:11:20 +00:00
Bernhard Schussek
7006202e24 Merge remote branch 'symfony/master' into experimental 2011-03-27 21:07:13 +02:00
Matthieu Bontemps
a294024184 Fix Filesystem->mkdir return value 2011-03-27 19:17:13 +02:00
Bernhard Schussek
8a981dd047 [Form] Removed unused variable 2011-03-27 17:37:42 +02:00
Bernhard Schussek
58b8555cb6 [Form] Removed unused use-statements 2011-03-27 15:59:35 +02:00
Bernhard Schussek
edfae73cd4 [Form] Moved PropertyPath, PropertyPathIterator and VirtualFormAwareIterator to subnamespace Util 2011-03-27 15:37:13 +02:00
Bernhard Schussek
29d412c15a [Form] Changed name of VirtualFormIterator to VirtualFormAwareIterator 2011-03-27 15:33:04 +02:00
Kris Wallsmith
a8ffa909ad [HttpKernel] updated component to work with shorter bundle names 2011-03-27 06:25:13 -07:00
Bernhard Schussek
b180319371 [Form] Moved creation of empty data to Form to clean up DataMapperInterface 2011-03-27 15:12:35 +02:00
Bernhard Schussek
5ac979b043 [Form] Fixed default value of 'validation_groups' option, removed duplicate definition 2011-03-27 14:52:03 +02:00
Bernhard Schussek
80116be577 [Form] Removed unused 'template' option 2011-03-27 14:42:44 +02:00
Bernhard Schussek
6588a47ba7 [Form] Removed FormBuilder::setDataClass(). Use the FieldType option "data_class" instead.
The problem was that "data_class" was used in two places: FormBuilder::build() and PropertyPathMapper.

PropertyPathMapper was already constructed during FormType::buildForm(), so any data class changes made to the FormBuilder wouldn't affect the data class of the PropertyPathMapper anymore and so lead to an inconsistent state.
2011-03-27 14:34:48 +02:00
Kris Wallsmith
dd9ad97a0c [HttpKernel] updated Bundle::getName() to validate bundle class name and rtrim "Bundle" 2011-03-27 05:31:57 -07:00
Bernhard Schussek
364b0f5208 [Form] Fixed: FormBuilder::add() accepts FormTypeInterface instances 2011-03-27 14:05:06 +02:00
Bernhard Schussek
dc38eeffe3 [Form] Changed the default value of the 'property_path' option to NULL. Explicitely set it to '' or false to disable mapping for a field/form 2011-03-27 14:02:24 +02:00
Bernhard Schussek
67d85c6bc7 [Form] Fixed signature of FormThemeInterface::render() 2011-03-27 13:48:38 +02:00
Bernhard Schussek
b21929423e [Form] Completely removed the fields variable in the renderer. The renderer itself supports ArrayAccess and Traversable 2011-03-27 13:48:36 +02:00
Ryan Weaver
80c102761c [HttpKernel] Making the "no response returned from controller" more explanatory when it's possible that the user forgot a return statement in his/her controller
Also made "null" show up as null in the exception message, instead of as a blank string (slightly more expressive).
2011-03-26 14:35:55 -05:00
Bernhard Schussek
eaff9c641e [Form] Fixed: the default template is only set on the root renderer and reused by children 2011-03-26 19:39:31 +01:00
Bernhard Schussek
89361d036f [Form] Renamed FormType::configure() to FormType::buildForm() 2011-03-26 18:52:24 +01:00
Bernhard Schussek
a58cfab37d [Form] Removed form.type.loader tag and according compiler pass to simplify configuration. Custom types that are not in the DIC can be instantiated manually and passed wherever a type is desired. 2011-03-26 18:48:55 +01:00
Bernhard Schussek
9ff91dc997 Merge remote branch 'beberlei/FormsCollectionPrototype' into beberlei-merge 2011-03-26 18:39:20 +01:00
Bernhard Schussek
ed69d7fa35 [Form] Fixed rendering using the PHP Templating engine 2011-03-26 18:38:03 +01:00
Bernhard Schussek
fae319e77a [Form] Renderers are now created explicitely using FormFactory::createRenderer(). This improves performance on requests where a form does not need to be rendered 2011-03-26 16:03:34 +01:00
Bernhard Schussek
8c7a93c90c [Form] Added FormTypeInterface::buildRendererBottomUp() which is called after children are initialized 2011-03-26 16:03:34 +01:00
Bernhard Schussek
c786fac303 [Form] Sample fix implementation of renderers 2011-03-26 16:03:34 +01:00
Bernhard Schussek
a396f8fdc8 Merge remote branch 'symfony/master' into experimental 2011-03-26 16:03:21 +01:00
Johannes M. Schmitt
7887f04dc2 removed Assert prefix from all constraints, renamed annotation namespace to assert 2011-03-26 15:26:05 +01:00
Benjamin Eberlei
f9e2864030 [Form] Set prototype to true by default. 2011-03-26 14:56:59 +01:00
Benjamin Eberlei
d87651b6a2 [Form] Add option "prototype" defaulting to true. 2011-03-26 14:52:03 +01:00
Bernhard Schussek
41c3aea668 Merge remote branch 'beberlei/FormRendererItrator' into beberlei-merge 2011-03-26 13:43:33 +01:00
Fabien Potencier
bfd57c5cf0 [HttpKernel] fixed typo 2011-03-26 12:54:13 +01:00
Benjamin Eberlei
f882a511a0 [Form] Initialize on iterator access. 2011-03-26 12:28:46 +01:00
Benjamin Eberlei
cd1ce86aee [Form] Iterator support for ThemeRenderer 2011-03-26 12:25:47 +01:00
Fabien Potencier
7bda949e41 Merge remote branch 'schmittjoh/security'
* schmittjoh/security:
  changed condition nesting
  [Security] ACL: AclVoter::vote only gets an ObjectIdentity if $object is not an instance of ObjectIdentityInterface
  [SecurityBundle] fixed missing argument EventDisplatcher in RememberMe service
2011-03-26 10:44:37 +01:00
Fabien Potencier
4de468e181 [Routing] makes the parameters argument of generate() optional 2011-03-26 09:54:44 +01:00
Benjamin Eberlei
73d8470a76 [Form] Fix children implementation, setChildren() is not used, the attribute "fields" is. 2011-03-26 09:42:45 +01:00
Johannes Schmitt
031bf35bb1 changed condition nesting 2011-03-26 09:06:03 +01:00
Fabien Potencier
cc46e8d46a moved the Filesystem class form FrameworBundle to HttpKernel (refactored it slightly) 2011-03-26 08:37:25 +01:00
Johannes Schmitt
1282a595f2 Merge branch 'remember_me_dispatcher' of https://github.com/patashnik/symfony into security 2011-03-26 01:26:20 +01:00
Johannes Schmitt
db2089de0d Merge branch 'acl-fix' of https://github.com/comfortablynumb/symfony into security 2011-03-26 01:11:11 +01:00
Bernhard Schussek
18b98353d5 Merge branch 'master' into experimental
Conflicts:
	src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 16:07:19 +01:00
Fabien Potencier
8d84fdfedc [Finder] added Finder::append() method to be able to combine several Finder instances into one 2011-03-25 15:50:47 +01:00
Bernhard Schussek
7585dce8dd [Form] Added options validation to field creation 2011-03-25 15:30:33 +01:00
Fabien Potencier
2d27b13338 Merge remote branch 'bschussek/validator'
* bschussek/validator:
  [Form] Fixed validation.xml (now really)
2011-03-25 14:57:16 +01:00
Fabien Potencier
a2fcd0cf6b Merge remote branch 'stealth35/removed_alias'
* stealth35/removed_alias:
  sanitize die (exit)
2011-03-25 14:54:18 +01:00
stealth35
dedf9b4fc0 tab to spaces 2011-03-25 13:38:09 +01:00
stealth35
58cd03cedf use SplFileInfo insteed fgetcsv 2011-03-25 11:51:32 +01:00
Bernhard Schussek
0ace068a52 [Form] PropertyPathMapper now only maps if the form data is synchronized to avoid duplicate form errors ('invalid'+'NotNull', for example) 2011-03-25 11:27:22 +01:00
Bernhard Schussek
6825ea2489 [Form] Improved test coverage of PropertyPathMapper 2011-03-25 11:27:20 +01:00
stealth35
cee94be277 sanitize die (exit) 2011-03-25 11:26:43 +01:00
Bernhard Schussek
e3ac248617 [Form] Errors are mapped to subforms correctly and bubble up again if necessary 2011-03-25 10:53:36 +01:00
Bernhard Schussek
4f360109ed [Form] Fixed validation.xml (now really) 2011-03-25 10:41:18 +01:00
Bernhard Schussek
eb18676354 Merge branch 'master' into experimental 2011-03-25 09:24:38 +01:00
Fabien Potencier
0e57943531 [HttpKernel] fixed typo 2011-03-25 07:19:02 +01:00
Bernhard Schussek
7b412cc762 [Form] Removed FormFactory::addGuessers() and moved guessers to constructor arg instead 2011-03-25 02:26:14 +01:00
Bernhard Schussek
9b1b8cbffa [Form] Replaced various occurences of 'field' by 'form' 2011-03-25 02:12:01 +01:00
Bernhard Schussek
3c412ffba0 [Form] Moved Form::validateData() to DelegatingValidator::validateFormData() 2011-03-25 01:59:28 +01:00
Gustavo Adrian
bedbe51081 [Security] ACL: AclVoter::vote only gets an ObjectIdentity if $object is not an instance of ObjectIdentityInterface 2011-03-24 21:54:21 -03:00
Bernhard Schussek
ec38901572 Merge branch 'rename-execute' into experimental
Conflicts:
	src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 01:49:17 +01:00
Bernhard Schussek
71230a094b [Form] Fixed validation.xml 2011-03-25 01:46:05 +01:00
Bernhard Schussek
729438fdea Merge branch 'rename-execute' into experimental
Conflicts:
	src/Symfony/Component/Form/FileField.php
	src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 01:38:49 +01:00
Bernhard Schussek
3e29348d21 [Validator] Added support for static callbacks to Callback constraint 2011-03-25 01:36:58 +01:00
Bernhard Schussek
9c6a6e13bf [Validator] Renamed Execute constraint to Callback 2011-03-25 01:34:35 +01:00
Bernhard Schussek
4c43aa07ea [Form] Fixed: Elements are removed from collections when a 'collection' field is sized down 2011-03-25 01:15:33 +01:00
Bernhard Schussek
770d403a52 [Form] Improved error mapping in DelegatingValidator 2011-03-25 00:57:35 +01:00
Bernhard Schussek
d2b07058f4 [Form] CSRF token is now only validated for root form 2011-03-25 00:19:00 +01:00
Bernhard Schussek
4372bd5dc8 [Form] Fixed: Bubbling errors are caught correctly 2011-03-25 00:18:58 +01:00
Bernhard Schussek
d84d167b71 [Form] Fixed display of enctype for file fields in Twig theme 2011-03-25 00:16:30 +01:00
Bernhard Schussek
66ba0c3a73 [Form] Fixed: vars are initialized when ThemeRenderer::getVars() is accessed 2011-03-25 00:16:23 +01:00
Bernhard Schussek
262bdcb21d [Form] Fixed validation 2011-03-25 00:16:21 +01:00
Bernhard Schussek
ef334dbc4a Merge remote branch 'beberlei/AttributeSupport' into beberlei-merge 2011-03-24 22:53:39 +01:00
Bernhard Schussek
3f390aa271 [Form] Removed EntityType from DefaultTypeLoader 2011-03-24 22:50:39 +01:00
Benjamin Eberlei
ee96ad0e81 [Form] [DoctrineBridge] Move EntityType and DoctrineTypeLoader into Doctrine Bridge 2011-03-24 22:43:00 +01:00
Bernhard Schussek
1ff6906608 [Form] Simplified ArrayTypeLoader and used it as base class of DefaultTypeLoader 2011-03-24 22:30:49 +01:00
Benjamin Eberlei
8d6dd2b9af [Form] Add Arbitrary Attribute Support to Form Rendering. 2011-03-24 22:08:08 +01:00
Benjamin Eberlei
6bcc04905c [Form] Introduce ArrayTypeLoader, Remove EntityManager and FormFactory interface from DefaultTypeLoader 2011-03-24 20:00:17 +01:00
Bernhard Schussek
15d5259eb8 [Form] Forms now remember the types used during their construction 2011-03-24 16:16:31 +01:00
Bernhard Schussek
0b4c3c0cb8 [Form] Fixed coding conventions 2011-03-24 15:26:17 +01:00
Bernhard Schussek
2faa47d03b [Form] Added fallback templates to TwigThemeFactory 2011-03-24 15:11:43 +01:00
Bernhard Schussek
1211d77f49 [Form] Introduced renderer theme factories so that themes can be changed during runtime 2011-03-24 14:27:21 +01:00
Fabien Potencier
e232218eed [Console] fixed PHP notice 2011-03-24 13:30:27 +01:00
Alexey Popkov
7423f0bf50 [SecurityBundle] fixed missing argument EventDisplatcher in RememberMe service 2011-03-24 14:00:16 +03:00
Bernhard Schussek
5b41810b6d Revert "[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'"
This reverts commit 1efd680b68.
2011-03-24 10:55:12 +01:00
Bernhard Schussek
5078a63c74 Revert "[Form] Fixed more naming of themes and theme engines"
This reverts commit 1aa34b7240.
2011-03-24 10:54:47 +01:00
Fabien Potencier
0f231c33e5 [EventDispatcher] tagged the guaranteed BC API 2011-03-24 10:06:26 +01:00
Fabien Potencier
c60ee9fef1 [Finder] tagged the guaranteed BC API 2011-03-24 10:05:16 +01:00
Fabien Potencier
faf72269dd Merge remote branch 'aurelijus/filefield_original_name'
* aurelijus/filefield_original_name:
  get originalName before move call
2011-03-24 10:01:03 +01:00
Fabien Potencier
f5ab021386 Merge remote branch 'aurelijus/clear_name_for_goto'
* aurelijus/clear_name_for_goto:
  removes unwanted characters from goto name
2011-03-24 10:00:31 +01:00
Fabien Potencier
e515913747 [DomCrawler] tagged the guaranteed BC API 2011-03-24 10:00:10 +01:00
Fabien Potencier
9206af1773 [Console] tagged the guaranteed BC API 2011-03-24 09:39:53 +01:00
Aurelijus
2ee47f3c69 get originalName before move call 2011-03-24 10:39:42 +02:00
Fabien Potencier
ff3c66753f [BrowserKit] tagged the guaranteed BC API 2011-03-24 09:25:46 +01:00
Fabien Potencier
7280da8af2 [Process] fixed previous commit 2011-03-24 09:15:33 +01:00
Fabien Potencier
b2a8e35900 [Process] tagged the guaranteed BC API 2011-03-24 09:13:58 +01:00
Fabien Potencier
639d93cbbf [Process] moved protected to private 2011-03-24 09:10:42 +01:00
Fabien Potencier
34cf511a1d [Translation] tagged the guaranteed BC API 2011-03-24 09:07:52 +01:00
Aurelijus
38318f8f80 removes unwanted characters from goto name 2011-03-24 10:03:59 +02:00
Fabien Potencier
e0469d398d [Yaml] tagged the guaranteed BC API 2011-03-24 09:02:09 +01:00
Fabien Potencier
8ab59f82db [CssSelector] tagged thlassLoader]d BC API 2011-03-24 08:44:53 +01:00
Fabien Potencier
f58654c6fd [CssSelector] tagged the guaranteed BC API 2011-03-24 08:40:47 +01:00
Fabien Potencier
eeca46dea0 [CssSelector] moved protected to private 2011-03-24 08:34:52 +01:00
Bernhard Schussek
9b6722222f [Form] Improved internal structore of PropertyPathMapper 2011-03-24 00:15:59 +01:00
Bernhard Schussek
1aa34b7240 [Form] Fixed more naming of themes and theme engines 2011-03-23 22:51:37 +01:00
Bernhard Schussek
1efd680b68 [Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes' 2011-03-23 22:34:58 +01:00
Fabien Potencier
06d00f36ba Merge remote branch 'kriswallsmith/framework/protocol-relative-base-urls'
* kriswallsmith/framework/protocol-relative-base-urls:
  [Templating] updated assets helper to leave protocol-relative URLs untouched
  [FrameworkBundle] cleaned up test class
2011-03-23 22:03:48 +01:00
Bernhard Schussek
f71ae03143 [Form] AbstractType::getParent() returns 'form' by default now 2011-03-23 21:51:50 +01:00
Fabien Potencier
1fb08b6445 [Routing] fixed private method 2011-03-23 21:40:54 +01:00
Fabien Potencier
a6e6cbbb27 [HttpFoundation] removed the hardcoded ^ and $ from the RequestMatcher 2011-03-23 21:27:04 +01:00
Bernhard Schussek
c01419d856 Merge remote branch 'johnwards/renderer_tests' into renderer-tests-merge 2011-03-23 21:13:36 +01:00
Kris Wallsmith
55671be888 [Templating] updated assets helper to leave protocol-relative URLs untouched 2011-03-23 13:02:49 -07:00
Fabien Potencier
1b8dc80215 [HttpKernel] moved from protected to private 2011-03-23 19:47:16 +01:00
Fabien Potencier
e4a3e0c2c7 [Config] moved from protected to private (WIP) 2011-03-23 19:34:00 +01:00
Fabien Potencier
b5857528e0 [Routing] moved protected to private 2011-03-23 19:25:56 +01:00
Bernhard Schussek
9839aafb7d Merge remote branch 'symfony/master' into experimental 2011-03-23 19:18:38 +01:00
Bernhard Schussek
08a09240f6 [Form] Fixed order of input and output timezone to a more natural one 2011-03-23 17:12:04 +01:00
Bernhard Schussek
a880f8d0d1 [Form] Fixed coding conventions 2011-03-23 16:14:53 +01:00
Fabien Potencier
662a4b3740 removed the status message from HttpException, changed the signature so that most useful arguments are first, fixed many small problems introduced with previous HTTP exception refactoring
Quote from HTTP (bis) spec (Part 2 - 5.1.1):

The Reason Phrase exists for the
sole purpose of providing a textual description associated with the
numeric status code, out of deference to earlier Internet application
protocols that were more frequently used with interactive text
clients.  A client SHOULD ignore the content of the Reason Phrase.
2011-03-23 16:11:54 +01:00
Bernhard Schussek
9e025440ca Merge remote branch 'johnwards/configuration' into configurable-merge 2011-03-23 16:05:16 +01:00
Fabien Potencier
abb99e9469 [HttpKernel] changed the abstract BaseHttpException to HttpException to allow the creation of any HTTP exception 2011-03-23 11:12:31 +01:00
Christophe Coevoet
cc036b4f2b [Security] Removed useless method call 2011-03-23 00:02:57 +01:00
Christophe Coevoet
8b8bb66afe [Security] Fixed some listeners not updated after the event refactoring 2011-03-22 23:56:46 +01:00
John Wards
85701b65af [Form] Missing methods from interfaces 2011-03-22 22:20:14 +00:00
John Wards
1a014d130e [Form] Tests for Renderer Plugins 2011-03-22 22:19:51 +00:00
John Wards
37f12f68da [Form] The declaration and initialization (constructor) of the variables should be in the same class. 2011-03-22 20:54:15 +00:00
Fabien Potencier
e159c47cc9 [Routing] fixed UrlMatcher when no method requirement is defined 2011-03-22 20:56:55 +01:00
Fabien Potencier
af9c292001 Merge remote branch 'subsven/master'
* subsven/master:
  re-add filename based directory filter to the AnnotationDirectoryLoader, now restricting to *.php files and therefore disregarding e.g. SVN metadata files
  revert adding filename based filter to the directory resource
  Eleminate the need to manually clear the cache if a new controller file containing routing annotations is added - part II * add unit tests * introduce filename filter to DirectoryResource (to restrict change monitoring to a subset of files) * modify AnnotationDirectoryLoader.php to use filename filter set on Controller\.php$
2011-03-22 19:52:55 +01:00
Fabien Potencier
68011c0dd6 [DependenInjection] fixed CS 2011-03-22 19:47:46 +01:00
Fabien Potencier
3c0ecf277e Merge remote branch 'jaypea/PhpDumperFix'
* jaypea/PhpDumperFix:
  Fixed PhpDumper isSimpleService and changed test fixtures
2011-03-22 19:46:58 +01:00
Sven Paulus
eb8491f754 re-add filename based directory filter to the AnnotationDirectoryLoader,
now restricting to *.php files and therefore disregarding e.g. SVN metadata
files
2011-03-22 18:23:54 +01:00
Jan Prieser
67aaf5ce91 Fixed PhpDumper isSimpleService and changed test fixtures 2011-03-22 17:01:03 +01:00
John Wards
e54973b5d4 [Form] Refactoring Types to use new DataTransfomer interface 2011-03-22 15:40:52 +00:00
Fabien Potencier
1991437766 Merge remote branch 'kriswallsmith/router/method-not-allowed' 2011-03-22 16:40:41 +01:00
Bernhard Schussek
ea0e5bb2d6 [Form] Renamed FieldTypeInterface to FormTypeInterface 2011-03-22 12:36:41 +01:00
Bernhard Schussek
270a98e413 [Form] Added support for types that are not registered in the DIC. These are identified by their FQ class name. 2011-03-22 12:33:15 +01:00
Sven Paulus
61974adb4f revert adding filename based filter to the directory resource 2011-03-22 12:14:12 +01:00
Sven Paulus
f93e4b2d73 Eleminate the need to manually clear the cache if a new controller file containing routing annotations is added - part II
* add unit tests
* introduce filename filter to DirectoryResource (to restrict change monitoring to a subset of files)
* modify AnnotationDirectoryLoader.php to use filename filter set on Controller\.php$
2011-03-22 09:03:45 +01:00
John Wards
5a5fdd0529 Merge remote branch 'bernhard/experimental' into configuration 2011-03-22 07:43:47 +00:00
Bernhard Schussek
33692eae4a [Form] Renamed Form::isTransformationSuccessful() to isSynchronized(). This method now indicates whether the data in the different representations is synchronized. Moved 'invalid' error to DefaultValidator 2011-03-22 02:03:22 +01:00
Bernhard Schussek
09da126464 [Form] Fixed validation.xml 2011-03-22 01:45:40 +01:00
Bernhard Schussek
16d65f6f16 [Form] Moved previously skipped tests from FormTypeTest to FormTest and fixed them 2011-03-22 01:40:02 +01:00
Bernhard Schussek
577e106361 [Form] Implemented custom mapping of data errors to form fields 2011-03-22 01:15:48 +01:00
John Wards
b4406f254d [Form] Removing Configurable from DataTransformers 2011-03-21 23:01:10 +00:00
John Wards
7d7c36a178 [Form] More sensible constructor variable order 2011-03-21 21:42:34 +00:00
Bernhard Schussek
87665bc380 [Form] Decoupled FormBuilder from CSRF protection 2011-03-21 22:41:19 +01:00
John Wards
714f2173be [Form] Coding conventions and use of the new variables 2011-03-21 21:39:59 +00:00
John Wards
3c80bc37df [Form] Removing use of old class 2011-03-21 21:20:57 +00:00
John Wards
d8287a6dff Merge remote branch 'bernhard/experimental' into experimental 2011-03-21 21:18:04 +00:00
John Wards
002a22df04 [Form] Refactoring DateTimeToStringTranformer not to use Configuration 2011-03-21 21:16:20 +00:00
Bernhard Schussek
c1abf08d9c [Form] Implemented error bubbling 2011-03-21 22:13:02 +01:00
Bernhard Schussek
255eda5238 [Form] Renamed RecursiveFieldIterator to RecursiveFormIterator 2011-03-21 21:19:36 +01:00
Bernhard Schussek
3985522b9b [Form] Removed obsolete classes Error and DataError 2011-03-21 21:19:31 +01:00
Bernhard Schussek
01a47457d0 [Form] Improved naming of various interfaces. Renamed DefaultRenderer to ThemeRenderer 2011-03-21 20:57:38 +01:00
Bernhard Schussek
321d40b21a [Form] Decoupled FormBuilder from ThemeInterface 2011-03-21 20:46:43 +01:00
Bernhard Schussek
61804bbd8b Merge remote branch 'symfony/master' into experimental 2011-03-21 20:27:39 +01:00
Fabien Potencier
6ace6af537 Merge remote branch 'mvrhov/variousFixes' 2011-03-21 16:57:34 +01:00
Kris Wallsmith
10dc18b28b [HttpKernel] refactored HTTP exceptions to be more flexible 2011-03-21 05:57:35 -07:00
Kris Wallsmith
b2f5ac8beb [Routing] refactored URL matching to support 405 Method Not Allowed responses 2011-03-21 05:56:53 -07:00
Johannes M. Schmitt
eb0d772743 [Security/Acl] removed remaining LIMIT clauses 2011-03-21 11:39:05 +01:00
Miha Vrhovnik
25e4193294 removed unused variable 2011-03-21 11:34:06 +01:00
Miha Vrhovnik
496280329b changing phpdoc parameter to array as all variables are used in foreach 2011-03-21 11:28:38 +01:00
Miha Vrhovnik
33dd0da420 removed unused variables 2011-03-21 11:22:29 +01:00
Miha Vrhovnik
909a6bfc30 $user* was refactored to $accout* 2011-03-21 11:20:21 +01:00
Fabien Potencier
e4a636a885 [FrameworkBundle] refactored the cache:clear command
* removed the hack on the Kernel
* removed inheritance from the warmup command
* major cleanup
2011-03-21 11:03:55 +01:00
Miha Vrhovnik
fb814c666b removed unused and undefined namespace and use statement 2011-03-21 10:45:34 +01:00
Miha Vrhovnik
a491af873b removed unecessary use statements (ExceptionEvent was also undefined namespace) 2011-03-21 10:41:39 +01:00
Miha Vrhovnik
d1a2681531 fixing undefined class RuntimeException 2011-03-21 10:37:49 +01:00
Miha Vrhovnik
031ffaee6b fixing undefined class UnsetKeyException 2011-03-21 10:33:27 +01:00
Fabien Potencier
82a5ae669e [FrameworkBundle] fixed merge problem 2011-03-21 09:43:41 +01:00
Fabien Potencier
45f9c2fbf4 merged francisbesset:cache_clear_command 2011-03-21 09:24:16 +01:00
Johannes M. Schmitt
ede59926a4 Merge branch 'interactive-login-event' of git://github.com/yethee/symfony into security 2011-03-21 09:18:55 +01:00
Bernhard Schussek
acaa9c9058 [Form] Fixed signature of Form::addError() 2011-03-20 15:23:36 +01:00
Bernhard Schussek
6c9ff0a2a3 [Form] Improved naming of data conversion methods in Form and made them private 2011-03-20 15:22:37 +01:00
Bernhard Schussek
119866e06d [Form] Renamed FormBuilder::getInstance() to getForm() 2011-03-20 15:17:25 +01:00
Bernhard Schussek
2dbb41714a [Form] Merged Field and Form. Merged FieldBuilder and FormBuilder. After the refactoring, the distinction between the two concepts is small enough to merge them 2011-03-20 13:35:19 +01:00
Bernhard Schussek
fc7281bcab [Form] Extracted validation logic of form. Fields can now contain multiple validators 2011-03-20 12:00:19 +01:00
Bernhard Schussek
cb599f417e [Form] Renamed field option 'disabled' to 'read_only'. How to render read-only fields is now the responsibility of the renderer 2011-03-20 10:35:16 +01:00
Bernhard Schussek
b5656f1290 [Form] Renamed ObjectMapper to PropertyPathMapper 2011-03-20 10:29:23 +01:00
Bernhard Schussek
295d01745b [Form] Renamed StripTagsFilter to StripTagsListener until we have better conventions 2011-03-20 10:26:38 +01:00
Bernhard Schussek
2c6c89d898 Merge remote branch 'beberlei/forms' into beberlei-merge 2011-03-20 10:15:59 +01:00
Benjamin Eberlei
b43318ee3e [Form] Add tests for untested classes. 2011-03-19 22:03:49 +01:00
Benjamin Eberlei
d62213662e Merge branch 'experimental' of git://github.com/bschussek/symfony into forms 2011-03-19 20:36:56 +01:00
Benjamin Eberlei
864a3ec45f [Form] Add StripTagsFilter EventListener 2011-03-19 20:36:49 +01:00
Bernhard Schussek
a1c3d21d0e [Form] Added comment 2011-03-19 19:56:18 +01:00
Bernhard Schussek
e9cb19721a [Form] Optimized code in Form to remove one event listener 2011-03-19 19:53:39 +01:00
Bernhard Schussek
fb2db58801 [Form] Added fluid interface for inline adding of sub-builders to a builder 2011-03-19 19:44:45 +01:00
Bernhard Schussek
6793bcd698 [Form] Removed magic from method signature of add() 2011-03-19 19:20:55 +01:00
Bernhard Schussek
c4b7a77ece Merge remote branch 'beberlei/forms' into beberlei-merge
Conflicts:
	src/Symfony/Component/Form/Type/Loader/DefaultTypeLoader.php
2011-03-19 19:01:57 +01:00
Bernhard Schussek
3586268bc2 [Form] Renamed field types. They are now always the name of the type with a 'Type' suffix 2011-03-19 18:31:24 +01:00
Bernhard Schussek
65353bd81e [Form] Fixed failing choice field tests 2011-03-19 18:22:08 +01:00
Benjamin Eberlei
c05b3c440d [Form] Add DefaultFormFactory for convenience usage outside of a DIC context. 2011-03-19 18:14:15 +01:00
Benjamin Eberlei
39c2d3f166 [Form] Add PhpTheme that relies on no Template Engine, generalize tests to use for PhpTheme and PhpEngineTheme. Fixed some bugs 2011-03-19 17:47:18 +01:00
Fabien Potencier
a505ff43b5 [Routing] added supported for multiple route annotations for a single controller 2011-03-19 17:40:24 +01:00
Bernhard Schussek
43a24fa931 [Form] Renamed events to match terminology in Field 2011-03-19 16:59:23 +01:00
Bernhard Schussek
0259d4da1e [Form] Moved namespace DataValidator to Validator 2011-03-19 16:54:07 +01:00
Bernhard Schussek
7f9284105d [Form] Moved namespace FieldGuesser to Type\Guesser 2011-03-19 16:46:03 +01:00
Benjamin Eberlei
af60ddf8ad Moved PhpTheme to FrameworkBundle and renamed to PhpEngineTheme 2011-03-19 15:27:39 +01:00
Benjamin Eberlei
32e1a7c8f9 Merge bschussek/experimental into branch forms. 2011-03-19 15:18:52 +01:00
Bernhard Schussek
d2210a2e79 [Form] Removed unused Form::isCsrfTokenValid() 2011-03-19 15:09:11 +01:00
Bernhard Schussek
3e17b26105 [Form] Moved CSRF protection into separate field 2011-03-19 15:06:54 +01:00
Benjamin Eberlei
3e2b8e5f12 Fix some missing use statements and small bugs. 2011-03-19 14:31:25 +01:00
Bernhard Schussek
89215d167d Merge remote branch 'symfony/master' into experimental 2011-03-19 13:25:41 +01:00
Miha Vrhovnik
e35832ef2d Fixing failure on forward which was broken by Event refactoring 2011-03-19 13:06:52 +01:00
Amal Raghav
eff6bc8a80 fix to use setException 2011-03-19 17:08:34 +05:30
Fabien Potencier
904cf6145e Merge remote branch 'everzet/routing-config-errors' 2011-03-19 12:27:38 +01:00
everzet
e4eee05b06 [Routing] tuned exception message 2011-03-19 12:58:31 +02:00
Benjamin Eberlei
bb8c2a9b9d Rename this to renderer to be able to use it in Php Templating 2011-03-19 11:54:46 +01:00
everzet
3fd50ea4e6 [Routing] throw an exception if route config has unsupported keys 2011-03-19 12:54:29 +02:00
Benjamin Eberlei
d44e2264ba Merge branch 'experimental' of git://github.com/bschussek/symfony into forms 2011-03-19 09:36:30 +01:00
ornicar
7440db7244 [HttpFoundation] Make sure Request::getLanguages always returns an array 2011-03-19 01:34:54 -07:00
Deni
5e40695272 [Security] Added a type hint. 2011-03-19 01:32:33 +03:00
Fabien Potencier
cdfc731ff5 Merge remote branch 'schmittjoh/security' 2011-03-18 21:07:11 +01:00
Fabien Potencier
f990bf96ee Merge remote branch 'ornicar/removeNamespaceInSwitchUserListener' 2011-03-18 20:57:48 +01:00
ornicar
5e75c66a66 [Security] Remove duplicated namespace in SwitchUserListener 2011-03-18 12:30:09 -07:00
Johannes Schmitt
7e1c4d5748 [Security] removed un-needed event parameter from many interfaces 2011-03-18 20:20:19 +01:00
Fabien Potencier
5658d224fd Merge remote branch 'hhamon/security_token_fix' 2011-03-18 19:32:28 +01:00
Fabien Potencier
263c32aff0 Merge remote branch 'schmittjoh/security' 2011-03-18 19:31:57 +01:00
Fabien Potencier
b7806cdb8d Merge remote branch 'kriswallsmith/http/html-errors' 2011-03-18 19:20:16 +01:00
Kris Wallsmith
73db141ce6 [HttpFoundation] stripped tags from native error messages in case html_errors is on 2011-03-18 11:11:42 -07:00
Fabien Potencier
bd8d2b829f [EventDispatcher] changed listener storage to use SplObjectStorage to avoid collisions 2011-03-18 18:48:26 +01:00
hhamon
681a3b7ff0 [Security] removed import of the UserInterface interface as it is unused in the file and fix some phpdoc. 2011-03-18 18:44:04 +01:00
Johannes Schmitt
a56dbec6d8 [Security] removed un-needed event parameter from many interfaces 2011-03-18 18:26:55 +01:00
Kris Wallsmith
e596931dc8 [DomCrawler] enabled removal of form fields to allow emulating javascript in a functional test 2011-03-18 09:39:08 -07:00
Bernhard Schussek
b66b8326a8 [Form] Fixed undefined variable in DefaultRenderer 2011-03-18 17:03:12 +01:00
Bernhard Schussek
6bc79a1a12 [Form] Renamed different kinds of data transformers within a field for better clarity 2011-03-18 16:59:34 +01:00
Bernhard Schussek
1c85daa56b [Form] Split FieldBuilder into FieldBuilder and FormBuilder to make creation of classes deterministic 2011-03-18 16:34:54 +01:00
Bernhard Schussek
2a1e394352 [Form] Renamed field configs to types. Everywhere else, we are referring to the name of the type as 'type' now (was 'identifier') 2011-03-18 16:20:00 +01:00
Bernhard Schussek
0b929ee342 [Form] Renamed ValueTransformers to DataTransformers to fit with DataMapper and DataValidator 2011-03-18 16:01:06 +01:00
Bernhard Schussek
f86ecec403 [Form] Extracted data validation logic into DataValidatorInterface 2011-03-18 15:58:22 +01:00
Bernhard Schussek
97d0183d84 [Form] Moved properties propertyPath, modifyByReference, validationGroups and virtual to generic attributes because they are specific to the used data validator/mapper implementations 2011-03-18 15:26:02 +01:00
Bernhard Schussek
700c96e7fa [Form] Moved FieldFactoryTest to FormFactoryTest and fixed it 2011-03-18 14:37:54 +01:00
Bernhard Schussek
4cb76c0045 [Form] Moved error distribution logic to validation listener 2011-03-18 13:07:06 +01:00
Bernhard Schussek
9caaf0f3a3 [Form] Introduced FieldBuilder for field/form creation and made Field/Form mostly immutable 2011-03-18 12:50:26 +01:00
Fabien Potencier
f0c558592c Merge remote branch 'everzet/console-formatter-refactoring' 2011-03-18 11:58:05 +01:00
Fabien Potencier
c5a6c8432f Merge remote branch 'vicb/templating' 2011-03-18 11:54:20 +01:00
Fabien Potencier
3627eee3c6 Merge remote branch 'vicb/cfg_rebase'
* vicb/cfg_rebase:
  [Config] Ability to add and override node types without having to subclass NodeBuilder
  [DoctrineBundle] Fix some typos
  [SwiftMailerBundle] Fix a merge issue in the configuration
  Tweak PHPDocs in the extension configuration files
  [Config] Component refactoring
2011-03-18 11:41:43 +01:00
Victor Berchet
cead49fa2b [Kernel] Fixed a typo 2011-03-18 11:17:56 +01:00
Bernhard Schussek
3f70f89339 Merge remote branch 'symfony/master' into experimental
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/Debug/TraceableEventDispatcher.php
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
	src/Symfony/Component/HttpFoundation/File/UploadedFile.php
2011-03-18 10:39:40 +01:00
Fabien Potencier
136b23ead4 [EventDispatcher] refactored the code
* The array returned by getListeners() now removes the listener hash as the key (as this is an implementation detail)
 * The sort method now guarantees that a listener registered before another will stay in the same order even for the same priority (for BC)
 * Made various optimizations
2011-03-18 09:01:22 +01:00
Fabien Potencier
69d324eca8 [EventDispatcher] added EventDispatcher::removeSubscriber() 2011-03-18 09:00:58 +01:00
Fabien Potencier
10a02ff7fa [EventDispatcher] reverted to the old event dispatcher way of storing listeners 2011-03-18 08:09:42 +01:00
Fabien Potencier
9e88fc4e66 Merge remote branch 'kriswallsmith/kernel/uploaded-file-for-test' 2011-03-18 08:02:16 +01:00
Fabien Potencier
e286adf173 [Security] fixed typos 2011-03-18 07:58:51 +01:00
Fabien Potencier
9de0a3872b Merge branch 'events'
* events:
  [FrameworkBundle] fixed the traceable event manager
  [EventDispatcher] made order deterministic (first registered one stay first) -- this makes the new system more compatible with the old one
  [FrameworkBundle] fixed class loading order
  fixed various bugs introduced during the event system migration
  renamed filterCore* to onCore*
  fixed CS
  fixed phpdoc
  renamed some methods in the event dispatcher
  [HttpKernel] Removed unused onCoreSecurity event
  [Security] Fixed method names in the Firewall listeners
  [HttpKernel] Added more code documentation to the HttpKernel events
  [Security] Fixed method calls on EventDispatcher
  [FrameworkBundle] Removed EventSubscriber support for DI tags because it currently cannot be implemented
  [Security] Fixed calls to EventDispatcher::dispatchEvent()
  Switched from Doctrine's EventManager implementation to the EventManager clone in Symfony2 (now called EventDispatcher again)
  [EventDispatcher] Replaced EventDispatcher by Doctrine's implementation
  Renamed EventArgs classes and adapted remaining code to EventManager
  Replaced EventDispatcher by Doctrine's EventManager implementation
2011-03-18 07:52:05 +01:00
Fabien Potencier
59ac6313ad [EventDispatcher] made order deterministic (first registered one stay first) -- this makes the new system more compatible with the old one 2011-03-18 07:36:02 +01:00
Fabien Potencier
1af43a1562 fixed various bugs introduced during the event system migration 2011-03-18 07:35:59 +01:00
Victor Berchet
9fd7d05ecf [Config] Ability to add and override node types without having to subclass NodeBuilder 2011-03-18 00:32:35 +01:00
Kris Wallsmith
a9af77a035 [HttpKernel] fixed file uploads in functional tests 2011-03-17 16:09:31 -07:00
Kris Wallsmith
ab3b8ac364 [HttpFoundation] cleaned up comments and coding standards, added better exception messages when filesystem functions throw errors, added "moved" arg to UploadedFile constructor, added FileNotFoundException to UploadedFile per the parent constructor 2011-03-17 16:07:53 -07:00
Kris Wallsmith
69609257ac [DomCrawler] updated upload logic to better emulate a real upload by copying the source file to the temp directory 2011-03-17 16:06:47 -07:00
Benjamin Eberlei
76b0041d1b [Form] Implemented first PhpTheme attempt 2011-03-17 22:47:19 +01:00
Bernhard Schussek
a51321c264 [Form] Moved validation logic to ValidationListener 2011-03-17 21:47:12 +01:00
Bernhard Schussek
0799662361 [Form] Extracted data mapping logic from Form into ObjectMapperListener 2011-03-17 21:23:59 +01:00
Benjamin Eberlei
3bc825bbd4 Merge branch 'experimental' of git://github.com/bschussek/symfony into forms 2011-03-17 19:05:59 +01:00
Benjamin Eberlei
85b61fe1e2 First attempt of PhpTheme. 2011-03-17 19:05:48 +01:00
ever.zet
3e7fa82f34 [Console] privatized protected variables, cuz they now have getters/setters 2011-03-17 18:51:37 +02:00
ever.zet
aa084dbc45 [Console] moved whole constructor definitions in one line 2011-03-17 18:51:01 +02:00
Fabien Potencier
6c8e71c8e7 renamed filterCore* to onCore*
The onCore* events are fired at some pre-defined points during the
handling of a request. At this is more important than the fact
that you can change things from the event.
2011-03-17 17:01:59 +01:00
ever.zet
8b885a991c [Console] updated console and stream outputs to support new output formatter 2011-03-17 17:53:46 +02:00
ever.zet
644cf612b3 [Console] updated console output to support new output formatter and styles 2011-03-17 17:52:36 +02:00
ever.zet
4fe2efd49e [Console] implemented output formatter to decorate and format output messages 2011-03-17 17:51:49 +02:00
ever.zet
e5700b817b [Console] implemented output formatter style class for defining custom styles 2011-03-17 17:51:25 +02:00
ever.zet
65681cdc85 [Console] added output formatter interfaces 2011-03-17 17:50:42 +02:00
Victor Berchet
1e0ed22c55 [Config] Component refactoring
The Config component API have changed and the extension configuration files must be updated accordingly:

1. Array nodes must enclosed their children definition in ->children() ... ->end() calls:

Before:

    $treeBuilder->root('zend', 'array')
        ->arrayNode('logger')
            ->scalarNode('priority')->defaultValue('INFO')->end()
            ->booleanNode('log_errors')->defaultFalse()->end()
        ->end();

After:

    $treeBuilder->root('zend', 'array')
        ->children()
            ->arrayNode('logger')
                ->children()
                    ->scalarNode('priority')->defaultValue('INFO')->end()
                    ->booleanNode('log_errors')->defaultFalse()->end()
                ->end()
            ->end()
        ->end();

2. The 'builder' method (in NodeBuilder) has been dropped in favor of an 'append' method (in ArrayNodeDefinition)

Before:

    $treeBuilder->root('doctrine', 'array')
        ->arrayNode('dbal')
            ->builder($this->getDbalConnectionsNode())
        ->end();

After:

    $treeBuilder->root('doctrine', 'array')
        ->children()
            ->arrayNode('dbal')
                ->append($this->getDbalConnectionsNode())
            ->end()
        ->end();

3. The root of a TreeBuilder is now an NodeDefinition (and most probably an ArrayNodeDefinition):

Before:

    $root = $treeBuilder->root('doctrine', 'array');
    $this->addDbalSection($root);

    public function addDbalSection(NodeBuilder $node)
    {
        ...
    }

After:

    $root = $treeBuilder->root('doctrine', 'array');
    $this->addDbalSection($root);

    public function addDbalSection(ArrayNodeDefinition $node)
    {
        ...
    }

4. The NodeBuilder API has changed (this is seldom used):

Before:

    $node = new NodeBuilder('connections', 'array');

After:

The recommended way is to use a tree builder:

    $treeBuilder = new TreeBuilder();
    $node = $treeBuilder->root('connections', 'array');

An other way would be:

    $builder = new NodeBuilder();
    $node = $builder->node('connections', 'array');

Some notes:

- Tree root nodes should most always be array nodes, so this as been made the default:

    $treeBuilder->root('doctrine', 'array') is equivalent to $treeBuilder->root('doctrine')

- There could be more than one ->children() ... ->end() sections. This could help with the readability:

    $treeBuilder->root('doctrine')
        ->children()
            ->scalarNode('default_connection')->end()
        ->end()
        ->fixXmlConfig('type')
        ->children()
            ->arrayNode('types')
                ....
            ->end()
        ->end()
2011-03-17 16:26:15 +01:00