This PR was merged into the 2.3 branch.
Discussion
----------
[WebProfiler] remove deprecated verbose option
test pass: yes
bc break: no
Commits
-------
8a4b91b [WebProfiler] remove deprecated verbose option
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] removed deprecated method from cache:clear command
bc break: no
test pass: yes
Commits
-------
024bd9e [FrameworkBundle] removed deprecated method from cache:clear command
This PR was merged into the 2.3 branch.
Discussion
----------
[ClassLoader] tiny refactoring
test pass: yes
bc break: no
Commits
-------
6394a5b [ClassLoader] tiny refactoring
This PR was merged into the 2.3 branch.
Discussion
----------
[Security] Added tests
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
8d5f39f [Security] Added tests for the DefaultLogoutSuccessHandler.
30fe940 [Security] Added tests for the DefaultAuthenticationSuccessHandler.
12d9b0a [Security] Added tests for the DefaultAuthenticationFailureHandler.
3129bee [Security] Added tests for the remember me ReponseListener.
573bf07 [Security] Added tests for the SessionAuthenticationStrategy.
9d3397d [Security] Added tests for the AccessMap.
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#8040).
Discussion
----------
[Monolog] fix logger in regards to DebugLoggerInterface
Commits
-------
438f75c [Monolog] fix logger in regards to DebugLoggerInterface
This PR was submitted for the master branch but it was merged into the 2.1 branch instead (closes#8117).
Discussion
----------
[Security] Added type of return value in VoterInterface.
| Q | A
| ------------- | ---
| Fixed tickets | none
| License | MIT
Simple addition of the return type for the `supportsClass` method, as per the `supportsAttribute` method doc in the interface.
Commits
-------
c176d1e [Security] Added type of return value in VoterInterface.
This PR was submitted for the 2.0 branch but it was merged into the 2.1 branch instead (closes#8098).
Discussion
----------
[HttpKernel] Fixed two bugs in HttpCache
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8097
| License | MIT
| Doc PR |
1. 304 responses always send "Content-Type: text/html; charset=UTF-8"
header
I discovered that the HttpCache::handle method calls Response::prepare
after calling Response::isModified. Response::isModified removes the
Content-Type header as it should, but Response::handle adds in the
default Content-Type header when none is set. If the default
Content-Type is not the correct Content-Type, then the Content-Type in
the cache gets clobered. I solved this problem by moving the
Response::isModified call after the Response::prepare call. I updated
the testRespondsWith304WhenIfModifiedSinceMatchesLastModified and
testRespondsWith304WhenIfNoneMatchMatchesETag tests to verify that the
Content-Type header was not being sent for 304 responses.
2. Failure to invalidate cached entities referred to by the Location
header
I discovered that the Store::invalidate method was looking for Location
and Content-Location headers to invalidate, but it was looking in the
request headers instead of the response headers. Because the
Store::invalidate method doesn't take a response, I decided it was
better to move this logic to the HttpCache::invalidate method instead.
I updated the testInvalidatesCachedResponsesOnPost test to verify that
Location headers are getting invalidated correctly.
Commits
-------
a4251bd [HttpKernel] Fixed two bugs in HttpCache
1. 304 responses always send "Content-Type: text/html; charset=UTF-8"
header
I discovered that the HttpCache::handle method calls Response::prepare
after calling Response::isModified. Response::isModified removes the
Content-Type header as it should, but Response::handle adds in the
default Content-Type header when none is set. If the default
Content-Type is not the correct Content-Type, then the Content-Type in
the cache gets clobered. I solved this problem by moving the
Response::isModified call after the Response::prepare call. I updated
the testRespondsWith304WhenIfModifiedSinceMatchesLastModified and
testRespondsWith304WhenIfNoneMatchMatchesETag tests to verify that the
Content-Type header was not being sent for 304 responses.
2. Failure to invalidate cached entities referred to by the Location
header
I discovered that the Store::invalidate method was looking for Location
and Content-Location headers to invalidate, but it was looking in the
request headers instead of the response headers. Because the
Store::invalidate method doesn't take a response, I decided it was
better to move this logic to the HttpCache::invalidate method instead.
I updated the testInvalidatesCachedResponsesOnPost test to verify that
Location headers are getting invalidated correctly.
This PR was merged into the 2.3 branch.
Discussion
----------
[SecurityBundle] Added missing files for phpunit
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes and no (BC Break in RequestMatcher, symfony/http-foundation: 2.2.x)
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
11497f3 [SecurityBundle] Added missing files for phpunit
This PR was merged into the 2.3 branch.
Discussion
----------
[Routing] Added Router tests and fixed an exception message
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
e61ba7d [Routing] Added Router tests and fixed an exception message.
This PR was merged into the 2.3 branch.
Discussion
----------
[WebProfilerBundle] Fixed composer.json
Commits
-------
d4f5389 [WebProfilerBundle] Fixed composer.json
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#8078).
Discussion
----------
[FrameworkBundle] fix double variable assignment in ContainerDebugComman...
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
9d1a219 [FrameworkBundle] fix double variable assignment in ContainerDebugCommand
This PR was merged into the 2.3 branch.
Discussion
----------
[Config] Including exception message to clarify the underlying issue
Hi guys!
In the framework if you, for example, make a syntax error in YAML, then the true, clear message (e.g. Unable to parse at line 5 (near "framework") is nested, and harder to visually see. This includes that message in the main exception so that users can debug more easily.
I see this quite a bit, it's a choke point for newcomers :).
Before: Cannot import resource "/path/to/app/config/config.yml" from "/path/to/app/config/config_dev.yml".
After: Cannot import resource "/path/to/app/config/config.yml" from "/path/to/app/config/config_dev.yml". (Unable to parse at line 5 (near "framework").)
Corrections and comments warmly appreciated.
Thanks!
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | --
| License | MIT
| Doc PR | n/a
Commits
-------
435012f [Config] Adding the previous exception message into the FileLoaderLoadException so it's more easily seen
This PR was merged into the master branch.
Discussion
----------
[Console] ensure integer exit codes in events
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
fe1db71 [Console] ensure integer exit codes in events
This PR was merged into the 2.1 branch.
Discussion
----------
[Console] fix and refactor exit code handling
Split of #8038
Commits
-------
5c317b7 [Console] fix and refactor exit code handling
* 2.2:
[CssSelector] Fix :nth-last-child() translation
Fix Crawler::children() to not trigger a notice for childless node
Conflicts:
src/Symfony/Component/CssSelector/Node/FunctionNode.php
src/Symfony/Component/CssSelector/Tests/Node/FunctionNodeTest.php
This PR was merged into the 2.1 branch.
Discussion
----------
[CssSelector] Fix :nth-last-child() translation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8068
| License | MIT
| Doc PR | n/a
Same as #8072, but for < 2.3
Commits
-------
1469953 [CssSelector] Fix :nth-last-child() translation
This PR was merged into the 2.3 branch.
Discussion
----------
[Intl] Fixed the class namespaces in the @covers annotations.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
a39db7b [Intl] Fixed the class namespaces in the @covers annotations.
This PR was merged into the 2.3 branch.
Discussion
----------
[CssSelector] Moved a test into the Tests folder.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
b2e52e8 [CssSelector] Moved a test into the Tests folder.
In the framework if you, for example, make a syntax error in YAML, then the true, clear message (e.g. Unable to parse at line 5 (near "framework") is nested, and harder to visually see. This includes that message in the main exception so that users can debug more easily.
Before: Cannot import resource "/path/to/app/config/config.yml" from "/path/to/app/config/config_dev.yml".
After: Cannot import resource "/path/to/app/config/config.yml" from "/path/to/app/config/config_dev.yml". (Unable to parse at line 5 (near "framework").)
One may want to print something else while the progress bar is running.
The output will be messy if the progress bar is not removed first.
One may also want to remove the progress bar after the work is complete.