Fabien Potencier
2c85a59599
Merge remote branch 'vicb/form-rendered'
...
* vicb/form-rendered:
[Form] Fix for nested forms getting erroneously set as rendered
2011-05-22 08:16:24 +02:00
Amal Raghav
517f95d8a4
added missing single-text option
2011-05-20 19:19:23 +05:30
Victor Berchet
e117613550
[Form] Fix for nested forms getting erroneously set as rendered
2011-05-20 15:48:55 +02:00
Victor Berchet
e0ff7d2613
[Form] Tweak the field type
2011-05-20 11:08:48 +02:00
Michel Weimerskirch
fd92105fa0
Fix merge error (function "guess" was in there twice)
2011-05-19 05:45:29 -07:00
Bernhard Schussek
dcc61a9a98
Merge remote branch 'shieldo/search_field' into shieldo_merge
2011-05-19 01:41:59 +02:00
Bernhard Schussek
13a964ae6d
[Form] Form::isBound() and Form::isValid() work correctly now for read-only forms
2011-05-19 01:24:28 +02:00
Bernhard Schussek
c3e8569f73
Merge remote branch 'vicb/form-csrf' into vicb_merge
2011-05-18 23:56:11 +02:00
Bernhard Schussek
a7ff4f484a
[Form] Further simplified PropertyPath code
2011-05-18 23:39:49 +02:00
Bernhard Schussek
857042458a
Merge remote branch 'vicb/form-ppath-optim' into vicb_merge
2011-05-18 23:34:53 +02:00
Bernhard Schussek
af66beed76
[Form] Added test for 6c337d1cc0
2011-05-18 23:20:37 +02:00
Bernhard Schussek
a3d84bc681
Merge remote branch 'vicb/form-9731' into vicb_merge
2011-05-18 23:12:27 +02:00
Bernhard Schussek
216d7e415d
Merge remote branch 'mweimerskirch/form_pattern_attribute' into mweimerskirch_merge
...
Conflicts:
src/Symfony/Bundle/TwigBundle/Resources/views/Form/div_layout.html.twig
src/Symfony/Component/Form/Extension/Core/Type/FieldType.php
src/Symfony/Component/Form/Extension/Validator/ValidatorTypeGuesser.php
2011-05-18 22:49:27 +02:00
Bernhard Schussek
520e3761e9
[Form] Removed unused option "pattern" of date and time type
2011-05-18 22:34:34 +02:00
Bernhard Schussek
f467317bab
[Form] Renamed view variable "name" to "full_name"
...
The variable "name" now contains the local, short name (equivalent to $form->getName()).
2011-05-18 22:16:16 +02:00
Bernhard Schussek
b39a21fbaf
[Form] Renamed collection option "type_options" to "options" to be consistent with the repeated type
2011-05-18 21:52:59 +02:00
Bernhard Schussek
2711fbc418
Merge remote branch 'jaugustin/fix_form' into jaugustin_merge
...
Conflicts:
src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php
2011-05-18 21:40:20 +02:00
Victor Berchet
ebb0e83a7e
[Form] CSRF documentation and a few CS changes
2011-05-18 12:45:01 +02:00
Victor Berchet
ba31b5acc5
[Form] Move CSRF options from types to the CSRF extension
2011-05-18 10:37:31 +02:00
Fabien Potencier
eb202bb7b7
merged kriswallsmith/form/csrf-intention
2011-05-17 15:25:50 +02:00
Fabien Potencier
75f0ab5d40
Merge remote branch 'vicb/form-fluid'
...
* vicb/form-fluid:
[Form] Fix the Form fluid interface
[Form] Fix the fluid interface of FormBuilder
[Form] Fix the fluid interface of FormBuilder
2011-05-17 09:45:29 +02:00
Fabien Potencier
d118e32783
Merge remote branch 'vicb/924-cosmetic'
...
* vicb/924-cosmetic:
[Form] CS related changes
2011-05-17 09:19:41 +02:00
Fabien Potencier
d0b403b7e4
Merge remote branch 'vicb/924-real'
...
* vicb/924-real:
[Form] Implement a fluid interface FormView
2011-05-17 09:19:39 +02:00
Kris Wallsmith
914620f948
[Form] renamed CSRF page_id to intention
2011-05-16 14:16:29 -07:00
Victor Berchet
42698608cb
[Form] CS related changes
2011-05-15 21:39:22 +02:00
Victor Berchet
39efc49da0
[Form] Implement a fluid interface FormView
2011-05-15 21:38:12 +02:00
Douglas Greenshields
bf2f9d2a02
[Form] Added a search form field type
2011-05-15 18:31:36 +01:00
Victor Berchet
971aad0593
Merge branch 'master' into form-phpdoc-2
2011-05-15 19:24:09 +02:00
Deni
e75edf205d
[Form] Fixed path mapping for DelegatingValidator
2011-05-14 13:38:34 +04:00
Fabien Potencier
dbdb3da6bf
Merge remote branch 'vicb/form-misc-fix-2'
...
* vicb/form-misc-fix-2:
[Form] fix calling closures
[Form] Add a missing property delcaration in the ResizeFormListener
2011-05-14 11:04:50 +02:00
Victor Berchet
3b9c1e3fee
[Form] Optimization of PropertyPath
2011-05-13 19:29:41 +02:00
Bernhard Schussek
e0ff61949e
[Form] Renamed the value "text" of the "widget" option of the "date" type to "single-text"
2011-05-13 19:17:28 +02:00
Bernhard Schussek
7570e04589
[Form] Implemented getAllowedOptionValues() for core types
2011-05-13 18:58:19 +02:00
Bernhard Schussek
da28f8e3b3
[Form] Added FormTypeInterface::getAllowedOptionValues() to better validate passed options
2011-05-13 18:44:03 +02:00
Bernhard Schussek
21013b930c
[Form] Improved test coverage of FormFactory and improved error handling
2011-05-13 18:29:18 +02:00
Bernhard Schussek
fdd18250b3
[Form] Added getType() to FormFactoryInterface
2011-05-13 17:16:36 +02:00
Victor Berchet
ae4bfbada4
[Form] fix calling closures
2011-05-13 11:01:31 +02:00
Victor Berchet
b2b3b190ef
[Form] Add a missing property delcaration in the ResizeFormListener
2011-05-13 11:01:27 +02:00
Victor Berchet
87a6fd0f99
[Form] phpDoc
2011-05-13 11:00:04 +02:00
Jeremy Mikola
61dc1af65b
[Form] Refer to FormView explicitly in its own getParent() type-hint
...
Using "self" makes mocking impossible, as the type-hint would then refer to the extending class and make the declaration incompatible.
2011-05-11 14:11:43 -07:00
Victor Berchet
f68d16fdff
[Form] Fix the Form fluid interface
2011-05-11 17:08:53 +02:00
Jeremie Augustin
0077963584
fix file permissions to 644
2011-05-11 11:19:21 +02:00
Jeremie Augustin
b5277752b7
[Form] add type_options for CollectionType to be abble to set options to type
2011-05-11 11:19:21 +02:00
Victor Berchet
2db53b5e28
[Form] Order method according to their visibility to respect the CS
2011-05-11 11:00:32 +02:00
Victor Berchet
5536d41906
[Form] Add phpDoc for form builder and fix method declaration order to conform to the CS
2011-05-11 11:00:32 +02:00
Fabien Potencier
1ae5ef6849
Merge remote branch 'vicb/form-padded-choice-list'
...
* vicb/form-padded-choice-list:
[Form] Allow for arbitrary keys in PaddedChoiceList
2011-05-11 10:18:30 +02:00
Fabien Potencier
b62cd109f0
Merge remote branch 'vicb/form-fixes'
...
* vicb/form-fixes:
[Form] Make the PropertyPathMapper class use the UnexpectedTypeException
[Form] Fix adding transformers in the FormBuilder
[Form] Fix the ReversedTransform class
2011-05-11 10:13:24 +02:00
Fabien Potencier
9651175914
Merge remote branch 'vicb/form-transformers'
...
* vicb/form-transformers:
[Form] Add argument type checking in BaseDateTimeTransformer
[Form] Catch exceptions in DataTransformers
2011-05-11 10:12:23 +02:00
Fabien Potencier
723a8f2bf3
[Form] fixed CS
2011-05-11 10:09:27 +02:00
Victor Berchet
adef14f687
[Form] Make the PropertyPathMapper class use the UnexpectedTypeException
2011-05-10 20:25:46 +02:00
Victor Berchet
daccf9bc17
[Form] Fix adding transformers in the FormBuilder
2011-05-10 20:25:30 +02:00
Victor Berchet
486294b50b
[Form] Fix the ReversedTransform class
2011-05-10 20:25:22 +02:00
Victor Berchet
2e68801ff3
[Form] Add argument type checking in BaseDateTimeTransformer
2011-05-10 20:21:02 +02:00
Victor Berchet
dac798c791
[Form] Catch exceptions in DataTransformers
2011-05-10 20:21:02 +02:00
Victor Berchet
aa71d16812
[Form] Make TimezoneChoiceList implement ChoiceListInterface rather than extend ArrayChoiceList
2011-05-10 20:14:11 +02:00
Victor Berchet
eca6453558
[Form] Fix the fluid interface of FormBuilder
2011-05-10 20:09:37 +02:00
Victor Berchet
75a499b0e2
[Form] Fix the fluid interface of FormBuilder
2011-05-10 20:09:28 +02:00
Victor Berchet
2d62dfdf83
[Form] Fix some phpDoc
2011-05-10 16:55:05 +02:00
Victor Berchet
2a8f2d2bfa
[Form] fix and add some phpDoc
2011-05-10 15:33:02 +02:00
Fabien Potencier
80a5074746
[Form] tweaked code ( closes #855 )
2011-05-09 17:53:18 +02:00
Victor Berchet
6c337d1cc0
[Form] Do not set the value attribute for file inputs
2011-05-09 17:00:19 +02:00
Victor Berchet
e0f03471ae
Merge branch 'master' into form-padded-choice-list
2011-05-09 15:30:04 +02:00
Deni
a15abc09bd
[Form] Added missing import statement of namespaces.
2011-05-09 14:30:04 +04:00
Kris Wallsmith
f3b077a0dd
[Form] removed a bunch of unused use statements
2011-05-06 14:07:16 -07:00
Victor Berchet
68b3d0d5ac
[Form] Allow for arbitrary keys in PaddedChoiceList
2011-05-06 10:31:51 +02:00
Michel Weimerskirch
476644a92c
[Form] Support for the HTML5 "pattern" attribute, see http://www.whatwg.org/specs/web-apps/current-work/multipage/common-input-element-attributes.html#the-pattern-attribute
...
If you use the MinLength validator with your entities, the ValidatorTypeGuesser gets the value, stored as "minlength". Then, the FormFactory generates a "pattern" attribute out of minlength and maxlength.
Modern browsers such as Chrome use this attribute to validate the form before submitting.
a "pattern" attribute is generated that validates the
2011-05-04 23:16:41 +02:00
Bernhard Schussek
74cca63938
[Form] CSRF fields are not included in the children of a FormView anymore if the view is not the root
2011-05-04 18:27:20 +02:00
Bernhard Schussek
173beeba74
[Form] FormView::offsetUnset() is now supported. It was possible anyway using getChildren() and setChildren().
2011-05-04 18:21:49 +02:00
Bernhard Schussek
3cc5d9f4cd
[Form] Split the option "modifiable" of the "collection" type into "allow_add" and "allow_delete"
2011-05-04 17:29:59 +02:00
Bernhard Schussek
bf1dfbbe99
[Form] Added test for last commit by kriswallsmith and improved dealing with original names
...
The form component should now guarantee to always pass an UploadedFile object to your model. There you can call getOriginalName() to retrieve the original name of the uploaded file. For security reasons, the real file name is a generated hash value.
2011-05-04 17:04:44 +02:00
Kris Wallsmith
4ea274244d
[Form] updated listener to check that data is an array
2011-05-02 15:56:35 -07:00
Amal Raghav
26bfa43bfc
fixed a typo
2011-04-28 23:37:40 +05:30
Fabien Potencier
05f1481c6a
[Form] added the possibility to configure the CSRF field name and the disabling of the CSRF feature altogether
2011-04-28 11:28:44 +02:00
Fabien Potencier
751eaab326
Merge remote branch 'mweimerskirch/form_fixes'
...
* mweimerskirch/form_fixes:
Fix DateTimeType by adding missing default options
2011-04-28 08:18:28 +02:00
Fabien Potencier
f865a79742
[Form] fixed DateTimeToTimestampTransformer to use the proper exception class
2011-04-28 08:07:19 +02:00
Fabien Potencier
0007702321
Merge remote branch 'Seldaek/datetime'
...
* Seldaek/datetime:
[Form] Use proper transformation exception in case of failure
2011-04-28 08:05:08 +02:00
Jeremy Mikola
f59423626a
[Form] Remove unnecessary use statements in EventListeners
2011-04-27 12:18:45 -04:00
Eriksen Costa
164ce5210d
capitalized 'boolean'
2011-04-27 02:35:10 -03:00
Eriksen Costa
4db0752894
replaced 'bool' with 'Boolean'
2011-04-27 02:35:03 -03:00
Jordi Boggiano
d11b7baa7e
[Form] Use proper transformation exception in case of failure
2011-04-26 16:02:01 +02:00
Michel Weimerskirch
87c609b4a4
Fix DateTimeType by adding missing default options
2011-04-26 14:21:00 +02:00
Victor Berchet
f83e92bf44
Make casting scalar to array consistent
2011-04-26 12:16:35 +02:00
Fabien Potencier
c0a160b5f9
partially reverted previous merge
2011-04-24 22:02:19 +02:00
Fabien Potencier
c6e0ccfdcd
Merge remote branch 'pborreli/form-typo'
...
* pborreli/form-typo:
[Form] Fixed typos
2011-04-24 21:56:47 +02:00
Fabien Potencier
f251eab92f
Revert "[Form] added a way to register a Form extension after creation of the FormFactory"
...
This reverts commit 2b8c7f84b5
.
2011-04-24 21:56:06 +02:00
Fabien Potencier
2f3ddb88ef
Merge remote branch 'bschussek/form'
...
* bschussek/form:
[Form] Automatically setting "data_class" option if objects are passed at the creation of a form
[Form] Improved the way passed data is handled in FormFactory
[Form] Simplified FileType code
[HttpFoundation] TemporaryStorage automatically creates the directory if it doesn't exist yet
[Form] Changed FormBuilder::build() to FormBuilder::create(). You hvae to pass the resulting builder to FormBuilder::add() manually now
[Form] Added FieldTypeValidatorExtension and fixed FQCN of DelegatingValidator
2011-04-24 21:53:24 +02:00
Pascal Borreli
06b3c386d9
[Form] Fixed typos
2011-04-24 14:05:16 +00:00
Fabien Potencier
08bf2af455
fixed email
2011-04-24 13:59:46 +02:00
Bernhard Schussek
e790587dc2
[Form] Automatically setting "data_class" option if objects are passed at the creation of a form
...
$form = $this->get('form.factory')->create(new PostType(), $post);
2011-04-24 13:38:12 +02:00
Bernhard Schussek
d58c610833
[Form] Improved the way passed data is handled in FormFactory
2011-04-24 13:32:29 +02:00
Bernhard Schussek
335f7e776a
[Form] Simplified FileType code
2011-04-24 12:08:56 +02:00
Bernhard Schussek
675e5ded9e
[Form] Changed FormBuilder::build() to FormBuilder::create(). You hvae to pass the resulting builder to FormBuilder::add() manually now
...
$builder->add(
$builder->create('child', 'form')
->add('foo', 'text')
->add('bar', 'text')
);
2011-04-24 12:08:50 +02:00
Fabien Potencier
823be5d956
Merge remote branch 'ornicar/fixDelegatingValidatorNamespace'
...
* ornicar/fixDelegatingValidatorNamespace:
[Form] Fix DelegatingValidator namespace
2011-04-24 08:45:50 +02:00
ornicar
b5055bb4fd
[Form] Fix DelegatingValidator namespace
2011-04-23 23:20:56 -07:00
Ryan Weaver
181ef3cc08
[Form] Removing an unused variable in TimeType
2011-04-23 20:52:26 -05:00
Ryan Weaver
af8aad9c34
[Form] Throwing exception for invalid "input" type of DateType
...
Also fixed typo in test of previous commit
2011-04-23 20:36:40 -05:00
Ryan Weaver
f435ed7e7e
[Form] Removing unused private property and adding PHPDoc
2011-04-23 20:14:12 -05:00
Ryan Weaver
0681e443d5
[Form] Fixing wrong variable name
2011-04-23 20:08:24 -05:00
Ryan Weaver
78b2062c5e
[Form] Adding an exception for an invalid widget option in DateType
2011-04-23 19:42:40 -05:00
Pascal Borreli
8c0beea677
[Phpdoc] Cleaning/fixing
2011-04-23 15:18:47 +00:00
Fabien Potencier
50d3c92e22
tweaked TemporaryStorage directory creation
2011-04-23 15:19:30 +02:00
Fabien Potencier
2b8c7f84b5
[Form] added a way to register a Form extension after creation of the FormFactory
2011-04-23 09:28:29 +02:00
Fabien Potencier
b69c5956d3
[Form] added missing use statement
2011-04-23 09:27:47 +02:00
Bernhard Schussek
6f1bc356a8
[Form] Refactored code from CoreExtension to new ValidatorExtension
...
CoreExtension is now independent of the Symfony2 validator.
2011-04-22 19:38:21 +02:00
Bernhard Schussek
1ce2db87e2
[Form] Added FormTypeExtensionInterface
...
With implementations of this interface, existing types can be amended.
The Csrf extension, for example, now contains a class FormTypeCsrfExtension
that adds CSRF capabilities to the "form" type.
To register new type extensions in the DIC, tag them with "form.type_extension"
and the name of the extended type as alias.
2011-04-22 19:24:38 +02:00
Bernhard Schussek
54e66c518f
[Form] Reorganized code into "form extensions"
...
The extension classes are now the only constructor argument of the FormFactory class. They replace the existing "type loader" classes.
new FormFactory(array(
new CoreExtension($validator, $storage),
new CsrfExtension($csrfProvider),
new DoctrineOrmExtension($em),
));
Together with a few upcoming commits this mechanism will make
* extension of the form framework in bundles and
* usage of the forms outside of Symfony2
much easier.
2011-04-22 17:41:21 +02:00
Bernhard Schussek
a97366fbcb
[Form] Split signature of FormFactory::create() into create() and createNamed()
...
The data can now be passed to all creation methods:
$form = $factory->create('form', $data);
By default, a form will receive the name of its type ("form" in above example). If you wish to pass a custom name, use createNamed():
$form = $factory->createNamed('form', 'myform', $data);
2011-04-22 10:42:21 +02:00
Ryan Weaver
df50e2b161
[Form] Removing excess option in the TimezoneType
2011-04-21 19:57:53 -05:00
Bernhard Schussek
c58b05a6d6
[Form] Removed obsolete code in TextType
2011-04-21 10:17:04 +02:00
Ryan Weaver
967a42b797
[Form] Adding a check that the choice_list option on the ChoiceType implements the ChoiceListInterface.
...
Also removed an unused "use" statement.
2011-04-20 08:52:31 -05:00
Fabien Potencier
3ca5f513a4
[Form] added support for groups in form validation (when using array data)
2011-04-19 09:56:49 +02:00
Fabien Potencier
5242859920
[Form] fixed error bubbling for choices when expanded is true
2011-04-19 09:13:29 +02:00
Bernhard Schussek
d93e10160c
[Form] Removed obsolete view variables
2011-04-18 15:47:18 +02:00
Bernhard Schussek
b93f5a372a
[Form] Renamed ChoiceUtil to FormUtil and gave its methods more general names
2011-04-18 15:07:12 +02:00
Bernhard Schussek
abb0d0cde1
[Form] Removed StripTagsListener. Its implementation is insufficient and needs to be replaced by a better one.
...
The current implementation does not sanitize HTML properly. See [1] and [2] for more information.
[1] https://github.com/padraic/wibble
[2] http://blog.astrumfutura.com/?s=html+sanitising
2011-04-18 14:19:20 +02:00
Fabien Potencier
bee5d07d86
[Form] added a way to specify the form constraint when building the form (useful if you work with arrays instead of objects)
2011-04-18 14:09:29 +02:00
Bernhard Schussek
57722550de
[Form] Added test for 'email' type and fixed a few bugs
2011-04-18 13:04:18 +02:00
Bernhard Schussek
23e9ad7a99
Merge remote branch 'mvrhov/email_type' into mvrhov_merge
2011-04-18 12:57:38 +02:00
Bernhard Schussek
eb21dc9fea
[Form] Removed obsolete constraints from validation.xml
2011-04-18 12:57:19 +02:00
Bernhard Schussek
325049ac73
Revert "[Form] removed validation.xml file (not used anymore)"
...
This reverts commit 3e476e1c30
.
2011-04-18 12:53:41 +02:00
Miha Vrhovnik
50011fa344
Added html5 email input to the forms
2011-04-18 11:17:41 +02:00
Miha Vrhovnik
43bcadbb80
Updating renamed event
2011-04-18 11:00:26 +02:00
Fabien Potencier
3a2ca3dd92
moved Doctrine2 Entity Type guesser to the Doctrine bridge
2011-04-18 08:44:37 +02:00
Fabien Potencier
4bfd5bf079
[Form] tweaked Date time transformer to allow fields with 0 as hour/minute/...
2011-04-17 22:50:22 +02:00
Fabien Potencier
3e476e1c30
[Form] removed validation.xml file (not used anymore)
2011-04-17 22:33:31 +02:00
Bernhard Schussek
be5738564f
[Form] Improved regular expression in AbstractType::getName() and added unit tests
2011-04-17 18:01:22 +02:00
Bernhard Schussek
4905bfd285
Merge remote branch 'brikou/form' into form
2011-04-17 18:01:17 +02:00
Tobias Naumann
f6ce451e2c
[Form] Made FormView implement Countable
2011-04-16 13:54:31 +02:00
Brikou CARRE
a83046f470
fixed regex (we don't need '?')
2011-04-15 19:04:53 +02:00
Brikou CARRE
28121e4a57
[Form] AbstractType::getName() improvement
2011-04-15 18:58:15 +02:00
Bernhard Schussek
30922d9375
[Form] Fixed: Checkboxes in an expanded choice field never have the 'required' HTML5 attribute. Closes http://trac.symfony-project.org/ticket/9588
2011-04-15 16:10:04 +02:00
Bernhard Schussek
9582221862
[Form] ResizeFormListener::preBind() now handles empty strings. Fixes https://github.com/symfony/symfony/pull/40
2011-04-15 15:43:02 +02:00
Bernhard Schussek
d0c572716a
Merge remote branch 'henrikbjorn/form' into henrik_merge
2011-04-15 15:34:29 +02:00
Henrik Bjørnskov
e687685f98
[Form] change FormView::setVar,getVar,getVars,hasVar to set,get,all,has
...
[Form] Fixed {get,set,has}Var references in templating php
[Form] Added getVars to FormView to ease usage in Twig. Also added some phpdoc and cleaned up the get method by adding a default value
[Form] Fix
[Form] Delete file generated by test
2011-04-15 15:25:37 +02:00
Bernhard Schussek
e787d5dc22
[Form] PropertyPath now can handle elements with special characters
2011-04-15 15:25:19 +02:00
Bernhard Schussek
4f1ae660fa
[Form] Fixed choice labels in expanded choice fields
2011-04-15 15:04:44 +02:00
Bernhard Schussek
41c6ab0ac7
[Form] Field labels can now be passed in the 'label' option
2011-04-15 15:03:10 +02:00
Bernhard Schussek
8fe21285ba
[Form] Renamed Form::getView() to createView() to clearly indicate that each call returns a new object
2011-04-15 13:52:11 +02:00
Bernhard Schussek
276b23a344
[Form] Moved creation logic of FormView to Form class
2011-04-15 13:41:45 +02:00
Bernhard Schussek
44fa9bbeaa
[Form] Fixed: CSRF token is regenerated if validation fails to avoid stalled tokens. Closes https://github.com/symfony/symfony/pull/415
2011-04-15 12:50:50 +02:00
Bernhard Schussek
c9c8b5c98e
[Form] Improved test coverage of MonthChoiceList and fixed timezone used in it. Fixes https://github.com/symfony/symfony/pull/433
...
Based on dfb93b1bcebf1f34d3a880d00f36acb2bcca0f08:
[FORM] Fixed DateField Month Choices
The month choices were calculated using the current day of the month with
gmmktime rather than the 1st of the month. Additionally, this provides a
UTC timestamp which is passed to the formatter (IntlDateFormatter) which
converts the timestamp using the current timezone. This means that the UTC
timestamp for 1st March was being converted for my timezone (EST) and giving
a date of 28th February, leading to Feb appearing again in the popup form
instead of Mar.
2011-04-15 12:26:07 +02:00
Bernhard Schussek
77bea81ed5
[Form] Improved test coverage of ResizeFormListener. Fixed https://github.com/symfony/symfony/pull/493
2011-04-15 11:06:51 +02:00
Bernhard Schussek
fa457b1cc4
[Form] Renamed 'filter' listeners to 'on' to match naming conventions across the framework
2011-04-15 10:57:32 +02:00
Bernhard Schussek
e3db366116
[Form] Passing FormFactory to FormBuilder in its constructor
2011-04-14 15:25:30 +02:00
Bernhard Schussek
72b17cd67c
[Form] Renamed TemplateContext to FormView
2011-04-14 15:02:51 +02:00
Bernhard Schussek
ca6ae09779
[Form] Removed TemplateContext::create()
2011-04-14 14:42:17 +02:00
Bernhard Schussek
ce5f3073bd
Fixed test suite and names of accessor methods in TemplateContext
2011-04-14 03:52:52 +02:00
Fabien Potencier
7913d7978e
[Form] removed DefaultFormFactory as it does not help that much and adds some confusion
2011-04-13 13:24:56 +02:00
Fabien Potencier
49dc836521
[Form] moved the template context creation to the Form class
...
Moving the template context creation makes sense and allows for simpler code for the end user:
Before:
return array('post' => $post, 'form' => $this->get('form.factory')->createTemplateContext($form));
After:
return array('post' => $post, 'form' => $form->getContext());
2011-04-13 09:31:13 +02:00
Fabien Potencier
7f2294395c
[Form] reverted the templating part to be similar to what we have today
2011-04-11 16:42:51 +02:00
Fabien Potencier
dfa1da0416
[Form] removed unused use statement and fixed phpdoc
2011-04-07 09:00:01 +02:00
Bernhard Schussek
3482ff73b7
[Form] Fixed empty value in choice fields
2011-04-06 15:59:09 +02:00
Bernhard Schussek
e476231e8a
[Form] Removed invalid tests, cleaned up some tests, added test coverage
2011-04-06 15:58:53 +02:00
Bernhard Schussek
72a41f8c94
[Form] Fixed: Booleans can be used as choice keys now
2011-04-02 18:26:28 +02:00
Bernhard Schussek
a5d0b3aea6
[Form] Changed FormBuilder::set(Client|Norm)Transformer to FormBuilder::prepend(Client|Norm)Transformer and FormBuilder::append(Client|Norm)Transformer to facilitate extension of types
2011-04-02 16:39:19 +02:00
Bernhard Schussek
be9ef42af9
[Form] Renamed choice transformers for better clarity
2011-04-02 16:11:20 +02:00
Bernhard Schussek
fc59936740
[Form] Fixed: ThemeRenderer::isChoiceSelected() works correctly for boolean choices
2011-04-02 16:00:46 +02:00
Bernhard Schussek
a4bbc40ac6
[Form] Cleaned up ChoiceListInterface
2011-04-02 15:41:43 +02:00
Bernhard Schussek
d3b7c4e8c1
[Form] Moved getLabel(), isChoiceSelected() and isChoiceGroup() from ChoiceListInterface to ThemeRenderer
2011-04-02 14:14:18 +02:00
Bernhard Schussek
94f2baa895
[Form] Fixed BooleanToStringTransformer::reverseTransform() to accept NULL values. Fixes ChoiceTypeTest
2011-04-02 13:00:19 +02:00
Bernhard Schussek
37e8e1270c
[Form][FrameworkBundle][TwigBundle] Renamed view variable 'disabled' to 'read_only' to match with the according FormInterface methods
2011-04-02 12:18:43 +02:00
Bernhard Schussek
35d9b7f800
[Form] Improved test coverage of Form. The emptyValue closure now receives the Form instance to use form data when constructing new objects
2011-04-02 12:00:19 +02:00
Bernhard Schussek
4f39234741
[Form] bind() is ignored if a form is read-only
2011-04-02 11:39:15 +02:00
Bernhard Schussek
ca20aef379
[Form] Improved test coverage of DelegatingValidator and fixed validation group inheritance
2011-04-02 11:35:58 +02:00
Bernhard Schussek
33b0011f86
[Form] Improved test coverage of Form
2011-04-02 11:22:29 +02:00
Bernhard Schussek
c864d7fae1
[Form] Improved test coverage of Form class
2011-03-31 15:23:33 +02:00
Bernhard Schussek
1ef18360fa
[Form] Made name immutable in FormBuilder to avoid synchronization problems with name and property path
2011-03-31 13:48:06 +02:00
Fabien Potencier
30f26ed091
[Form] changed DefaultFormFactory to be more 'useable'
2011-03-31 07:35:43 +02:00
Fabien Potencier
c7ccb6643b
[Form] removed unused constructor argument from Type\FieldType (themeFactory and template)
2011-03-31 07:34:04 +02:00
Fabien Potencier
a1fc882fad
[Form] fixed DefaultFormFactory
2011-03-30 23:38:40 +02:00
Bernhard Schussek
53838abf3f
Merge remote branch 'symfony/master' into experimental
...
Conflicts:
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/money_field.html.php
src/Symfony/Bundle/FrameworkBundle/Resources/views/Form/percent_field.html.php
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-28 22:52:15 +02:00
Fabien Potencier
52c3a1d53d
fixed typo
2011-03-28 22:48:18 +02:00
Bernhard Schussek
e2198b0dc6
[Form] Fixed a few references to AssertTrue/AssertFalse
2011-03-28 17:45:11 +02:00
Bernhard Schussek
e7df781c34
[Form] Fixed calls to ThemeRenderer::renderPart()
2011-03-28 11:22:27 +02:00
Bernhard Schussek
65f58c9fd1
[Form] Introduced generic RendererInterface
2011-03-27 23:43:14 +02:00
Bernhard Schussek
1fa004ceb2
[Form] Simplified the interface names of the Renderer subnamespace
2011-03-27 23:39:01 +02:00
Bernhard Schussek
4ec6ba8674
[Form] Fixed: set data is treated as string except if a transformer is set
2011-03-27 23:09:46 +02:00
Bernhard Schussek
cfaa03eeec
[Form] Fixed: empty objects are only created upon binding forms with empty data
2011-03-27 23:07:30 +02:00
Bernhard Schussek
8a981dd047
[Form] Removed unused variable
2011-03-27 17:37:42 +02:00
Bernhard Schussek
58b8555cb6
[Form] Removed unused use-statements
2011-03-27 15:59:35 +02:00
Bernhard Schussek
edfae73cd4
[Form] Moved PropertyPath, PropertyPathIterator and VirtualFormAwareIterator to subnamespace Util
2011-03-27 15:37:13 +02:00
Bernhard Schussek
29d412c15a
[Form] Changed name of VirtualFormIterator to VirtualFormAwareIterator
2011-03-27 15:33:04 +02:00
Bernhard Schussek
b180319371
[Form] Moved creation of empty data to Form to clean up DataMapperInterface
2011-03-27 15:12:35 +02:00
Bernhard Schussek
5ac979b043
[Form] Fixed default value of 'validation_groups' option, removed duplicate definition
2011-03-27 14:52:03 +02:00
Bernhard Schussek
80116be577
[Form] Removed unused 'template' option
2011-03-27 14:42:44 +02:00
Bernhard Schussek
6588a47ba7
[Form] Removed FormBuilder::setDataClass(). Use the FieldType option "data_class" instead.
...
The problem was that "data_class" was used in two places: FormBuilder::build() and PropertyPathMapper.
PropertyPathMapper was already constructed during FormType::buildForm(), so any data class changes made to the FormBuilder wouldn't affect the data class of the PropertyPathMapper anymore and so lead to an inconsistent state.
2011-03-27 14:34:48 +02:00
Bernhard Schussek
364b0f5208
[Form] Fixed: FormBuilder::add() accepts FormTypeInterface instances
2011-03-27 14:05:06 +02:00
Bernhard Schussek
dc38eeffe3
[Form] Changed the default value of the 'property_path' option to NULL. Explicitely set it to '' or false to disable mapping for a field/form
2011-03-27 14:02:24 +02:00
Bernhard Schussek
67d85c6bc7
[Form] Fixed signature of FormThemeInterface::render()
2011-03-27 13:48:38 +02:00
Bernhard Schussek
b21929423e
[Form] Completely removed the fields variable in the renderer. The renderer itself supports ArrayAccess and Traversable
2011-03-27 13:48:36 +02:00
Bernhard Schussek
eaff9c641e
[Form] Fixed: the default template is only set on the root renderer and reused by children
2011-03-26 19:39:31 +01:00
Bernhard Schussek
89361d036f
[Form] Renamed FormType::configure() to FormType::buildForm()
2011-03-26 18:52:24 +01:00
Bernhard Schussek
a58cfab37d
[Form] Removed form.type.loader tag and according compiler pass to simplify configuration. Custom types that are not in the DIC can be instantiated manually and passed wherever a type is desired.
2011-03-26 18:48:55 +01:00
Bernhard Schussek
9ff91dc997
Merge remote branch 'beberlei/FormsCollectionPrototype' into beberlei-merge
2011-03-26 18:39:20 +01:00
Bernhard Schussek
fae319e77a
[Form] Renderers are now created explicitely using FormFactory::createRenderer(). This improves performance on requests where a form does not need to be rendered
2011-03-26 16:03:34 +01:00
Bernhard Schussek
8c7a93c90c
[Form] Added FormTypeInterface::buildRendererBottomUp() which is called after children are initialized
2011-03-26 16:03:34 +01:00
Bernhard Schussek
c786fac303
[Form] Sample fix implementation of renderers
2011-03-26 16:03:34 +01:00
Johannes M. Schmitt
7887f04dc2
removed Assert prefix from all constraints, renamed annotation namespace to assert
2011-03-26 15:26:05 +01:00
Benjamin Eberlei
f9e2864030
[Form] Set prototype to true by default.
2011-03-26 14:56:59 +01:00
Benjamin Eberlei
d87651b6a2
[Form] Add option "prototype" defaulting to true.
2011-03-26 14:52:03 +01:00
Bernhard Schussek
41c3aea668
Merge remote branch 'beberlei/FormRendererItrator' into beberlei-merge
2011-03-26 13:43:33 +01:00
Benjamin Eberlei
f882a511a0
[Form] Initialize on iterator access.
2011-03-26 12:28:46 +01:00
Benjamin Eberlei
cd1ce86aee
[Form] Iterator support for ThemeRenderer
2011-03-26 12:25:47 +01:00
Benjamin Eberlei
73d8470a76
[Form] Fix children implementation, setChildren() is not used, the attribute "fields" is.
2011-03-26 09:42:45 +01:00
Bernhard Schussek
7585dce8dd
[Form] Added options validation to field creation
2011-03-25 15:30:33 +01:00
Bernhard Schussek
0ace068a52
[Form] PropertyPathMapper now only maps if the form data is synchronized to avoid duplicate form errors ('invalid'+'NotNull', for example)
2011-03-25 11:27:22 +01:00
Bernhard Schussek
6825ea2489
[Form] Improved test coverage of PropertyPathMapper
2011-03-25 11:27:20 +01:00
Bernhard Schussek
e3ac248617
[Form] Errors are mapped to subforms correctly and bubble up again if necessary
2011-03-25 10:53:36 +01:00
Bernhard Schussek
4f360109ed
[Form] Fixed validation.xml (now really)
2011-03-25 10:41:18 +01:00
Bernhard Schussek
7b412cc762
[Form] Removed FormFactory::addGuessers() and moved guessers to constructor arg instead
2011-03-25 02:26:14 +01:00
Bernhard Schussek
9b1b8cbffa
[Form] Replaced various occurences of 'field' by 'form'
2011-03-25 02:12:01 +01:00
Bernhard Schussek
3c412ffba0
[Form] Moved Form::validateData() to DelegatingValidator::validateFormData()
2011-03-25 01:59:28 +01:00
Bernhard Schussek
ec38901572
Merge branch 'rename-execute' into experimental
...
Conflicts:
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 01:49:17 +01:00
Bernhard Schussek
71230a094b
[Form] Fixed validation.xml
2011-03-25 01:46:05 +01:00
Bernhard Schussek
729438fdea
Merge branch 'rename-execute' into experimental
...
Conflicts:
src/Symfony/Component/Form/FileField.php
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 01:38:49 +01:00
Bernhard Schussek
9c6a6e13bf
[Validator] Renamed Execute constraint to Callback
2011-03-25 01:34:35 +01:00
Bernhard Schussek
4c43aa07ea
[Form] Fixed: Elements are removed from collections when a 'collection' field is sized down
2011-03-25 01:15:33 +01:00
Bernhard Schussek
770d403a52
[Form] Improved error mapping in DelegatingValidator
2011-03-25 00:57:35 +01:00
Bernhard Schussek
d2b07058f4
[Form] CSRF token is now only validated for root form
2011-03-25 00:19:00 +01:00
Bernhard Schussek
4372bd5dc8
[Form] Fixed: Bubbling errors are caught correctly
2011-03-25 00:18:58 +01:00
Bernhard Schussek
d84d167b71
[Form] Fixed display of enctype for file fields in Twig theme
2011-03-25 00:16:30 +01:00
Bernhard Schussek
66ba0c3a73
[Form] Fixed: vars are initialized when ThemeRenderer::getVars() is accessed
2011-03-25 00:16:23 +01:00
Bernhard Schussek
262bdcb21d
[Form] Fixed validation
2011-03-25 00:16:21 +01:00
Bernhard Schussek
ef334dbc4a
Merge remote branch 'beberlei/AttributeSupport' into beberlei-merge
2011-03-24 22:53:39 +01:00
Bernhard Schussek
3f390aa271
[Form] Removed EntityType from DefaultTypeLoader
2011-03-24 22:50:39 +01:00
Benjamin Eberlei
ee96ad0e81
[Form] [DoctrineBridge] Move EntityType and DoctrineTypeLoader into Doctrine Bridge
2011-03-24 22:43:00 +01:00
Bernhard Schussek
1ff6906608
[Form] Simplified ArrayTypeLoader and used it as base class of DefaultTypeLoader
2011-03-24 22:30:49 +01:00
Benjamin Eberlei
8d6dd2b9af
[Form] Add Arbitrary Attribute Support to Form Rendering.
2011-03-24 22:08:08 +01:00
Benjamin Eberlei
6bcc04905c
[Form] Introduce ArrayTypeLoader, Remove EntityManager and FormFactory interface from DefaultTypeLoader
2011-03-24 20:00:17 +01:00
Bernhard Schussek
15d5259eb8
[Form] Forms now remember the types used during their construction
2011-03-24 16:16:31 +01:00
Bernhard Schussek
0b4c3c0cb8
[Form] Fixed coding conventions
2011-03-24 15:26:17 +01:00
Bernhard Schussek
2faa47d03b
[Form] Added fallback templates to TwigThemeFactory
2011-03-24 15:11:43 +01:00
Bernhard Schussek
1211d77f49
[Form] Introduced renderer theme factories so that themes can be changed during runtime
2011-03-24 14:27:21 +01:00
Bernhard Schussek
5b41810b6d
Revert "[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'"
...
This reverts commit 1efd680b68
.
2011-03-24 10:55:12 +01:00
Bernhard Schussek
5078a63c74
Revert "[Form] Fixed more naming of themes and theme engines"
...
This reverts commit 1aa34b7240
.
2011-03-24 10:54:47 +01:00
Aurelijus
2ee47f3c69
get originalName before move call
2011-03-24 10:39:42 +02:00
Bernhard Schussek
9b6722222f
[Form] Improved internal structore of PropertyPathMapper
2011-03-24 00:15:59 +01:00
Bernhard Schussek
1aa34b7240
[Form] Fixed more naming of themes and theme engines
2011-03-23 22:51:37 +01:00
Bernhard Schussek
1efd680b68
[Form] Changed naming of Themes to ThemeEngines. Theme templates are now 'themes'
2011-03-23 22:34:58 +01:00
Bernhard Schussek
f71ae03143
[Form] AbstractType::getParent() returns 'form' by default now
2011-03-23 21:51:50 +01:00
Bernhard Schussek
c01419d856
Merge remote branch 'johnwards/renderer_tests' into renderer-tests-merge
2011-03-23 21:13:36 +01:00
Bernhard Schussek
08a09240f6
[Form] Fixed order of input and output timezone to a more natural one
2011-03-23 17:12:04 +01:00
Bernhard Schussek
a880f8d0d1
[Form] Fixed coding conventions
2011-03-23 16:14:53 +01:00
Bernhard Schussek
9e025440ca
Merge remote branch 'johnwards/configuration' into configurable-merge
2011-03-23 16:05:16 +01:00
John Wards
85701b65af
[Form] Missing methods from interfaces
2011-03-22 22:20:14 +00:00
John Wards
1a014d130e
[Form] Tests for Renderer Plugins
2011-03-22 22:19:51 +00:00
John Wards
37f12f68da
[Form] The declaration and initialization (constructor) of the variables should be in the same class.
2011-03-22 20:54:15 +00:00
John Wards
e54973b5d4
[Form] Refactoring Types to use new DataTransfomer interface
2011-03-22 15:40:52 +00:00
Bernhard Schussek
ea0e5bb2d6
[Form] Renamed FieldTypeInterface to FormTypeInterface
2011-03-22 12:36:41 +01:00
Bernhard Schussek
270a98e413
[Form] Added support for types that are not registered in the DIC. These are identified by their FQ class name.
2011-03-22 12:33:15 +01:00