Commits
-------
ca6299d [FrameworkBundle] Fixed a typo in the translation file per @PeymanHR
Discussion
----------
[FrameworkBundle] Fixed a typo in the translation file per @PeymanHR
Closes#2082
Commits
-------
d19f1d7 [Doctrine] Fix UniqueEntityValidator reporting a false positive by ignoring multiple query results
Discussion
----------
[Doctrine] Fix UniqueEntityValidator reporting a false positive by ignoring multiple query results
An entity should only be considered unique if its search criteria returns no matches or a single, identical entity. Multiple results indicates that conflicting entities exist.
Note: the DoctrineMongoDBBundle's unique validator checks identifier values if the object strict-equality check is false. This may be a worthwhile improvement, as it would prevent reporting a validation error for an enttiy which is going to overwrite its conflicting counter-part in the database.
---------------------------------------------------------------------------
by jmikola at 2011/09/01 14:23:27 -0700
This is the Doctrine bridge equivalent for my fix to DoctrineMongoDBBundle: https://github.com/symfony/DoctrineMongoDBBundle/pull/42
---------------------------------------------------------------------------
by fabpot at 2011/09/02 00:13:52 -0700
As this is a bug fix, can you base your PR on the symfony/2.0 branch? Thanks.
* EvanK-patch-1:
Per the [documentation][1], the `NotBlank` constraint should be using the `empty` language construct, otherwise it will not trigger on, for example, a boolean false from an unchecked checkbox field.
An entity should only be considered unique if its search criteria returns no matches or a single, identical entity. Multiple results indicates that conflicting entities exist.
Commits
-------
e991c59 [Console] Improved checks for InputArgument and InputOption constructor's $mode parameter.
Discussion
----------
Check that $mode is not below 1 to actually look if any of the flags are
Check that $mode is not below 1 to actually look if any of the flags are set.
I'm not sure if 0 must be allowed or not.
---------------------------------------------------------------------------
by fabpot at 2011/08/31 08:59:41 -0700
Can you squash your commit before I merge? Thanks.
---------------------------------------------------------------------------
by ktomk at 2011/08/31 15:25:05 -0700
Squashed and polished.
Commits
-------
6bd1749 Fixed a bug when multiple expanded choices would render unchecked because of the Form Framework's strict type checking.
Discussion
----------
[DoctrineBridge] Entities to array transformer
Fixed a bug when multiple expanded choices would render unchecked because of the Form Framework's strict type checking.
---------------------------------------------------------------------------
by fabpot at 2011/08/31 09:01:47 -0700
Looks good to me. Can you squash your commits before I merge? Thanks.
Commits
-------
0224a34 Fixes typo on ACL Doctrine cache.
Discussion
----------
[2.0] Impossible to use ACL provider cache
Using ACL provider cache is impossible. It's due to a typo in the configuration file (an undescore in place of a dot). My PR fixes this. Maybe add some tests to validate the ACL cache feature?
Check that $mode in InputArgument::__construct() is not below 1 to actually look if any of the flags are set.
Check that $mode in InputOption::__construct() is not below 1 to actually look if any of the flags are set.
Check for the correct parameter type, as in InputOption (integer).
InputArgumentTest: Added test for negative integer $mode parameter input in constructor.
InputOptionTest: Added test for negative integer $mode parameter input in constructor.
Commits
-------
f448029 [HttpKernel] Tweaked SQLite to speed up SqliteProfilerStorage
Discussion
----------
[HttpKernel] Tweaked SQLite to speed up SqliteProfilerStorage
See: http://stackoverflow.com/questions/6108602/avoiding-locked-sqlite-database-timeouts-with-php-pdo
This is the PR rebased for symfony/2.0 (the old PR was #1864)
---
Hi,
Here is a PR as discussed in issue #1856.
It solves a "fatal error" in the `SqliteProfilerStorage`.
I tested it all day long for real and it works fine.
Regards,
William
Commits
-------
eb8f3cb added uniqueEntity message translation (fr)
df9f223 added missing french translations
f4c133e removed trailing dot to make it consistent with other validator messages
Discussion
----------
[Translation] Unique Entity message
I've added the translation of uniqueEntity validation message, I've used ``trans-unit id="41"`` which seems to be unused
Commits
-------
2cfa22c Fix Method ContainerAwareEventDispatcher::hasListeners
Discussion
----------
Fix Method ContainerAwareEventDispatcher::hasListeners
Related to #1903.
This is the squashed on 2.0 branch version of the PR #1903
---
Fix Method ContainerAwareEventDispatcher::hasListeners
Fix the fact that Method ContainerAwareEventDispatcher::hasListeners return false if my service is not lazyLoaded
---------------------------------------------------------------------------
by cedriclombardot at 2011/08/31 01:40:45 -0700
@stof it's fixed
Doctrine caches annotations. For methods, it uses PHP reflection and the getDeclaringClass() to create
a unique cache key. Unfortunately, if you have 2 classes that extend another one, the cache will be shared.
It's not a problem except that before this patch, the default route name was also cached (as the cache is serialized
after we changed the object). So, all other classes inherited this default route name. The fix is quite easy:
just don't change the read annotation object.
From the PHP CHANGELOG:
The flag ENT_SUBSTITUTE makes invalid multibyte sequences be replaced by
U+FFFD (UTF-8) or &#FFFD; by htmlspecialchars and htmlentities. It is an
alternative to the default behavior, which just returns an empty string and to
ENT_IGNORE, which is a security risk. The behavior follows the recommendations
of Unicode Technical Report #36.
Commits
-------
ae3b128 [ClassLoader] Support for autoloading include_path incl. tests.
Discussion
----------
Autoload
GH Issue #1823
---------------------------------------------------------------------------
by stof at 2011/07/29 00:42:10 -0700
note that another fix was proposed in #1852 but this implementation is cleaner IMO
---------------------------------------------------------------------------
by henrikbjorn at 2011/08/12 01:57:45 -0700
@fabpot @stof any suggestions? need this kind of badly
---------------------------------------------------------------------------
by stof at 2011/08/12 02:06:54 -0700
for me it is fine. I guess you need to wait the end of @fabpot's holydays to see it merged.
---------------------------------------------------------------------------
by henrikbjorn at 2011/08/25 02:24:13 -0700
Added tests in the hope it will make it in soon :)
---------------------------------------------------------------------------
by henrikbjorn at 2011/08/29 03:31:08 -0700
Any other requests / suggestions ?
---------------------------------------------------------------------------
by stof at 2011/08/29 03:36:15 -0700
could you rebase the PR ? Github says that it conflicts.
---------------------------------------------------------------------------
by henrikbjorn at 2011/08/29 04:11:43 -0700
Should be rebased now or that is what git cli says :)
---------------------------------------------------------------------------
by henrikbjorn at 2011/08/29 04:16:28 -0700
And squashed.
Commits
-------
6278fcb -- add dumpers for translation component
Discussion
----------
[2.1] Add dumpers for translation catalogs
As seen here #1283, I push just the translation catalogs dumpers. It involved renaming and some essentially.
I also included a Pot dumper/loader that have been provided here : https://github.com/michelsalib/BCCExtraToolsBundle/pull/12.
---------------------------------------------------------------------------
by fabpot at 2011/08/28 11:12:30 -0700
Can you add the license header? and the main phpdoc block for each class?
---------------------------------------------------------------------------
by michelsalib at 2011/08/29 02:32:50 -0700
Done !
---------------------------------------------------------------------------
by fabpot at 2011/08/29 03:17:43 -0700
Last, but not the least, can you add some unit tests and squash all your commits? Thanks a lot.
---------------------------------------------------------------------------
by michelsalib at 2011/08/29 03:21:43 -0700
How do I squash it, should I make a new PR ?
---------------------------------------------------------------------------
by fabpot at 2011/08/29 03:25:09 -0700
No need to make a new PR, you can just force the push with `-f`.
---------------------------------------------------------------------------
by fabpot at 2011/08/29 03:33:59 -0700
Also, in the tests, it would great if you can add some that do a load/dump/load, just to be sure that everything work fine.
---------------------------------------------------------------------------
by michelsalib at 2011/08/29 03:39:41 -0700
What is the need of such a test, considering that the current tests that I am writing are using the same fixtures ?
---------------------------------------------------------------------------
by fabpot at 2011/08/29 03:47:50 -0700
The goal is to ensure that the load/dump calls are idempotent.
---------------------------------------------------------------------------
by michelsalib at 2011/08/29 03:56:12 -0700
Ye. Actually the load is using referenc files from the fixtures directory. My new tests will be using the dumper with the same files. Isn't that enough ? I try to stay DRY on this one.
---------------------------------------------------------------------------
by michelsalib at 2011/08/29 05:09:52 -0700
I just add unit tests and squash the commits.
I still need to be conviced about the load/dump/load unit tests. But if I did not made a point, I'll do as requested on next answer.