Commit Graph

25415 Commits

Author SHA1 Message Date
Fabien Potencier
097ce09140 security #24994 Prevent bundle readers from breaking out of paths (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

Prevent bundle readers from breaking out of paths

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

c8f9f916b4 prevent bundle readers from breaking out of paths
2017-11-16 17:15:44 +02:00
Fabien Potencier
0a1ea85998 security #24993 Ensure that submitted data are uploaded files (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

Ensure that submitted data are uploaded files

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

f9e210cc7b ensure that submitted data are uploaded files
2017-11-16 17:14:44 +02:00
Fabien Potencier
07fc11cd65 fixed CS 2017-11-16 17:13:44 +02:00
Fabien Potencier
b4dbdd7cd8 security #24992 Namespace generated CSRF tokens depending of the current scheme (dunglas)
This PR was merged into the 2.7 branch.

Discussion
----------

Namespace generated CSRF tokens depending of the current scheme

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

<!--
- Bug fixes must be submitted against the lowest branch where they apply
  (lowest branches are regularly merged to upper ones so they get the fixes too).
- Features and deprecations must be submitted against the master branch.
- Please fill in this template according to the PR you're about to submit.
- Replace this comment by a description of what your PR is solving.
-->

Commits
-------

cdb4271975 [Security] Namespace generated CSRF tokens depending of the current scheme
2017-11-16 17:12:07 +02:00
Kévin Dunglas
cdb4271975
[Security] Namespace generated CSRF tokens depending of the current scheme 2017-11-16 15:51:08 +02:00
Roland Franssen
278088931b Replace array|\Traversable by iterable 2017-11-16 13:37:27 +01:00
Christian Flothmann
f9e210cc7b ensure that submitted data are uploaded files 2017-11-16 09:58:50 +01:00
Robin Chalas
2c2253df8c minor #24962 [Console] remove dead code (Tobion)
This PR was merged into the 2.7 branch.

Discussion
----------

[Console] remove dead code

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Part of #24961 for 2.7

Commits
-------

65f2b13 [Console] remove dead code
2017-11-15 10:26:39 +01:00
Tobias Schultze
65f2b13e6b [Console] remove dead code 2017-11-13 22:35:01 +01:00
Fabien Potencier
49fe412ccc bumped Symfony version to 2.7.38 2017-11-13 11:29:05 -08:00
Anatol Belski
059f59a106 Fix ambiguous pattern 2017-11-13 20:26:33 +01:00
Fabien Potencier
c166da4131
Merge pull request #24955 from fabpot/release-2.7.37
released v2.7.37
2017-11-13 10:51:56 -08:00
Fabien Potencier
9a161068bc updated VERSION for 2.7.37 2017-11-13 10:51:22 -08:00
Fabien Potencier
2a70d55b9f updated CHANGELOG for 2.7.37 2017-11-13 10:51:16 -08:00
Nicolas Grekas
5fa5ef76b1 minor #24940 [Form] fix method name (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] fix method name

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

b862168 fix method name
2017-11-13 19:05:48 +01:00
Nicolas Grekas
70dd46ba93 bug #24952 [HttpFoundation] Fix session-related BC break (nicolas-grekas, sroze)
This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] Fix session-related BC break

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24941, #24934, #24947 and #24946
| License       | MIT
| Doc PR        | -

Conservative fix.

Commits
-------

38186aa [HttpFoundation] Add test
3eaa188 [HttpFoundation] Fix session-related BC break
2017-11-13 19:03:47 +01:00
Samuel ROZE
38186aab2f [HttpFoundation] Add test 2017-11-13 18:34:39 +01:00
Nicolas Grekas
3eaa18889c [HttpFoundation] Fix session-related BC break 2017-11-13 16:55:02 +01:00
Christian Flothmann
b862168cd0 fix method name 2017-11-13 06:34:51 +01:00
Fabien Potencier
99f8d85116 bug #24929 [Console] Fix traversable autocomplete values (ro0NL)
This PR was merged into the 2.7 branch.

Discussion
----------

[Console] Fix traversable autocomplete values

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

`Question::setAutocompleterValues` implies passing a `\Traversable` value is allowed, yet it doesnt work :) It also restricts the traversable to be countable, which is not really needed (blocking pure API / iterable type as of 4.0).

Commits
-------

965b5b5f8d [Console] Fix traversable autocomplete values
2017-11-12 08:02:36 -08:00
Fabien Potencier
cf78277f93 minor #24884 [ExpressionLanguage] Fixed PhpDoc type-hints on Token value (mcg-web)
This PR was merged into the 2.7 branch.

Discussion
----------

[ExpressionLanguage] Fixed PhpDoc type-hints on Token value

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

Fixed PhpDoc type-hints on Token value and added test to prevent BC with Parser when treating numbers (example `a === 123` compile as `$a === "123"`)

Commits
-------

18f0fc594d [ExpressionLanguage] Fix PhpDoc type-hints on Token value
2017-11-12 07:39:34 -08:00
Roland Franssen
965b5b5f8d [Console] Fix traversable autocomplete values 2017-11-11 23:09:14 +01:00
Jeremiah VALERIE
18f0fc594d
[ExpressionLanguage] Fix PhpDoc type-hints on Token value
Also added tests to cover number parser BC
2017-11-11 08:04:00 +01:00
Fabien Potencier
6fe8435c6f bumped Symfony version to 2.7.37 2017-11-10 11:52:56 -08:00
Fabien Potencier
93f88f5231
Merge pull request #24914 from fabpot/release-2.7.36
released v2.7.36
2017-11-10 11:43:19 -08:00
Fabien Potencier
12135adbd0 updated VERSION for 2.7.36 2017-11-10 11:43:01 -08:00
Fabien Potencier
0f8757e2e8 update CONTRIBUTORS for 2.7.36 2017-11-10 11:42:39 -08:00
Fabien Potencier
3de61a58aa updated CHANGELOG for 2.7.36 2017-11-10 11:42:31 -08:00
Fabien Potencier
f249310f30 bug #24888 [FrameworkBundle] Specifically inject the debug dispatcher in the collector (ogizanagi)
This PR was merged into the 2.7 branch.

Discussion
----------

[FrameworkBundle] Specifically inject the debug dispatcher in the collector

| Q             | A
| ------------- | ---
| Branch?       | 2.7 <!-- see comment below -->
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | N/A <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

This ensures we always collect data about events, even when the `event_dispatcher` service is decorated, no matter the decoration order.

Commits
-------

7b3a641acc [FrameworkBundle] Specifically inject the debug dispatcher in the collector
2017-11-10 10:29:29 -08:00
Fabien Potencier
2110dc3a70 bug #24909 [Intl] Update ICU data to 60.1 (jakzal)
This PR was squashed before being merged into the 2.7 branch (closes #24909).

Discussion
----------

[Intl] Update ICU data to 60.1

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

http://site.icu-project.org/download/60

All tests are passing, including those from the intl-data group.

Commits
-------

cf04e7cefe [Intl] Update ICU data to 60.1
2017-11-10 10:28:11 -08:00
Jakub Zalas
cf04e7cefe [Intl] Update ICU data to 60.1 2017-11-10 10:28:06 -08:00
Fabien Potencier
ae65bd8410 bug #24906 [Bridge/ProxyManager] Remove direct reference to value holder property (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Bridge/ProxyManager] Remove direct reference to value holder property

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23110
| License       | MIT
| Doc PR        | -

This fixes https://github.com/Ocramius/ProxyManager/issues/394 on Symfony's side, because proxy-manager v1 is not maintained anymore, but is the only one that works on PHP 5.3/5.5, which we still support.
Cannot be tested easily (but code is run by the existing test suite.)

Commits
-------

af9d6446ea [Bridge/ProxyManager] Remove direct reference to value holder property
2017-11-10 07:28:23 -08:00
Fabien Potencier
b1ad577263 bug #24900 [Validator] Fix Costa Rica IBAN format (Bozhidar Hristov)
This PR was squashed before being merged into the 2.7 branch (closes #24900).

Discussion
----------

[Validator] Fix Costa Rica IBAN format

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        | no

Fix Costa Rica IBAN format: https://bank.codes/iban/structure/costa-rica/

Commits
-------

b9b5e18f8b [Validator] Fix Costa Rica IBAN format
2017-11-10 07:11:42 -08:00
Bozhidar Hristov
b9b5e18f8b [Validator] Fix Costa Rica IBAN format 2017-11-10 07:11:41 -08:00
Fabien Potencier
470629045b bug #24904 [Validator] Add Belarus IBAN format (Bozhidar Hristov)
This PR was merged into the 2.7 branch.

Discussion
----------

[Validator] Add Belarus IBAN format

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | no
| License       | MIT
| Doc PR        | no

Add missing Belarus IBAN format - https://bank.codes/iban/structure/belarus/

Commits
-------

128f2fa14e [Validator] Add Belarus IBAN format
2017-11-10 07:10:39 -08:00
Nicolas Grekas
af9d6446ea [Bridge/ProxyManager] Remove direct reference to value holder property 2017-11-10 14:01:38 +01:00
Bozhidar Hristov
128f2fa14e [Validator] Add Belarus IBAN format 2017-11-10 14:40:09 +02:00
Maxime Steinhausser
7b3a641acc [FrameworkBundle] Specifically inject the debug dispatcher in the collector 2017-11-09 18:29:09 +01:00
Robin Chalas
85f7cc8d0a minor #24869 update the pull request template (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

update the pull request template

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

a64f7c1 update the pull request template
2017-11-08 15:02:49 +01:00
Christian Flothmann
a64f7c1350 update the pull request template 2017-11-08 11:12:35 +01:00
Nicolas Grekas
5420cfca36 [Stopwatch] minor fix 2017-11-07 15:25:27 +01:00
Nicolas Grekas
1e0f2267bb minor #24857 [2.7] More docblock fixes (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[2.7] More docblock fixes

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

ac671ac [2.7] More docblock fixes
2017-11-07 15:08:02 +01:00
Nicolas Grekas
ac671ac68c [2.7] More docblock fixes 2017-11-07 15:04:08 +01:00
Nicolas Grekas
4371d03d61 minor #24854 Docblock fixes (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

Docblock fixes

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Commits
-------

b56bfe7 Docblock fixes
2017-11-07 12:56:10 +01:00
Nicolas Grekas
b56bfe7d8a Docblock fixes 2017-11-07 12:54:30 +01:00
Nicolas Grekas
52b06f1c21 [Security] Validate redirect targets using the session cookie domain 2017-11-06 18:06:45 +01:00
Nicolas Grekas
ff58ec865c bug #24531 [HttpFoundation] Fix forward-compat of NativeSessionStorage with PHP 7.2 (sroze)
This PR was merged into the 2.7 branch.

Discussion
----------

[HttpFoundation] Fix forward-compat of NativeSessionStorage with PHP 7.2

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24524
| License       | MIT
| Doc PR        | ø

PHP 7.2 disallow setting session options when the session was already started. This PR will not set any option if the session is already started and throw an exception if trying to do so with custom options.

Commits
-------

00a1357 [HttpFoundation] Fix forward-compat of NativeSessionStorage with PHP 7.2
2017-11-05 20:04:12 +01:00
Samuel ROZE
00a1357d82 [HttpFoundation] Fix forward-compat of NativeSessionStorage with PHP 7.2 2017-11-05 19:48:11 +01:00
Fabien Potencier
efb4891981 minor #24666 [WebProfilerBundle] add missing tests (mhujer)
This PR was squashed before being merged into the 2.7 branch (closes #24666).

Discussion
----------

[WebProfilerBundle] add missing tests

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT

This PR fixes one test in WebDebugToolbarListenerTest and adds one that was missing (more detailed description is available in the commits description)

Commits
-------

363d3a8cf2 [WebProfilerBundle] add missing tests
2017-11-05 08:07:30 -08:00
Martin Hujer
363d3a8cf2 [WebProfilerBundle] add missing tests 2017-11-05 08:07:08 -08:00