This PR was squashed before being merged into the 5.2 branch.
Discussion
----------
[Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix [#42076](https://github.com/symfony/symfony/issues/42076)
| License | MIT
When a command extends a class wich implements SignalableCommandInterface but the command has empty signals to dispatch, it still can be executed, It can be useful when the extension is not available and the command is necessary.
Also, it can be used like a workaround for support other environments, for example windows servers, they don't have pcntl extension
Commits
-------
ad63d0b553 [Console] Run commands when implements SignalableCommandInterface without pcntl and they have'nt signals
This PR was merged into the 4.4 branch.
Discussion
----------
[Form] Fix 'invalid_message' use in multiple ChoiceType
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41422
| License | MIT
| Doc PR |
Commits
-------
4f2b492166 [Form] Fix 'invalid_message' use in multiple ChoiceType
This PR was merged into the 4.4 branch.
Discussion
----------
[Form] fix some type annotations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Backported from #41998
The change in `FormValidator` is likely a bug fix, but it could be an incomplete one.
`testFieldsValidateInSequenceWithNestedGroupsArray` triggers a call to `getConstraintsInGroups` with an array.
I'd appreciate if `@HeahDude`, `@xabbuh`, or anyone with a better knowledge of Form could have a look please.
Commits
-------
e49441d5c2 [Form] fix some type annotations
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] Allow passing a previous throwable to exceptions
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
It should always be possible to pass a a previous throwable to a new exception. This PR streamlines the constructors of the Notifier component's exception classes.
Commits
-------
e1973089d8 [Notifier] Allow passing a previous throwable to exceptions
This PR was squashed before being merged into the 5.2 branch.
Discussion
----------
[Notifier] Make sure Http TransportException is not leaking
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
We dont want the notifier to throw exceptions from the http-client component. This will make sure to catch such exceptions and rethrow the proper TransportException from the Notifier component.
Commits
-------
1eed48892d [Notifier] Make sure Http TransportException is not leaking
This PR was merged into the 5.2 branch.
Discussion
----------
[Notifier] Make sure Smsapi 5.2 has a changelog
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Im not sure what the best way to fix this issue is. The smsapi bridge was released in 5.2 without a changelog. In 5.3 we added a changelog and incorrectly stated that the package was first released in 5.3.
Related PR: #39557
Packagist: https://packagist.org/packages/symfony/smsapi-notifier
This PR adds the changelog for 5.2 and I hope the maintainer that do the merge up handles the conflict correctly.
Commits
-------
984e890efb Make sure Smsapi 5.2 has a changelog
This PR was merged into the 5.2 branch.
Discussion
----------
[Messenger] [Redis] Fix auth option wrongly considered invalid
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Will also make the CI back to green on 5.2.
Commits
-------
8bc6ee52fc [Messenger][Redis] Fix auth option wrongly considered invalid
This PR was merged into the 5.2 branch.
Discussion
----------
[Cache] Don't use deprecated TestLogger class
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
`TestLogger` has been removed with `psr/log` 2. I'm replacing it with a local implementation to make our tests pass again.
Commits
-------
3ea73c7b1d Don't use deprecated TestLogger class
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
Simplify some code with null coalesce operator
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
For your consideration. There are many other possible usages of null coalesce operator, but the result is not very readable ... so this PR only contains the changes where the result is clearly better.
Commits
-------
17ad5b75fa Simplify some code with null coalesce operator
This PR was merged into the 4.4 branch.
Discussion
----------
Indicate compatibility with psr/log 2 and 3
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Versions 2 and 3 of the PSR-3 interfaces have been published and most of our components are already compatible.
Commits
-------
d2209ec8dd Indicate compatibility with psr/log 2 and 3
This PR was merged into the 4.4 branch.
Discussion
----------
[CI] Fix wrongly skipped integration tests
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
The integration tests from bridges located in components (e.g. `Notifier/Bridge/Discord/Tests` or `Messenger/Bridge/Redis/Tests`) were excluded from the CI.
Spotted while working on #42163 - Some redis-messenger tests are currently broken on 5.x, which we didn't spot because of the missing entry in the phpunit config.
Commits
-------
438a503cad [ci] Fix wrongly skipped integration tests
This PR was merged into the 5.2 branch.
Discussion
----------
[Form] backport type fixes
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Backported from #41998
Commits
-------
75691c64d1 [Form] backport type fixes
This PR was merged into the 4.4 branch.
Discussion
----------
Optimized some strlen() calls when possible
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Done with PhpStorm refactoring tools and only when it's safe to do.
Commits
-------
53aaa9ef7d Optimized some strlen() calls when possible
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
Use is_iterable() function when possible
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
PHP added `is_iterable()` in PHP 7.1.0 (see https://www.php.net/manual/en/function.is-iterable.php) and Symfony 4.4 requires `>=7.1.3`, so maybe we can use this function to simplify some code.
Commits
-------
6919c1317d Use is_iterable() function when possible
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Add German expression language syntax constraint violation message
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
Commits
-------
1d6d57d179 Add German expression language syntax constraint violation message
This PR was merged into the 5.2 branch.
Discussion
----------
[RateLimiter] Remove redundant properties
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
Backported from #42140: Those three classes use `ResetLimiterTrait` and redeclare the properties that the trait already provides. This PR removes that redundancy.
Commits
-------
587d99f44a [RateLimiter] Remove redundant properties
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[HttpFoundation] fix FileBag under PHP 8.1
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no<!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | Fix #... <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License | MIT
| Doc PR | symfony/symfony-docs#... <!-- required for new features -->
See https://php.watch/versions/8.1/$_FILES-full-path - in \Symfony\Component\HttpFoundation\FileBag::convertFileInformation() we check against a list of hardcoded keys. This logic breaks in PHP 8.1 because of the new key.
Commits
-------
dc3504989b [HttpFoundation] fix FileBag under PHP 8.1
alireza
Nyholm
Vasilij Dusko
Nicolas Grekas
PaoRuby
Alexandre Daubois
Oskar Stark
Alexander M. Turek
Robin Chalas
Javier Eguiluz
Tobias Schultze
Christian Flothmann
Alex Pott