Benjamin Eberlei
b43318ee3e
[Form] Add tests for untested classes.
2011-03-19 22:03:49 +01:00
Benjamin Eberlei
d62213662e
Merge branch 'experimental' of git://github.com/bschussek/symfony into forms
2011-03-19 20:36:56 +01:00
Benjamin Eberlei
864a3ec45f
[Form] Add StripTagsFilter EventListener
2011-03-19 20:36:49 +01:00
Bernhard Schussek
6793bcd698
[Form] Removed magic from method signature of add()
2011-03-19 19:20:55 +01:00
Bernhard Schussek
c4b7a77ece
Merge remote branch 'beberlei/forms' into beberlei-merge
...
Conflicts:
src/Symfony/Component/Form/Type/Loader/DefaultTypeLoader.php
2011-03-19 19:01:57 +01:00
Benjamin Eberlei
39c2d3f166
[Form] Add PhpTheme that relies on no Template Engine, generalize tests to use for PhpTheme and PhpEngineTheme. Fixed some bugs
2011-03-19 17:47:18 +01:00
Bernhard Schussek
43a24fa931
[Form] Renamed events to match terminology in Field
2011-03-19 16:59:23 +01:00
Bernhard Schussek
7f9284105d
[Form] Moved namespace FieldGuesser to Type\Guesser
2011-03-19 16:46:03 +01:00
Bernhard Schussek
89215d167d
Merge remote branch 'symfony/master' into experimental
2011-03-19 13:25:41 +01:00
Fabien Potencier
510c30693b
[HttpFoundation] fixed a test
2011-03-19 12:29:23 +01:00
everzet
3fd50ea4e6
[Routing] throw an exception if route config has unsupported keys
2011-03-19 12:54:29 +02:00
Kris Wallsmith
e596931dc8
[DomCrawler] enabled removal of form fields to allow emulating javascript in a functional test
2011-03-18 09:39:08 -07:00
Bernhard Schussek
6bc79a1a12
[Form] Renamed different kinds of data transformers within a field for better clarity
2011-03-18 16:59:34 +01:00
Bernhard Schussek
2a1e394352
[Form] Renamed field configs to types. Everywhere else, we are referring to the name of the type as 'type' now (was 'identifier')
2011-03-18 16:20:00 +01:00
Bernhard Schussek
0b929ee342
[Form] Renamed ValueTransformers to DataTransformers to fit with DataMapper and DataValidator
2011-03-18 16:01:06 +01:00
Bernhard Schussek
97d0183d84
[Form] Moved properties propertyPath, modifyByReference, validationGroups and virtual to generic attributes because they are specific to the used data validator/mapper implementations
2011-03-18 15:26:02 +01:00
Bernhard Schussek
700c96e7fa
[Form] Moved FieldFactoryTest to FormFactoryTest and fixed it
2011-03-18 14:37:54 +01:00
Bernhard Schussek
9caaf0f3a3
[Form] Introduced FieldBuilder for field/form creation and made Field/Form mostly immutable
2011-03-18 12:50:26 +01:00
Fabien Potencier
f0c558592c
Merge remote branch 'everzet/console-formatter-refactoring'
2011-03-18 11:58:05 +01:00
Fabien Potencier
3627eee3c6
Merge remote branch 'vicb/cfg_rebase'
...
* vicb/cfg_rebase:
[Config] Ability to add and override node types without having to subclass NodeBuilder
[DoctrineBundle] Fix some typos
[SwiftMailerBundle] Fix a merge issue in the configuration
Tweak PHPDocs in the extension configuration files
[Config] Component refactoring
2011-03-18 11:41:43 +01:00
Bernhard Schussek
3f70f89339
Merge remote branch 'symfony/master' into experimental
...
Conflicts:
src/Symfony/Bundle/FrameworkBundle/Debug/TraceableEventDispatcher.php
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
src/Symfony/Component/HttpFoundation/File/UploadedFile.php
2011-03-18 10:39:40 +01:00
Fabien Potencier
136b23ead4
[EventDispatcher] refactored the code
...
* The array returned by getListeners() now removes the listener hash as the key (as this is an implementation detail)
* The sort method now guarantees that a listener registered before another will stay in the same order even for the same priority (for BC)
* Made various optimizations
2011-03-18 09:01:22 +01:00
Fabien Potencier
69d324eca8
[EventDispatcher] added EventDispatcher::removeSubscriber()
2011-03-18 09:00:58 +01:00
Fabien Potencier
9e88fc4e66
Merge remote branch 'kriswallsmith/kernel/uploaded-file-for-test'
2011-03-18 08:02:16 +01:00
Victor Berchet
9fd7d05ecf
[Config] Ability to add and override node types without having to subclass NodeBuilder
2011-03-18 00:32:35 +01:00
Kris Wallsmith
0a229947a6
[Form] updated tests for changes in HttpFoundation
2011-03-17 16:09:12 -07:00
Kris Wallsmith
ab3b8ac364
[HttpFoundation] cleaned up comments and coding standards, added better exception messages when filesystem functions throw errors, added "moved" arg to UploadedFile constructor, added FileNotFoundException to UploadedFile per the parent constructor
2011-03-17 16:07:53 -07:00
Kris Wallsmith
69609257ac
[DomCrawler] updated upload logic to better emulate a real upload by copying the source file to the temp directory
2011-03-17 16:06:47 -07:00
Bernhard Schussek
a51321c264
[Form] Moved validation logic to ValidationListener
2011-03-17 21:47:12 +01:00
Bernhard Schussek
0799662361
[Form] Extracted data mapping logic from Form into ObjectMapperListener
2011-03-17 21:23:59 +01:00
Fabien Potencier
6c8e71c8e7
renamed filterCore* to onCore*
...
The onCore* events are fired at some pre-defined points during the
handling of a request. At this is more important than the fact
that you can change things from the event.
2011-03-17 17:01:59 +01:00
ever.zet
8b55c239a2
[Console] updated output tests after formatter adding
2011-03-17 17:53:28 +02:00
ever.zet
4fe2efd49e
[Console] implemented output formatter to decorate and format output messages
2011-03-17 17:51:49 +02:00
ever.zet
e5700b817b
[Console] implemented output formatter style class for defining custom styles
2011-03-17 17:51:25 +02:00
Victor Berchet
1e0ed22c55
[Config] Component refactoring
...
The Config component API have changed and the extension configuration files must be updated accordingly:
1. Array nodes must enclosed their children definition in ->children() ... ->end() calls:
Before:
$treeBuilder->root('zend', 'array')
->arrayNode('logger')
->scalarNode('priority')->defaultValue('INFO')->end()
->booleanNode('log_errors')->defaultFalse()->end()
->end();
After:
$treeBuilder->root('zend', 'array')
->children()
->arrayNode('logger')
->children()
->scalarNode('priority')->defaultValue('INFO')->end()
->booleanNode('log_errors')->defaultFalse()->end()
->end()
->end()
->end();
2. The 'builder' method (in NodeBuilder) has been dropped in favor of an 'append' method (in ArrayNodeDefinition)
Before:
$treeBuilder->root('doctrine', 'array')
->arrayNode('dbal')
->builder($this->getDbalConnectionsNode())
->end();
After:
$treeBuilder->root('doctrine', 'array')
->children()
->arrayNode('dbal')
->append($this->getDbalConnectionsNode())
->end()
->end();
3. The root of a TreeBuilder is now an NodeDefinition (and most probably an ArrayNodeDefinition):
Before:
$root = $treeBuilder->root('doctrine', 'array');
$this->addDbalSection($root);
public function addDbalSection(NodeBuilder $node)
{
...
}
After:
$root = $treeBuilder->root('doctrine', 'array');
$this->addDbalSection($root);
public function addDbalSection(ArrayNodeDefinition $node)
{
...
}
4. The NodeBuilder API has changed (this is seldom used):
Before:
$node = new NodeBuilder('connections', 'array');
After:
The recommended way is to use a tree builder:
$treeBuilder = new TreeBuilder();
$node = $treeBuilder->root('connections', 'array');
An other way would be:
$builder = new NodeBuilder();
$node = $builder->node('connections', 'array');
Some notes:
- Tree root nodes should most always be array nodes, so this as been made the default:
$treeBuilder->root('doctrine', 'array') is equivalent to $treeBuilder->root('doctrine')
- There could be more than one ->children() ... ->end() sections. This could help with the readability:
$treeBuilder->root('doctrine')
->children()
->scalarNode('default_connection')->end()
->end()
->fixXmlConfig('type')
->children()
->arrayNode('types')
....
->end()
->end()
2011-03-17 16:26:15 +01:00
Fabien Potencier
1219b98ec5
renamed some methods in the event dispatcher
2011-03-17 15:27:42 +01:00
Bernhard Schussek
7a63b840f3
[Form] Renamed submit() to bind()
2011-03-17 14:55:26 +01:00
Bernhard Schussek
5bfd02bcd0
[Form] Renamed bind() to bindRequest(). It is now semantically the same as in symfony1 again
2011-03-17 14:51:22 +01:00
Bernhard Schussek
ffa5bd264a
[Form] Moved logic of Field::isMultipart() to rendering layer
2011-03-17 14:40:34 +01:00
Bernhard Schussek
50ce0d53a0
[Form] Removed FieldInterface::getDisplayedData(). Use getTransformedData() instead
2011-03-17 14:28:59 +01:00
Bernhard Schussek
f0d841ef8c
[Form] Fixed DateTimeToArrayTransformer when transforming empty values and the option 'fields' is set
2011-03-17 14:27:10 +01:00
Bernhard Schussek
1c9a00733f
Merge branch 'event-manager' into experimental
...
Conflicts:
src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php
src/Symfony/Component/Security/Http/Firewall/AbstractPreAuthenticatedListener.php
2011-03-17 13:38:24 +01:00
Bernhard Schussek
466f1b99c5
[Security] Fixed method names in the Firewall listeners
2011-03-17 13:24:23 +01:00
Bernhard Schussek
5f14d8d6aa
Merge remote branch 'symfony/master' into event-manager
...
Conflicts:
src/Symfony/Bundle/AsseticBundle/CacheWarmer/AssetWriterCacheWarmer.php
src/Symfony/Bundle/AsseticBundle/Tests/CacheWarmer/AssetWriterCacheWarmerTest.php
src/Symfony/Bundle/FrameworkBundle/Profiler/ProfilerListener.php
src/Symfony/Bundle/FrameworkBundle/Resources/config/profiling.xml
src/Symfony/Component/HttpKernel/HttpKernel.php
src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php
src/Symfony/Component/Security/Http/Firewall/AbstractPreAuthenticatedListener.php
2011-03-17 12:34:12 +01:00
Fabien Potencier
c5c8e57754
[Locale] updated the tests so that we can be green again (previous version always add 2 skipped tests)
2011-03-17 12:20:37 +01:00
Bernhard Schussek
73464f411e
Merge remote branch 'Infranology/intl-stub' into intl-stub
2011-03-17 11:20:52 +01:00
Bernhard Schussek
f966c30c8b
Merge remote branch 'symfony/master' into intl-stub
2011-03-17 11:20:25 +01:00
Bernhard Schussek
cb283d3783
[Form] Renamed 'key' to 'name'. Removed setKey() totally.
2011-03-17 11:03:10 +01:00
Fabien Potencier
7edb1a5f13
fixed previous commit
2011-03-16 21:39:30 +01:00
Bernhard Schussek
e85aab2dc1
[Form] Changed form to use the new EventDispatcher implementation
2011-03-16 18:20:13 +01:00
Fabien Potencier
005287ac88
Merge remote branch 'kriswallsmith/templating/asset-packages'
2011-03-16 16:18:45 +01:00
Bernhard Schussek
fb8efaba67
[Form] Fixed a couple of failing tests
2011-03-16 16:13:06 +01:00
Fabien Potencier
bf938cc885
Merge remote branch 'rrehbeindoi/master'
2011-03-16 16:03:14 +01:00
Bernhard Schussek
f64f55002b
Merge remote branch 'symfony/master' into experimental
...
Conflicts:
src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php
src/Symfony/Component/Security/Http/Firewall/AbstractPreAuthenticatedListener.php
2011-03-16 16:00:54 +01:00
Fabien Potencier
8cc37eaa23
[HttpKernel] fixed CS
2011-03-16 15:16:21 +01:00
Fabien Potencier
f9d2f69ca8
Merge remote branch 'janschumann/mysql_profiler_storage'
2011-03-16 15:09:07 +01:00
Ray
73f70ae53c
Merge remote branch 'symfony/master'
2011-03-16 09:00:13 -05:00
Ray
e83629139c
Added matching test to mirror the xml file loader test
2011-03-16 08:56:26 -05:00
Fabien Potencier
ac49289451
Merge remote branch 'rrehbeindoi/master'
2011-03-16 14:44:44 +01:00
Kris Wallsmith
a5d8770a54
[HttpFoundation] fixed ApacheRequest, added tests
2011-03-16 06:13:01 -07:00
Ray
c2908cdaa0
Allow collection's internal keys to be mixed case
2011-03-15 09:35:40 -05:00
Jan Schumann
d1ebc8da9f
- Added abstract PDO profiler storage, updated sqlite storage and added a mysql storage.
...
- Updated profiler config in framework bundle
2011-03-15 14:08:43 +01:00
Fabien Potencier
e5fad94482
[HttpKernel] fixed a unit test
2011-03-15 13:43:45 +01:00
Johannes M. Schmitt
98216a9af2
[DependencyInjection] refactored some more exceptions
2011-03-14 21:14:49 +01:00
Johannes M. Schmitt
4539b47522
[Security] small performance optimization
2011-03-14 17:41:33 +01:00
Eriksen Costa
157f001253
Merge remote branch 'bschussek/intl-stub' into intl-stub
2011-03-13 21:50:25 -03:00
Eriksen Costa
9c6ccd8290
[Locale] replaced symfony-project.org by symfony.com
2011-03-13 21:22:11 -03:00
Eriksen Costa
50aee60e9b
Merge branch 'master' into intl-stub
2011-03-13 21:20:57 -03:00
Bernhard Schussek
0bf566310c
Merge branch 'event-manager' into experimental
...
Conflicts:
src/Symfony/Component/Form/BirthdayField.php
src/Symfony/Component/Form/CheckboxField.php
src/Symfony/Component/Form/ChoiceField.php
src/Symfony/Component/Form/ChoiceList/TimeZoneChoiceList.php
src/Symfony/Component/Form/CollectionField.php
src/Symfony/Component/Form/DateField.php
src/Symfony/Component/Form/DateTimeField.php
src/Symfony/Component/Form/EntityChoiceField.php
src/Symfony/Component/Form/Events.php
src/Symfony/Component/Form/FieldFactory/FieldFactory.php
src/Symfony/Component/Form/FieldFactory/FieldFactoryInterface.php
src/Symfony/Component/Form/FileField.php
src/Symfony/Component/Form/Filters.php
src/Symfony/Component/Form/FormContext.php
src/Symfony/Component/Form/FormContextInterface.php
src/Symfony/Component/Form/FormFactoryInterface.php
src/Symfony/Component/Form/HybridField.php
src/Symfony/Component/Form/IntegerField.php
src/Symfony/Component/Form/LanguageField.php
src/Symfony/Component/Form/LocaleField.php
src/Symfony/Component/Form/MoneyField.php
src/Symfony/Component/Form/NumberField.php
src/Symfony/Component/Form/PasswordField.php
src/Symfony/Component/Form/PercentField.php
src/Symfony/Component/Form/RepeatedField.php
src/Symfony/Component/Form/TextField.php
src/Symfony/Component/Form/TimeField.php
src/Symfony/Component/Form/ToggleField.php
src/Symfony/Component/Form/UrlField.php
src/Symfony/Component/HttpFoundation/File/UploadedFile.php
tests/Symfony/Tests/Component/Form/FileFieldTest.php
tests/Symfony/Tests/Component/Form/FormContextTest.php
tests/Symfony/Tests/Component/Form/HiddenFieldTest.php
2011-03-13 21:04:24 +01:00
Bernhard Schussek
06c682b4fb
Switched from Doctrine's EventManager implementation to the EventManager clone in Symfony2 (now called EventDispatcher again)
2011-03-13 19:49:10 +01:00
Bernhard Schussek
699e046b4f
[EventDispatcher] Replaced EventDispatcher by Doctrine's implementation
2011-03-13 19:15:38 +01:00
Bernhard Schussek
25931caeab
Merge remote branch 'symfony/master' into event-manager
...
Conflicts:
src/Symfony/Bundle/FrameworkBundle/Debug/TraceableEventManager.php
src/Symfony/Bundle/WebProfilerBundle/WebDebugToolbarListener.php
src/Symfony/Component/Security/Http/Firewall.php
src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php
src/Symfony/Component/Security/Http/Firewall/AbstractPreAuthenticatedListener.php
src/Symfony/Component/Security/Http/Firewall/AccessListener.php
src/Symfony/Component/Security/Http/Firewall/AnonymousAuthenticationListener.php
src/Symfony/Component/Security/Http/Firewall/BasicAuthenticationListener.php
src/Symfony/Component/Security/Http/Firewall/ChannelListener.php
src/Symfony/Component/Security/Http/Firewall/ContextListener.php
src/Symfony/Component/Security/Http/Firewall/DigestAuthenticationListener.php
src/Symfony/Component/Security/Http/Firewall/ExceptionListener.php
src/Symfony/Component/Security/Http/Firewall/ListenerInterface.php
src/Symfony/Component/Security/Http/Firewall/LogoutListener.php
src/Symfony/Component/Security/Http/Firewall/RememberMeListener.php
src/Symfony/Component/Security/Http/Firewall/SwitchUserListener.php
tests/Symfony/Tests/Component/Security/Http/Firewall/RememberMeListenerTest.php
2011-03-13 19:15:25 +01:00
Artur Kotyrba
3f73a748a9
[Routing] Fixed compiling routes with empty string or 0 as default parameter value.
2011-03-13 18:13:41 +01:00
Pascal Borreli
fb33358d20
[Security] Fixed test
2011-03-12 16:17:42 -08:00
Fabien Potencier
411a382d80
[Serializer] fixed XmlEncoder for single char tags
2011-03-12 15:23:30 +01:00
Johannes Schmitt
70867f06e9
re-added a __toString method for debugging purposes
2011-03-12 13:24:57 +01:00
ever.zet
5ec8f47d7c
if proper style not found, then this is a tag - no need in Exception
2011-03-12 11:55:44 +02:00
ever.zet
9cc3e1bd87
added ability to clear TestConsole
2011-03-12 11:55:01 +02:00
Fabien Potencier
bc6ffeef83
[HttpFoundation] fixed flash management
2011-03-11 20:23:17 +01:00
Fabien Potencier
a1fcbf4d5f
Merge remote branch 'kriswallsmith/dic/false-circular-ref-fix'
...
* kriswallsmith/dic/false-circular-ref-fix:
[DependencyInjection] fixed false positive when detecting circular references if a service throws an exception during creation
2011-03-11 19:58:54 +01:00
Fabien Potencier
cedf588e98
Revert "Merge remote branch 'kriswallsmith/dic/lazy-replace-ext-params'"
...
This reverts commit 32ac2e8709
, reversing
changes made to 6e81c28ca4
.
2011-03-11 15:35:09 +01:00
Fabien Potencier
f321fadad6
[DependencyInjection] moved most protected things to private
2011-03-11 14:50:46 +01:00
Fabien Potencier
a8d05746ff
Merge remote branch 'schmittjoh/propertyAnnotations'
...
* schmittjoh/propertyAnnotations:
[DependencyInjection] added some tests
[DependencyInjection] adds property injection
2011-03-11 13:12:12 +01:00
Fabien Potencier
ad36ce7b38
Merge remote branch 'schmittjoh/security'
...
* schmittjoh/security:
[Security] fixed some tests
[SecurityBundle] removed the option to declare access_control rules based on request attributes
[Security] removed core.security event
[Security] refactored remember-me code
2011-03-11 13:08:37 +01:00
Fabien Potencier
b940cc6f40
moved most protected to private in the Console component
2011-03-11 12:53:42 +01:00
Johannes Schmitt
97125269d2
[Security] fixed some tests
2011-03-11 12:50:52 +01:00
Fabien Potencier
c2e9dd27b2
[Console] fixed synopsis when an error occurs
2011-03-11 11:51:05 +01:00
Fabien Potencier
32ac2e8709
Merge remote branch 'kriswallsmith/dic/lazy-replace-ext-params'
...
* kriswallsmith/dic/lazy-replace-ext-params:
[DependencyInjection] added test for lazy param replacement
Removed replacement of parameter placeholders at load time since they're now replaced at compile time. Extensions should be written to expect parameter placeholders.
2011-03-11 10:41:22 +01:00
Amal Raghav
2d1ef129b2
Updated tests for ResolveDefinitionTemplatesPass
2011-03-11 10:36:48 +01:00
Johannes M. Schmitt
3d97638813
[Security] refactored remember-me code
2011-03-11 01:19:55 +01:00
Kris Wallsmith
6385431a2d
[DependencyInjection] added test for lazy param replacement
2011-03-10 13:24:14 -08:00
Johannes M. Schmitt
d9848f38ac
[DependencyInjection] added some tests
2011-03-10 15:31:00 +01:00
Johannes M. Schmitt
13665fc113
[Security] added some more tests
2011-03-10 10:25:33 +01:00
Johannes Schmitt
1d5538fc60
[Security] various changes, see below
...
- visibility changes from protected to private
- AccountInterface -> UserInterface
- SecurityContext::vote() -> SecurityContext::isGranted()
2011-03-10 10:25:32 +01:00
Fabien Potencier
0a1c3c7285
Merge remote branch 'digitalkaoz/httpkernel-bundle'
...
* digitalkaoz/httpkernel-bundle:
[HttpKernel] added tests for Bundle
2011-03-09 21:48:37 +01:00
Fabien Potencier
72586b2d5f
Merge remote branch 'opensky/hotfix/test_client'
...
* opensky/hotfix/test_client:
[HttpKernel] added test for uri change
[HttpKernel] got rid of url transformation into uri, as parse_url doesn't work with uris
2011-03-09 21:46:16 +01:00
Bulat Shakirzyanov
e95bb73335
[HttpKernel] added test for uri change
2011-03-09 13:48:41 -05:00
Fabien Potencier
57245517ab
Merge remote branch 'Seldaek/test_fix'
...
* Seldaek/test_fix:
[Config] fix test on windows
2011-03-09 17:26:55 +01:00
Fabien Potencier
1fe25bc00a
Merge remote branch 'Seldaek/file_field'
...
* Seldaek/file_field:
[HttpFoundation] Fixed test breaking on windows
[HttpFoundation] UploadedFile::getOriginalName is now overriding getName
[HttpFoundation] Minor optimization
[Form] Add exception for missing enctype attribute
2011-03-09 17:26:51 +01:00
Jordi Boggiano
30a8f4fd42
[HttpFoundation] Fixed test breaking on windows
2011-03-09 17:26:11 +01:00
Jordi Boggiano
991b1ed225
[HttpFoundation] UploadedFile::getOriginalName is now overriding getName
2011-03-09 17:26:08 +01:00
Fabien Potencier
17ef911f19
[Routing] removed the normalizeUrl() method and renamed url to pathinfo as this is more correct
2011-03-09 17:25:44 +01:00
Jordi Boggiano
88cfc4c011
[Form] Add exception for missing enctype attribute
2011-03-09 17:23:21 +01:00
Jordi Boggiano
2ffa8521b5
[Config] fix test on windows
2011-03-09 17:22:43 +01:00
Jordi Boggiano
4c0ea6179b
[Routing] UrlMatcher shouldn't collapse multiple slashes
...
* fixes a problem with security (/foo/bar and /foo///bar are not the same URL as far as security is concerned)
* this can still be done in your web server configuration or by adding a core.request listener
2011-03-09 17:07:12 +01:00
Kris Wallsmith
8c45a21637
[DependencyInjection] fixed false positive when detecting circular references if a service throws an exception during creation
2011-03-09 06:38:02 -08:00
Bernhard Schussek
0eb04e487d
Merge remote branch 'Infranology/intl-stub' into intl-stub
2011-03-09 12:04:51 +01:00
Bernhard Schussek
8658287ed6
Merge branch 'master' into intl-stub
2011-03-09 12:02:35 +01:00
Eriksen Costa
b5622f3c77
[Locale] fixed typo
2011-03-08 17:00:32 -03:00
Kris Wallsmith
e273a709f1
[Templating] introduced concept of asset packages so base URLs and asset versions can be set more granularly
2011-03-08 08:31:39 -08:00
Fabien Potencier
8716c2ad1e
merged
2011-03-08 15:43:02 +01:00
Bernhard Schussek
2cf3779a2c
Renamed EventArgs classes and adapted remaining code to EventManager
...
The only missing part is ContainerAwareEventManager::addEventSubscriberService(),
because I'm not sure how to find out the class name of a service in the DIC.
Also, inline documentation of this code needs to be finished once it is accepted.
2011-03-07 19:16:05 +01:00
Eriksen Costa
0be12d7a89
[Locale] skip test if intl extension is not loaded
2011-03-07 03:19:47 -03:00
Eriksen Costa
d8e35a2f5c
[Locale] added tests to document behavior not implemented by StubIntlDateFormatter::parse()
2011-03-07 03:07:18 -03:00
Eriksen Costa
0a577e6fce
[Locale] added more tests to time zone parsing with AM/PM markers
2011-03-07 03:07:17 -03:00
Eriksen Costa
d2df09f744
[Locale] refactored time zone support
2011-03-07 03:07:12 -03:00
Kris Wallsmith
2d1d2ba893
[Security] cleaned up opt-in to benchmark test
2011-03-06 20:06:13 +01:00
Robert Schönthal
8caa5dfdb9
[HttpKernel] added tests for Bundle
2011-03-06 15:15:36 +01:00
Fabien Potencier
8c423edfef
replaced symfony-project.org by symfony.com
2011-03-06 12:40:06 +01:00
Fabien Potencier
a137d72351
Merge remote branch 'hhamon/cookie_path_fix'
...
* hhamon/cookie_path_fix:
[Security] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[HttpKernel] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[BrowserKit] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[HttpFoundation] fix cookie path default value to / and added some new unit tests to cover the class
2011-03-06 10:44:40 +01:00
Fabien Potencier
487cddcfee
Merge remote branch 'DuoSRX/code-coverage'
...
* DuoSRX/code-coverage:
[HttpFoundation] Fixed a typo in response->setLastModified()
[HttpFoundation] Added some more tests on response
[HttpFoundation] Added some tests on Response
[HttpFoundation] Replace a duplicated test with a method in Response
Fixed code coverage generation when resources folder are deeper
2011-03-06 10:44:13 +01:00
Fabien Potencier
bbc5f40636
Merge remote branch 'jakzal/FileLocatorTest'
...
* jakzal/FileLocatorTest:
[Config] Added missing tests to satisfy 100% test coverage of FileLocator. Made sure that every path returned with locate() is unique.
2011-03-06 10:40:52 +01:00
Fabien Potencier
31eb5ff443
Merge remote branch 'jakzal/BooleanNodeTest'
...
* jakzal/BooleanNodeTest:
[Config] Added tests for BooleanNode.
2011-03-06 10:40:48 +01:00
Fabien Potencier
c02ebbf2d8
Merge remote branch 'digitalkaoz/httpkernel-datacollector'
...
* digitalkaoz/httpkernel-datacollector:
[HttpKernel] added Tests for DataCollectors
[HttpFoundation] more sophisticated checks for valid expiration
2011-03-06 10:38:55 +01:00
Fabien Potencier
89f309a1a3
Merge remote branch 'digitalkaoz/httpkernel-exception'
...
* digitalkaoz/httpkernel-exception:
[HttpKernel] added Tests for FlattenException
2011-03-06 10:37:35 +01:00
Fabien Potencier
54e19b5376
Merge remote branch 'digitalkaoz/httpkernel-debug'
...
* digitalkaoz/httpkernel-debug:
[HttpKernel] added tests for debug stuff
[HttpKernel] reset handling if subject::handle throws an exception, otherwise it wouldnt be able to handle furthermore
2011-03-06 10:37:14 +01:00
Fabien Potencier
4accca3a76
Merge remote branch 'digitalkaoz/httpfoundation-session'
...
* digitalkaoz/httpfoundation-session:
[HttpFoundation] added Session tests.
[HttpFoundation] added a check for array keys existence.
2011-03-06 10:36:15 +01:00
Fabien Potencier
1e996901f5
Merge remote branch 'schmittjoh/security'
...
* schmittjoh/security:
[Security] forward the entire access denied exception instead of only the message
[Security] changed defaults for MessageDigestEncoder
TICKET #9557 : session isn't required when using http basic authentification mecanism for example
[Security] improved entropy to make collision attacks harder
[Security] added the 'key' attribute of RememberMeToken to serialized string to be stored in session
Fix the Acl schema generator script.
2011-03-06 10:33:18 +01:00
Fabien Potencier
0a8730ab26
Merge remote branch 'lewinski/yaml-escapes'
...
* lewinski/yaml-escapes:
[Yaml] Improved support for double quoted values.
2011-03-06 08:34:20 +01:00
Robert Schönthal
44b0bbc0d1
[HttpKernel] added Tests for DataCollectors
2011-03-06 00:15:01 +01:00
Xavier Perez
7900e8624f
[HttpFoundation] Added some more tests on response
2011-03-06 00:14:10 +01:00
Robert Schönthal
87e1359ebd
[HttpFoundation] more sophisticated checks for valid expiration
2011-03-06 00:13:47 +01:00
Matthew Lewinski
ed338d9422
[Yaml] Improved support for double quoted values.
...
Added support for the full range of escaped values in double quoted
strings in chapter 5 of the YAML 1.1 and 1.2 specs. The escaping
and unescaping strategies were factored out into separate classes to
keep the logic isolated.
Added examples from the spec to the unit tests for all escaped values.
2011-03-05 15:39:48 -06:00
Robert Schönthal
935315bd79
[HttpKernel] added Tests for FlattenException
2011-03-05 21:21:19 +01:00
Robert Schönthal
3e7ccae2ba
[HttpKernel] added tests for debug stuff
2011-03-05 20:23:35 +01:00
Xavier Perez
0327e93552
[HttpFoundation] Added some tests on Response
2011-03-05 16:12:17 +01:00
Jakub Zalas
bdd4194b6f
[Config] Added missing tests to satisfy 100% test coverage of FileLocator. Made sure that every path returned with locate() is unique.
2011-03-05 15:24:44 +01:00
Jakub Zalas
61f67d20c8
[Config] Added tests for BooleanNode.
2011-03-05 13:53:07 +01:00
Johannes Schmitt
f82b89cdc5
[Security] changed defaults for MessageDigestEncoder
...
- encode_as_base64 set to true
- iterations increased to 5000 from 1
2011-03-05 13:45:35 +01:00
Robert Schönthal
3567fc4e6c
[HttpFoundation] added Session tests.
2011-03-05 13:32:36 +01:00
Fabien Potencier
44d069a3fb
Merge remote branch 'kriswallsmith/dic/auto-ext-load'
...
* kriswallsmith/dic/auto-ext-load:
[HttpKernel] added an subclass merge extension configuration compiler pass to ensure each bundle's "main" extension is loaded
[DependencyInjection] extensions should only load if called during configuration
2011-03-05 12:18:18 +01:00
Fabien Potencier
50c118a368
Merge remote branch 'cyqui/FIX-OVERRIDED-SERVER'
...
* cyqui/FIX-OVERRIDED-SERVER:
requestTest, override globals erase for the next tests. so backup it and restore it.
2011-03-05 12:12:07 +01:00
Cyril Quintin
1e4e899641
requestTest, override globals erase for the next tests. so backup it and restore it.
2011-03-05 12:11:21 +01:00
Fabien Potencier
4a8f10192f
[DependencyInjection] fixed unit tests when using phar and suhosin
2011-03-05 11:43:11 +01:00
Hugo Hamon
cd5d1bd62e
[Security] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
2011-03-03 14:52:53 +01:00
Hugo Hamon
8182913f1f
[BrowserKit] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
2011-03-03 14:52:03 +01:00
Hugo Hamon
ad56bd8e47
[HttpFoundation] fix cookie path default value to / and added some new unit tests to cover the class
2011-03-03 14:50:14 +01:00
Kris Wallsmith
33d47be32e
[HttpKernel] added an subclass merge extension configuration compiler pass to ensure each bundle's "main" extension is loaded
2011-03-03 13:54:32 +01:00
Kris Wallsmith
bf0553c23a
[DependencyInjection] extensions should only load if called during configuration
2011-03-03 13:53:29 +01:00
Igor Wiedler
c22a43860b
[Locale] add missing StubCollator methods, with tests
2011-03-02 17:13:24 +01:00
Bernhard Schussek
5705f74bd0
[Form] Refactored FieldFactory and moved new implementation into the DIC. FormTest fails now.
2011-03-02 14:58:19 +01:00
Bernhard Schussek
68013f4db2
Merge remote branch 'symfony/master' into experimental
2011-03-02 12:27:30 +01:00
Bernhard Schussek
8a6246bd06
[Form] Refactored contents of FormFactory into individual FieldConfig classes
2011-03-02 12:20:30 +01:00
Fabien Potencier
fd53035c8d
Merge remote branch 'schmittjoh/inlinePassFix'
...
* schmittjoh/inlinePassFix:
[DependencyInjection/Compiler] fixes a bug which silently changed the scope of services
2011-03-01 20:38:48 +01:00
Pascal Borreli
3a47fa6eed
[Tests] Fixed Typo
2011-03-01 18:58:08 +01:00
Bernhard Schussek
9eff64dd54
[Form] Added EventListener implementation and moved CollectionField to factory
2011-03-01 15:18:55 +01:00
Bernhard Schussek
528ef55da6
[Form] Implemented generic data filter hooks
...
You can now modify set or bound data by adding a filter for either of the following events:
* Filters::filterBoundDataFromClient
* Filters::filterBoundData
* Filters::filterSetData
2011-03-01 14:19:28 +01:00
Johannes M. Schmitt
67c886f3df
[DependencyInjection/Compiler] fixes a bug which silently changed the scope of services
2011-03-01 13:47:34 +01:00
Eriksen Costa
18e16860ae
[Locale] fixed PHP notice
2011-03-01 02:24:19 -03:00
Eriksen Costa
4cc5b6f2d0
[Locale] throw exception if value different than null is provided (behavior not implemented in the stub)
2011-03-01 02:08:13 -03:00
Igor Wiedler
fd0cc37c71
[Locale] handle escaped (enquoted) strings when parsing
2011-02-28 18:22:22 +01:00
Degory Valentine
057e86161e
added test to verify ArgvInput->parse() failure with array input definition
2011-02-28 17:16:58 +01:00
Bernhard Schussek
c1edf116f2
[Form] Removed notion of "hidden" fields
...
Instead, hidden fields now override the "row" template to not include a label or errors.
The "rest" (former "hidden") helper has been adapted to output any fields that were not
rendered manually. It should usually be called at the end of a form.
2011-02-28 17:01:11 +01:00
Bernhard Schussek
02d2121dcd
[Form] Improved rendering
...
Fields are not available in the templates anymore. Instead, all required information can be
accessed through view variables.
Example usage of helpers and variables in a form theme:
// use the label helper
{{ this.label('my label') }}
// use the label variable
{{ this.vars.label }}
{{ label }}
Example usage of helpers and variables in a normal template:
// use the label helper
{{ field.label('my label') }}
// use the label variable
{{ field.vars.label }}
2011-02-28 16:50:23 +01:00
Igor Wiedler
a5f8411eff
[Locale] minor cosmetical tweaks to the pre-escaped regExp
2011-02-28 13:54:38 +01:00
Igor Wiedler
7e577acede
[Locale] do not use unimplemented chars in examples
2011-02-28 09:46:30 -03:00
Igor Wiedler
20acdac57d
[Locale] remove support for era (BC|AD)
...
parsing it is a pain, nobody uses it, BC only works on 64 bit.
2011-02-28 09:46:30 -03:00
Igor Wiedler
195b2ebdde
[Locale] handle IntlDateFormatter::parse with non-integer timestamp
2011-02-28 09:46:30 -03:00
Igor Wiedler
3f42be3fe9
[Locale] use assertSame in parse tests
2011-02-28 09:46:29 -03:00
Eriksen Costa
b7e9b35ca9
[Locale] added parsing of dates with regExp metachars
2011-02-28 09:44:14 -03:00
Martin Hason
3d94c6c4bd
[DependencyInjection] added phar creator in test
2011-02-28 09:58:37 +01:00
Martin Hason
c75622cb4b
[DependencyInjection] removed unused class Extension, fix tests
2011-02-28 09:57:18 +01:00
Martin Hason
d231a8a8d5
[Config] [DependencyInjection] removed DependencyInjection dependency in Config, fix tests
2011-02-28 09:19:13 +01:00
Eriksen Costa
0449889513
[Locale] added timezone parsing implementation
2011-02-28 01:19:19 -03:00
Eriksen Costa
dadd896915
[Locale] added implementation for minutes and seconds
2011-02-27 18:21:35 -03:00
Fabien Potencier
c99a44b1e8
Merge remote branch 'schmittjoh/security'
...
* schmittjoh/security:
[Security] added method to retrieve the configured remember-me parameter
[Security] Copy token attributes when auth providers create a new token from another
2011-02-27 22:20:44 +01:00
Fabien Potencier
72a0f3b7f0
[Translation] re-added a unit test inadvertently removed in a previous commit
2011-02-27 22:18:34 +01:00
Fabien Potencier
c58b6afc38
Merge remote branch 'cristiangsp/Translation_FallbackLocale'
...
* cristiangsp/Translation_FallbackLocale:
[Translation] Modified Translation unit test "testTransWithFallbackLocale"
[Translation] Fixed the addition of the fallbackLocale catalogue to the current locale catalogue.
[Translation] Added search to FallbackLocale Catalogue.
2011-02-27 21:48:34 +01:00
Fabien Potencier
2b4b3f83a5
fixed previous commit
2011-02-27 21:14:03 +01:00
Fabien Potencier
49f84f1997
Merge remote branch 'lsmith77/code_analyzer_2011_02_27'
...
* lsmith77/code_analyzer_2011_02_27:
corrected NonceExpiredException namespace
issues found by static code analysis
2011-02-27 21:12:31 +01:00
Lukas Kahwe Smith
4b3c49550f
issues found by static code analysis
2011-02-27 19:34:02 +01:00
Eriksen Costa
c1c0c3c42e
[Locale] added parsing for hours (12 and 24 hours)
2011-02-27 15:22:25 -03:00
Pascal Borreli
96981670ea
[BrowserKit] Removed useless else
2011-02-27 18:36:36 +01:00
Cristian Gonzalez
db1ea0d2e1
[Translation] Modified Translation unit test "testTransWithFallbackLocale"
...
Now the test shows the behavior when is requested a translation to an undefined locale catalogue and, therefore, the fallbacklocale catalogue must be queried. The original test function only checks the step to reach the language catalog not to the fallbacklocale one (even the fallbacklocale isn't set). This test gives error in the current version of symfony/symfony.
2011-02-27 12:32:46 +01:00
Eriksen Costa
ed85345312
[Locale] added parsing implementation for year, month and day
2011-02-27 02:22:07 -03:00
Johannes Schmitt
97ee92e7b0
Merge branch 'CopyTokenAttributesInProviders' of https://github.com/opensky/symfony into opensky-CopyTokenAttributesInProviders
2011-02-26 21:47:57 +01:00
Johannes Schmitt
621a79f1f2
[Security] added method to retrieve the configured remember-me parameter
2011-02-26 21:44:40 +01:00
Fabien Potencier
e16c666266
[Routing] made an empty path info to redirect to / (as for any other route that ends with a /)
2011-02-26 08:56:44 +01:00
Bernhard Schussek
e334c4734e
[Form] Registered FormFactory in the DIC
2011-02-24 21:27:44 +01:00
Bernhard Schussek
f2c1976da6
[Form] Refactored FileField to FormFactory and fixed file upload mechanism
2011-02-24 20:47:48 +01:00
Bernhard Schussek
848ec01f02
[Form] Refactored RepeatedField to FormFactory
2011-02-24 16:54:34 +01:00
Bernhard Schussek
0f8a413221
[Form] Fixed EntityChoiceFieldTest
2011-02-24 16:26:57 +01:00
Bernhard Schussek
acc5c76f77
[Form] Fixed failing DateFieldTest and TimeFieldTest
2011-02-24 16:19:59 +01:00
Bernhard Schussek
e3e8c29875
Merge branch 'bugfix' into experimental
...
Conflicts:
src/Symfony/Component/Form/EntityChoiceField.php
src/Symfony/Component/Form/Field.php
src/Symfony/Component/Form/HybridField.php
tests/Symfony/Tests/Component/Form/FieldTest.php
tests/Symfony/Tests/Component/Form/FormTest.php
2011-02-24 13:17:53 +01:00
Bernhard Schussek
87e6cbf8f0
[Form] Fixed: PropertyPath always requires arrays or objects. Forms now always store arrays or objects as transformed data, even when they were bound empty
2011-02-24 12:22:00 +01:00
Bernhard Schussek
0e75891f25
[Form] Fixed DateTimeToLocalizedStringTransformerTest
2011-02-24 10:05:35 +01:00
Bernhard Schussek
8e2d0bae90
[Form] Ported DateTimeField to FormFactory
2011-02-23 23:34:25 +01:00
Bernhard Schussek
b5671c1be0
[Form] Implemented ArrayToPartsTransformer and ValueToDuplicatesTransformer
2011-02-23 22:30:15 +01:00
Jeremy Mikola
5113886f34
[Security] Copy token attributes when auth providers create a new token from another
...
PreAuthenticatedAuthenticationProvider and UserAuthenticationProvider tend to copy a token instead of modifying it during their authenticate() methods, which is probably a good idea if the token might be immutable. Ensure that the token's attributes get copied along with everything else.
2011-02-23 16:03:01 -05:00
Bernhard Schussek
ac5440f8d4
[Form] DateTimeToArrayTransformer does not accept partially filled arrays anymore. Replaces DateField::isPartiallyFilled() and TimeField::isPartiallyFilled()
2011-02-23 21:17:20 +01:00
Igor Wiedler
bcca989c41
[Locale] refactor and simplify some parts of StubIntlDateFormatter
2011-02-23 19:09:48 +01:00
Bernhard Schussek
33e70673c2
[Locale] Fixed failing StubNumberFormatterTest when intl extension is not loaded
2011-02-23 14:38:05 +01:00
Igor Wiedler
71c99422f3
[Locale] convenience createStubFormatter method for StubIntlDateFormatter tests
2011-02-23 14:20:47 +01:00
Igor Wiedler
ee5bc36c55
[Locale] add docblocks to StubIntlDateFormatter and adjust some things to be more like StubNumberFormatter
2011-02-23 14:20:47 +01:00
Igor Wiedler
5fdf68a08a
[Locale] add license docblock to LocaleTestCase
2011-02-23 14:20:47 +01:00
Igor Wiedler
31313f183a
[Locale] use is64Bit helper for StubIntlDateFormatterTest
2011-02-23 14:20:46 +01:00
Igor Wiedler
17e2d4e24c
[Locale] StubCollator: asort with initial tests
2011-02-23 14:20:46 +01:00
Igor Wiedler
3cc60f7cb4
[Locale] throw NotImplementedException on unimplemented chars
2011-02-23 14:20:45 +01:00
Igor Wiedler
d555049342
[Locale] only test BC era if on 64bit
2011-02-23 14:20:45 +01:00
Igor Wiedler
4fb79b715a
[Locale] split another StubIntlDateFormatter test into two
2011-02-23 14:20:45 +01:00
Igor Wiedler
53839f9235
[Locale] refactor tests, make use of specialized exception
2011-02-23 14:20:45 +01:00
Igor Wiedler
77258223f1
[Locale] re-order StubIntlDateFormatter methods, rename timezoneId to timeZoneId, add setLenient method
2011-02-23 14:20:44 +01:00
Igor Wiedler
1191ab4b56
[Locale] add remaining IntlDateFormatter methods with tests
2011-02-23 14:20:44 +01:00
Igor Wiedler
69b38faff7
[Locale] refactoring and some more tests
2011-02-23 14:20:44 +01:00
Igor Wiedler
e95df5d2a7
[Locale] fix failing test case
2011-02-23 14:20:44 +01:00
Igor Wiedler
8dab760160
[Locale] use eriksens intl test helpers
2011-02-23 14:20:43 +01:00
Jordi Boggiano
47c1110166
[Locale] Fixed two tests
2011-02-23 14:20:43 +01:00
Igor Wiedler
e962c4a633
[Locale] add another failing escape test case
2011-02-23 14:20:42 +01:00
Igor Wiedler
c7380fbb4c
[Locale] support standard date and time types if no format is set, refactoring and more tests
2011-02-23 14:20:42 +01:00
Igor Wiedler
85e6c5e426
[Locale] add some more test cases with escaping
2011-02-23 14:20:42 +01:00
Igor Wiedler
632ded5c96
[Locale] use UTC if timezone is unsupported
2011-02-23 14:20:42 +01:00
Igor Wiedler
a883a3f62a
[Locale] adjust to new quoting format, some tests failing
2011-02-23 14:20:42 +01:00
Igor Wiedler
cbfaaef76e
[Locale] support for z (timezone offset from GMT)
2011-02-23 14:20:41 +01:00
Igor Wiedler
d68c5fa7fd
[Locale] refactor to use DateTime and DateTimeZone, adding timezone support
2011-02-23 14:20:41 +01:00
Igor Wiedler
7efe476693
[Locale] support for s (second)
2011-02-23 14:20:41 +01:00
Igor Wiedler
87d3547679
[Locale] support for m (minute of hour)
2011-02-23 14:20:40 +01:00
Igor Wiedler
6b26f8296d
[Locale] support for K (12-hour (0-11))
2011-02-23 14:20:40 +01:00
Igor Wiedler
5a767045b6
[Locale] implement k (24-hour (1-24)
2011-02-23 14:20:40 +01:00
Igor Wiedler
bfc7e55692
[Locale] support for H (24 hour)
2011-02-23 14:20:39 +01:00
Igor Wiedler
71e3c97358
[Locale] support for a (AM/PM)
2011-02-23 14:20:39 +01:00
Igor Wiedler
49752f104b
[Locale] support for E (day of week)
2011-02-23 14:20:39 +01:00
Igor Wiedler
d4c1357f11
[Locale] support for D (day of year)
2011-02-23 14:20:39 +01:00
Igor Wiedler
5ffce2d6a2
[Locale] add support for h
2011-02-23 14:20:39 +01:00
Igor Wiedler
3b9f52ae9a
[Locale] use assertSame instead of assertEquals
2011-02-23 14:20:39 +01:00
Igor Wiedler
ae3ee5d896
[Locale] add support for L, which is the same as M
2011-02-23 14:20:38 +01:00
Igor Wiedler
b702ce86b5
[Locale] support for G and Q placeholders in StubIntlDateFormatter::format
2011-02-23 14:20:38 +01:00
Igor Wiedler
69f56dbbd9
[Locale] move intl bugs to skipped tests
2011-02-23 14:20:38 +01:00
Igor Wiedler
8c1146974f
[Locale] add support for escaping, give specifics on implementation used in tests
2011-02-23 14:20:38 +01:00
Igor Wiedler
55ac407458
[Locale] first implementation of StubIntlDateFormatter
2011-02-23 14:20:37 +01:00
Bernhard Schussek
a40e2dd77b
[Form] Deleted obsolete Field classes, ported some more to FormFactory and fixed lots of failing tests
2011-02-23 14:11:18 +01:00
Bernhard Schussek
7492873186
[Form] Fixed a couple of unit tests, refactored PasswordField to FormFactory
2011-02-23 14:11:18 +01:00
Bernhard Schussek
fee0885256
[Form] Moved options from Field and Form to FormFactory. Tests fail now
2011-02-23 14:11:18 +01:00
Bernhard Schussek
7a48c0a5c5
[Form] Refactored logic from ChoiceField into ChoicePlugin and SelectMultipleNamePlugin
2011-02-23 14:11:18 +01:00
Bernhard Schussek
f7dc71ef59
[Form] Refactored id and name generation to renderer plugins
2011-02-23 14:11:17 +01:00
Bernhard Schussek
813ec54fa1
[Form] Refactored parts of the choice fields into ChoiceList instances
2011-02-23 14:11:17 +01:00
Eriksen Costa
b649843e00
[Locale] added implementation to StubNumberFormatter::getLocale(), matching StubIntlDateFormatter::getLocale()
2011-02-23 13:26:05 +01:00
Eriksen Costa
b58e25cc83
[Locale] added static constructor
2011-02-23 13:26:05 +01:00
Eriksen Costa
69b0e09d6a
[Locale] added stub implementations of Locale and NumberFormatter classes
...
Updated update-data.php script to extract locales, countries names, languages and currencies
from ICU to be used by the stub implementations
2011-02-23 13:26:05 +01:00
Kris Wallsmith
fb005396dc
[HttpKernel] fixed another test where an explicit cache-control header is necessary
2011-02-21 21:53:04 -08:00
Kris Wallsmith
3e131f5b70
[HttpKernel] fixed invalid test
...
According to ResponseHeaderBag::computeCacheControlValue(), a response with an ETag but no explicit Cache-Control header should have a sensible Cache-Control of "private, must-revalidate" set. According to Response::isCacheable(), a response that includes a private Cache-Controls is not considered cacheable. Therefore, in order for this test response to be cacheable and stored, it requires an explicit Cache-Control of public.
2011-02-21 20:09:50 -08:00