Commit Graph

3036 Commits

Author SHA1 Message Date
hhamon
2d68ca4d00 [WebProfilerBundle] changed web debug toolbar css layout 2011-03-06 11:44:56 +01:00
hhamon
f75ec8d4ad [FrameworkBundle] implemented new exception stack trace layout 2011-03-06 11:44:56 +01:00
Fabien Potencier
c2e0537c31 Merge remote branch 'aurelijus/routehelper_cachedrouter_fix'
* aurelijus/routehelper_cachedrouter_fix:
  Add cache warmed routers support to RouteHelper
2011-03-06 10:50:11 +01:00
Lenar Lõhmus
c6bbecf0bb Check if config/template file is actually readable before further processing 2011-03-06 10:46:39 +01:00
Fabien Potencier
a137d72351 Merge remote branch 'hhamon/cookie_path_fix'
* hhamon/cookie_path_fix:
  [Security] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
  [HttpKernel] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
  [BrowserKit] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
  [HttpFoundation] fix cookie path default value to / and added some new unit tests to cover the class
2011-03-06 10:44:40 +01:00
Fabien Potencier
487cddcfee Merge remote branch 'DuoSRX/code-coverage'
* DuoSRX/code-coverage:
  [HttpFoundation] Fixed a typo in response->setLastModified()
  [HttpFoundation] Added some more tests on response
  [HttpFoundation] Added some tests on Response
  [HttpFoundation] Replace a duplicated test with a method in Response
  Fixed code coverage generation when resources folder are deeper
2011-03-06 10:44:13 +01:00
Fabien Potencier
bbc5f40636 Merge remote branch 'jakzal/FileLocatorTest'
* jakzal/FileLocatorTest:
  [Config] Added missing tests to satisfy 100% test coverage of FileLocator. Made sure that every path returned with locate() is unique.
2011-03-06 10:40:52 +01:00
Fabien Potencier
31eb5ff443 Merge remote branch 'jakzal/BooleanNodeTest'
* jakzal/BooleanNodeTest:
  [Config] Added tests for BooleanNode.
2011-03-06 10:40:48 +01:00
Fabien Potencier
51023eea86 [HttpFoundation] fixed CS 2011-03-06 10:39:33 +01:00
Fabien Potencier
c02ebbf2d8 Merge remote branch 'digitalkaoz/httpkernel-datacollector'
* digitalkaoz/httpkernel-datacollector:
  [HttpKernel] added Tests for DataCollectors
  [HttpFoundation] more sophisticated checks for valid expiration
2011-03-06 10:38:55 +01:00
Fabien Potencier
89f309a1a3 Merge remote branch 'digitalkaoz/httpkernel-exception'
* digitalkaoz/httpkernel-exception:
  [HttpKernel] added Tests for FlattenException
2011-03-06 10:37:35 +01:00
Fabien Potencier
54e19b5376 Merge remote branch 'digitalkaoz/httpkernel-debug'
* digitalkaoz/httpkernel-debug:
  [HttpKernel] added tests for debug stuff
  [HttpKernel] reset handling if subject::handle throws an exception, otherwise it wouldnt be able to handle furthermore
2011-03-06 10:37:14 +01:00
Fabien Potencier
4accca3a76 Merge remote branch 'digitalkaoz/httpfoundation-session'
* digitalkaoz/httpfoundation-session:
  [HttpFoundation] added Session tests.
  [HttpFoundation] added a check for array keys existence.
2011-03-06 10:36:15 +01:00
Fabien Potencier
ce60ebbbf5 Merge remote branch 'yethee/fix-target-url'
* yethee/fix-target-url:
  [AsseticBundle] Fixed url for assets in the debugging mode.
2011-03-06 10:34:28 +01:00
Fabien Potencier
1e996901f5 Merge remote branch 'schmittjoh/security'
* schmittjoh/security:
  [Security] forward the entire access denied exception instead of only the message
  [Security] changed defaults for MessageDigestEncoder
  TICKET #9557: session isn't required when using http basic authentification mecanism for example
  [Security] improved entropy to make collision attacks harder
  [Security] added the 'key' attribute of RememberMeToken to serialized string to be stored in session
  Fix the Acl schema generator script.
2011-03-06 10:33:18 +01:00
Fabien Potencier
a972770371 Merge remote branch 'Seldaek/exception_msg'
* Seldaek/exception_msg:
  [Config] Improved exception message a bit
2011-03-06 10:32:12 +01:00
Fabien Potencier
0a8730ab26 Merge remote branch 'lewinski/yaml-escapes'
* lewinski/yaml-escapes:
  [Yaml] Improved support for double quoted values.
2011-03-06 08:34:20 +01:00
Xavier Perez
19090d3fb7 [HttpFoundation] Fixed a typo in response->setLastModified() 2011-03-06 00:17:54 +01:00
Robert Schönthal
44b0bbc0d1 [HttpKernel] added Tests for DataCollectors 2011-03-06 00:15:01 +01:00
Xavier Perez
7900e8624f [HttpFoundation] Added some more tests on response 2011-03-06 00:14:10 +01:00
Robert Schönthal
87e1359ebd [HttpFoundation] more sophisticated checks for valid expiration 2011-03-06 00:13:47 +01:00
Deni
4c54218a4b [AsseticBundle] Fixed url for assets in the debugging mode. 2011-03-06 00:54:21 +03:00
Matthew Lewinski
ed338d9422 [Yaml] Improved support for double quoted values.
Added support for the full range of escaped values in double quoted
strings in chapter 5 of the YAML 1.1 and 1.2 specs. The escaping
and unescaping strategies were factored out into separate classes to
keep the logic isolated.

Added examples from the spec to the unit tests for all escaped values.
2011-03-05 15:39:48 -06:00
Robert Schönthal
935315bd79 [HttpKernel] added Tests for FlattenException 2011-03-05 21:21:19 +01:00
Robert Schönthal
3e7ccae2ba [HttpKernel] added tests for debug stuff 2011-03-05 20:23:35 +01:00
Robert Schönthal
415b456b4e [HttpKernel] reset handling if subject::handle throws an exception, otherwise it wouldnt be able to handle furthermore 2011-03-05 20:21:23 +01:00
Xavier Perez
0327e93552 [HttpFoundation] Added some tests on Response 2011-03-05 16:12:17 +01:00
Bernhard Schussek
f1393d7b1f Replaced EventDispatcher by Doctrine's EventManager implementation
Doctrine's EventManager implementation has several advantages over the
EventDispatcher implementation of Symfony2. Therefore I suggest that we
use their implementation.

Advantages:

 * Event Listeners are objects, not callbacks. These objects have handler
   methods that have the same name as the event. This helps a lot when
   reading the code and makes the code for adding an event listener shorter.
 * You can create Event Subscribers, which are event listeners with an
   additional getSubscribedEvents() method. The benefit here is that the
   code that registers the subscriber doesn't need to know about its
   implementation.
 * All events are defined in static Events classes, so users of IDEs benefit
   of code completion
 * The communication between the dispatching class of an event and all
   listeners is done through a subclass of EventArgs. This subclass can be
   tailored to the type of event. A constructor, setters and getters can be
   implemented that verify the validity of the data set into the object.
   See examples below.
 * Because each event type corresponds to an EventArgs implementation,
   developers of event listeners can look up the available EventArgs methods
   and benefit of code completion.
 * EventArgs::stopPropagation() is more flexible and (IMO) clearer to use
   than notifyUntil(). Also, it is a concept that is also used in other
   event implementations

Before:

    class EventListener
    {
        public function handle(EventInterface $event, $data) { ... }
    }

    $dispatcher->connect('core.request', array($listener, 'handle'));
    $dispatcher->notify('core.request', new Event(...));

After (with listeners):

    final class Events
    {
        const onCoreRequest = 'onCoreRequest';
    }

    class EventListener
    {
        public function onCoreRequest(RequestEventArgs $eventArgs) { ... }
    }

    $evm->addEventListener(Events::onCoreRequest, $listener);
    $evm->dispatchEvent(Events::onCoreRequest, new RequestEventArgs(...));

After (with subscribers):

    class EventSubscriber
    {
        public function onCoreRequest(RequestEventArgs $eventArgs) { ... }

        public function getSubscribedEvents()
        {
            return Events::onCoreRequest;
        }
    }

    $evm->addEventSubscriber($subscriber);
    $evm->dispatchEvent(Events::onCoreRequest, new RequestEventArgs(...));
2011-03-05 15:30:34 +01:00
Fabien Potencier
fe0ef667c8 Merge remote branch 'kriswallsmith/assetic/php-templating'
* kriswallsmith/assetic/php-templating:
  [AsseticBundle] finished and enabled php templating support
2011-03-05 15:25:11 +01:00
Jakub Zalas
bdd4194b6f [Config] Added missing tests to satisfy 100% test coverage of FileLocator. Made sure that every path returned with locate() is unique. 2011-03-05 15:24:44 +01:00
Johannes Schmitt
b67a1dd677 [Security] forward the entire access denied exception instead of only the message 2011-03-05 14:30:08 +01:00
Xavier Perez
0d56ca5654 [HttpFoundation] Replace a duplicated test with a method in Response 2011-03-05 14:27:35 +01:00
Johannes Schmitt
63dbcea8ee Merge branch 'lewinski-fix-acl-schema-generator' into security 2011-03-05 14:13:53 +01:00
Kris Wallsmith
8d4dae9f2a [AsseticBundle] finished and enabled php templating support 2011-03-05 14:11:29 +01:00
Johannes Schmitt
0eb4f49061 Merge branch 'fix-acl-schema-generator' of https://github.com/lewinski/symfony into lewinski-fix-acl-schema-generator 2011-03-05 13:54:10 +01:00
Jakub Zalas
61f67d20c8 [Config] Added tests for BooleanNode. 2011-03-05 13:53:07 +01:00
Johannes Schmitt
4c7aa343d3 Merge branch 'opensky-hotfix/remember-me-token-fix' into security 2011-03-05 13:51:52 +01:00
Johannes Schmitt
966607746f Merge branch 'hotfix/remember-me-token-fix' of https://github.com/opensky/symfony into opensky-hotfix/remember-me-token-fix 2011-03-05 13:51:20 +01:00
Johannes Schmitt
e03958f5b0 Merge branch 'cyqui-TICKET_9557' into security 2011-03-05 13:50:14 +01:00
Johannes Schmitt
e91cb7cf96 Merge branch 'TICKET_9557' of https://github.com/cyqui/symfony into cyqui-TICKET_9557 2011-03-05 13:49:38 +01:00
Johannes Schmitt
f82b89cdc5 [Security] changed defaults for MessageDigestEncoder
- encode_as_base64 set to true
- iterations increased to 5000 from 1
2011-03-05 13:45:35 +01:00
Cyril Quintin
310a6c99a2 TICKET #9557: session isn't required when using http basic authentification mecanism for example 2011-03-05 13:33:56 +01:00
Robert Schönthal
3567fc4e6c [HttpFoundation] added Session tests. 2011-03-05 13:32:36 +01:00
Robert Schönthal
58db452e21 [HttpFoundation] added a check for array keys existence. 2011-03-05 13:30:54 +01:00
Johannes Schmitt
f010742e45 [Security] improved entropy to make collision attacks harder 2011-03-05 13:30:27 +01:00
Johannes Schmitt
eb2eb2e47a [DependencyInjection] adds property injection 2011-03-05 13:03:28 +01:00
Xavier Perez
751043456c Fixed code coverage generation when resources folder are deeper 2011-03-05 12:59:36 +01:00
Fabien Potencier
44d069a3fb Merge remote branch 'kriswallsmith/dic/auto-ext-load'
* kriswallsmith/dic/auto-ext-load:
  [HttpKernel] added an subclass merge extension configuration compiler pass to ensure each bundle's "main" extension is loaded
  [DependencyInjection] extensions should only load if called during configuration
2011-03-05 12:18:18 +01:00
Fabien Potencier
727326b7b8 Merge remote branch 'kriswallsmith/assetic/factory-workers'
* kriswallsmith/assetic/factory-workers:
  [AsseticBundle] added compiler pass for factory workers
2011-03-05 12:14:24 +01:00
Fabien Potencier
7eb4b67ec4 Merge remote branch 'kriswallsmith/assetic/update'
* kriswallsmith/assetic/update:
  [AsseticBundle] updated for assetic changes
2011-03-05 12:14:01 +01:00