Commit Graph

7306 Commits

Author SHA1 Message Date
Lukas Kahwe Smith
41ab1f78f7 updated RegistryInterface for https://github.com/doctrine/common/pull/68 2011-10-15 11:26:58 +02:00
Fabien Potencier
6b3c7ac62d Merge branch '2.0'
* 2.0:
  [Doctrine] GH-1635 - UniqueValidator now works with associations
2011-10-15 11:07:39 +02:00
Fabien Potencier
5dba01851e merged branch beberlei/GH-1635 (PR #2396)
Commits
-------

9d8046e [Doctrine] GH-1635 - UniqueValidator now works with associations

Discussion
----------

GH 1635

Handle associations in unique validator correctly.

---------------------------------------------------------------------------

by beberlei at 2011/10/15 00:34:31 -0700

This can be merged into "master" as well. The test-code is also a little bit smelling, it includes files manually that dont follow PSR-0. I am going to fix that in another PR after this is merged.
2011-10-15 11:06:44 +02:00
Benjamin Eberlei
9d8046e407 [Doctrine] GH-1635 - UniqueValidator now works with associations 2011-10-15 09:20:06 +02:00
Fabien Potencier
3ca1ccbf67 [DoctrineBridge] removed the Xml and Yaml driver as they are now part of Doctrine 2011-10-15 04:25:55 +02:00
Fabien Potencier
8b4552ff76 updated vendors 2011-10-15 03:39:42 +02:00
Fabien Potencier
79877ab3dd updated CHANGELOG for 2.1 2011-10-15 03:39:16 +02:00
Fabien Potencier
ec45893c2d merged branch lsmith77/ManagerRegistry (PR #2244)
Commits
-------

dc5772d use ORM master
4364463 use doctrine-common master
55b572d fixed getting the alias for a namespace
2b89e15 use getObjectNamespace() in getEntityNamespace()
0217a0e updated base class name
e8f3c21 updated vendors to point to lsmith77's fork of doctrine-common until its merged
6e87d01 fix tests
13c2f33 added a default implementation of the ManagerRegistry integrating the container

Discussion
----------

[Doctrine] added a default implementation of the ManagerRegistry

Bug fix: no
Feature addition: yes
Backwards compatibility break: yes (minor change in the interface see below)
Symfony2 tests pass: yes
Fixes the following tickets: -

added a default implementation of the ManagerRegistry integrating the container

attempted to maintain BC as good as possible, but RegistryInterface::getRepository() had to be dropped from RegistryInterface. Its still part of the ManagerRegistry, so its only a BC break for people using RegistryInterface to create their own implementation as I ran into https://bugs.php.net/bug.php?id=43200

all implementation (ORM/ODM) will need to match the changes to the ClassMetadataFactory interface

ORM, PHPCR, CouchDB have been upgraded already.
The Bundles also need to be updated. ORM is covered with this PR, I have a PR ready for PHPCR:
https://github.com/symfony-cmf/symfony-cmf/pull/108

also note that before merging the change to vendors.php needs to be fixed to point to the right repo again

For MongoDB it currently does not yet have a registry and I can take care of CouchDB once this is all merged.

---------------------------------------------------------------------------

by lsmith77 at 2011/09/23 00:40:07 -0700

still a few failing tests and details still need to be discussed ..

---------------------------------------------------------------------------

by lsmith77 at 2011/09/23 00:53:23 -0700

ok .. tests are passing now

---------------------------------------------------------------------------

by lsmith77 at 2011/10/11 10:27:52 -0700

ok Doctrine/ORM updates are done .. PR updated .. ready to be merged.
2011-10-15 03:38:50 +02:00
Fabien Potencier
278e187974 updated CHANGELOG for 2.1 2011-10-15 03:38:40 +02:00
Fabien Potencier
6664e1d95f merged branch schmittjoh/interBundleExtensibility (PR #2349)
Commits
-------

1b57727 removed unused use statements
fd67c78 updated implementation to re-use the existing build() method
59e2e97 improves extensibility between bundles

Discussion
----------

[RFC] Improving extensibility between bundles

This is a quick draft for improving extensibility between different bundles.

The idea behind this is that an extension can provide configurable settings that other bundles can change.

---------------------------------------------------------------------------

by Seldaek at 2011/10/07 13:28:13 -0700

I am not yet sure what I would use it for, but I like the idea.

---------------------------------------------------------------------------

by lsmith77 at 2011/10/07 13:45:19 -0700

can you show a bit more how to use this?

---------------------------------------------------------------------------

by lsmith77 at 2011/10/07 13:47:38 -0700

oh it appears this is an example?

f4e76640a0 (diff-9)

---------------------------------------------------------------------------

by schmittjoh at 2011/10/07 13:57:00 -0700

yes

On Fri, Oct 7, 2011 at 10:47 PM, Lukas Kahwe Smith <
reply@reply.github.com>wrote:

> oh it appears this is an example?
>
>
> f4e76640a0 (diff-9)
>
> --
> Reply to this email directly or view it on GitHub:
> https://github.com/symfony/symfony/pull/2349#issuecomment-2328078
>

---------------------------------------------------------------------------

by schmittjoh at 2011/10/11 01:11:39 -0700

@fabpot, do you have an opinion on this, 👍 👎?
2011-10-15 03:26:46 +02:00
Fabien Potencier
3bbb6e5993 merged branch hhamon/type_validator_fix (PR #2379)
Commits
-------

73312ab [Validator] The Type constraint now accepts the "Boolean" type instead of "boolean".

Discussion
----------

[Validator] The Type constraint now accepts the "Boolean" type instead of

[Validator] The Type constraint now accepts the "Boolean" type instead of "boolean".

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -

---------------------------------------------------------------------------

by stloyd at 2011/10/11 03:43:24 -0700

As this is bugfix only, this should be made againts __2.0__ branch.

---------------------------------------------------------------------------

by hhamon at 2011/10/11 05:03:52 -0700

@stloyd I don't really know if it's a bug fix or an improvement. We could not use "Boolean" but we could use "boolean" or "bool" only. So that's why I just improved this constraint validator.
2011-10-15 03:12:16 +02:00
Fabien Potencier
4b476c3617 Merge branch '2.0'
* 2.0:
  [BrowserKit] fixed cookie updates from Response (the URI here is not the base URI, so it should not be used to determine the default values missing in the cookie, closes #2309)
2011-10-15 02:32:29 +02:00
Fabien Potencier
3426c8390c [BrowserKit] fixed cookie updates from Response (the URI here is not the base URI, so it should not be used to determine the default values missing in the cookie, closes #2309) 2011-10-15 02:32:15 +02:00
Danny Berger
dabff0e4d5 [Security] Support removing tokens from a session. 2011-10-14 20:27:53 -04:00
Fabien Potencier
5b69dae9c8 [HttpKernel] fixed profiler file storage for children 2011-10-15 01:52:05 +02:00
Fabien Potencier
cc76da1144 [HttpKernel] fixed file profile storage when trying to read an empty token 2011-10-15 01:49:28 +02:00
Fabien Potencier
7816290f3f Merge branch '2.0'
* 2.0:
  [HttpKernel] fixed profile saving when it has children
2011-10-15 01:46:43 +02:00
Fabien Potencier
c0f5b8a3b6 [HttpKernel] fixed profile saving when it has children 2011-10-15 01:46:19 +02:00
Fabien Potencier
4dc5953100 merged 2.0 2011-10-15 00:56:57 +02:00
Fabien Potencier
3d7510e921 [HttpKernel] fixed missing init for Profile children property 2011-10-15 00:56:18 +02:00
Fabien Potencier
d35fb9ff70 merged branch alexandresalome/file-storage-children-fix (PR #2368)
Commits
-------

ba6bd4b [HttpKernel] Fix the FileProfileStorage, according to the tests
1654473 [HttpKernel] Create a test to outline the problem with file storage

Discussion
----------

[HttpKernel] Fix the file storage

The file storage was not correctly fetching children back.

* First the test showing the problem
* Second the fix to the test

Solution is to add a file for each stored profile file, containing the list of children tokens.
2011-10-15 00:48:58 +02:00
Fabien Potencier
663e25af64 merged branch cs278/issue/2394 (PR #2394)
Commits
-------

d8dfca2 [BrowserKit] Added additional unit tests for capital letters in cookies
00cbd39 [BrowserKit] Fixed cookie expiry discard when attribute contains capitals

Discussion
----------

[BrowserKit] Cookie expiry is discared if the attribute name contains a capital letter

`Cookie::fromString()` discards the expiry time of a cookie where the `expires` attribute contains a capital letter, like `foo=bar; Expires=Fri, 31 Dec 2010 23:59:59 GMT`.

Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
2011-10-15 00:31:26 +02:00
Chris Smith
d8dfca21f2 [BrowserKit] Added additional unit tests for capital letters in cookies 2011-10-14 20:31:31 +01:00
Chris Smith
00cbd39813 [BrowserKit] Fixed cookie expiry discard when attribute contains capitals 2011-10-14 20:23:34 +01:00
Fabien Potencier
89295b8d02 [Translation] made the MessageSelector constructor argument for Translator optional (using a custom one is pretty rare) 2011-10-13 15:34:34 +02:00
Miha Vrhovnik
090711183d session data needs to be encoded because it can contain non binary safe
characters e.g null. Fixes #2067
2011-10-12 10:35:39 +02:00
Miha Vrhovnik
edfa29b01b session data needs to be encoded because it can contain non binary safe
characters e.g null. Fixes #2067
2011-10-11 21:42:38 +02:00
Lukas Kahwe Smith
dc5772dfb6 use ORM master 2011-10-11 19:26:57 +02:00
Lukas Kahwe Smith
436446323f use doctrine-common master 2011-10-11 19:24:58 +02:00
Fabien Potencier
c00ba4dab8 [Console] fixed typo (closes #2358) 2011-10-11 12:56:40 +02:00
Fabien Potencier
d01b29e9f6 [FrameworkBundle] added some unit tests 2011-10-11 12:54:11 +02:00
Hugo Hamon
73312ab5e9 [Validator] The Type constraint now accepts the "Boolean" type instead of "boolean".
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
2011-10-11 12:27:45 +02:00
Fabien Potencier
d407be068d updated CHANGELOG for 2.1 2011-10-10 19:47:28 +02:00
Fabien Potencier
8476d26015 merged branch stof/form_translation_domain (PR #2374)
Commits
-------

a2cf023 [FrameworkBundle] Added the translation domain
3aa7582 [TwigBridge] Added the translation domain
6e4269f [Form] Added the ability to specify the translation domain

Discussion
----------

Form translation domain

This implements #1895

Bug fix: no
Feature addition: yes
BC break: no
Tests pass: yes (well, I had some failing tests before, that are still failing, in some other parts of Symfony)
2011-10-10 19:45:25 +02:00
Christophe Coevoet
a2cf023da1 [FrameworkBundle] Added the translation domain 2011-10-10 18:25:45 +02:00
Christophe Coevoet
3aa75828b0 [TwigBridge] Added the translation domain 2011-10-10 18:08:37 +02:00
Christophe Coevoet
6e4269f9eb [Form] Added the ability to specify the translation domain 2011-10-10 17:58:32 +02:00
Fabien Potencier
ca2962ee6f merged branch tigranazatyan/master (PR #2370)
Commits
-------

249164d fixed typos
f4b7805 Edited src/Symfony/Bundle/FrameworkBundle/Resources/translations/validators.hy.xliff via GitHub
4cc1ed0 Edited src/Symfony/Bundle/FrameworkBundle/Resources/translations/validators.hy.xliff via GitHub
6a23e5f fixed typos
5b9d92a Fixed some errors

Discussion
----------

Translation of Framework Bundle in Armenian

fixed some typos
2011-10-10 15:41:14 +02:00
Fabien Potencier
550f158428 merged branch weaverryan/entity_better_exception_2_0 (PR #2372)
Commits
-------

2270a4d [Bridge][Doctrine] Adding a catch for when a developer uses the EntityType with multiple=false but on a "hasMany" relationship

Discussion
----------

[Bridge][Doctrine] Adding a catch for when a developer uses the EntityType

Hey guys!

See #2348 - same commit, but against the right branch.

Thanks!
2011-10-10 15:40:52 +02:00
Ryan Weaver
2270a4da5a [Bridge][Doctrine] Adding a catch for when a developer uses the EntityType with multiple=false but on a "hasMany" relationship
Without this, the exception is eventually thrown in EntityChoiceList::getIdentifierValues() with a very a message that doesn't really suit the real error: "Entities passed to the choice field must be managed"
2011-10-10 08:26:22 -05:00
Fabien Potencier
beda03ba96 updated all HttpKernel event listeners to implement EventSubscriberInterface 2011-10-10 14:54:49 +02:00
Fabien Potencier
38fb43c5f5 [FrameworkBundle] fixed wrong class name 2011-10-10 14:41:48 +02:00
Fabien Potencier
7a89d34872 [HttpKernel] made RouterListener implement EventSubscriberInterface 2011-10-10 14:30:15 +02:00
Fabien Potencier
4539e5c554 moved configuration of the default HTTP and HTTPS ports from RouterListener to RequestContext 2011-10-10 13:24:45 +02:00
Fabien Potencier
658722b2eb moved some logic from HttpKernel to Routing (make it reusable) 2011-10-10 13:07:36 +02:00
Fabien Potencier
8f15794274 moved LocaleListener and RouterListener to the HttpKernel component 2011-10-10 13:03:55 +02:00
Tigran Azatyan
249164d9b2 fixed typos 2011-10-10 14:44:40 +06:00
Tigran Azatyan
f4b78051fc Edited src/Symfony/Bundle/FrameworkBundle/Resources/translations/validators.hy.xliff via GitHub 2011-10-10 14:42:02 +06:00
Tigran Azatyan
4cc1ed004c Edited src/Symfony/Bundle/FrameworkBundle/Resources/translations/validators.hy.xliff via GitHub 2011-10-10 14:29:06 +06:00
Tigran Azatyan
6a23e5fabf fixed typos 2011-10-10 14:27:36 +06:00