This PR was merged into the 2.3 branch.
Discussion
----------
DependencyInjection] Fix parameter description in ConfigurationExtensionInterface
| Q | A
| ------------- | ---
| Fixed tickets | #10845
| License | MIT
This fixes the description of parameter `array $config` in file [ConfigurationExtensionInterface.php](https://github.com/symfony/symfony/blob/2.3/src/Symfony/Component/DependencyInjection/Extension/ConfigurationExtensionInterface.php) by removing the extra `$config`.
Commits
-------
93544aa [DependencyInjection] Fix parameter description in ConfigurationExtensionInterface
| Q | A
| ------------- | ---
| Fixed tickets | #10845
| License | MIT
This fixes the description of parameter `array $config` in file ConfigurationExtensionInterface.php by removing the extra `$config`.
This PR was merged into the 2.4 branch.
Discussion
----------
[Security] fixed wrong PHPDoc of the TokenGeneratorInterface
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
0e32676 [Security] fixed wrong PHPDoc of the TokenGeneratorInterface
This PR was merged into the 2.3 branch.
Discussion
----------
[TwigBridge][Transchoice] set %count% from the current context.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | [no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8408
| License | MIT
Commits
-------
8f7b2cc [TwigBridge][Transchoice] set %count% from the current context.
This PR was merged into the 2.3 branch.
Discussion
----------
Finder typehint fix
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
f3b0ef1 [Finder] fixed typehint of the Finder::addAdapter() method
This PR was merged into the 2.3 branch.
Discussion
----------
Fix a test that was ambiguous
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | see #9634 for a discussion of this and #9383 for the report
| License | MIT
| Doc PR | n/a
This PR fixes a test that was always passing as the exception catch was catching the PHP notice but also the exception sent by `fail`, so it was useless. That said, I'm not even convinced that this test is useful at all.
Commits
-------
a94b4e0 [Validator] fixed wrong test
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3] Fix phpunit test suite on travis #2
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10821
| License | MIT
This is a second approach to solve #10821.
Something is weird: `Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest` passes when using PHPUnit as phar and fails when using a composer global install
Commits
-------
32e5f67 [DependencyInjection] Fix travis unit tests
c7befd5 Update PHPUnit before run
This PR was merged into the 2.3 branch.
Discussion
----------
[WebProfilerBundle] Fixed profiler seach/homepage with empty token
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10806
| License | MIT
| Doc PR | none
Commits
-------
16dd0e5 [WebProfilerBundle] added test case for #107735b91e70 [WebProfilerBundle] fixed profiler homepage, fixed#108067b425d2 [WebProfilerBundle] Added test case for #10806
This PR was merged into the 2.5-dev branch.
Discussion
----------
Use absolute URLs to assets on Symfony its internal pages.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7524
| License | MIT
| Doc PR |
Commits
-------
e401533 Use absolute URLs to assets on Symfony its internal pages.
This PR was merged into the 2.3 branch.
Discussion
----------
changed travis to run on the nightly builds of HHVM until everything gets stable
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
As HHVM is not stable enough yet to run Symfony, let's test on the HHVM nightly builds. It will allow us to get a better feeling of the remaining problems with HHVM. ping @deguif
Commits
-------
e93cbd7 changed travis to run on the nightly builds of HHVM until everything gets stable
This PR was merged into the 2.5-dev branch.
Discussion
----------
Fixed composer to include config component for mocks in phpunit
Commits
-------
939e92d Fixed composer to include config component for mocks in phpunit
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10815).
Discussion
----------
Fixed issue #5427
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5427
| License | MIT
Commits
-------
f308f52 Fixed issue #5427
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] fix#10313: FlattenException not found
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10313
| License | MIT
| Doc PR | none
Note that this patch should be ignored while merging into 2.5/master (it will conflict because 2.5/master has a much stronger workaround, not suitable for a minor release IMHO).
Commits
-------
b147cfa [Debug] fix#10313: FlattenException not found because of https://bugs.php.net/42098
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] fix ErrorHandlerTest when context is not an array
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Commits
-------
988a5dc [Debug] fix ErrorHandlerTest when context is not an array
* 2.4:
[Debug] ErrorHandler: remove $GLOBALS from context in PHP5.3 fix#10292
Allow File instance to be passed to BinaryFileResponse
Add upgrade instructions for the LoggerInterface
fixed CS
Removed strict check when found variables inside a translation
[ExpressionLanguage] Test for the non-strict in_array check in parsePrimaryExpression in Parser.php
Strict in_array check in Parser.php
Updated Serbian latin validation translation
Conflicts:
src/Symfony/Component/Debug/ErrorHandler.php
* 2.3:
[Debug] ErrorHandler: remove $GLOBALS from context in PHP5.3 fix#10292
Allow File instance to be passed to BinaryFileResponse
Add upgrade instructions for the LoggerInterface
fixed CS
Removed strict check when found variables inside a translation
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Debug] less intrusive work around for https://bugs.php.net/54275
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10787, #10292
| License | MIT
| Doc PR | none
- This PR supersedes the behavior introduced in https://github.com/symfony/symfony/pull/10725 :
Instead of building some complicated code to work around https://bugs.php.net/54275, the code is now as
straightforward as possible, with a conditional fallback work around.
- The handling of fatal errors is also made more robust/fail-safe.
- Last but not least, ErrorsLoggerListener and FatalErrorExceptionsListener are now registered earlier and
are now cleaning up their handler/logger once set to prevent setting again and again for sub-requests
(+remove one refcount for these handler and logger).
Commits
-------
d7a186f [Debug] less intrusive work around for https://bugs.php.net/54275
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Allow File instance to be passed to BinaryFileResponse
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10608
| License | MIT
| Doc PR |
See https://github.com/symfony/symfony/issues/10608 for discussion and reasoning.
The docblocks get rather long with this change. The File class does extend SplFileObject so technically it could be left out of the docblock if that is more desirable.
Commits
-------
fc04ad2 Allow File instance to be passed to BinaryFileResponse