Commit Graph

32032 Commits

Author SHA1 Message Date
Nicolas Grekas
e659ec175f bug #23477 [Process] Fix parsing args on Windows (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[Process] Fix parsing args on Windows

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23455
| License       | MIT
| Doc PR        | -

Commits
-------

8826da1 [Process] Fix parsing args on Windows
2017-07-12 08:48:08 +02:00
Nicolas Grekas
954e9f13c5 feature #23037 [TwigBundle] Added a RuntimeExtensionInterface to take advantage of autoconfigure (lyrixx)
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBundle] Added a RuntimeExtensionInterface to take advantage of autoconfigure

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | - (asked by @nicolas-grekas)
| License       | MIT
| Doc PR        | -

---

Before:

```yaml
#app/config/services.yml
services:
    _defaults:
        autoconfigure: true

    AppBundle\Twig\HelloExtension:
        tags: ['twig.runtime']
```

After:

```yaml
#app/config/services.yml
services:
    _defaults:
        autoconfigure: true

#Yes, there are nothing anymore
```

Commits
-------

ba8763b [TwigBundle] Added a RuntimeExtensionInterface to take advantage of autoconfigure
2017-07-12 08:47:27 +02:00
Nicolas Grekas
c2a6a6e9b5 bug #23256 [Security] Fix authentication.failure event not dispatched on AccountStatusException (chalasr)
This PR was merged into the 2.7 branch.

Discussion
----------

[Security] Fix authentication.failure event not dispatched on AccountStatusException

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/18807
| License       | MIT
| Doc PR        | n/a

Authentication fails if the user exists but its account is disabled/expired/locked, the failure event should be dispatched in this case, so that you can hook into as for any authentication exception.

Commits
-------

64c2efd [Security] Fix authentication.failure event not dispatched on AccountStatusException
2017-07-12 08:41:53 +02:00
Nicolas Grekas
676a17e22b bug #23461 Use rawurlencode() to transform the Cookie into a string (javiereguiluz)
This PR was squashed before being merged into the 2.7 branch (closes #23461).

Discussion
----------

Use rawurlencode() to transform the Cookie into a string

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23255
| License       | MIT
| Doc PR        | -

Commits
-------

025dfff Use rawurlencode() to transform the Cookie into a string
2017-07-11 16:37:20 +02:00
Javier Eguiluz
025dfff675 Use rawurlencode() to transform the Cookie into a string 2017-07-11 16:37:17 +02:00
Nicolas Grekas
66ead2e972 minor #23476 [VarDumper] Test ReflectionCaster excluding verbosity (maidmaid)
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] Test ReflectionCaster excluding verbosity

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

Cover better ``ReflectionCaster`` in tests thanks to ``EXCLUDE_*`` filter which was added in https://github.com/symfony/symfony/pull/22588.

Commits
-------

e535089 Add exculde verbosity test
2017-07-11 16:36:03 +02:00
Grégoire Pineau
ba8763b12e [TwigBundle] Added a RuntimeExtensionInterface to take advantage of autoconfigure 2017-07-11 16:22:33 +02:00
Fabien Potencier
f9d73b902d feature #22176 [DI] Allow imports in string format for YAML (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Allow imports in string format for YAML

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

I see no real reasons why this shouldnt be allowed..

Before

```yml
imports:
    - { resource: config.yml }
```

After

```yml
imports:
    - config.yml
```

Commits
-------

632e934cfa [DI] Allow imports in string format for YAML
2017-07-11 15:58:08 +02:00
Nicolas Grekas
050d686096 feature #23295 [Security] Lazy load user providers (chalasr)
This PR was merged into the 3.4 branch.

Discussion
----------

[Security] Lazy load user providers

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

d7914a6 [Security] Lazy load user providers
2017-07-11 15:48:06 +02:00
Nicolas Grekas
8826da1c81 [Process] Fix parsing args on Windows 2017-07-11 15:19:03 +02:00
Dany Maillard
e53508986a Add exculde verbosity test 2017-07-11 11:21:44 +02:00
Nicolas Grekas
2b3afd2683 bug #23465 [HttpKernel][VarDumper] Truncate profiler data & optim perf (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[HttpKernel][VarDumper] Truncate profiler data & optim perf

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23415, #21547 and hopefully #23110 and #23175
| License       | MIT
| Doc PR        | -

Commits
-------

754d3a7 [HttpKernel][VarDumper] Truncate profiler data & optim perf
2017-07-11 11:17:07 +02:00
Nicolas Grekas
bd30a27805 minor #23470 [VarDumper] Test ExceptionCaster excluding verbosity (maidmaid)
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] Test ExceptionCaster excluding verbosity

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

Cover better ``ExceptionCaster`` in tests thanks to filter which was added in https://github.com/symfony/symfony/pull/22588.

Commits
-------

85766c9 Add exculde verbosity test
2017-07-11 11:12:37 +02:00
Nicolas Grekas
77b8ea751c Merge branch '3.3' into 3.4
* 3.3:
  Don't display the Symfony debug toolbar when printing the page
  do not wire namespaces for the ArrayAdapter
  check _controller attribute is a string before parsing it
  [Cache] Added test for ApcuAdapter when using in CLI
  allow to configure custom formats in XML configs
  [HttpKernel] fix DumpDataCollector tests
  [FrameworkBundle] fix changelog
  [WebProfilerBundle] Cleanup profiler leftover
  [DotEnv] Fix variable substitution
  require the XML PHP extension
  Fix phpdoc for serializer normalizers exceptions
  Fixed absolute url generation for query strings and hash urls
  bumped Symfony version to 2.8.25
  updated VERSION for 2.8.24
  updated CHANGELOG for 2.8.24
  bumped Symfony version to 2.7.32
  [Filesystem] Dont copy perms when origin is remote
  updated VERSION for 2.7.31
  update CONTRIBUTORS for 2.7.31
  updated CHANGELOG for 2.7.31
2017-07-11 09:19:17 +02:00
Nicolas Grekas
22b67a4430 Merge branch '3.2' into 3.3
* 3.2:
  Don't display the Symfony debug toolbar when printing the page
  do not wire namespaces for the ArrayAdapter
  [Cache] Added test for ApcuAdapter when using in CLI
  allow to configure custom formats in XML configs
  [HttpKernel] fix DumpDataCollector tests
  [FrameworkBundle] fix changelog
  [WebProfilerBundle] Cleanup profiler leftover
  require the XML PHP extension
  Fix phpdoc for serializer normalizers exceptions
  Fixed absolute url generation for query strings and hash urls
  bumped Symfony version to 2.8.25
  updated VERSION for 2.8.24
  updated CHANGELOG for 2.8.24
  bumped Symfony version to 2.7.32
  [Filesystem] Dont copy perms when origin is remote
  updated VERSION for 2.7.31
  update CONTRIBUTORS for 2.7.31
  updated CHANGELOG for 2.7.31
2017-07-11 09:17:58 +02:00
Nicolas Grekas
6435c7f3cf Merge branch '2.8' into 3.2
* 2.8:
  Don't display the Symfony debug toolbar when printing the page
  allow to configure custom formats in XML configs
  require the XML PHP extension
  Fixed absolute url generation for query strings and hash urls
  bumped Symfony version to 2.8.25
  updated VERSION for 2.8.24
  updated CHANGELOG for 2.8.24
  bumped Symfony version to 2.7.32
  [Filesystem] Dont copy perms when origin is remote
  updated VERSION for 2.7.31
  update CONTRIBUTORS for 2.7.31
  updated CHANGELOG for 2.7.31
2017-07-11 09:14:38 +02:00
Nicolas Grekas
6735b35062 Merge branch '2.7' into 2.8
* 2.7:
  allow to configure custom formats in XML configs
  require the XML PHP extension
  Fixed absolute url generation for query strings and hash urls
  bumped Symfony version to 2.7.32
  [Filesystem] Dont copy perms when origin is remote
  updated VERSION for 2.7.31
  update CONTRIBUTORS for 2.7.31
  updated CHANGELOG for 2.7.31
2017-07-11 09:12:11 +02:00
Nicolas Grekas
38905d3f6a feature #23440 [Routing] Add matched and default parameters to redirect responses (artursvonda, Tobion)
This PR was merged into the 3.4 branch.

Discussion
----------

[Routing] Add matched and default parameters to redirect responses

| Q | A |
| --- | --- |
| Branch? | master |
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | #18012, #19037 |
| License | MIT |
| Doc PR |  |

Finished #18012 and #19037

Commits
-------

4c1fdd4 [Routing] also add matched params for redirect due to trailing slash
dc3f7a9 [Routing] Add matched and default parameters to redirect responses
2017-07-11 09:07:41 +02:00
Nicolas Grekas
0e988ca9be minor #23453 [WebProfilerBundle] Cleanup profiler leftover (ro0NL)
This PR was merged into the 3.2 branch.

Discussion
----------

[WebProfilerBundle] Cleanup profiler leftover

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Leftover from 2.8

Commits
-------

8a19795 [WebProfilerBundle] Cleanup profiler leftover
2017-07-11 08:59:50 +02:00
Nicolas Grekas
4c483ba3f4 bug #23457 [FrameworkBundle] check _controller attribute is a string before parsing it (alekitto)
This PR was merged into the 3.3 branch.

Discussion
----------

[FrameworkBundle] check _controller attribute is a string before parsing it

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23456
| License       | MIT

Avoids an error to be raised in case described in issue #23456.

Commits
-------

0b349ae check _controller attribute is a string before parsing it
2017-07-11 08:58:29 +02:00
Nicolas Grekas
05e3332fe2 bug #23459 [TwigBundle] allow to configure custom formats in XML configs (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[TwigBundle] allow to configure custom formats in XML configs

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #13554
| License       | MIT
| Doc PR        |

Commits
-------

5a3a24b allow to configure custom formats in XML configs
2017-07-11 08:56:31 +02:00
Nicolas Grekas
26ad2ad400 bug #23460 Don't display the Symfony debug toolbar when printing the page (javiereguiluz)
This PR was squashed before being merged into the 2.8 branch (closes #23460).

Discussion
----------

Don't display the Symfony debug toolbar when printing the page

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23303
| License       | MIT
| Doc PR        | -

Commits
-------

ca3ff88 Don't display the Symfony debug toolbar when printing the page
2017-07-11 08:54:59 +02:00
Javier Eguiluz
ca3ff88361 Don't display the Symfony debug toolbar when printing the page 2017-07-11 08:54:57 +02:00
Nicolas Grekas
7fd523678a bug #23469 [FrameworkBundle] do not wire namespaces for the ArrayAdapter (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[FrameworkBundle] do not wire namespaces for the ArrayAdapter

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23214
| License       | MIT
| Doc PR        |

Commits
-------

9380614 do not wire namespaces for the ArrayAdapter
2017-07-11 08:48:27 +02:00
Tobias Schultze
4c1fdd4edf [Routing] also add matched params for redirect due to trailing slash 2017-07-11 08:35:47 +02:00
Nicolas Grekas
2fc9bd2f99 minor #23446 [Cache] Added test for ApcuAdapter when using in CLI (lyrixx)
This PR was merged into the 3.2 branch.

Discussion
----------

[Cache] Added test for ApcuAdapter when using in CLI

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23344
| License       | MIT
| Doc PR        | -

---

I also hit #23344 and I did not notice it was already fixed (#23390) and released (2 days ago, I updated the vendors 4 days ago :trollface: ). But as I have written test for it ... Let's contribute anyway

Commits
-------

64d196a [Cache] Added test for ApcuAdapter when using in CLI
2017-07-11 08:33:12 +02:00
Dany Maillard
85766c9b5e Add exculde verbosity test 2017-07-10 23:04:06 +02:00
Christian Flothmann
9380614de9 do not wire namespaces for the ArrayAdapter 2017-07-10 19:31:39 +02:00
Alessandro Chitolina
0b349aee18
check _controller attribute is a string before parsing it 2017-07-10 18:12:17 +02:00
Grégoire Pineau
64d196adae [Cache] Added test for ApcuAdapter when using in CLI 2017-07-10 18:11:13 +02:00
Nicolas Grekas
754d3a7568 [HttpKernel][VarDumper] Truncate profiler data & optim perf 2017-07-10 16:18:27 +02:00
Nicolas Grekas
195d949e6b minor #23458 [HttpKernel] fix DumpDataCollector tests (xabbuh)
This PR was merged into the 3.2 branch.

Discussion
----------

[HttpKernel] fix DumpDataCollector tests

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

to reflect the changes from #23413

Commits
-------

5dbee5b [HttpKernel] fix DumpDataCollector tests
2017-07-10 11:30:54 +02:00
Christian Flothmann
9b8d96b845 [Validator] sync upgrade file with latest code changes 2017-07-09 20:26:31 +02:00
Christian Flothmann
5a3a24b0ac allow to configure custom formats in XML configs 2017-07-09 16:08:05 +02:00
Christian Flothmann
5dbee5b5bd [HttpKernel] fix DumpDataCollector tests 2017-07-09 14:41:10 +02:00
Christian Flothmann
b033e79211 [FrameworkBundle] fix changelog
The `framework.serializer.cache` option was also deprecated in Symfony
3.1. This was documented in the upgrade file, but was not reflected in
the bundle's changelog.
2017-07-09 12:28:17 +02:00
Roland Franssen
8a197958cb [WebProfilerBundle] Cleanup profiler leftover 2017-07-08 21:14:51 +02:00
Roland Franssen
632e934cfa [DI] Allow imports in string format for YAML 2017-07-08 18:23:22 +02:00
Roland Franssen
595a225a0f [DI] Remove irrelevant comment from container 2017-07-08 10:35:50 +02:00
Maxime Steinhausser
07c5aa6822 [Validator] Allow to use a property path to get value to compare in comparison constraints 2017-07-06 20:13:35 +02:00
Arturs Vonda
dc3f7a9ebd [Routing] Add matched and default parameters to redirect responses 2017-07-06 17:17:23 +03:00
Nicolas Grekas
0bcc5afbda Minor cleanups 2017-07-06 16:36:30 +03:00
Fabien Potencier
c3ec5c5361 bug #23434 [DotEnv] Fix variable substitution (brieucthomas)
This PR was merged into the 3.3 branch.

Discussion
----------

[DotEnv] Fix variable substitution

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23423
| License       | MIT
| Doc PR        | no

Commits
-------

1dfcdc7000 [DotEnv] Fix variable substitution
2017-07-06 15:57:36 +03:00
Tobias Schultze
c7c5ba8946 [TwigBridge] cleaner implementation of the TwigRenderer 2017-07-06 14:34:37 +02:00
Brieuc Thomas
1dfcdc7000 [DotEnv] Fix variable substitution 2017-07-06 14:23:24 +02:00
Nicolas Grekas
47ee1d53c1 Merge branch '3.3' into 3.4
* 3.3: (33 commits)
  Preserve HttpOnly value when deserializing a header
  [DX] [TwigBundle] Enhance the new exception page design
  Fix deprecated message
  [DI][Security] Prevent unwanted deprecation notices when using Expression Languages
  bumped Symfony version to 3.3.5
  updated VERSION for 3.3.4
  updated CHANGELOG for 3.3.4
  [VarDumper] Reduce size of serialized Data objects
  bumped Symfony version to 3.2.12
  updated VERSION for 3.2.11
  updated CHANGELOG for 3.2.11
  fixed bad merge
  Fix indent of methods
  [Cache] Handle APCu failures gracefully
  [DoctrineBridge] Use normalizedIds for resetting entity manager services
  [FrameworkBundle] Do not remove files from assets dir
  [FrameworkBundle] 3.3: Don't get() private services from debug:router
  bumped Symfony version to 3.3.4
  updated VERSION for 3.3.3
  updated CHANGELOG for 3.3.3
  ...
2017-07-06 13:23:40 +03:00
Nicolas Grekas
7ac2570d5c feature #22832 [Debug] Deprecate support for stacked errors (mbabker)
This PR was merged into the 3.4 branch.

Discussion
----------

[Debug] Deprecate support for stacked errors

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | #22804
| License       | MIT
| Doc PR        | n/a

Per discussion in #22804 this deprecates support for error stacking.  // @nicolas-grekas

Commits
-------

04b8b80 Deprecate support for stacked errors
2017-07-06 13:21:47 +03:00
Michael Babker
04b8b8027c Deprecate support for stacked errors 2017-07-06 13:08:05 +03:00
Fabien Potencier
26641bdf44 fixed tests 2017-07-06 12:58:45 +03:00
Fabien Potencier
4f187ced94 feature #21469 [HttpFoundation] Find the original request protocol version (thewilkybarkid)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead (closes #21469).

Discussion
----------

[HttpFoundation] Find the original request protocol version

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #21415
| License       | MIT
| Doc PR        |

Adds a new method to `Request` to find the original protocol version from the `Via` header, if the request is from a trusted proxy.

Commits
-------

5a37f84713 [HttpFoundation] Find the original request protocol version
2017-07-06 12:57:48 +03:00