This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12446).
Discussion
----------
[Twig/DebugBundle] move dump extension registration
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12440
| License | MIT
| Doc PR | -
An alternative fix for #12440
Commits
-------
8cf3d69 [TwigBundle/DebugBundle] move dump extension & cleanups
This PR was merged into the 2.3 branch.
Discussion
----------
compare version using PHP_VERSION_ID
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
To let opcode caches optimize cached code, the `PHP_VERSION_ID`
constant is used to detect the current PHP version instead of calling
`version_compare()` with `PHP_VERSION`.
Commits
-------
367ed3c compare version using PHP_VERSION_ID
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12433).
Discussion
----------
[Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
Commits
-------
0bd19aa [Bridge/Propel1] Changed deps to accepts all upcoming propel1 versions
To let opcode caches optimize cached code, the `PHP_VERSION_ID`
constant is used to detect the current PHP version instead of calling
`version_compare()` with `PHP_VERSION`.
This PR was merged into the 2.6 branch.
Discussion
----------
[Form] *_timezone changes also affect the BirthdayType
| Q | A
| ------------- | ---
| Fixed tickets |
| License | MIT
The changes from #12404 also affect the `BirthdayType`.
Commits
-------
7faee60 *_timezone changes also affect the BirthdayType
This PR was merged into the 2.5 branch.
Discussion
----------
[2.5][FrameworkBundle] Fix server run in case the router script does not exist
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
I've also added the use of `Process\PhpExecutableFinder`
Commits
-------
1a79859 [FrameworkBundle] Fix server run in case the router script does not exist
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12404).
Discussion
----------
[Form] Remove timezone options from DateType and TimeType
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #12239
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/4417
replaces #12380
Commits
-------
849fb29 Drop support for model_timezone and view_timezone options in TimeType and DateType.
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12487).
Discussion
----------
[DomCrawler] Added support for 'link' tags in the Link class
| Q | A
| ------------- | ---
| Bug fix? | No
| New feature? | Not really
| BC breaks? | No
| Deprecations? | No
| Tests pass? | Yes (at least those of DomCrawler)
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
My use case is that I crawl web pages for RSS links so I need to retrieve the 'href' attributes of 'link' elements.
I would like to use the Link class to resolve encountered 'href' relative URLs.
Please note that I did not replace `if ('a' !== $node->nodeName && 'area' !== $node->nodeName)` with `if (!$node->hasAttribute('href'))` to ensure backward compatibility.
Indeed, according to http://www.w3.org/TR/html5/links.html, the 'href' attribute is optional for 'a' and 'area' elements.
Commits
-------
d8d6fcf [DomCrawler] Added support for link tags in the Link class
This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#12448).
Discussion
----------
[Session] Fix parameter names in WriteCheckSessionHandler
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
90e7830 [Session] Fix parameter names in WriteCheckSessionHandler
This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#12492).
Discussion
----------
[HttpKernel] Add consistency with request type checking
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
1852f85 Add consistency with request type checking
* 2.7:
Update filesystem readme.md to include exists method
Add machine readable events
Fixed minor typo
[FrameworkBundle] Fix server start in case the PHP binary is not found
Update UPGRADE-2.6.md
[HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector
fixed typo
[Translations] Added missing Hebrew language trans-unit sources
[DependencyInjection] inlined factory not referenced
Fixed case for empty folder
Fixed whitespace control for password form widget
[Routing] correctly initialize condition as string
* 2.6:
Update filesystem readme.md to include exists method
Add machine readable events
Fixed minor typo
[FrameworkBundle] Fix server start in case the PHP binary is not found
Update UPGRADE-2.6.md
[HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector
fixed typo
[Translations] Added missing Hebrew language trans-unit sources
[DependencyInjection] inlined factory not referenced
Fixed case for empty folder
Fixed whitespace control for password form widget
[Routing] correctly initialize condition as string
* 2.5:
Update filesystem readme.md to include exists method
Add machine readable events
[HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector
fixed typo
[Translations] Added missing Hebrew language trans-unit sources
[DependencyInjection] inlined factory not referenced
Fixed case for empty folder
Fixed whitespace control for password form widget
[Routing] correctly initialize condition as string
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12468).
Discussion
----------
Update filesystem readme.md to include exists method
Read the contributing docs, I don't think I missed anything but to be fair I went through it pretty fast :-/
Commits
-------
16c1b66 Update filesystem readme.md to include exists method
This PR was merged into the 2.6 branch.
Discussion
----------
[2.6][FrameworkBundle] Fix server start in case the PHP binary is not found
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
Commits
-------
a6b1cfc [FrameworkBundle] Fix server start in case the PHP binary is not found
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12299).
Discussion
----------
Add machine readable events
As discussed in [#11878] it would be great to have some simple machine readable way to find events
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #11878
| License | MIT
Commits
-------
ace9a22 Add machine readable events
This PR was submitted for the master branch but it was merged into the 2.6 branch instead (closes#12458).
Discussion
----------
Update UPGRADE-2.6.md
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | -
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
450e341 Update UPGRADE-2.6.md
This PR was submitted for the master branch but it was merged into the 2.5 branch instead (closes#12443).
Discussion
----------
[HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
As part of https://github.com/symfony/symfony/pull/11193 support for controllers using `__invoke()` was added.
The `RequestDataCollector` did not support controllers that were defined in the routing as...
```php
route_name:
path: /{id}
defaults: { _controller: acme_app.page.controller.page }
requirements:
id: \d+
```
Where the controller was defined as...
```php
class PageController
{
public function __invoke()
{
//
}
}
```
This PR adds that support. Tests have been updated.
Commits
-------
f1d043a [HttpKernel][2.6] Adding support for invokable controllers in the RequestDataCollector
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12449).
Discussion
----------
fixed typo
Commits
-------
a7c2a9a fixed typo
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12450).
Discussion
----------
[Translations] Added missing Hebrew language trans-unit sources
[Form] [Validator] [Translations] added missing files
[Security][Translations] added missing files
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | no
| License | MIT
| Doc PR | no
Commits
-------
918b16b [Translations] Added missing Hebrew language trans-unit sources
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#12393).
Discussion
----------
[DependencyInjection] inlined factory not referenced
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
While working with the DI I encountered a `You have requested a non-existent service "xxxxx"` exception.
Research it seems that a private reference was inlined but the private factory that was also referencing to the service was ignored.
A example of the problem:
```XML
<service id="manager"
class="\stdClass"
factory-method="getX"
factory-service="factory"
public="false">
<argument>X</argument>
</service>
<service id="repository"
class="\stdClass"
factory-method="getRepository"
factory-service="manager"
public="false">
<argument>X</argument>
</service>
<service id="storage" class="\stdClass" public="false">
<argument type="service" id="manager"/>
<argument type="service" id="repository"/>
</service>
```
What happens before the patch:
1. repository get's inlined
2. manager get's inlined for the first argument
3. manager get's removed since there was no reference.
After the first commit the following will happen:
1. repository get's inlined
2. manager get's inlined for the first argument
3. manager will not be removed since the inlined repository still references manager
This introduced a smell since InlineServiceDefinitionsPass was still inlining the manager for the first argument.
To fix this I have chosen that not inline factories if they are used more then once by the same definition.
So after the second commit the following will happen:
1. repository get's inlined
Personally I feel that the InlineServiceDefinitionsPass patch isn't the best possible one but that a different fix would probably mean breaking BC so it's probably a good idea to look at this for Symfony 3.0.
Commits
-------
7816a98 [DependencyInjection] inlined factory not referenced