This PR was merged into the 2.3 branch.
Discussion
----------
Enforce UTF-8 charset for core controllers
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7532
| License | MIT
| Doc PR | -
See https://github.com/symfony/symfony/issues/7617 and https://github.com/symfony/symfony/pull/7532 for the context of this PR.
Commits
-------
3032014 Enforce UTF-8 charset for core controllers
This PR was submitted for the 2.7 branch but it was merged into the 3.0-dev branch instead (closes#13756).
Discussion
----------
[3.0][Console] Added type hint
The method `Symfony\Component\Console\Application::renderException()` have 2 parameters not type hint but the PHPDoc reveal types.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | yes
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
Commits
-------
e98c537 [Console] Added type hint
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#13683).
Discussion
----------
[PROCESS] make sure /dev/tty is readable
When using Process from Web-SAPI it is likely that the webserver user
doesn't has rights to use /dev/tty
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #13261
| License | MIT
| Doc PR | -
Commits
-------
935afe6 [PROCESS] make sure /dev/tty is readable
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][FrameworkBundle] Fixed Shell logo
This PR fix#12565.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
d7f008d [FrameworkBundle] Fixed Shell logo
This PR was merged into the 2.7 branch.
Discussion
----------
[PhpUnitBridge] Allow PHP 5.3.3 to use with Symfony 2.3
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
25aa12d [PhpUnitBridge] Allow PHP 5.3.3 to use with Symfony 2.3
This PR was squashed before being merged into the 2.3 branch (closes#13733).
Discussion
----------
[2.3][Process] Fixed PhpProcess::getCommandLine() result
The `PhpProcess::getCommandLine()` return `null` if `PhpProcess::start()` was not called.
```php
$process = new PhpProcess(<<<PHP
<?php echo "foobar";
PHP
);
$process->getCommandLine(); // return null
$process->start();
$process->getCommandLine(); // return the PHP binary path
```
This PR fix the problem.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
Commits
-------
d0f1d32 [2.3][Process] Fixed PhpProcess::getCommandLine() result
This PR was merged into the 2.6 branch.
Discussion
----------
Fix the toolbar JS for IE
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | n/a
- fix the binding of listeners on XMLHttpRequest to always use the addEventListener method. It does not make sense to change it to attachEvent as it is about binding listeners on DOM elements.
- fix the feature detection for the event binding on DOM elements:
- the attachEvent and addEventListener methods are on DOM elements, not on the document object
- the standard method should be preferred in IE versions supporting both methods
- avoid JS errors when XMLHttpRequest is not defined by avoiding to override its open method when the object is not there (old IE versions will still not intercept ajax calls though)
this is the complete fix for the code submitted in #13636 (the fix in https://github.com/symfony/symfony/pull/13684 was incomplete).
Commits
-------
b7aa171 Fix the toolbar JS for IE
This PR was merged into the 2.6 branch.
Discussion
----------
[PropertyAccess] unify and fix doc
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
Commits
-------
d1c8c5d [PropertyAccess] unify and fix doc
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] assertion for ArgvInput::getFirstArgument() with no arguments
| Q | A
| ------------- | ---
| Bug fix? | [no]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| License | MIT
Commits
-------
11b2a9b [Console] explicit assertion for ArgvInput::getFirstArgument() with no arguments
* 2.7:
[PhpUnitBridge] Tweak and fix deprecation notices
[FrameworkBundle] move Routing dep up to make tests pass
Conflicts:
.travis.yml
src/Symfony/Bridge/Twig/composer.json
src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/Compiler/LegacyTemplatingAssetHelperPassTest.php
src/Symfony/Bundle/FrameworkBundle/composer.json
src/Symfony/Bundle/TwigBundle/Tests/Extension/LegacyAssetsExtensionTest.php
src/Symfony/Component/Debug/Tests/FatalErrorHandler/ClassNotFoundFatalErrorHandlerTest.php
This PR was merged into the 2.6 branch.
Discussion
----------
[FrameworkBundle] move Routing dep up to make tests pass
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Ping @Tobion
Commits
-------
c71e2d5 [FrameworkBundle] move Routing dep up to make tests pass
This PR was merged into the 2.7 branch.
Discussion
----------
[PhpUnit] new PhpUnit bridge
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #13644
| License | MIT
| Doc PR | -
From the proposed README:
PHPUnit Bridge
==============
Provides utilities for PHPUnit, especially user deprecation notices management.
It comes with the following features:
* disable the garbage collector;
* auto-register `class_exists` to load Doctrine annotations;
* print a user deprecation notices summary at the end of the test suite.
Handling user deprecation notices is sensitive to the SYMFONY_DEPRECATIONS_HELPER
environment variable. This env var configures 3 behaviors depending on its value:
* when set to `strict`, all but legacy-tagged deprecation notices will make tests
fail. This is the recommended mode for best forward compatibility.
* `weak` on the contrary will make tests ignore all deprecation notices.
This is the recommended mode for legacy projects that must use deprecated
interfaces for backward compatibility reasons.
* any other value will respect the current error reporting level.
All three modes will display a summary of deprecation notices at the end of the
test suite, split in two groups:
* **Legacy** deprecation notices denote tests that explicitly test some legacy
interfaces. In all 3 modes, deprecation notices triggered in a legacy-tagged
test do never make a test fail. There are four ways to mark a test as legacy:
- make its class start with the `Legacy` prefix;
- make its method start with `testLegacy`;
- make its data provider start with `provideLegacy` or `getLegacy`;
- add the `@group legacy` annotation to its class or method.
* **Remaining/Other** deprecation notices are all other (non-legacy)
notices, grouped by message, test class and method.
Usage
-----
Add this bridge to the `require-dev` section of your composer.json file
(not in `require`) with e.g.
`composer require --dev "symfony/phpunit-bridge"`.
When running `phpunit`, you will see a summary of deprecation notices at the end
of the test suite.
Deprecation notices in the **Remaining/Other** section need some thought.
You have to decide either to:
* update your code to not use deprecated interfaces anymore, thus gaining better
forward compatibility;
* or move them to the **Legacy** section (by using one of the above way).
After reviewing them, you should silence deprecations in the **Legacy** section
if you think they are triggered by tests dedicated to testing deprecated
interfaces. To do so, add the following line at the beginning of your legacy
test case or in the `setUp()` method of your legacy test class:
`$this->iniSet('error_reporting', -1 & ~E_USER_DEPRECATED);`
Last but not least, you should then configure your C.I. to the reporting mode
that is appropriated to your project by setting SYMFONY_DEPRECATIONS_HELPER to
`strict`, `weak` or empty. It is recommended to start with `weak` mode, upgrade
your code as described above, then when the *Remaining/Other* sections are empty,
move to `strict` to keep forward compatibility on the long run.
Commits
-------
acac734 [PhpUnitBridge] new bridge for testing with PHPUnit
This PR was merged into the 2.6 branch.
Discussion
----------
[Security] Fix expectation in a test.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This is related to #13466, which worked perfectly fine in 2.3. It breaks in 2.6 since we've changed the way we check for master request.
Commits
-------
8299a44 [Security] Fix expectation in a test.
This PR was merged into the 2.3 branch.
Discussion
----------
[PropertyAccess] refactor type checks
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
#13735 for 2.3
Commits
-------
9cacecb [PropertyAccess] the property path constructor already implements the type check
4e11c07 [PropertyAccess] refactor type checks to remove duplicate logic
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#13737).
Discussion
----------
[HttpFoundation] Fix getHost and getPort functions in docblock
This fixes the incorrect references to the functions `getClientHost` and `getClientPort` in the docblock for Request::setTrustedHeaderName.
| Q | A
| ------------- | ---
| Fixed tickets | none
| License | MIT
Commits
-------
1ae9f9c [HttpFoundation] Fix getHost and getPort functions in docblock
- fix the binding of listeners on XMLHttpRequest to always use the
addEventListener method. It does not make sense to change it to
attachEvent as it is about binding listeners on DOM elements.
- fix the feature detection for the event binding on DOM elements:
- the attachEvent and addEventListener methods are on DOM elements,
not on the document object
- the standard method should be preferred in IE versions supporting
both methods
- avoid JS errors when XMLHttpRequest is not defined by avoiding to
override its open method when the object is not there (old IE versions
will still not intercept ajax calls though)
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#13725).
Discussion
----------
Add phpdoc for SecurityFactoryInterface::getPosition
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
bcb2e09 Add phpdoc for SecurityFactoryInterface::getPosition