diogo/symfony
Archived
1
0
Fork 0
Code Issues Pull Requests Packages Projects Releases Wiki Activity
48,895 Commits 24 Branches 563 Tags 228 MiB
4d05dbbfb5
Commit Graph

48895 Commits

This Branch
This Branch
All Branches
Author SHA1 Message Date
Fabien Potencier
a73523b065 minor #36798 Secrets, Security, and Messenger commands descriptions should not end with a "." (dot) (carlosbuenosvinos) 
This PR was squashed before being merged into the 5.1-dev branch.

Discussion
----------

Secrets, Security, and Messenger commands descriptions should not end with a "." (dot)

| Q             | A
| ------------- | ---
| Branch?       | 4.4 (to be switched while merging)
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

When running `bin/console` almost all the command descriptions do not end with a ".". So in order to be consistent, we should remove it from the Secrets Commands.

**Current Output for Secrets Commands (with dots)**
![image](https://user-images.githubusercontent.com/351553/81734096-4a8bca00-9493-11ea-8d5c-bb1dda20bcb0.png)

**Other Command Descriptions (without dots)**
![image](https://user-images.githubusercontent.com/351553/81734428-c84fd580-9493-11ea-8312-05557c7e6f0b.png)

![image](https://user-images.githubusercontent.com/351553/81734489-def62c80-9493-11ea-8d2b-1eb3668291cc.png)

**Symfony CLI output (without dots)**
![image](https://user-images.githubusercontent.com/351553/81734720-3eecd300-9494-11ea-805e-2a3ae3178e8c.png)

Commits
-------

4f7633983e Secrets, Security, and Messenger commands descriptions should not end with a "." (dot)
 2020-05-12 22:48:08 +02:00
Carlos Buenosvinos
4f7633983e Secrets, Security, and Messenger commands descriptions should not end with a "." (dot) 2020-05-12 22:47:58 +02:00
Nicolas Grekas
44b45cbaf1 [Serializer] fix issue with PHP 8 2020-05-12 22:34:06 +02:00
Nicolas Grekas
869770c952 bug #36796 [DI] Use require_once instead of require when appending cache warmer-returned files to preload file (ovrflo) 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[DI] Use require_once instead of require when appending cache warmer-returned files to preload file

Use require_once instead of require when appending cache warmer-returned files to preload file.

| Q             | A
| ------------- | ---
| Branch?       | master/5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36793
| License       | MIT

As requested in #36793, I have changed the Preloader to append files with `require_once` (instead of the existing `require`). This should also help for cases when multiple CacheWarmers return the same file(s).

Commits
-------

a53d12674c bug #36793 [DI][Preload] Use require_once instead of require when appending cache warmer-returned files to preload file.
 2020-05-12 21:00:26 +02:00
Catalin Dan
a53d12674c bug #36793 [DI][Preload] Use require_once instead of require when appending cache warmer-returned files to preload file. 2020-05-12 20:28:51 +03:00
Nathan Dench
967bc4a860 [WebProfiler] Remove 'none' when appending CSP tokens 2020-05-12 17:24:37 +10:00
Fabien Potencier
a8cb3cd2da bug #36743 [Yaml] Fix escaped quotes in quoted multi-line string (ossinkine) 
This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] Fix escaped quotes in quoted multi-line string

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| License       | MIT

This PR continues https://github.com/symfony/symfony/pull/19304

This PR fixes incorrect parsing quoted multi-line string which contain escaped quotes, see tests

Commits
-------

2e99caacaf [Yaml] Fix escaped quotes in quoted multi-line string
 2020-05-11 09:51:54 +02:00
Fabien Potencier
1de42a5f08 bug #36773 [HttpClient] preserve the identity of responses streamed by TraceableHttpClient (nicolas-grekas) 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpClient] preserve the identity of responses streamed by TraceableHttpClient

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

afc44dae16 [HttpClient] preserve the identity of responses streamed by TraceableHttpClient
 2020-05-10 18:21:09 +02:00
Fabien Potencier
6541ac2d03 bug #36777 [TwigBundle] FormExtension does not have a constructor anymore since sf 4.0 (Tobion) 
This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBundle] FormExtension does not have a constructor anymore since sf 4.0

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

35e391aaa2 [TwigBundle] FormExtension does not have a constructor anymore since sf 4.0
 2020-05-10 18:07:44 +02:00
Tobias Schultze
35e391aaa2 [TwigBundle] FormExtension does not have a constructor anymore since sf 4.0 2020-05-10 16:50:02 +02:00
Jakub Zalas
50db61ec90
Install mongodb/mongodb to enable mongodb tests 2020-05-10 15:15:39 +01:00
Nicolas Grekas
afc44dae16 [HttpClient] preserve the identity of responses streamed by TraceableHttpClient 2020-05-10 09:16:11 +02:00
Fabien Potencier
3acc28f7e3 bug #36766 [HttpClient] add TimeoutExceptionInterface (nicolas-grekas) 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpClient] add TimeoutExceptionInterface

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

This is fixing a design issue: unlike any other `TransportExceptionInterface`, timeouts are not fatal transport errors. For this reason, we must allow one to identify them.

~This PR also marks exception classes as `@internal`, to encourage ppl to catch them using their interface and not their class name.~ this would revert #30549

Commits
-------

ab8eca0ef6 [HttpClient] add TimeoutExceptionInterface
 2020-05-10 08:03:39 +02:00
Nicolas Grekas
ab8eca0ef6 [HttpClient] add TimeoutExceptionInterface 2020-05-09 20:37:03 +02:00
Nicolas Grekas
2ed6a0d74c Merge branch '5.0' 
* 5.0:
  [HttpClient] fix testTimeoutIsNotAFatalError (bis)
 2020-05-09 19:43:56 +02:00
Nicolas Grekas
b3e49ee2b4 Merge branch '4.4' into 5.0 
* 4.4:
  [HttpClient] fix testTimeoutIsNotAFatalError (bis)
 2020-05-09 19:43:51 +02:00
Nicolas Grekas
333f7187dc [HttpClient] fix testTimeoutIsNotAFatalError (bis) 2020-05-09 19:43:44 +02:00
Nicolas Grekas
3cdd2e4643 Merge branch '5.0' 
* 5.0:
  [HttpClient] fix testTimeoutIsNotAFatalError
 2020-05-09 18:24:19 +02:00
Nicolas Grekas
0ff13b2404 Merge branch '4.4' into 5.0 
* 4.4:
  [HttpClient] fix testTimeoutIsNotAFatalError
 2020-05-09 18:24:13 +02:00
Nicolas Grekas
00ae470307 [HttpClient] fix testTimeoutIsNotAFatalError 2020-05-09 18:24:06 +02:00
Nicolas Grekas
53423db039 Merge branch '5.0' 
* 5.0:
  [HttpClient] improve testTimeoutIsNotAFatalError
  Fix for #36715
 2020-05-09 17:57:56 +02:00
Nicolas Grekas
c794cab0cb Merge branch '4.4' into 5.0 
* 4.4:
  [HttpClient] improve testTimeoutIsNotAFatalError
  Fix for #36715
 2020-05-09 17:57:42 +02:00
Nicolas Grekas
4ab6ff37bd [HttpClient] improve testTimeoutIsNotAFatalError 2020-05-09 17:57:30 +02:00
Fabien Potencier
6310084f25 bug #36716 [Mime] handle passing custom mime types as string (mcneely) 
This PR was merged into the 4.4 branch.

Discussion
----------

[Mime] handle passing custom mime types as string

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #36715
| License       | MIT
| Doc PR        | none
Fix's issue where custom mimetypes were failing

Commits
-------

f3005ec653 Fix for #36715
 2020-05-09 14:32:08 +02:00
Paul L. McNeely
f3005ec653
Fix for #36715 2020-05-09 07:22:40 -05:00
Fabien Potencier
97a578201d minor #36763 [Security] Improve method signatures (minor) (umulmrum) 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[Security] Improve method signatures (minor)

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Improves type declarations and docblocks of new authenticator-related methods.

Commits
-------

b009254090 [Security] Improve method signatures (minor)
 2020-05-09 14:14:32 +02:00
Nicolas Grekas
52c52a846c Merge branch '5.0' 
* 5.0:
  [HttpClient] test that timeout is not fatal
 2020-05-09 14:11:30 +02:00
Nicolas Grekas
d01ea50f7b Merge branch '4.4' into 5.0 
* 4.4:
  [HttpClient] test that timeout is not fatal
 2020-05-09 14:10:43 +02:00
Nicolas Grekas
99d5818489 minor #36771 [HttpClient] test that timeout is not fatal (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpClient] test that timeout is not fatal

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

36ccf4c65b [HttpClient] test that timeout is not fatal
 2020-05-09 14:10:26 +02:00
Nicolas Grekas
36ccf4c65b [HttpClient] test that timeout is not fatal 2020-05-09 14:08:40 +02:00
Stefan Kruppa
b009254090 [Security] Improve method signatures (minor) 2020-05-09 13:45:48 +02:00
Nicolas Grekas
8fec0654d2 bug #36765 [HttpClient] fix dealing with informational response (nicolas-grekas) 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpClient] fix dealing with informational response

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Skipping the test was a bad idea, the failure was legit.

Commits
-------

9068aa48e2 [HttpClient] fix dealing with informational response
 2020-05-08 23:44:02 +02:00
Nicolas Grekas
012247dc98 minor #36764 [HttpClient] remove "experimental" annotations (nicolas-grekas) 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[HttpClient] remove "experimental" annotations

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

db4cb51f0c [HttpClient] remove "experimental" annotations
 2020-05-08 23:43:12 +02:00
Nicolas Grekas
2b554d8ad7 [Contracts] bump branch alias 2020-05-08 23:41:03 +02:00
Nicolas Grekas
9068aa48e2 [HttpClient] fix dealing with informational response 2020-05-08 22:52:14 +02:00
Nicolas Grekas
db4cb51f0c [HttpClient] remove "experimental" annotations 2020-05-08 22:08:25 +02:00
Nicolas Grekas
fb90fb3bb7 minor #36758 [5.1] CS fixes (nicolas-grekas) 
This PR was merged into the 5.1-dev branch.

Discussion
----------

[5.1] CS fixes

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

bb164e6615 [5.1] CS fixes
 2020-05-08 14:37:13 +02:00
Nicolas Grekas
f8616f8eae Merge branch '5.0' 
* 5.0:
  [PhpUnitBridge] fix bad test
  [4.4] CS fixes
  [3.4] CS fixes
  Disable phpunit verbosity
  Queue name is a required parameter
  [FrameworkBundle] display actual target for error in AssetsInstallCommand
  Remove patches for Doctrine bugs and deprecations
  [Mime] fix bad method call on "EmailAddressContains"
  [DI][EventDispatcher] added contract for implementation
 2020-05-08 14:36:29 +02:00
Nicolas Grekas
0b34b39cc8 Merge branch '4.4' into 5.0 
* 4.4:
  [PhpUnitBridge] fix bad test
  [4.4] CS fixes
  [3.4] CS fixes
  Disable phpunit verbosity
  Queue name is a required parameter
  [FrameworkBundle] display actual target for error in AssetsInstallCommand
  Remove patches for Doctrine bugs and deprecations
  [Mime] fix bad method call on "EmailAddressContains"
  [DI][EventDispatcher] added contract for implementation
 2020-05-08 14:34:39 +02:00
Nicolas Grekas
3783200074 minor #36761 [PhpUnitBridge] fix bad test (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[PhpUnitBridge] fix bad test

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Mutating the global state of the autoloader... terrible idea. This should fix tests and remove the lines we were wondering about in the CI:
`Undefined index: remaining selfCount in [...]`

Commits
-------

edb517699a [PhpUnitBridge] fix bad test
 2020-05-08 14:34:26 +02:00
Nicolas Grekas
edb517699a [PhpUnitBridge] fix bad test 2020-05-08 14:32:38 +02:00
Nicolas Grekas
da8b9552ad Merge branch '3.4' into 4.4 
* 3.4:
  [3.4] CS fixes
 2020-05-08 12:54:34 +02:00
Nicolas Grekas
020fa77db9 minor #36757 [4.4] CS fixes (nicolas-grekas) 
This PR was merged into the 4.4 branch.

Discussion
----------

[4.4] CS fixes

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

eba09d47e7 [4.4] CS fixes
 2020-05-08 12:54:24 +02:00
Nicolas Grekas
1e1060f2eb minor #36756 [3.4] CS fixes (nicolas-grekas) 
This PR was merged into the 3.4 branch.

Discussion
----------

[3.4] CS fixes

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

02b378f248 [3.4] CS fixes
 2020-05-08 12:53:15 +02:00
Nicolas Grekas
bb164e6615 [5.1] CS fixes 2020-05-08 12:41:08 +02:00
Nicolas Grekas
eba09d47e7 [4.4] CS fixes 2020-05-08 12:39:41 +02:00
Nicolas Grekas
02b378f248 [3.4] CS fixes 2020-05-08 12:38:31 +02:00
Nicolas Grekas
66cd9f470c Disable phpunit verbosity 2020-05-08 12:04:27 +02:00
Nicolas Grekas
e75c227d79 bug #36747 Queue name is a required parameter (theravel) 
This PR was submitted for the 5.0 branch but it was merged into the 4.4 branch instead.

Discussion
----------

Queue name is a required parameter

| Q             | A
| ------------- | ---
| Branch?       | 5.0
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Queue name is required parameter, which means this block will just fail

Commits
-------

9d48eedbdc Queue name is a required parameter
 2020-05-08 12:02:38 +02:00
theravel
9d48eedbdc Queue name is a required parameter 2020-05-08 12:02:31 +02:00