Commit Graph

15918 Commits

Author SHA1 Message Date
n-aleha
93544aadfa [DependencyInjection] Fix parameter description in ConfigurationExtensionInterface
| Q             | A
| ------------- | ---
| Fixed tickets | #10845
| License       | MIT

This fixes the description of parameter `array $config` in file ConfigurationExtensionInterface.php by removing the extra `$config`.
2014-05-02 22:42:57 +00:00
Fabien Potencier
c6d88a8cf8 bug #10833 [TwigBridge][Transchoice] set %count% from the current context. (aitboudad)
This PR was merged into the 2.3 branch.

Discussion
----------

[TwigBridge][Transchoice] set %count% from the current context.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | [no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #8408
| License       | MIT

Commits
-------

8f7b2cc [TwigBridge][Transchoice] set %count% from the current context.
2014-05-02 09:31:13 +02:00
Fabien Potencier
a1143be31a minor #10835 Finder typehint fix (hhamon)
This PR was merged into the 2.3 branch.

Discussion
----------

Finder typehint fix

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

f3b0ef1 [Finder] fixed typehint of the Finder::addAdapter() method
2014-05-02 08:19:40 +02:00
Hugo Hamon
f3b0ef1a6f [Finder] fixed typehint of the Finder::addAdapter() method 2014-05-02 00:38:16 +02:00
Abdellatif Ait boudad
8f7b2cc44d [TwigBridge][Transchoice] set %count% from the current context. 2014-05-01 19:10:47 +01:00
Fabien Potencier
d1267cb2d7 minor #10819 Fix a test that was ambiguous (fabpot)
This PR was merged into the 2.3 branch.

Discussion
----------

Fix a test that was ambiguous

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | see #9634 for a discussion of this and #9383 for the report
| License       | MIT
| Doc PR        | n/a

This PR fixes a test that was always passing as the exception catch was catching the PHP notice but also the exception sent by `fail`, so it was useless. That said, I'm not even convinced that this test is useful at all.

Commits
-------

a94b4e0 [Validator] fixed wrong test
2014-05-01 08:28:42 +02:00
Fabien Potencier
1b6daf304f minor #10826 [2.3] Fix phpunit test suite on travis #2 (romainneutron)
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3] Fix phpunit test suite on travis #2

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10821
| License       | MIT

This is a second approach to solve #10821.
Something is weird: `Symfony\Component\Form\Tests\Extension\Core\EventListener\TrimListenerTest` passes when using PHPUnit as phar and fails when using a composer global install

Commits
-------

32e5f67 [DependencyInjection] Fix travis unit tests
c7befd5 Update PHPUnit before run
2014-04-30 18:56:37 +02:00
Romain Neutron
32e5f6727a [DependencyInjection] Fix travis unit tests 2014-04-30 17:29:47 +02:00
Romain Neutron
c7befd5380 Update PHPUnit before run 2014-04-30 17:29:47 +02:00
Fabien Potencier
a94b4e0ae2 [Validator] fixed wrong test 2014-04-30 16:30:03 +02:00
Fabien Potencier
b471dbe27d bug #10820 [WebProfilerBundle] Fixed profiler seach/homepage with empty token (tucksaun)
This PR was merged into the 2.3 branch.

Discussion
----------

[WebProfilerBundle] Fixed profiler seach/homepage with empty token

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10806
| License       | MIT
| Doc PR        | none

Commits
-------

16dd0e5 [WebProfilerBundle] added test case for #10773
5b91e70 [WebProfilerBundle] fixed profiler homepage, fixed #10806
7b425d2 [WebProfilerBundle] Added test case for #10806
2014-04-30 11:31:25 +02:00
Tugdual Saunier
16dd0e5dda [WebProfilerBundle] added test case for #10773 2014-04-30 10:15:45 +02:00
Tugdual Saunier
5b91e70777 [WebProfilerBundle] fixed profiler homepage, fixed #10806 2014-04-30 10:11:17 +02:00
Tugdual Saunier
7b425d229d [WebProfilerBundle] Added test case for #10806 2014-04-30 10:11:11 +02:00
Fabien Potencier
4b56c69319 minor #10802 changed travis to run on the nightly builds of HHVM until everything gets stable (fabpot)
This PR was merged into the 2.3 branch.

Discussion
----------

changed travis to run on the nightly builds of HHVM until everything gets stable

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

As HHVM is not stable enough yet to run Symfony, let's test on the HHVM nightly builds. It will allow us to get a better feeling of the remaining problems with HHVM. ping @deguif

Commits
-------

e93cbd7 changed travis to run on the nightly builds of HHVM until everything gets stable
2014-04-30 09:12:35 +02:00
Fabien Potencier
e93cbd7735 changed travis to run on the nightly builds of HHVM until everything gets stable 2014-04-30 08:48:11 +02:00
Fabien Potencier
93926cae34 bug #10815 Fixed issue #5427 (umpirsky)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10815).

Discussion
----------

Fixed issue #5427

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #5427
| License       | MIT

Commits
-------

f308f52 Fixed issue #5427
2014-04-30 08:40:38 +02:00
umpirsky
f308f521a6 Fixed issue #5427 2014-04-30 08:40:38 +02:00
Fabien Potencier
c18bf19016 bug #10817 [Debug] fix #10313: FlattenException not found (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Debug] fix #10313: FlattenException not found

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10313
| License       | MIT
| Doc PR        | none

Note that this patch should be ignored while merging into 2.5/master (it will conflict because 2.5/master has a much stronger workaround, not suitable for a minor release IMHO).

Commits
-------

b147cfa [Debug] fix #10313: FlattenException not found because of https://bugs.php.net/42098
2014-04-30 08:22:14 +02:00
Nicolas Grekas
b147cfaf15 [Debug] fix #10313: FlattenException not found because of https://bugs.php.net/42098 2014-04-29 21:42:43 +02:00
Fabien Potencier
585b61db95 bug #10803 [Debug] fix ErrorHandlerTest when context is not an array (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Debug] fix ErrorHandlerTest when context is not an array

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

Commits
-------

988a5dc [Debug] fix ErrorHandlerTest when context is not an array
2014-04-28 22:25:34 +02:00
Nicolas Grekas
988a5dc937 [Debug] fix ErrorHandlerTest when context is not an array 2014-04-28 20:50:14 +02:00
Fabien Potencier
48f26f7e94 bug #10801 [Debug] ErrorHandler: remove $GLOBALS from context in PHP5.3 fix #10292 (nicolas-grekas)
This PR was merged into the 2.3 branch.

Discussion
----------

[Debug] ErrorHandler: remove $GLOBALS from context in PHP5.3 fix #10292

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10292
| License       | MIT
| Doc PR        | none

Commits
-------

ed0ed80 [Debug] ErrorHandler: remove $GLOBALS from context in PHP5.3 fix #10292
2014-04-28 18:51:21 +02:00
Fabien Potencier
9e2a834582 bug #10797 [HttpFoundation] Allow File instance to be passed to BinaryFileResponse (anlutro)
This PR was merged into the 2.3 branch.

Discussion
----------

[HttpFoundation] Allow File instance to be passed to BinaryFileResponse

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10608
| License       | MIT
| Doc PR        |

See https://github.com/symfony/symfony/issues/10608 for discussion and reasoning.

The docblocks get rather long with this change. The File class does extend SplFileObject so technically it could be left out of the docblock if that is more desirable.

Commits
-------

fc04ad2 Allow File instance to be passed to BinaryFileResponse
2014-04-28 18:47:48 +02:00
Nicolas Grekas
ed0ed80286 [Debug] ErrorHandler: remove $GLOBALS from context in PHP5.3 fix #10292 2014-04-28 18:43:50 +02:00
Andreas Lutro
fc04ad2134 Allow File instance to be passed to BinaryFileResponse 2014-04-28 18:17:17 +02:00
Fabien Potencier
37a4876d8b minor #10644 Add upgrade instructions for the LoggerInterface that changed in Symfony 2.2 (ch3ric)
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes #10644).

Discussion
----------

Add upgrade instructions for the LoggerInterface that changed in Symfony 2.2

Commits
-------

6daa295 Add upgrade instructions for the LoggerInterface
2014-04-28 12:01:28 +02:00
Charles-Eric Gorron
6daa2951fc Add upgrade instructions for the LoggerInterface 2014-04-28 12:01:28 +02:00
Fabien Potencier
17d7186cf8 fixed CS 2014-04-28 11:30:24 +02:00
Fabien Potencier
11f9497e50 bug #10643 [TwigBridge] Removed strict check when found variables inside a translation (goetas)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10643).

Discussion
----------

[TwigBridge] Removed strict check when found variables inside a translation

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no?
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10638
| License       | MIT

Commits
-------

074191e Removed strict check when found variables inside a translation
2014-04-28 11:28:59 +02:00
Asmir Mustafic
074191e705 Removed strict check when found variables inside a translation 2014-04-28 11:28:59 +02:00
Fabien Potencier
d28149f75e bumped Symfony version to 2.3.14 2014-04-27 15:17:08 +02:00
Fabien Potencier
9c4b11915d updated VERSION for 2.3.13 2014-04-27 10:34:33 +02:00
Fabien Potencier
096d3c983c update CONTRIBUTORS for 2.3.13 2014-04-27 10:34:15 +02:00
Fabien Potencier
f096093d44 updated CHANGELOG for 2.3.13 2014-04-27 10:33:05 +02:00
Fabien Potencier
961275dc27 bug #10789 [Console] Fixed the rendering of exceptions on HHVM with a terminal width (stof)
This PR was merged into the 2.3 branch.

Discussion
----------

[Console] Fixed the rendering of exceptions on HHVM with a terminal width

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | -

If ``getTerminalWidth`` returns a big integer (which is the case in Behat 2.5 which overwrites the method to return ``PHP_INT_MAX`` to avoid limiting the width), the fix done in #10000 for HHVM would be needed as well. So this moves it after the condition rather than having it only for the default.

Commits
-------

6e57380 [Console] Fixed the rendering of exceptions on HHVM with a terminal width
2014-04-27 10:32:45 +02:00
Christophe Coevoet
6e57380d14 [Console] Fixed the rendering of exceptions on HHVM with a terminal width 2014-04-26 13:09:19 +02:00
Fabien Potencier
555fde54fa bug #10773 [WebProfilerBundle ] Fixed an edge case on WDT loading (tucksaun)
This PR was squashed before being merged into the 2.3 branch (closes #10773).

Discussion
----------

[WebProfilerBundle ] Fixed an edge case on WDT loading

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #6824 ?
| License       | MIT
| Doc PR        | none

In some case you can notice the WDT just disappears.
By tracking it down, I noticed that the XHR call returns an empty response with 200 as status code, but if you go directly on the _wdt/my_token URL it works correctly.
What's happening is that when you have a slow listener on `kernel.terminate` (for example the SwiftMailer one with a slow connection), you response (and therefore the WDT javascript) is sent and processed by the browser, the XHR call is done, but the Profiler storage didn't happened yet so no profiling data is available and the `ProfilerController` just sends an empty response with 200 as status code.

Here we change to instead send a specific status code, and treat it in javascript by retrying several times before failing.

The question are:
* Is 204 the most appropriate response code?
* Are 500 ms and 5 max retries good values?

Commits
-------

9d885ed [WebProfilerBundle ] Fixed an edge case on WDT loading
2014-04-25 14:19:16 +02:00
Tugdual Saunier
9d885ed898 [WebProfilerBundle ] Fixed an edge case on WDT loading 2014-04-25 14:19:13 +02:00
Fabien Potencier
763674659c minor #10782 fixed typo (ghost098)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes #10782).

Discussion
----------

fixed typo

[Validator] [FrameworkBundle]  fixed a typo in farsi translation of length validator when input must be of exact size.

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

dc3f350 fixed typo
2014-04-25 08:54:53 +02:00
Arash Tabriziyan
dc3f3505e8 fixed typo 2014-04-25 08:54:53 +02:00
Fabien Potencier
544e43f5e2 bug #10763 [Process] Disable TTY mode on Windows platform (romainneutron)
This PR was merged into the 2.3 branch.

Discussion
----------

[Process] Disable TTY mode on Windows platform

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

7942c2a [Process] Disable TTY mode on Windows platform
2014-04-24 15:28:08 +02:00
Romain Neutron
7942c2a64c [Process] Disable TTY mode on Windows platform 2014-04-24 14:53:00 +02:00
Fabien Potencier
67be44737e [Validator] added missing ANNOTATION config to @Target annotation 2014-04-24 07:32:02 +02:00
Fabien Potencier
ed53afe0fe bug #10772 [Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator (jakzal)
This PR was merged into the 2.3 branch.

Discussion
----------

[Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator

| Q             | A
| ------------- | ---
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #10747
| License       | MIT
| Doc PR        | -

`\RecursiveDirectoryIterator::getChildren()` creates an instance of the current (overloaded) class with default constructor arguments. Therefore the `ignoreUnreadableDirs` is not passed to the child directories as @marcj suggested in #10747.

My fix relies on PHP's ability to modify private properties in objects of the same class. My reasoning behind choosing this approach, instead of using a setter, is that it's an internal detail which doesn't need to be part of a public interface.

Unfortunately, I can't really cover this case by tests.

Commits
-------

1346641 [Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator.
2014-04-24 07:29:16 +02:00
Jakub Zalas
13466415c4 [Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator. 2014-04-23 22:00:27 +01:00
Fabien Potencier
3d14556bd9 minor #10767 added @Target annotations (fabpot)
This PR was merged into the 2.3 branch.

Discussion
----------

added @Target annotations

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #1930
| License       | MIT
| Doc PR        | n/a

Commits
-------

542d6fa added @Target annotations
2014-04-23 16:03:45 +02:00
Fabien Potencier
542d6fa580 added @Target annotations 2014-04-23 15:35:47 +02:00
Fabien Potencier
5947eec36f minor #10756 [2.3][Process] Add missing docblocks, remove variable declarations (romainneutron)
This PR was merged into the 2.3 branch.

Discussion
----------

[2.3][Process] Add missing docblocks, remove variable declarations

| Q             | A
| ------------- | ---
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT

Commits
-------

ff77f24 [Process] Add missing docblocks, remove variable declarations
2014-04-23 08:32:13 +02:00
thewilkybarkid
fc1223f924 Allow URLs that don't contain a path 2014-04-22 15:58:51 +01:00