Commit Graph

39768 Commits

Author SHA1 Message Date
Fabien Potencier
9e84e0ff98 bumped Symfony version to 3.4.21 2018-12-06 15:57:52 +00:00
Fabien Potencier
f6b8ddc362
Merge pull request #29488 from fabpot/release-3.4.20
released v3.4.20
2018-12-06 15:24:36 +00:00
Fabien Potencier
b09cb1e8e6 updated VERSION for 3.4.20 2018-12-06 14:59:33 +00:00
Fabien Potencier
4386fb48b1 update CONTRIBUTORS for 3.4.20 2018-12-06 14:59:29 +00:00
Fabien Potencier
cf0583a2a0 updated CHANGELOG for 3.4.20 2018-12-06 14:59:19 +00:00
Nicolas Grekas
c38a79cc4f Merge branch '4.2'
* 4.2:
  fix CI
2018-12-06 11:52:12 +00:00
Nicolas Grekas
54fe82d1c2 Merge branch '4.1' into 4.2
* 4.1:
  fix CI
2018-12-06 11:52:06 +00:00
Nicolas Grekas
3d664a6a2f Merge branch '3.4' into 4.1
* 3.4:
  fix CI
2018-12-06 11:52:00 +00:00
Nicolas Grekas
ffe49fd160 Merge branch '2.8' into 3.4
* 2.8:
  fix CI
2018-12-06 11:51:10 +00:00
Nicolas Grekas
c8389f788d Merge branch '2.7' into 2.8
* 2.7:
  fix CI
2018-12-06 11:51:03 +00:00
Nicolas Grekas
9b10db2207 fix CI 2018-12-06 11:49:24 +00:00
Nicolas Grekas
ee337dd761 Merge branch '4.2'
* 4.2:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:37:20 +00:00
Nicolas Grekas
95e4edba92 Merge branch '4.1' into 4.2
* 4.1:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:36:58 +00:00
Nicolas Grekas
34f6a4066d Merge branch '3.4' into 4.1
* 3.4:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:26:33 +00:00
Nicolas Grekas
3aaa5aba1b Merge branch '2.8' into 3.4
* 2.8:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:25:03 +00:00
Nicolas Grekas
410ed830c5 Merge branch '2.7' into 2.8
* 2.7:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:12:46 +00:00
Nicolas Grekas
f27dd4b5be security #cve-2018-19790 [Security\Http] detect bad redirect targets using backslashes (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[Security\Http] detect bad redirect targets using backslashes

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #76
| License       | MIT
| Doc PR        |

Commits
-------

99a0cec0a6 [Security\Http] detect bad redirect targets using backslashes
2018-12-06 11:09:35 +00:00
Nicolas Grekas
b65e6f1a47 security #cve-2018-19789 [Form] Filter file uploads out of regular form types (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Filter file uploads out of regular form types

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR filters uploaded files out of the data processed by any form type except `FileType`.

Commits
-------

205a44ea7d [Form] Filter file uploads out of regular form types
2018-12-06 11:08:15 +00:00
Nicolas Grekas
e6fa538387 Merge branch '4.2'
* 4.2:
  [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications
  [Cache] Fixed Memcached adapter doClear()to call flush()
  Fixes sprintf(): Too few arguments in Translator
  fix TransChoiceTokenParser deprecation message
  [DoctrineBridge] Conflict with Messenger <4.2
  [Contracts] extract LocaleAwareInterface out of TranslatorInterface
2018-12-06 11:00:21 +00:00
Nicolas Grekas
15fefd8cd5 Merge branch '4.1' into 4.2
* 4.1:
  [Cache] Fixed Memcached adapter doClear()to call flush()
2018-12-06 11:00:08 +00:00
Nicolas Grekas
5fc7d5ec81 Merge branch '3.4' into 4.1
* 3.4:
  [Cache] Fixed Memcached adapter doClear()to call flush()
2018-12-06 10:58:36 +00:00
Nicolas Grekas
8816b56559 bug #29481 [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications (yceruto)
This PR was squashed before being merged into the 4.2 branch (closes #29481).

Discussion
----------

[TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

I've also added some missing tests.

Commits
-------

96169b8046 [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications
2018-12-06 10:57:56 +00:00
Yonel Ceruto
96169b8046 [TwigBridge] Deprecating legacy Twig paths in DebugCommand and simplifications 2018-12-06 10:57:49 +00:00
Nicolas Grekas
922e13c2b2 bug #29436 [Cache] Fixed Memcached adapter doClear()to call flush() (raitocz)
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29436).

Discussion
----------

[Cache] Fixed Memcached adapter doClear()to call flush()

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29435
| License       | MIT
| Doc PR        | symfony/symfony-docs

MemcachedTrait now calls Memcached::flush via its client instead of just returning false.

Commits
-------

447baacbad [Cache] Fixed Memcached adapter doClear()to call flush()
2018-12-06 10:55:16 +00:00
Raito Akehanareru
447baacbad [Cache] Fixed Memcached adapter doClear()to call flush() 2018-12-06 10:54:02 +00:00
Nicolas Grekas
7ad8341486 minor #29464 [DoctrineBridge] Conflict with Messenger <4.2 (ogizanagi)
This PR was merged into the 4.2 branch.

Discussion
----------

[DoctrineBridge] Conflict with Messenger <4.2

| Q             | A
| ------------- | ---
| Branch?       | 4.2 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #29463   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

8624cde5b0 [DoctrineBridge] Conflict with Messenger <4.2
2018-12-06 10:50:02 +00:00
Nicolas Grekas
5949349480 minor #29479 Fix TransChoiceTokenParser deprecation message (fbourigault)
This PR was merged into the 4.2 branch.

Discussion
----------

Fix TransChoiceTokenParser deprecation message

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

While debugging a `cache:clear`, I found the following errors on stderr:
```
PHP Warning: sprintf(): Too few arguments in .../vendor/symfony/twig-bridge/TokenParser/TransChoiceTokenParser.php on line 43
```

This was caused by using unescaped `%` in the `sprintf` format string.

This fix the `sprintf` format string so the deprecation message will now works.

Commits
-------

3d3b3ced48 fix TransChoiceTokenParser deprecation message
2018-12-06 10:49:29 +00:00
Nicolas Grekas
9b25b6a264 bug #29482 Fixes sprintf(): Too few arguments in MessageFormatter::choiceFormat (stephanedelprat)
This PR was submitted for the master branch but it was merged into the 4.2 branch instead (closes #29482).

Discussion
----------

Fixes sprintf(): Too few arguments in MessageFormatter::choiceFormat

Similar to : https://github.com/symfony/symfony/pull/29344

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no <!-- don't forget to update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | related to a previous deprecation <!-- don't forget to update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | I hope so
| Fixed tickets | none
| License       | MIT
| Doc PR        | none

Fixes the log produced when the method is called :

Before : "sprintf(): Too few arguments"

After : "The "Symfony\Component\Translation\Formatter\MessageFormatter::choiceFormat()" method is deprecated since Symfony 4.2, use the format() one instead with a %count% parameter."

Reference : http://php.net/manual/function.sprintf.php

Commits
-------

109fee5709 Fixes sprintf(): Too few arguments in Translator
2018-12-06 10:45:39 +00:00
Stéphane Delprat
109fee5709 Fixes sprintf(): Too few arguments in Translator
Similar to : https://github.com/symfony/symfony/pull/29344
2018-12-06 10:45:32 +00:00
Nicolas Grekas
e2ae5d9ac8 bug #29461 [Contracts] extract LocaleAwareInterface out of TranslatorInterface (nicolas-grekas)
This PR was merged into the 4.2 branch.

Discussion
----------

[Contracts] extract LocaleAwareInterface out of TranslatorInterface

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

While reviewing #28929, I realized we have a design issue in the Translation contract: we missed segregating `setLocale()`/`getLocale()` out of `TranslatorInterface`. E.g. when people type-hint for `TranslatorInterface`, they *should not* be auto-suggested with the `setLocale()` mutator.

Technically, that's a BC break. I think we should do it. The release is close enough in time and that will save us from maintenance issues this will create in the future otherwise.

Commits
-------

73e4a1a5ff [Contracts] extract LocaleAwareInterface out of TranslatorInterface
2018-12-06 10:43:00 +00:00
Fabien Bourigault
3d3b3ced48 fix TransChoiceTokenParser deprecation message 2018-12-05 23:36:36 +01:00
Maxime Steinhausser
8624cde5b0 [DoctrineBridge] Conflict with Messenger <4.2 2018-12-05 09:34:58 +00:00
Nicolas Grekas
73e4a1a5ff [Contracts] extract LocaleAwareInterface out of TranslatorInterface 2018-12-05 08:06:11 +00:00
Nicolas Grekas
c7fe1b6bcb Merge branch '4.2'
* 4.2:
  [VarExporter] fix dumping private properties from abstract classes
  Fix empty output for debug:autowiring when reflection-docblock is not available
  [Workflow] Fixed BC break for Workflow metadata
  [Routing] ignore trailing slash for non-GET requests
2018-12-03 22:43:20 +00:00
Nicolas Grekas
b932300149 bug #29446 [VarExporter] fix dumping private properties from abstract classes (nicolas-grekas)
This PR was merged into the 4.2 branch.

Discussion
----------

[VarExporter] fix dumping private properties from abstract classes

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29406
| License       | MIT
| Doc PR        | -

Commits
-------

b10e2638a4 [VarExporter] fix dumping private properties from abstract classes
2018-12-03 22:42:02 +00:00
Nicolas Grekas
b10e2638a4 [VarExporter] fix dumping private properties from abstract classes 2018-12-03 22:40:09 +00:00
Nicolas Grekas
4548a44a01 Merge branch '4.1' into 4.2
* 4.1:
  [Workflow] Fixed BC break for Workflow metadata
  [Routing] ignore trailing slash for non-GET requests
2018-12-03 23:08:12 +01:00
Nicolas Grekas
db2c64d580 Merge branch '3.4' into 4.1
* 3.4:
  [Routing] ignore trailing slash for non-GET requests
2018-12-03 22:38:57 +01:00
Nicolas Grekas
317a2f9787 bug #29441 [Routing] ignore trailing slash for non-GET requests (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Routing] ignore trailing slash for non-GET requests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29410
| License       | MIT
| Doc PR        | -

Another test case provided by @peterrehm in the linked issue - the dumped matcher already passes this test - but the non-dumped one doesn't (neither does the dumped one in 4.1 - I'll fix while merging up)

Commits
-------

7521af7ea0 [Routing] ignore trailing slash for non-GET requests
2018-12-03 22:36:45 +01:00
Nicolas Grekas
4657c12179 bug #29445 [FrameworkBundle] Fix empty output for debug:autowiring when reflection-docblock is not installed (chalasr)
This PR was merged into the 4.2 branch.

Discussion
----------

[FrameworkBundle] Fix empty output for debug:autowiring when reflection-docblock is not installed

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29442
| License       | MIT
| Doc PR        | n/a

![screenshot 2018-12-03 at 19 25 07](https://user-images.githubusercontent.com/7502063/49393383-549f8a00-f731-11e8-822c-43959514c69d.png)

instead of no output at all when phpdocumentor/reflection-docblock is not installed

Commits
-------

bd0dbe415f Fix empty output for debug:autowiring when reflection-docblock is not available
2018-12-03 22:33:28 +01:00
Nicolas Grekas
b8f87e185f bug #29444 [Workflow] Fixed BC break for Workflow metadata (lyrixx)
This PR was merged into the 4.1 branch.

Discussion
----------

[Workflow] Fixed BC break for Workflow metadata

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29427
| License       | MIT
| Doc PR        |

I used SplObjectStorage to store the transition metadata.
So we need to use the exact same PHP Object.

Commits
-------

5691818397 [Workflow] Fixed BC break for Workflow metadata
2018-12-03 22:25:56 +01:00
Robin Chalas
bd0dbe415f Fix empty output for debug:autowiring when reflection-docblock is not available 2018-12-03 19:37:18 +01:00
Grégoire Pineau
5691818397 [Workflow] Fixed BC break for Workflow metadata 2018-12-03 19:01:20 +01:00
Nicolas Grekas
7521af7ea0 [Routing] ignore trailing slash for non-GET requests 2018-12-03 14:20:34 +01:00
Jérôme Vasseur
5196dac7a8 Fix HeaderBag::get phpdoc
When setting $first to false, the default value is wrapped into an array
meaning you need to pass a string as the default value instead of an
array of strings.
2018-12-03 11:46:14 +01:00
Nicolas Grekas
974b98b17b Merge branch '4.2'
* 4.2:
  [DI] dont inline when lazy edges are found
2018-12-02 16:59:43 +01:00
Nicolas Grekas
cfebe0c565 Merge branch '4.1' into 4.2
* 4.1:
  [DI] dont inline when lazy edges are found
2018-12-02 16:59:36 +01:00
Nicolas Grekas
a256c6914d Merge branch '3.4' into 4.1
* 3.4:
  [DI] dont inline when lazy edges are found
2018-12-02 16:58:55 +01:00
Nicolas Grekas
0ca1614aa2 bug #29432 [DI] dont inline when lazy edges are found (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] dont inline when lazy edges are found

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29412, #29391
| License       | MIT
| Doc PR        | -

I'm not able to create a reproducer to hit this situation, but on 4.2, this check makes the difference.
I'm merging to fix the issue as that's still the proper fix.

Commits
-------

484c49edb3 [DI] dont inline when lazy edges are found
2018-12-02 16:55:40 +01:00
Nicolas Grekas
484c49edb3 [DI] dont inline when lazy edges are found 2018-12-02 16:50:25 +01:00