This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10460).
Discussion
----------
Typo fix at UploadedFile.php documentation
Commits
-------
ced3f04 Typo fix at UploadedFile.php documentation
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Fix random failures in test suite on TravisCI
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
783e377 [Process] Avoid failures because of slow IOs
238565e [Process] Avoid failure because of a slow process
173f8c5 [Process] Avoid failure when calling Process::stop in edge cases
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10436).
Discussion
----------
Update DefaultAuthenticationSuccessHandler.php
[Security] [Http] [Authentication] Fixed class description of DefaultAuthenticatioNSuccessHander
| Q | A
| ------------- | ---
| Fixed tickets | none
| License | MIT
Commits
-------
b458551 Update DefaultAuthenticationSuccessHandler.php
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Fix quoted arguments escaping
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
This PR replaces #8972
Commits
-------
de681cb [Process] Add tests on ProcessUtils::escapeArgument
85fb495 [Process] Fix: Arguments including space and quote are not correctly escaped (win)
This PR was merged into the 2.3 branch.
Discussion
----------
[DomCrawler] Fixed incorrect value name conversion in getPhpValues() and getPhpFiles()
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6908
| License | MIT
This PR replaces #10193
Commits
-------
89c599e [DomCrawler] Add tests for recursive cases of getPhpValues() and getPhpFiles()
e961f57 [DomCrawler] Fixed incorrect value name conversion in getPhpValues() and getPhpFiles()
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10447).
Discussion
----------
[Config][Loader] Code style fix
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
6d84c04 Minor style fix
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10423).
Discussion
----------
[Config] XmlUtils::convertDomElementToArray does not handle '0'
`XmlUtils::convertDomElementToArray` does not handle `0` as a value of a text node, and interprets it as `null`.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | maybe? (if someone is depending on the previous behaviour.)
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
Commits
-------
e56ac59 convertDomElementToArray should handle zero values
This PR was merged into the 2.3 branch.
Discussion
----------
adding http:// to server:run output to make it clickable
|Q |A |
|--- |---|
|Bug Fix? |yes |
|New Feature? |n |
|BC Breaks? |n |
|Deprecations?|n |
|Tests Pass? |n |
|Fixed Tickets| #10430 |
|License |MIT|
|Doc PR | no |
Commits
-------
6498518 prefixed http:// to url output on server:run command in order to make it clickable
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fixed data in pipe being truncated if not read before process termination
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9409
| License | MIT
| Doc PR | N/A
This is a repeat of the botched pull request #9630.
Commits
-------
7e51913 Fixed data in pipe being truncated if not read before process termination
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Fix#9160 : escaping an argument with a trailing backslash on windows fails
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9160
| License | MIT
Commits
-------
10e903a [Process] Fix#9160 : escaping an argument with a trailing backslash on windows fails
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix some unit tests that create the process object instead of delegate it to the implementation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
This is a minor error ; creating the process must be delegated to the implementation
Commits
-------
227b85b [Process] Fix some unit tests that create the process object instead of delegate it to the implementation
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Make process tests more accurate on exception messages
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
I need exception message to be checked more accurately in my upcoming PR about windows.
I decided to make a separated PR as the other one will probably take some time before being merged
Commits
-------
1b1768a [Process] Make process tests more accurate on exception messages
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix process status in TTY mode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
When running a process with TTY mode, status in automatically set to `terminated`
once it's started.
It's wrong for two reasons :
- The status of the process is not yet terminated.
- The exitcode value is never caught
Commits
-------
51c70f8 [Process] Fix process status in TTY mode
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix comparisons against process exitcode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Use identical comparison instead of equal. In case the exitcode has not been caught, `Process::isSuccessful` returns true instead of false. It should not happen, but it's much more clean like that.
Commits
-------
d66f63f [Process] Use assertSame instead of assertEquals to avoid comparison against `null`
When running a process with TTY mode, status in automatically set to `terminated`
once it's started.
It's wrong for two reasons :
- The status of the process is not yet terminated.
- The exitcode value is never caught
This PR was squashed before being merged into the 2.3 branch (closes#10382).
Discussion
----------
10158 get vary multiple
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | [#10158]
| License | MIT
| Doc PR | none
Commits
-------
3a4a3cb 10158 get vary multiple
This PR was merged into the 2.3 branch.
Discussion
----------
fixed some HHVM bugs
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This is a workaround for facebook/hhvm#1161. I made the change as the workaround does the same thing and the eval is part of unit tests.
Commits
-------
d014dac made Cookie stringification more robust
fa24749 [Yaml] fix for a HHVM bug
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10326).
Discussion
----------
[HttpFoundation][Tests] Add tests for RequestStack class
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
6f25d39 [HttpFoundation][Tests] Add tests for RequestStack class
This PR was squashed before being merged into the 2.3 branch (closes#10251).
Discussion
----------
[Form][2.3] Fixes empty file-inputs getting treated as extra field.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8575 (https://github.com/symfony/symfony/pull/8575#issuecomment-34867485)
| License | MIT
Re-applies 968fe23 (PR #8575).
The test for this already exists, it was just this line that got overwritten by eb9f76d5ba (diff-ca5e25b47f3ecc94cd557946aeb486c6L542)
To clarify, this is a PR into 2.3 branch - this already exists in 2.4 (and later from this PR: https://github.com/symfony/symfony/pull/9146)
Commits
-------
8d99d75 [Form][2.3] Fixes empty file-inputs getting treated as extra field.
This PR was merged into the 2.3 branch.
Discussion
----------
PHPUnit more specific assertions
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10357
| License | MIT
| Doc PR | n/a
Commits
-------
4927d0c changed some PHPUnit assertions to more specific ones