This PR was squashed before being merged into the 2.3 branch (closes#13769).
Discussion
----------
[Form] NativeRequestHandler file handling fix
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #13746
| License | MIT
| Doc PR | n/a
`NativeRequestHandler` reused the local variable for the form name `$name` as a loop variable for processing the `$_FILES` array. A separate variable is now used.
Two new test cases are included:
- Handling a request with multiple files
- Handling a request with file upload and a nameless form
Both tests fail without the fix. The test cases could probably be better though.
Commits
-------
9b3421f [Form] NativeRequestHandler file handling fix
This PR was merged into the 2.3 branch.
Discussion
----------
Enforce UTF-8 charset for core controllers
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7532
| License | MIT
| Doc PR | -
See https://github.com/symfony/symfony/issues/7617 and https://github.com/symfony/symfony/pull/7532 for the context of this PR.
Commits
-------
3032014 Enforce UTF-8 charset for core controllers
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#13683).
Discussion
----------
[PROCESS] make sure /dev/tty is readable
When using Process from Web-SAPI it is likely that the webserver user
doesn't has rights to use /dev/tty
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #13261
| License | MIT
| Doc PR | -
Commits
-------
935afe6 [PROCESS] make sure /dev/tty is readable
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][FrameworkBundle] Fixed Shell logo
This PR fix#12565.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
d7f008d [FrameworkBundle] Fixed Shell logo
This PR was squashed before being merged into the 2.3 branch (closes#13733).
Discussion
----------
[2.3][Process] Fixed PhpProcess::getCommandLine() result
The `PhpProcess::getCommandLine()` return `null` if `PhpProcess::start()` was not called.
```php
$process = new PhpProcess(<<<PHP
<?php echo "foobar";
PHP
);
$process->getCommandLine(); // return null
$process->start();
$process->getCommandLine(); // return the PHP binary path
```
This PR fix the problem.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
Commits
-------
d0f1d32 [2.3][Process] Fixed PhpProcess::getCommandLine() result
This PR was merged into the 2.6 branch.
Discussion
----------
Fix the toolbar JS for IE
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | n/a
- fix the binding of listeners on XMLHttpRequest to always use the addEventListener method. It does not make sense to change it to attachEvent as it is about binding listeners on DOM elements.
- fix the feature detection for the event binding on DOM elements:
- the attachEvent and addEventListener methods are on DOM elements, not on the document object
- the standard method should be preferred in IE versions supporting both methods
- avoid JS errors when XMLHttpRequest is not defined by avoiding to override its open method when the object is not there (old IE versions will still not intercept ajax calls though)
this is the complete fix for the code submitted in #13636 (the fix in https://github.com/symfony/symfony/pull/13684 was incomplete).
Commits
-------
b7aa171 Fix the toolbar JS for IE
This PR was merged into the 2.6 branch.
Discussion
----------
[PropertyAccess] unify and fix doc
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
Commits
-------
d1c8c5d [PropertyAccess] unify and fix doc
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] assertion for ArgvInput::getFirstArgument() with no arguments
| Q | A
| ------------- | ---
| Bug fix? | [no]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| License | MIT
Commits
-------
11b2a9b [Console] explicit assertion for ArgvInput::getFirstArgument() with no arguments
This PR was merged into the 2.6 branch.
Discussion
----------
[FrameworkBundle] move Routing dep up to make tests pass
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Ping @Tobion
Commits
-------
c71e2d5 [FrameworkBundle] move Routing dep up to make tests pass
This PR was merged into the 2.6 branch.
Discussion
----------
[Security] Fix expectation in a test.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This is related to #13466, which worked perfectly fine in 2.3. It breaks in 2.6 since we've changed the way we check for master request.
Commits
-------
8299a44 [Security] Fix expectation in a test.
This PR was merged into the 2.3 branch.
Discussion
----------
[PropertyAccess] refactor type checks
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
#13735 for 2.3
Commits
-------
9cacecb [PropertyAccess] the property path constructor already implements the type check
4e11c07 [PropertyAccess] refactor type checks to remove duplicate logic
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#13737).
Discussion
----------
[HttpFoundation] Fix getHost and getPort functions in docblock
This fixes the incorrect references to the functions `getClientHost` and `getClientPort` in the docblock for Request::setTrustedHeaderName.
| Q | A
| ------------- | ---
| Fixed tickets | none
| License | MIT
Commits
-------
1ae9f9c [HttpFoundation] Fix getHost and getPort functions in docblock
- fix the binding of listeners on XMLHttpRequest to always use the
addEventListener method. It does not make sense to change it to
attachEvent as it is about binding listeners on DOM elements.
- fix the feature detection for the event binding on DOM elements:
- the attachEvent and addEventListener methods are on DOM elements,
not on the document object
- the standard method should be preferred in IE versions supporting
both methods
- avoid JS errors when XMLHttpRequest is not defined by avoiding to
override its open method when the object is not there (old IE versions
will still not intercept ajax calls though)
This PR was submitted for the 2.7 branch but it was merged into the 2.3 branch instead (closes#13725).
Discussion
----------
Add phpdoc for SecurityFactoryInterface::getPosition
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
bcb2e09 Add phpdoc for SecurityFactoryInterface::getPosition