Commit Graph

49885 Commits

Author SHA1 Message Date
Christian Flothmann
f04f507cd5 [Validator] fix tests 2020-08-17 14:06:24 +02:00
Fabien Potencier
fe5021ea04 bug #37826 [Messenger] Fix BC layer for stamps moved into separate packages (ogizanagi)
This PR was merged into the 5.1 branch.

Discussion
----------

[Messenger] Fix BC layer for stamps moved into separate packages

| Q             | A
| ------------- | ---
| Branch?       | 5.1 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #37616 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

118579ced7 [Messenger] Fix BC layer for stamps moved into separate packages
2020-08-17 14:05:19 +02:00
Fabien Potencier
58166dfd75 bug #37853 [Validator] ensure that the validator is a mock object for backwards-compatibility (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] ensure that the validator is a mock object for backwards-compatibility

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

I accidentally broke the class in #37808. The validator was a mock object before (see the failing tests on the `5.1` branch).

Commits
-------

1c9b6714c7 ensure that the validator is a mock object for backwards-compatibility
2020-08-17 13:51:16 +02:00
Christian Flothmann
1c9b6714c7 ensure that the validator is a mock object for backwards-compatibility 2020-08-17 13:46:11 +02:00
Fabien Potencier
38e5a15ff4 Merge branch '4.4' into 5.1
* 4.4:
  stop using deprecated PHPUnit APIs
2020-08-17 12:01:29 +02:00
Fabien Potencier
dbe4e83ae6 minor #37831 stop using deprecated PHPUnit APIs (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

stop using deprecated PHPUnit APIs

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

3d209c46e4 stop using deprecated PHPUnit APIs
2020-08-17 11:56:45 +02:00
Christian Flothmann
3d209c46e4 stop using deprecated PHPUnit APIs 2020-08-17 11:35:39 +02:00
Fabien Potencier
a36f34f0fb Fix CS 2020-08-17 09:48:54 +02:00
Fabien Potencier
524941e36e Merge branch '4.4' into 5.1
* 4.4:
  Fix CS
  Fix CS
  [Validator] Add Polish translation for ISIN constraint
2020-08-17 09:42:30 +02:00
Fabien Potencier
85090fcfb8 Fix CS 2020-08-17 09:39:58 +02:00
Fabien Potencier
c9cdac153f Merge branch '3.4' into 4.4
* 3.4:
  Fix CS
  [Validator] Add Polish translation for ISIN constraint
2020-08-17 09:31:35 +02:00
Fabien Potencier
ba042b1acf Fix CS 2020-08-17 09:27:37 +02:00
Fabien Potencier
78605e1ad9 Merge branch '4.4' into 5.1
* 4.4:
  Fix CS
  [Serializer] Fix configuration of the cache key
  [Messenger] Do not stack retry stamp
  [FrameworkBundle] Add missing mailer transports in xsd
  [ErrorHandler][DebugClassLoader] Add mixed and static return types support
2020-08-17 09:03:44 +02:00
Fabien Potencier
3cdf5c47db Fix CS 2020-08-17 08:12:26 +02:00
Fabien Potencier
66b9fef4ac bug #36340 [Serializer] Fix configuration of the cache key (dunglas)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Serializer] Fix configuration of the cache key

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Fix #35574 doctrine/orm#8030 (partially)
| License       | MIT
| Doc PR        | n/a

Currently, a bug prevents to configure the context keys to exclude from the cache key computation. The value is always replaced in the constructor. This PR fixes the problem.

Commits
-------

3b034cb343 [Serializer] Fix configuration of the cache key
2020-08-17 08:10:54 +02:00
Kévin Dunglas
3b034cb343 [Serializer] Fix configuration of the cache key 2020-08-17 08:10:41 +02:00
Fabien Potencier
df3ab767dd bug #36810 [Messenger] Do not stack retry stamp (jderusse)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[Messenger] Do not stack retry stamp

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | /
| License       | MIT
| Doc PR        | /

With the "RecoverableException" or a very high number of retry, the message is currently stacking a lot of stamp, which increase the size of the message sent to queue and (in my case) reach the "maximum size allowed" after 60 retries + php serializer

This PR removes previous stamps before adding the new Delay+RetryStamps.

Commits
-------

ad6f8532c6 [Messenger] Do not stack retry stamp
2020-08-17 08:02:22 +02:00
Jérémy Derussé
ad6f8532c6 [Messenger] Do not stack retry stamp 2020-08-17 08:02:06 +02:00
Fabien Potencier
9d995bdd3b bug #37849 [FrameworkBundle] Add missing mailer transports in xsd (l-vo)
This PR was merged into the 4.4 branch.

Discussion
----------

[FrameworkBundle] Add missing mailer transports in xsd

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

c21df9b50a [FrameworkBundle] Add missing mailer transports in xsd
2020-08-17 07:31:49 +02:00
Fabien Potencier
9720061e95 minor #37851 [Validator] Add Polish translation for ISIN constraint (przemyslaw-bogusz)
This PR was submitted for the master branch but it was merged into the 3.4 branch instead.

Discussion
----------

[Validator] Add Polish translation for ISIN constraint

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| License       | MIT

Commits
-------

5fa2975b42 [Validator] Add Polish translation for ISIN constraint
2020-08-17 07:25:37 +02:00
Przemysław Bogusz
5fa2975b42 [Validator] Add Polish translation for ISIN constraint 2020-08-17 07:25:28 +02:00
Laurent VOULLEMIER
c21df9b50a [FrameworkBundle] Add missing mailer transports in xsd 2020-08-16 23:25:38 +02:00
Fabien Potencier
5f074cdf4e bug #37218 [Lock] MongoDbStore skim non-standard options from uri (kralos)
This PR was squashed before being merged into the 5.1 branch.

Discussion
----------

[Lock] MongoDbStore skim non-standard options from uri

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37180
| License       | MIT
| Doc PR        |

Don't allow non-standard connection uri options reach `MongoDB\Client`

Commits
-------

67912faf9f [Lock] MongoDbStore skim non-standard options from uri
2020-08-16 16:54:56 +02:00
Joe Bennett
67912faf9f [Lock] MongoDbStore skim non-standard options from uri 2020-08-16 16:54:50 +02:00
Fabien Potencier
d6b9936f61 bug #37586 [ErrorHandler][DebugClassLoader] Add mixed and static return types support (fancyweb)
This PR was merged into the 4.4 branch.

Discussion
----------

[ErrorHandler][DebugClassLoader] Add mixed and static return types support

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Commits
-------

0533f1f63e [ErrorHandler][DebugClassLoader] Add mixed and static return types support
2020-08-16 16:46:36 +02:00
Fabien Potencier
5ef1679707 Merge branch '4.4' into 5.1
* 4.4:
  [Serializer] Fix variadic support when using type hints
  [VarDumper] Backport handler lock when using VAR_DUMPER_FORMAT
2020-08-16 10:27:43 +02:00
Fabien Potencier
803a257b6d Merge branch '3.4' into 4.4
* 3.4:
  [Serializer] Fix variadic support when using type hints
2020-08-16 10:27:11 +02:00
Fabien Potencier
688dbd9dab bug #37845 [Serializer] Fix variadic support when using type hints (fabpot)
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] Fix variadic support when using type hints

| Q             | A
| ------------- | ---
| Branch?       | 3.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

3fffa96928 [Serializer] Fix variadic support when using type hints
2020-08-16 10:23:32 +02:00
Fabien Potencier
3fffa96928 [Serializer] Fix variadic support when using type hints 2020-08-16 10:12:12 +02:00
Fabien Potencier
7f2726a7ca bug #37841 [VarDumper] Backport handler lock when using VAR_DUMPER_FORMAT (ogizanagi)
This PR was merged into the 4.4 branch.

Discussion
----------

[VarDumper] Backport handler lock when using VAR_DUMPER_FORMAT

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | N/A <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | N/A

Backport of the "lock" behavior from #35967, preventing unexpected handler change when using the `VAR_DUMPER_FORMAT` env var.

---

As a concrete example of this not working as expected:
Start a PHPUnit test suite with this env var to the desired format. If a web test case is making a request (with debug enabled), the `DebugBundle` replaces the handler set initially by the `VAR_DUMPER_FORMAT`, will collect dumps into the profiler, but won't output these.
As well, for dumps made in between the the kernel is boot (`DebugBundle::build()` is called) and a request, the dumps are properly sent to the output with expected format, but looses colors.

IMHO, the use-cases of `VAR_DUMPER_FORMAT` justifies locking the handler for the whole process.

Commits
-------

19b341e2b2 [VarDumper] Backport handler lock when using VAR_DUMPER_FORMAT
2020-08-16 07:21:43 +02:00
Maxime Steinhausser
19b341e2b2 [VarDumper] Backport handler lock when using VAR_DUMPER_FORMAT 2020-08-14 17:54:02 +02:00
Fabien Potencier
49e047bf85 minor #37833 Added missing router config (dragosprotung)
This PR was merged into the 5.1 branch.

Discussion
----------

Added missing router config

    | Q             | A
    | ------------- | ---
    | Branch?       | 5.1
    | Bug fix?      | yes
    | New feature?  | no
    | Deprecations? | no
    | Tickets       | N/A
    | License       | MIT
    | Doc PR        | N/A

Commits
-------

a3bfb7d204 Added missing router config
2020-08-14 12:26:40 +02:00
Fabien Potencier
5a6b24b3fb minor #37834 [FrameworkBundle] Remove unused form-resources complex type from XSD file (fancyweb)
This PR was merged into the 5.1 branch.

Discussion
----------

[FrameworkBundle] Remove unused form-resources complex type from XSD file

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Unused since d5be373cac (diff-e7427ecf018e4434c1645712ebe715f6L165).

Commits
-------

8bec34dd22 [FrameworkBundle] Remove unused form-resources complex type from XSD file
2020-08-14 12:25:38 +02:00
Thomas Calvet
8bec34dd22 [FrameworkBundle] Remove unused form-resources complex type from XSD file 2020-08-14 11:56:16 +02:00
Dragos Protung
a3bfb7d204
Added missing router config 2020-08-14 11:34:02 +02:00
Fabien Potencier
c777e02b9d Merge branch '4.4' into 5.1
* 4.4:
  use expectWarning() when possible
2020-08-13 16:36:42 +02:00
Fabien Potencier
0bb2a1a918 Merge branch '3.4' into 4.4
* 3.4:
  use expectWarning() when possible
2020-08-13 16:36:30 +02:00
Fabien Potencier
30d8496921 minor #37828 use expectWarning() when possible (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

use expectWarning() when possible

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

26dd39eb06 use expectWarning() when possible
2020-08-13 16:35:54 +02:00
Fabien Potencier
cb92a3c8c1 Merge branch '4.4' into 5.1
* 4.4:
  add validator translation 99 for Italian language
  stop using the deprecated at() PHPUnit matcher
  Fix typehint phpdoc
2020-08-13 16:19:42 +02:00
Fabien Potencier
544d276cba Merge branch '3.4' into 4.4
* 3.4:
  add validator translation 99 for Italian language
  stop using the deprecated at() PHPUnit matcher
  Fix typehint phpdoc
2020-08-13 16:18:44 +02:00
Christian Flothmann
26dd39eb06 use expectWarning() when possible 2020-08-13 16:16:26 +02:00
Fabien Potencier
6972bc232d minor #37808 stop using the deprecated at() PHPUnit matcher (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

stop using the deprecated at() PHPUnit matcher

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #37780
| License       | MIT
| Doc PR        |

Commits
-------

850389731c stop using the deprecated at() PHPUnit matcher
2020-08-13 16:08:51 +02:00
Maxime Steinhausser
118579ced7 [Messenger] Fix BC layer for stamps moved into separate packages 2020-08-13 16:04:02 +02:00
Fabien Potencier
8ca1bac7d2 bug #37821 Postpone Range BC layer removal to 6.0. (l-vo)
This PR was merged into the 5.1 branch.

Discussion
----------

Postpone Range BC layer removal to 6.0.

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

This BC layer triggers a deprecation message when using `minMessage`/`maxMessage` and `min` and `max` are both set.
Since users on 5.0 and 5.1 hasn't have the deprecation, removing the BC layer (and so throwing an exception) in 5.x would be a big BC break.

Also updated trigger_error to trigger_deprecation and `@deprecationMessage` to `ExpectDeprecationTrait::expectDeprecation`.

Commits
-------

1f66618bb1 Postpone BC layer removal to 6.0.
2020-08-13 11:06:44 +02:00
Laurent VOULLEMIER
1f66618bb1 Postpone BC layer removal to 6.0.
Since users on 5.0 and 5.1 hasn't have the deprecation, removing the BC layer (and so throwing an exception) in 5.x would be a big BC break.
2020-08-13 10:39:22 +02:00
Fabien Potencier
804b8dd8b5 minor #37820 add validator translation 99 for Italian language (garak)
This PR was merged into the 3.4 branch.

Discussion
----------

add validator translation 99 for Italian language

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | none
| License       | MIT
| Doc PR        | not needed

This is a followup to PR #37730 for Italian language.

Commits
-------

ad4923f706 add validator translation 99 for Italian language
2020-08-13 09:33:49 +02:00
Massimiliano Arione
ad4923f706
add validator translation 99 for Italian language 2020-08-13 09:29:37 +02:00
Fabien Potencier
7241f658b9 bug #37725 [Form] Fix Guess phpdoc return type (franmomu)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Fix Guess phpdoc return type

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | -
| License       | MIT
| Doc PR        | -

Since `Guess` is abstract, `static` represents better the return type, so calling `TypeGuess::getBestGuess()` would return `TypeGuess` instead of `Guess`.

Commits
-------

27bb1c499d Fix typehint phpdoc
2020-08-13 09:26:14 +02:00
Fabien Potencier
2b0fdc9857 Merge branch '4.4' into 5.1
* 4.4:
  [Validator] RangeTest: fix expected deprecation
  [Yaml] Fix for #36624; Allow PHP constant as first key in block
  Use PHPUnit 9.3 on php 8.
  fix mapping errors from unmapped forms
  [Validator] Add target guards for Composite nested constraints
2020-08-13 08:24:11 +02:00
Fabien Potencier
a379051c82 Merge branch '3.4' into 4.4
* 3.4:
  [Yaml] Fix for #36624; Allow PHP constant as first key in block
  Use PHPUnit 9.3 on php 8.
  fix mapping errors from unmapped forms
  [Validator] Add target guards for Composite nested constraints
2020-08-13 08:22:32 +02:00