Commit Graph

53171 Commits

Author SHA1 Message Date
Nicolas Grekas
2852a42468 bug #39788 [Cache] fix possible collision when writing tmp file in filesystem adapter (nicolas-grekas)
This PR was merged into the 4.4 branch.

Discussion
----------

[Cache] fix possible collision when writing tmp file in filesystem adapter

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39786
| License       | MIT
| Doc PR        | -

Commits
-------

340d15e400 [Cache] fix possible collision when writing tmp file in filesystem adapter
2021-01-12 11:20:15 +01:00
Nicolas Grekas
d5d388fc25 bug #39796 Dont allow unserializing classes with a destructor - 5.2 (jderusse)
This PR was merged into the 5.2 branch.

Discussion
----------

Dont allow unserializing classes with a destructor - 5.2

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Prevent destructors with side-effects from being unserialized

Commits
-------

98601908bb Dont allow unserializing classes with a destructor - 5.2
2021-01-12 10:53:07 +01:00
Nicolas Grekas
b85611fbd6 bug #39794 Dont allow unserializing classes with a destructor - 4.4 (jderusse)
This PR was merged into the 4.4 branch.

Discussion
----------

Dont allow unserializing classes with a destructor - 4.4

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Prevent destructors with side-effects from being unserialized

Commits
-------

955395c999 Dont allow unserializing classes with a destructor - 4.4
2021-01-12 10:49:10 +01:00
Jérémy Derussé
955395c999
Dont allow unserializing classes with a destructor - 4.4 2021-01-12 10:42:12 +01:00
Nicolas Grekas
8bc5679bcc bug #39795 Dont allow unserializing classes with a destructor - 5.1 (jderusse)
This PR was merged into the 5.1 branch.

Discussion
----------

Dont allow unserializing classes with a destructor - 5.1

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

Prevent destructors with side-effects from being unserialized

Commits
-------

07402f4af3 Dont allow unserializing classes with a destructor - 5.1
2021-01-12 10:31:38 +01:00
Jérémy Derussé
5dff21b45b
bug #39389 [Security]  Move the handleAuthenticationSuccess logic outside try/catch block (jderusse)
This PR was merged into the 5.2 branch.

Discussion
----------

[Security]  Move the handleAuthenticationSuccess logic outside try/catch block

| Q             | A
| ------------- | ---
| Branch?       | 5.2
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | -
| License       | MIT
| Doc PR        | -

The current implementation of `AuthenticationManager` handle the `handleAuthenticationSuccess` logic in a try/catch block which triggers the `handleAuthenticationFailure` in case of failure.

Which could leads to inconsistency and unexpected behavior. The authentication is either successfully or failure, but can't be both in the same request.

Commits
-------

da5c39ec2e Move AuthenticationSuccessEvent outside try/catch block
2021-01-12 09:13:20 +01:00
Ivan Kurnosov
fec66e61c8 [Config] Add \Symfony\Component\Config\Loader::load() return type 2021-01-12 14:21:27 +13:00
Nicolas Grekas
340d15e400 [Cache] fix possible collision when writing tmp file in filesystem adapter 2021-01-11 19:31:21 +01:00
Christian Flothmann
f72c6a5ad4 a colon followed by spaces exclusively separates mapping keys and values 2021-01-11 15:27:16 +01:00
Fabien Potencier
ecfa4bd549 minor #39785 Use ::class keyword when possible (fabpot)
This PR was merged into the 5.3-dev branch.

Discussion
----------

Use ::class keyword when possible

| Q             | A
| ------------- | ---
| Branch?       | 5.x <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

6b6f777979 Use ::class keyword when possible
2021-01-11 12:14:55 +01:00
Fabien Potencier
6b6f777979 Use ::class keyword when possible 2021-01-11 12:03:44 +01:00
Fabien Potencier
cce5a42ced Merge branch '5.2' into 5.x
* 5.2:
  Use ::class keyword when possible
2021-01-11 12:02:56 +01:00
Fabien Potencier
84ce026ffa minor #39783 Use ::class keyword when possible (fabpot)
This PR was merged into the 5.2 branch.

Discussion
----------

Use ::class keyword when possible

| Q             | A
| ------------- | ---
| Branch?       | 5.2  <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

2922224d29 Use ::class keyword when possible
2021-01-11 12:01:36 +01:00
Fabien Potencier
2922224d29 Use ::class keyword when possible 2021-01-11 11:45:43 +01:00
Fabien Potencier
742dd1326a Merge branch '5.2' into 5.x
* 5.2:
  Use ::class keyword when possible
2021-01-11 11:44:47 +01:00
Fabien Potencier
b145df90e6 Merge branch '5.1' into 5.2
* 5.1:
  Use ::class keyword when possible
2021-01-11 11:44:39 +01:00
Fabien Potencier
b2fa4053b2 minor #39782 Use ::class keyword when possible (fabpot)
This PR was merged into the 5.1 branch.

Discussion
----------

Use ::class keyword when possible

| Q             | A
| ------------- | ---
| Branch?       | 5.1 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

1f3a29ba83 Use ::class keyword when possible
2021-01-11 11:43:27 +01:00
Fabien Potencier
1f3a29ba83 Use ::class keyword when possible 2021-01-11 11:34:08 +01:00
Fabien Potencier
91d8bebfac Merge branch '5.2' into 5.x
* 5.2:
  Use ::class keyword when possible
2021-01-11 10:52:33 +01:00
Fabien Potencier
b9909c4432 Merge branch '5.1' into 5.2
* 5.1:
  Use ::class keyword when possible
2021-01-11 10:51:46 +01:00
Fabien Potencier
83b087364b Merge branch '4.4' into 5.1
* 4.4:
  Use ::class keyword when possible
2021-01-11 10:50:50 +01:00
Fabien Potencier
bde3e28084 minor #39781 Use ::class keyword when possible (fabpot)
This PR was merged into the 4.4 branch.

Discussion
----------

Use ::class keyword when possible

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

As we cannot easily change all occurrences of class names to use the `::class` (no PHP CS Fixer rule for now, and probably never), I've added this feature in fabbot.io for when we are 100% sure that the string is indeed a class name (I detect strings for `getMockBuilder()` or `is_class()`, ...).

For now, I use the short class name when available as a use statement, and I fall back to the FQCN when not (I don't add use statements, which should probably be done as another fixer).

Commits
-------

6c8d5808a6 Use ::class keyword when possible
2021-01-11 10:47:10 +01:00
Fabien Potencier
6c8d5808a6 Use ::class keyword when possible 2021-01-11 09:57:50 +01:00
Fabien Potencier
665222cf4d Merge branch '5.2' into 5.x
* 5.2:
  Use ::class keyword when possible
2021-01-11 09:45:39 +01:00
Fabien Potencier
f798b1c2dc Merge branch '5.1' into 5.2
* 5.1:
  Use ::class keyword when possible
2021-01-11 09:45:11 +01:00
Fabien Potencier
ba24bca384 Use ::class keyword when possible 2021-01-11 07:14:03 +01:00
Fabien Potencier
c373e24e49 Merge branch '5.2' into 5.x
* 5.2:
  Use ::class keyword when possible
2021-01-11 07:08:00 +01:00
Fabien Potencier
2d3385187c Merge branch '5.1' into 5.2
* 5.1:
  Use ::class keyword when possible
2021-01-11 07:07:06 +01:00
Fabien Potencier
589ab8b8fc Merge branch '4.4' into 5.1
* 4.4:
  Use ::class keyword when possible
2021-01-11 07:06:28 +01:00
Fabien Potencier
c79e61f1f2 minor #39775 [WIP] Use ::class keyword when possible (fabpot)
This PR was merged into the 4.4 branch.

Discussion
----------

[WIP] Use ::class keyword when possible

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | n/a  <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

036a36cb14 Use ::class keyword when possible
2021-01-11 07:02:33 +01:00
Alexis Lefebvre
aa7f83576c
Contracts: Remove ellipsis 2021-01-10 20:12:53 +01:00
Fabien Potencier
036a36cb14 Use ::class keyword when possible 2021-01-10 17:45:22 +01:00
Fabien Potencier
88ecaa5aba Merge branch '5.2' into 5.x
* 5.2:
  Improve composer.json descriptions
  Improve composer.json descriptions
  Improve composer.json descriptions
2021-01-10 17:41:41 +01:00
Fabien Potencier
cf5d1f9baa Improve composer.json descriptions 2021-01-10 17:41:31 +01:00
Fabien Potencier
b57cbb41b3 Merge branch '5.1' into 5.2
* 5.1:
  Improve composer.json descriptions
2021-01-10 17:40:11 +01:00
Fabien Potencier
28ca51611e Improve composer.json descriptions 2021-01-10 17:40:03 +01:00
Fabien Potencier
ef6d6a5f00 Merge branch '5.1' into 5.2
* 5.1:
  Improve composer.json descriptions
2021-01-10 17:38:27 +01:00
Fabien Potencier
b40597844a Improve composer.json descriptions 2021-01-10 17:38:16 +01:00
Fabien Potencier
7409566cf1 Merge branch '5.2' into 5.x
* 5.2:
  Improve composer.json descriptions
2021-01-10 17:31:27 +01:00
Fabien Potencier
1154fd4059 Merge branch '5.1' into 5.2
* 5.1:
  Improve composer.json descriptions
2021-01-10 17:30:10 +01:00
Fabien Potencier
dbbcb9cd1f Merge branch '4.4' into 5.1
* 4.4:
  Improve composer.json descriptions
2021-01-10 17:29:19 +01:00
Fabien Potencier
cfab37fecf minor #39773 Improve composer.json descriptions (fabpot)
This PR was merged into the 4.4 branch.

Discussion
----------

Improve composer.json descriptions

| Q             | A
| ------------- | ---
| Branch?       | 4.4 <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets       | Refs #39768 <!-- prefix each issue number with "Fix #", no need to create an issue if none exist, explain below instead -->
| License       | MIT
| Doc PR        | n/a

Commits
-------

611a2dfaf3 Improve composer.json descriptions
2021-01-10 17:26:45 +01:00
Fabien Potencier
3c738b3e2c Merge branch '5.2' into 5.x
* 5.2:
  Remove "requires PHP 7.2" annotations
  quote all dumped unicode spaces
  Switched from parent type hard-coded FQCN to `::class` keyword.
2021-01-10 17:26:23 +01:00
Fabien Potencier
ff3c37dc10 Merge branch '5.1' into 5.2
* 5.1:
  Remove "requires PHP 7.2" annotations
  quote all dumped unicode spaces
  Switched from parent type hard-coded FQCN to `::class` keyword.
2021-01-10 17:26:11 +01:00
Fabien Potencier
26aad18a63 Merge branch '4.4' into 5.1
* 4.4:
  quote all dumped unicode spaces
  Switched from parent type hard-coded FQCN to `::class` keyword.
2021-01-10 17:26:00 +01:00
Fabien Potencier
611a2dfaf3 Improve composer.json descriptions 2021-01-10 17:25:35 +01:00
Fabien Potencier
5380fac733 minor #39777 Remove "requires PHP 7.2" annotations (derrabus)
This PR was merged into the 5.1 branch.

Discussion
----------

Remove "requires PHP 7.2" annotations

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

Commits
-------

1ec5a65c73 Remove "requires PHP 7.2" annotations
2021-01-10 16:33:49 +01:00
Alexander M. Turek
1ec5a65c73 Remove "requires PHP 7.2" annotations 2021-01-10 16:19:05 +01:00
Fabien Potencier
220cedf58c minor #39762 [Form] Update AbstractType.php (DonCallisto)
This PR was merged into the 4.4 branch.

Discussion
----------

[Form] Update AbstractType.php

Switched from parent type hard-coded FQCN to `::class` keyword.

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

ff13967545 Switched from parent type hard-coded FQCN to `::class` keyword.
2021-01-10 13:19:09 +01:00
Fabien Potencier
4cba31e49f minor #39769 [Yaml] quote all dumped unicode spaces (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[Yaml] quote all dumped unicode spaces

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39767
| License       | MIT
| Doc PR        |

Commits
-------

0028efe8f8 quote all dumped unicode spaces
2021-01-10 09:40:13 +01:00