This PR was merged into the 3.4 branch.
Discussion
----------
[PropertyAccess] Fix TypeError parsing again
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | #36872
| License | MIT
| Doc PR | N/A
Apparently, the format of `TypeError`s has changed again in php8. While investigating, I noticed our error message parsing is not handling anonymous classes well, so I've added some test cases for them.
I chose a fuzzier regular expression to parse the expected return type from the error message. Additionally, I'm checking the stack trace if the caught `TypeError` is really caused by the accessor call.
Commits
-------
03b4e98630 [PropertyAccess] Fix TypeError parsing again.
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] validate subforms in all validation groups
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#36852
| License | MIT
| Doc PR |
Commits
-------
b819d94d14 validate subforms in all validation groups
This PR was merged into the 3.4 branch.
Discussion
----------
Fixes sprintf(): Too few arguments in form transformer
Similar to: #29482
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | none
| License | MIT
| Doc PR | none
Fixes the form reverse transformation when the method viewToNorm is called within a value with the character %:
Before : "sprintf(): Too few arguments"
After : Form reverse transformation works.
Reference : http://php.net/manual/function.sprintf.php
Commits
-------
ff7d3f4f01 Fixes sprintf(): Too few arguments in form transformer
This PR was merged into the 4.4 branch.
Discussion
----------
[Validator] Use Mime component to determine mime type for file validator
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
| Doc PR | N/A
When validating the mime type for a file, the Validator component relies on the `Symfony\Component\HttpFoundation\File\File` class, but if the HttpFoundation component is not installed, then you just get the error
```
PHP Fatal error: Uncaught Error: Class 'Symfony\Component\HttpFoundation\File\File' not found
```
This PR uses the Mime component to get the mime type for a file and throws an exception if the Mime component is not installed.
Commits
-------
472883313f [Validator] Use Mime component to determine mime type for file validator
This PR was merged into the 3.4 branch.
Discussion
----------
[Form] Update Hungarian translations
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | no
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | -
| License | MIT
| Doc PR | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch master.
-->
Commits
-------
1614595424 Update Hungarian translations
This PR was submitted for the master branch but it was merged into the 3.4 branch instead.
Discussion
----------
Add meaningful message when using ProcessHelper and Process is not installed
| Q | A
| ------------- | ---
| Branch? | master
| Bug fix? | no
| New feature? | yes
| Deprecations? | no
| Tickets |
| License | MIT
| Doc PR |
When using the process helper without the `Process` component, a php fatal error is triggered (`PHP Fatal error: Uncaught Error: Class 'Symfony\Component\Process\Process' not found`). This PR adds a meaningful exception; allowing to display a console error message instead of a raw php fatal error.
Commits
-------
3ab76e40ff Add meaningful message when Process is not installed (ProcessHelper)
This PR was merged into the 5.1 branch.
Discussion
----------
[Messenger] Change the default notify timeout value for PostgreSQL
| Q | A
| ------------- | ---
| Branch? | 5.1 <!-- see below -->
| Bug fix? | yes-ish
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | n/a <!-- prefix each issue number with "Fix #", if any -->
| License | MIT
| Doc PR | n/a
The default value of 0 means that notify is kind of disable and that incurs many SQL requests. 10 minutes is kind of arbitrary but seems to be a good balance between waiting for a message (blocking) and trying again later in case of an issue.
Commits
-------
d9decf9da2 [Messenger] Change the default notify timeout value for PostgreSQL
This PR was merged into the 4.4 branch.
Discussion
----------
[TwigBridge] fix fallback html-to-txt body converter
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Right now, the content of the `<head>` and `<style>` are dumped as text. This fixes it.
Of course, use `league/html-to-markdown` if you need a better parser.
Commits
-------
6f59d60508 [TwigBridge] fix fallback html-to-txt body converter
This PR was merged into the 4.4 branch.
Discussion
----------
[ErrorHandler] fix setting $trace to null in FatalError
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Spotted by @nikic in https://github.com/php/php-src/pull/5620#issuecomment-635258024
Commits
-------
aa50c9287c [ErrorHandler] fix setting $trace to null in FatalError
* 5.1:
Handle fetch mode deprecation of DBAL 2.11.
Fixed security-* package dependencies
Fixed handling of CSRF logout error
[WebProfilerBundle] changed label of memory usage in time panel (Mb into MiB)
[DotEnv][WebLink][Templating][ErrorHandler] Updated README with minimal example
* 5.0:
Handle fetch mode deprecation of DBAL 2.11.
Fixed handling of CSRF logout error
[WebProfilerBundle] changed label of memory usage in time panel (Mb into MiB)
[DotEnv][WebLink][Templating][ErrorHandler] Updated README with minimal example
* 4.4:
Handle fetch mode deprecation of DBAL 2.11.
Fixed handling of CSRF logout error
[WebProfilerBundle] changed label of memory usage in time panel (Mb into MiB)
[DotEnv][WebLink][Templating][ErrorHandler] Updated README with minimal example
This PR was merged into the 3.4 branch.
Discussion
----------
[Validator] Add missing translations for cs locale (Czech)
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| License | MIT
Is it enough to submit this only against 3.4 to have it included also in 5.1 version?
Commits
-------
3d18c1c185 [Validator] add missing Czech translations
This PR was merged into the 3.4 branch.
Discussion
----------
Handle fetch mode deprecation of DBAL 2.11.
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | no
| License | MIT
| Doc PR | N/A
See doctrine/dbal#4019
DBAL has deprecated PDO-style fetch modes in favor of more explicit methods.
Commits
-------
ed518551e1 Handle fetch mode deprecation of DBAL 2.11.
This PR was merged into the 5.1 branch.
Discussion
----------
[SecurityBundle] Fixed version constraint on security-core and security-guard
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix https://symfony.com/blog/new-in-symfony-5-1-updated-security-system#comment-24048
| License | MIT
| Doc PR | -
We somehow completely forgot to upgrade these version constraints to `^5.1`.
*build failures are unrelated*
Commits
-------
e3d9b259e0 Fixed security-* package dependencies
* 5.1:
[Contracts/Deprecation] fix composer.json for PHP 8
bumped Symfony version to 5.1.0
updated VERSION for 5.1.0-RC2
updated CHANGELOG for 5.1.0-RC2
This PR was merged into the 5.1 branch.
Discussion
----------
[Contracts/Deprecation] fix composer.json for PHP 8
| Q | A
| ------------- | ---
| Branch? | 5.1
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | -
Spotted by @xepozz in https://github.com/symfony/deprecation-contracts/pull/2
Commits
-------
5db0a8bf4b [Contracts/Deprecation] fix composer.json for PHP 8
This PR was merged into the 4.4 branch.
Discussion
----------
[WebProfilerBundle] changed label of memory usage in time panel (Mb into MiB)
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#36533
| License | MIT
| Doc PR | -
This PR fixes the memory usage labels in the time panel of the web profiler for 4.4+. PR #36571 already fixed this for 3.4 but since the time panel has been rewritten in 4.3, that minor fix has not correctly been transferred into 4.4+.
Commits
-------
a91204a79d [WebProfilerBundle] changed label of memory usage in time panel (Mb into MiB)
This PR was merged into the 3.4 branch.
Discussion
----------
[Security] Fixed handling of CSRF logout error
| Q | A
| ------------- | ---
| Branch? | 3.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#36814
| License | MIT
| Doc PR | -
8 years ago, a typo was made while refactoring the `ExceptionListener`, loosing this logic (46071f3238). I think we should fix it.
The `LogoutException` is a very generic name for something only used when the CSRF token is invalid. Should we match the exception message to make sure only this CSRF error is transformed into 403? I didn't yet do it because any usage of `LogoutException` would have resulted in 500, which always is worse than 403.
Commits
-------
50348f2eb7 Fixed handling of CSRF logout error
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[DotEnv][WebLink][Templating][ErrorHandler] Updated README with minimal example
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | -
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/13706
We're about to delete some more component docs. The minimal examples where copy/pasted from the original component docs.
Commits
-------
f3b8a58513 [DotEnv][WebLink][Templating][ErrorHandler] Updated README with minimal example