Commit Graph

42226 Commits

Author SHA1 Message Date
Nicolas Grekas
3fadcc6a96 Merge branch '4.4'
* 4.4:
  [HttpKernel] Make DebugHandlersListener internal
  HttpKernel 4.4 is incompatible with Console 5 because of the EventDispatcher changes.
  Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
  bump Twig bridge dependency
  [HttpClient] Minor fix in an error message
  Fix parameter documentation for Inflector::pluralize() method
  Use a more appropriate group when deprecating mode
  Marked several components as incompatible with EventDispatcher 5.
  bumped Symfony version to 4.3.1
  updated VERSION for 4.3.0
  updated CHANGELOG for 4.3.0
  [FrameworkBundle] fix test fixture using deprecated controller and add missing deprecation
  exchanged $rootDir and $fileLinkFormatter arguments in DebugCommand
  [FrameworkBundle] Add a validation on the messenger section
2019-05-30 15:57:29 +02:00
Nicolas Grekas
47fd08eb5c Merge branch '4.3' into 4.4
* 4.3:
  Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
  [HttpClient] Minor fix in an error message
  Fix parameter documentation for Inflector::pluralize() method
  Use a more appropriate group when deprecating mode
  bumped Symfony version to 4.3.1
  updated VERSION for 4.3.0
  updated CHANGELOG for 4.3.0
  [FrameworkBundle] fix test fixture using deprecated controller and add missing deprecation
  [FrameworkBundle] Add a validation on the messenger section
2019-05-30 15:50:22 +02:00
Nicolas Grekas
fb865a670c minor #31699 [Serializer] Unified normalizers/encoders config through default context solely (ogizanagi)
This PR was squashed before being merged into the 5.0-dev branch (closes #31699).

Discussion
----------

[Serializer] Unified normalizers/encoders config through default context solely

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see below -->
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #28709   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

As planned in #28709.
Split into two commits to ease review.

Commits
-------

914577eaa9 [Serializer] Unified normalizers/encoders config through default context solely
2019-05-30 15:48:28 +02:00
Maxime Steinhausser
914577eaa9 [Serializer] Unified normalizers/encoders config through default context solely 2019-05-30 15:48:21 +02:00
Robin Chalas
317b80facc [Console] Remove deprecated features 2019-05-30 15:36:38 +02:00
Nicolas Grekas
1203290688 feature #31732 [HttpKernel] Make DebugHandlersListener internal (chalasr)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Make DebugHandlersListener internal

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Required to remove the legacy `Event` argument type declaration from its `configure()` method in 5.0.
Unlocks #31689

Commits
-------

1a8db293c6 [HttpKernel] Make DebugHandlersListener internal
2019-05-30 15:26:48 +02:00
Robin Chalas
1a8db293c6 [HttpKernel] Make DebugHandlersListener internal 2019-05-30 15:23:23 +02:00
Nicolas Grekas
174a0a7576 minor #31731 [DI] remove support for non-string default env() parameters (ro0NL)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI] remove support for non-string default env() parameters

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

See #27808

Commits
-------

614f5da2a6 [DI] remove support for non-string default env() parameters
2019-05-30 15:19:32 +02:00
Nicolas Grekas
2ff0273206 minor #31734 [HttpKernel] Don't install HttpKernel 4.4 with Console 5 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[HttpKernel] Don't install HttpKernel 4.4 with Console 5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Another attempt to get the build of #31709 green. Because the base class of `ConsoleEvent` was changed, the Console component 5.0 in going to be incompatible with `DebugHandlersListener` in HttpKernel 4.4.

Commits
-------

44f326dc4c HttpKernel 4.4 is incompatible with Console 5 because of the EventDispatcher changes.
2019-05-30 15:13:04 +02:00
Alexander M. Turek
44f326dc4c HttpKernel 4.4 is incompatible with Console 5 because of the EventDispatcher changes. 2019-05-30 14:30:19 +02:00
Roland Franssen
614f5da2a6 [DI] remove support for non-string default env() parameters 2019-05-30 13:48:35 +02:00
Nicolas Grekas
3392186e7f minor #31719 Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client (andrew-demb)
This PR was squashed before being merged into the 4.3 branch (closes #31719).

Discussion
----------

Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

In `Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client` property exists phpdoc about property class, but no `use` declaration added.

As `Symfony\Bundle\FrameworkBundle\Client` deprecated, and actually this will be `Symfony\Bundle\FrameworkBundle\KernelBrowser` instance, we can put `KernelBrowser` instead `Client` (not sure about BC)
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

6982025e3a Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client
2019-05-30 13:26:49 +02:00
Andrii Dembitskyi
6982025e3a Add missed use class for Symfony\Bundle\FrameworkBundle\Test\WebTestCase::$client 2019-05-30 13:26:44 +02:00
Nicolas Grekas
bfa43d3038 minor #31724 [Security] remove the has_role() security expression function (xabbuh)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Security] remove the has_role() security expression function

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Commits
-------

c99dfdf119 remove the has_role() security expression function
2019-05-30 13:25:38 +02:00
Nicolas Grekas
299b6264cb minor #31728 [TwigBundle] bump Twig bridge dependency (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBundle] bump Twig bridge dependency

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31688
| License       | MIT
| Doc PR        |

We need a version of the `DebugCommand` class that is compatible with
its service definition in the Twig bundle.

Commits
-------

9df66b831a bump Twig bridge dependency
2019-05-30 13:23:15 +02:00
Christian Flothmann
9df66b831a bump Twig bridge dependency
We need a version of the `DebugCommand` class that is compatible with
its service definition in the Twig bundle.
2019-05-30 12:28:51 +02:00
Nicolas Grekas
d690792dc7 minor #31726 [HttpClient] Minor fix in an error message (javiereguiluz)
This PR was merged into the 4.3 branch.

Discussion
----------

[HttpClient] Minor fix in an error message

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Fixes this:

![image](https://user-images.githubusercontent.com/73419/58624608-e9de9e00-82d0-11e9-9558-3f52388f1531.png)

Commits
-------

2da9e3f717 [HttpClient] Minor fix in an error message
2019-05-30 12:01:41 +02:00
Nicolas Grekas
695ee319df minor #31722 Fix parameter documentation for Inflector::pluralize() method (Chi-teck)
This PR was merged into the 4.3 branch.

Discussion
----------

Fix parameter documentation for Inflector::pluralize() method

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
|License | MIT
|Doc PR | n/a

Commits
-------

33844376da Fix parameter documentation for Inflector::pluralize() method
2019-05-30 11:58:12 +02:00
Nicolas Grekas
b33a61b6e9 bug #31721 [PHPUnitBridge] Use a more appropriate group when deprecating mode (greg0ire)
This PR was merged into the 4.3 branch.

Discussion
----------

[PHPUnitBridge] Use a more appropriate group when deprecating mode

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.

Commits
-------

3a88f11662 Use a more appropriate group when deprecating mode
2019-05-30 11:57:43 +02:00
Nicolas Grekas
d4464afeb9 minor #31716 [DI] removed support for extension config without ConfigurationInterface implem (ro0NL)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[DI] removed support for extension config without ConfigurationInterface implem

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

See #27042

Commits
-------

4dd84f0720 [DI] removed support for extension config without ConfigurationInterface implem
2019-05-30 11:55:48 +02:00
Nicolas Grekas
b49d59fec3 minor #31712 Marked several components as incompatible with EventDispatcher 5 (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

Marked several components as incompatible with EventDispatcher 5

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | N/A
| License       | MIT
| Doc PR        | N/A

Quite a few components still use the old event class that is to be removed in Symfony 5. This PR ensures that they are only installed with EventDispatcher 4.

Follow up to #31709

Commits
-------

e6a4526fa3 Marked several components as incompatible with EventDispatcher 5.
2019-05-30 11:53:54 +02:00
Javier Eguiluz
2da9e3f717 [HttpClient] Minor fix in an error message 2019-05-30 11:47:28 +02:00
Christian Flothmann
c99dfdf119 remove the has_role() security expression function 2019-05-30 11:42:14 +02:00
Chi-teck
33844376da Fix parameter documentation for Inflector::pluralize() method 2019-05-30 14:28:08 +05:00
Grégoire Paris
3a88f11662
Use a more appropriate group when deprecating mode
The deprecation comes from a vendor: the phpunit bridge itself, so it's
either the direct or the indirect group. And since only the end user is
supposed to set the group, then this is supposed to be a direct
deprecation.
2019-05-30 10:57:55 +02:00
Alexander M. Turek
e6a4526fa3 Marked several components as incompatible with EventDispatcher 5. 2019-05-30 09:25:19 +02:00
Fabien Potencier
f9beee7424 bumped Symfony version to 4.3.1 2019-05-30 08:26:43 +02:00
Fabien Potencier
0bf8d128ef
Merge pull request #31717 from fabpot/release-4.3.0
released v4.3.0
2019-05-30 08:21:30 +02:00
Fabien Potencier
090c029f21 updated VERSION for 4.3.0 2019-05-30 08:21:08 +02:00
Fabien Potencier
65531c8499 updated CHANGELOG for 4.3.0 2019-05-30 08:20:59 +02:00
Roland Franssen
4dd84f0720 [DI] removed support for extension config without ConfigurationInterface implem 2019-05-30 08:17:44 +02:00
Fabien Potencier
d0cef8271c minor #31713 [FrameworkBundle] fix test fixture using deprecated controller (Tobion)
This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle] fix test fixture using deprecated controller

| Q             | A
| ------------- | ---
| Branch?       | 4.3
| Bug fix?      | no
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets |
| License       | MIT
| Doc PR        |

https://github.com/symfony/symfony/pull/21035/files#diff-636946f5b52668178ede98d59135a181 reintroduced some deprecated controller notations (#26085) which wasn't spotted because ResolveControllerNameSubscriber missed a deprecation trigger. This also adds this trigger.

Commits
-------

7f00a74754 [FrameworkBundle] fix test fixture using deprecated controller and add missing deprecation
2019-05-30 08:06:50 +02:00
Tobias Schultze
7f00a74754 [FrameworkBundle] fix test fixture using deprecated controller and add missing deprecation 2019-05-30 05:17:01 +02:00
Tobias Schultze
ea8c054971 minor #31688 [TwigBridge] Swapped $rootDir and $fileLinkFormatter arguments in DebugCommand (yceruto)
This PR was merged into the 4.4 branch.

Discussion
----------

[TwigBridge] Swapped $rootDir and $fileLinkFormatter arguments in DebugCommand

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | yes
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This is necessary to remove the `$rootDir` in 5.0, see https://github.com/symfony/symfony/pull/31667

Commits
-------

beca8642ca exchanged $rootDir and $fileLinkFormatter arguments in DebugCommand
2019-05-30 00:24:54 +02:00
Tobias Schultze
e1923c620d minor #31662 [FrameworkBundle] Add a validation on the messenger section (vincenttouzet)
This PR was merged into the 4.3 branch.

Discussion
----------

[FrameworkBundle] Add a validation on the messenger section

| Q             | A
| ------------- | ---
| Branch?       | 4.3  <!-- see below -->
| Bug fix?      | yes
| New feature?  | no <!-- please update src/**/CHANGELOG.md files -->
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #31624    <!-- #-prefixed issue number(s), if any -->
| License       | MIT

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

36f16e8461 [FrameworkBundle] Add a validation on the messenger section
2019-05-30 00:23:24 +02:00
Robin Chalas
3fec46861a reword changelog entry 2019-05-29 23:10:57 +02:00
Nicolas Grekas
7d78252630 minor #31706 [Form] Remove the scale argument of the IntegerToLocalizedStringTransformer (yceruto)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] Remove the scale argument of the IntegerToLocalizedStringTransformer

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See https://github.com/symfony/symfony/pull/28569

Commits
-------

2cef8a2a2a Remove the scale argument of the IntegerToLocalizedStringTransformer
2019-05-29 22:38:02 +02:00
Nicolas Grekas
c9b146b557 minor #31673 [Form] Remove legacy regions option in TimezoneType (ro0NL)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] Remove legacy regions option in TimezoneType

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.

Additionally (see https://symfony.com/roadmap):
 - Bug fixes must be submitted against the lowest maintained branch where they apply
   (lowest branches are regularly merged to upper ones so they get the fixes too).
 - Features and deprecations must be submitted against the master branch.
-->

Commits
-------

5b5edd10cc [Form] Remove legacy regions option in TimezoneType
2019-05-29 21:16:09 +02:00
Yonel Ceruto
2cef8a2a2a Remove the scale argument of the IntegerToLocalizedStringTransformer 2019-05-29 15:15:44 -04:00
Nicolas Grekas
abc652cc0c minor #31705 [Form] Throw exception for invalid form buttons name (yceruto)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] Throw exception for invalid form buttons name

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See https://github.com/symfony/symfony/pull/28969

Commits
-------

6deeaa42ae Validating form buttons name
2019-05-29 21:14:39 +02:00
Roland Franssen
5b5edd10cc [Form] Remove legacy regions option in TimezoneType 2019-05-29 21:05:02 +02:00
Nicolas Grekas
8401f27106 minor #31704 [Form] Throw exception when render a field which was already rendered (yceruto)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] Throw exception when render a field which was already rendered

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

See https://github.com/symfony/symfony/pull/27247

Commits
-------

d1bbad063d Throw exception when render a field which was already rendered
2019-05-29 21:03:02 +02:00
Yonel Ceruto
d1bbad063d Throw exception when render a field which was already rendered 2019-05-29 14:51:07 -04:00
Yonel Ceruto
6deeaa42ae Validating form buttons name 2019-05-29 14:47:52 -04:00
Nicolas Grekas
bb9cf60c1f minor #31703 [Form] Remove legacy code related to getExtendedType() method (yceruto)
This PR was merged into the 5.0-dev branch.

Discussion
----------

[Form] Remove legacy code related to getExtendedType() method

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Ref: https://github.com/symfony/symfony/pull/24530

Commits
-------

208b729bca Remove legacy code related to getExtendedType() method
2019-05-29 20:45:16 +02:00
Nicolas Grekas
c2c6a01dac Merge branch '4.4'
* 4.4:
  [Intl] Improve the error message when country code is wrong
  Fix tests
  [Intl][4.3] Cleanup internal api
  [HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping
  bumped Symfony version to 4.2.10
  updated VERSION for 4.2.9
  updated CHANGELOG for 4.2.9
  Use AsserEquals for floating-point values
2019-05-29 20:12:19 +02:00
Nicolas Grekas
5af3e54d2b Merge branch '4.3' into 4.4
* 4.3:
  [Intl] Improve the error message when country code is wrong
  Fix tests
  [Intl][4.3] Cleanup internal api
  [HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping
  bumped Symfony version to 4.2.10
  updated VERSION for 4.2.9
  updated CHANGELOG for 4.2.9
  Use AsserEquals for floating-point values
2019-05-29 20:10:53 +02:00
Nicolas Grekas
ac88953ef9 Merge branch '4.2' into 4.3
* 4.2:
  [HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping
  bumped Symfony version to 4.2.10
  updated VERSION for 4.2.9
  updated CHANGELOG for 4.2.9
  Use AsserEquals for floating-point values
2019-05-29 20:10:42 +02:00
Nicolas Grekas
31f51ca9a5 Merge branch '3.4' into 4.2
* 3.4:
  [HttpFoundation] Do not set X-Accel-Redirect for paths outside of X-Accel-Mapping
  Use AsserEquals for floating-point values
2019-05-29 20:10:06 +02:00
Yonel Ceruto
208b729bca Remove legacy code related to getExtendedType() method 2019-05-29 14:08:52 -04:00