This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] fix#10313: FlattenException not found
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10313
| License | MIT
| Doc PR | none
Note that this patch should be ignored while merging into 2.5/master (it will conflict because 2.5/master has a much stronger workaround, not suitable for a minor release IMHO).
Commits
-------
b147cfa [Debug] fix#10313: FlattenException not found because of https://bugs.php.net/42098
This PR was merged into the 2.3 branch.
Discussion
----------
[Debug] fix ErrorHandlerTest when context is not an array
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | none
| License | MIT
| Doc PR | none
Commits
-------
988a5dc [Debug] fix ErrorHandlerTest when context is not an array
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Allow File instance to be passed to BinaryFileResponse
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10608
| License | MIT
| Doc PR |
See https://github.com/symfony/symfony/issues/10608 for discussion and reasoning.
The docblocks get rather long with this change. The File class does extend SplFileObject so technically it could be left out of the docblock if that is more desirable.
Commits
-------
fc04ad2 Allow File instance to be passed to BinaryFileResponse
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#10644).
Discussion
----------
Add upgrade instructions for the LoggerInterface that changed in Symfony 2.2
Commits
-------
6daa295 Add upgrade instructions for the LoggerInterface
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10643).
Discussion
----------
[TwigBridge] Removed strict check when found variables inside a translation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no?
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10638
| License | MIT
Commits
-------
074191e Removed strict check when found variables inside a translation
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] Fixed the rendering of exceptions on HHVM with a terminal width
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
If ``getTerminalWidth`` returns a big integer (which is the case in Behat 2.5 which overwrites the method to return ``PHP_INT_MAX`` to avoid limiting the width), the fix done in #10000 for HHVM would be needed as well. So this moves it after the condition rather than having it only for the default.
Commits
-------
6e57380 [Console] Fixed the rendering of exceptions on HHVM with a terminal width
This PR was squashed before being merged into the 2.3 branch (closes#10773).
Discussion
----------
[WebProfilerBundle ] Fixed an edge case on WDT loading
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #6824 ?
| License | MIT
| Doc PR | none
In some case you can notice the WDT just disappears.
By tracking it down, I noticed that the XHR call returns an empty response with 200 as status code, but if you go directly on the _wdt/my_token URL it works correctly.
What's happening is that when you have a slow listener on `kernel.terminate` (for example the SwiftMailer one with a slow connection), you response (and therefore the WDT javascript) is sent and processed by the browser, the XHR call is done, but the Profiler storage didn't happened yet so no profiling data is available and the `ProfilerController` just sends an empty response with 200 as status code.
Here we change to instead send a specific status code, and treat it in javascript by retrying several times before failing.
The question are:
* Is 204 the most appropriate response code?
* Are 500 ms and 5 max retries good values?
Commits
-------
9d885ed [WebProfilerBundle ] Fixed an edge case on WDT loading
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10782).
Discussion
----------
fixed typo
[Validator] [FrameworkBundle] fixed a typo in farsi translation of length validator when input must be of exact size.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
dc3f350 fixed typo
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Disable TTY mode on Windows platform
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Commits
-------
7942c2a [Process] Disable TTY mode on Windows platform
This PR was merged into the 2.3 branch.
Discussion
----------
[Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #10747
| License | MIT
| Doc PR | -
`\RecursiveDirectoryIterator::getChildren()` creates an instance of the current (overloaded) class with default constructor arguments. Therefore the `ignoreUnreadableDirs` is not passed to the child directories as @marcj suggested in #10747.
My fix relies on PHP's ability to modify private properties in objects of the same class. My reasoning behind choosing this approach, instead of using a setter, is that it's an internal detail which doesn't need to be part of a public interface.
Unfortunately, I can't really cover this case by tests.
Commits
-------
1346641 [Finder] Fix ignoring of unreadable dirs in the RecursiveDirectoryIterator.
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10750).
Discussion
----------
[Config] fix docblock
| Q | A
| ------------- | ---
| Fixed tickets | none
| License | MIT
Some phpdoc are wrong in the Config component after the PR #10701 was merged.
eg:
IntegerNode was changed to intNode
BooleanNodeDefinition was changed to boolNodeDefinition
Commits
-------
68debfb fix docblock
This PR was merged into the 2.3 branch.
Discussion
----------
[FrameworkBundle] improve English in RouterMatchCommand
Improve English in command output.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
dd26d1e [FrameworkBundle] improve English in RouterMatchCommand
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Setting STDIN while running should not be possible
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
Commits
-------
3e3517a [Process] Setting STDIN while running should not be possible
This PR was squashed before being merged into the 2.3 branch (closes#10749).
Discussion
----------
Fixed incompatibility of x509 auth with nginx
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
This commit fixes x509 authentication when using nginx as web server.
X509AuthenticationListener depends on the SSL_CLIENT_S_DN_Email field being set.
As is, this field is specific to Apache and cannot be provided by nginx. nginx
can provide the DN of the certificate in SSL_CLIENT_S_DN. If the email field is
not set, the listener tries to extract the email address from the DN.
Commits
-------
ba8fc16 Fixed incompatibility of x509 auth with nginx
This PR was merged into the 2.3 branch.
Discussion
----------
[Doctrine Bridge] simplify session handler
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no because the driver connection could not be used anyway before
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
Use main connection as discussed in #10720
Commits
-------
6518b74 [Doctrine Bridge] simplify session handler by using main connection
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10735).
Discussion
----------
[Translation] [PluralizationRules] Little correction for case 'ar'
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
ef85f4c Little correction for case 'ar'
This PR was merged into the 2.3 branch.
Discussion
----------
[Finder] Marked test skipped when ftp stream wrapper is not available
| Q | A
| ---------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
This should prevent test from failing on hhvm as ftp stream wrapper is not currently implemented.
See https://github.com/facebook/hhvm/issues/2108 for more details.
Commits
-------
f35fc81 [Finder] Marked test skipped when ftp stream wrapper is not available
This PR was merged into the 2.3 branch.
Discussion
----------
[HttpFoundation] Fix DbalSessionHandler
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
This is basically the same as #10652 for the DbalSessionHandler.
- First commit fixes fix DbalSessionHandler for high concurrency, interface compliance, compatibility with all drivers (oci8, mysqli, pdo with mysql, sqlsrv, sqlite).
- Second commit updates phpdoc of SessionHandlerInterface and unifies parameters of all handlers according to interface (so inheritdoc actually makes sense).
Commits
-------
524bf84 [HttpFoundation] update phpdoc of SessionHandlerInterface and unify parameters of all handlers according to interface
ccdfbe6 [Doctrine Bridge] fix DbalSessionHandler for high concurrency, interface compliance, compatibility with all drivers (oci8, mysqli, pdo with mysql, sqlsrv, sqlite)
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#10730).
Discussion
----------
No need to use mb functions here
When mb functions are used and a large response is given the OOM happens as mb functions will use large quantities of memory.
In my example the response is approximately 27M in size and a php has a memory consumption of about 150M... When mb functions are used the memory shoots over 250M
Commits
-------
4e8ba13 No need to use mb functions here
This PR was merged into the 2.3 branch.
Discussion
----------
unified return null usages
| Q | A
| ------------- | ---
| License | MIT
This PR unifies the way we return `null` from a function or method:
* always use `return;` instead of `return null;` (the current code base uses both);
* never use `return;` at the end of a function/method.
Commits
-------
d1d569b unified return null usages
Fabien Potencier
Nicolas Grekas
Andreas Lutro
Charles-Eric Gorron
Asmir Mustafic
Christophe Coevoet
Tugdual Saunier
Arash Tabriziyan
Romain Neutron
Jakub Zalas
thewilkybarkid
Loick Piera
alcaeus
Douglas Greenshields
Tobias Schultze
klyk50
Miha Vrhovnik