Commit Graph

28828 Commits

Author SHA1 Message Date
Nicolas Grekas
0c3b7d7b8d [HttpKernel] Revert BC breaking change of Request::isMethodSafe() 2016-11-23 14:53:57 +01:00
Nicolas Grekas
3c1361cd6d bug #20590 [DI] Allow null as default env value (sroze)
This PR was squashed before being merged into the 3.2 branch (closes #20590).

Discussion
----------

[DI] Allow null as default env value

| Q             | A
| ------------- | ---
| Branch?       | 3.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | ø
| License       | MIT
| Doc PR        | ø

This PR allows the environment variable default value to be null. The way, we can allow optional environment variables, such as in this example:

```yaml
parameters:
    # Default values
    env(DATABASE_HOST): database
    env(DATABASE_PORT): ~
    env(DATABASE_NAME): symfony
    env(DATABASE_USERNAME): root
    env(DATABASE_PASSWORD): ~

    # Database configuration
    database_host:     "%env(DATABASE_HOST)%"
    database_port:     "%env(DATABASE_PORT)%"
    database_name:     "%env(DATABASE_NAME)%"
    database_user:     "%env(DATABASE_USERNAME)%"
    database_password: "%env(DATABASE_PASSWORD)%"
```

Commits
-------

519a471 [DI] Allow null as default env value
2016-11-23 14:12:27 +01:00
Samuel ROZE
519a47179a [DI] Allow null as default env value 2016-11-23 14:12:24 +01:00
Robin Chalas
10992cd3bf [Process] Fix kill process on reached timeout using getIterator() 2016-11-23 09:58:31 +01:00
Nicolas Grekas
b4c327d89b [WebProfilerBundle] Fix deprecated uses of profiler_dump 2016-11-22 20:22:01 +01:00
Nicolas Grekas
7752308c96 [DI] Aliases should preserve the aliased invalid behavior 2016-11-22 19:19:49 +01:00
Maxime STEINHAUSSER
f09ccf49d1 [SecurityBundle] Fix FirewallConfig nullable arguments
Nullable arguments were replaced by empty string by the DIC config if values weren't replaced in the extension.
2016-11-22 11:07:22 +01:00
Fabien Potencier
30d161c0ae bug #20499 [Doctrine][Form] support large integers (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[Doctrine][Form] support large integers

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #15642
| License       | MIT
| Doc PR        | n/a

Commits
-------

6954a07 [Doctrine][Form] support large integers
2016-11-21 16:16:03 -08:00
Fabien Potencier
59f99493f8 bug #20559 [FrameworkBundle] Avoid warming up the validator cache for non-existent class (Seldaek)
This PR was submitted for the master branch but it was merged into the 3.2 branch instead (closes #20559).

Discussion
----------

[FrameworkBundle] Avoid warming up the validator cache for non-existent class

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? |no
| Tests pass?   | yes
| License       | MIT

This relates to https://github.com/FriendsOfSymfony/FOSUserBundle/issues/2224 - where basically the cache warmer triggers autoloading of a class that is broken, and it then blows up.

This doesn't fix the problem in itself, loading broken classes will still fail, but it allows us at least to work around it by doing:

```
        "exclude-from-classmap": [
            "vendor/friendsofsymfony/user-bundle/Propel/"
        ]
```

And then `composer dump-autoload -a` to get an authoritative classmap. That way the hasMetadataFor will return false because class_exist() won't try to load the class at all. Without the hasMetadataFor fix though, it calls getMetadataFor which throws an exception in the case the class doesn't exist. I am not sure if that's by design.. that the cache warmer would force you to have classes existing for all your validation definitions.

Commits
-------

cb12f22 [FrameworkBundle] Avoid warming up the validator cache for non-existent classes
2016-11-21 16:13:33 -08:00
Jordi Boggiano
cb12f2200d [FrameworkBundle] Avoid warming up the validator cache for non-existent classes 2016-11-21 16:13:32 -08:00
Fabien Potencier
9c82a9bd92 minor #20505 [DOMCrawler] Bug fixed (Imangazaliev)
This PR was submitted for the master branch but it was merged into the 2.7 branch instead (closes #20505).

Discussion
----------

[DOMCrawler] Bug fixed

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT
| Doc PR        | reference to the documentation PR, if any

Commits
-------

6c3150d [DOMCrawler] Bug fixed
2016-11-21 16:09:36 -08:00
Imangazaliev
6c3150df63 [DOMCrawler] Bug fixed 2016-11-21 16:09:36 -08:00
Fabien Potencier
adaa8ec50f minor #20561 Fix annotation type for $context (KmeCnin)
This PR was merged into the 2.8 branch.

Discussion
----------

Fix annotation type for $context

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Previous type ExecutionContextInterface was referring to a non declared namespace. Replacing it by ExecutionContextInterface2Dot5 fixes autocomplete.

Commits
-------

55e134c Fix annotation type for $context
2016-11-21 16:03:35 -08:00
Fabien Potencier
7047e4d31f bug #20576 [Process] Do feat test before enabling TTY mode (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Process] Do feat test before enabling TTY mode

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20565
| License       | MIT
| Doc PR        | -

Commits
-------

69bfbbf [Process] Do feat test before enabling TTY mode
2016-11-21 15:59:43 -08:00
Fabien Potencier
bd34b67f31 bug #20577 [FrameworkBundle] Mark cache.default_*_provider services private (nicolas-grekas)
This PR was merged into the 3.1 branch.

Discussion
----------

[FrameworkBundle] Mark cache.default_*_provider services private

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20563
| License       | MIT
| Doc PR        | -

I know making a service private has a potential for breaking BC. Yet, these services should not be used directly in controllers/userland code, and I really doubt anyone did. Let's make it private now and fix linked issue (even if it's a false positive from SymfonyServiceDefinitionValidator, it shows we have this service that really isn't meant to be public).

Commits
-------

09adfda [FrameworkBundle] Mark cache.default_*_provider services private
2016-11-21 15:54:59 -08:00
Julien Falque
b25c1d30f6
Fix complete config tests 2016-11-21 23:48:35 +01:00
Nicolas Grekas
09adfda57e [FrameworkBundle] Mark cache.default_*_provider services private 2016-11-21 11:06:34 +01:00
Nicolas Grekas
69bfbbf8c2 [Process] Do feat test before enabling TTY mode 2016-11-21 10:47:03 +01:00
Nicolas Grekas
2acaf5f511 [github] Tweak PR template 2016-11-21 10:13:36 +01:00
Fabien Potencier
f09b933564 bumped Symfony version to 3.1.8 2016-11-20 19:12:53 -08:00
Fabien Potencier
db1c32c723 Merge pull request #20575 from fabpot/release-3.1.7
released v3.1.7
2016-11-20 18:44:44 -08:00
Fabien Potencier
386fd29f67 updated VERSION for 3.1.7 2016-11-20 18:44:20 -08:00
Fabien Potencier
ba6420bf88 updated CHANGELOG for 3.1.7 2016-11-20 18:44:16 -08:00
Fabien Potencier
d94a631f4d bumped Symfony version to 2.8.15 2016-11-20 18:42:55 -08:00
Fabien Potencier
6ceca5b415 Merge pull request #20574 from fabpot/release-2.8.14
released v2.8.14
2016-11-20 18:24:51 -08:00
Fabien Potencier
8af226fe39 updated VERSION for 2.8.14 2016-11-20 18:24:42 -08:00
Fabien Potencier
38118a324b updated CHANGELOG for 2.8.14 2016-11-20 18:24:38 -08:00
Fabien Potencier
2af58be68f bumped Symfony version to 2.7.22 2016-11-20 18:19:38 -08:00
Fabien Potencier
cdc25e2d47 Merge pull request #20573 from fabpot/release-2.7.21
released v2.7.21
2016-11-20 17:13:05 -08:00
Fabien Potencier
dec83adc4b updated VERSION for 2.7.21 2016-11-20 17:12:54 -08:00
Fabien Potencier
4367d0c853 update CONTRIBUTORS for 2.7.21 2016-11-20 17:12:28 -08:00
Fabien Potencier
aefd0489a9 updated CHANGELOG for 2.7.21 2016-11-20 17:12:23 -08:00
Nicolas Grekas
2094715152 [Serializer] Fix test assuming UTC default TZ 2016-11-18 16:58:27 -05:00
Nicolas Grekas
39c830997e Merge branch '3.1'
* 3.1:
  [YAML] Fix processing timestamp with timezone
  [ci] Testing with UTC hides bugs
  [DI] Fix error when trying to resolve a DefinitionDecorator
  [DoctrineBridge] Fix deprecation message/documentation of implementing UserProviderInterface using the entity provider
  Fix time-sensitive tests that use data providers
  [Validator] improve and added more Indonesian translation.
2016-11-18 16:17:59 -05:00
Nicolas Grekas
c01a1a9149 bug #20550 [YAML] Fix processing timestamp strings with timezone (myesain)
This PR was merged into the 3.1 branch.

Discussion
----------

[YAML] Fix processing timestamp strings with timezone

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20399
| License       | MIT
| Doc PR        | -

Parse date strings containing timezone data correctly
Default date strings not containing timezone data to UTC

Commits
-------

cdb11a7 [YAML] Fix processing timestamp with timezone
2016-11-18 16:16:50 -05:00
Nicolas Grekas
2e6618b144 Merge branch '2.8' into 3.1
* 2.8:
  [ci] Testing with UTC hides bugs
  [DI] Fix error when trying to resolve a DefinitionDecorator
  [DoctrineBridge] Fix deprecation message/documentation of implementing UserProviderInterface using the entity provider
  [Validator] improve and added more Indonesian translation.
2016-11-18 16:15:08 -05:00
Nicolas Grekas
546ec682bf Merge branch '2.7' into 2.8
* 2.7:
  [ci] Testing with UTC hides bugs
  [DI] Fix error when trying to resolve a DefinitionDecorator
  [Validator] improve and added more Indonesian translation.
2016-11-18 16:10:01 -05:00
Noah Heck
cdb11a7ec9 [YAML] Fix processing timestamp with timezone
Parse date strings containing timezone data correctly
Default date strings not containing timezone data to UTC
2016-11-18 16:05:29 -05:00
Nicolas Grekas
e968d0ff5d minor #20551 [ci] Testing with UTC hides bugs (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[ci] Testing with UTC hides bugs

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As shown by #20550, we're having bugs because we don't in proper TZ conditions.
Let's do Europe on Travis, and America on Windows.

Commits
-------

e0f9bda [ci] Testing with UTC hides bugs
2016-11-18 15:46:21 -05:00
Nicolas Grekas
e0f9bda49a [ci] Testing with UTC hides bugs 2016-11-18 15:26:45 -05:00
Pierre-Chanel Gauthier
55e134cab0 Fix annotation type for $context
Previous type ExecutionContextInterface was referring to a non declared namespace. Replacing it by ExecutionContextInterface2Dot5 fixes autocomplete.
2016-11-18 18:16:13 +01:00
Fabien Potencier
faef0b003f minor #20553 Fixed generation mistake in changelog (chalasr)
This PR was merged into the 3.2-dev branch.

Discussion
----------

Fixed generation mistake in changelog

| Q             | A
| ------------- | ---
| Branch?       | "master"
| Fixed tickets |n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

c30ec36 Fixed generation mistake in changelog
2016-11-18 09:11:01 -05:00
Fabien Potencier
d987c40e7a minor #20540 [DoctrineBridge] Fix deprecation message/documentation of implementing UserProviderInterface using the entity provider (chalasr)
This PR was merged into the 2.8 branch.

Discussion
----------

[DoctrineBridge] Fix deprecation message/documentation of implementing UserProviderInterface using the entity provider

| Q             | A
| ------------- | ---
| Branch?       | 2.8
| Bug fix?      | yes (but the behavior doesn't change)
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #20514
| License       | MIT
| Doc PR        | https://github.com/symfony/symfony-docs/pull/5993 (already merged)

Commits
-------

127af57 [DoctrineBridge] Fix deprecation message/documentation of implementing UserProviderInterface using the entity provider
2016-11-18 09:06:08 -05:00
Fabien Potencier
bc25e08bb5 bumped Symfony version to 3.2.0 2016-11-17 15:47:16 -05:00
Robin Chalas
c30ec36f21 Fixed generation mistake in changelog 2016-11-17 21:40:35 +01:00
Fabien Potencier
7d00e4f006 Merge pull request #20552 from fabpot/release-3.2.0-RC1
released v3.2.0-RC1
2016-11-17 15:27:40 -05:00
Fabien Potencier
6f6bce42fc updated VERSION for 3.2.0-RC1 2016-11-17 15:27:25 -05:00
Fabien Potencier
d3cbd13054 updated CHANGELOG for 3.2.0-RC1 2016-11-17 15:27:15 -05:00
Fabien Potencier
5f14e529a5 updated CHANGELOG for 3.2.0-RC1 2016-11-17 15:26:37 -05:00
Fabien Potencier
015fe87266 bug #20543 [DI] Fix error when trying to resolve a DefinitionDecorator (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[DI] Fix error when trying to resolve a DefinitionDecorator

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Instead of the currently obscure `ReflectionException: Class does not exist` message, let's throw a useful error message.

Commits
-------

8e0da2f [DI] Fix error when trying to resolve a DefinitionDecorator
2016-11-17 11:18:58 -05:00