This PR was merged into the 2.3 branch.
Discussion
----------
[Yaml] fixed some license headers
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Fixes lambdas once and for all.
Commits
-------
a2a6bd4 fixed a typo
35b407f fixed CS for lambdas
93edf44 [Yaml] fixed some license headers
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9865).
Discussion
----------
[Validator] Fixes message value for objects
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
7b69e9b [Validator] Fixes message value for objects
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9441).
Discussion
----------
[Form][DateTimeToArrayTransformer] Check for hour, minute & second validity
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9440
| License | MIT
| Doc PR | -
This PR checks if hour, minute & second values are valid in the datetime to array transformer (values must be integer if they exist).
Commits
-------
1543653 [Form][DateTimeToArrayTransformer] Check for hour, minute & second validity
This PR was merged into the 2.3 branch.
Discussion
----------
fixed various typos
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
Commits
-------
2f15ac7 fixed various typos
This PR was merged into the 2.3 branch.
Discussion
----------
#9866 [Filesystem] Fixed mirror for symlinks
| Q | A
| ------------- | ---
| Bug fix? | [yes]
| New feature? | [no]
| BC breaks? | [no]
| Deprecations? | [no]
| Tests pass? | [yes]
| Fixed tickets | [#9866]
| License | MIT
| Doc PR | [NA]
Check the original ticket for the full description and how to reproduce.
The initial PR #9213 was closed.
Commits
-------
d136555 [Filesystem] Fixed mirror for symlinks
This PR was merged into the 2.3 branch.
Discussion
----------
[Validator] Removed duplicated test for IBAN in data provider
Working on #9850, I spotted a duplicated value on `getValidIbans` data provider and I just removed the duplicated value.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
35610d0 [Validator] Removed duplicated test for IBAN in data provider
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9806).
Discussion
----------
[Security] Fix parent serialization of user object
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
`parent::serialize()` and `parent::unserialize()`, which are used in the `AbstractToken` are [problematic](https://bugs.php.net/bug.php?id=62836) in PHP >= 5.4. [Cloning the object](https://gist.github.com/aurelijus/4713758) before serialization seems to fix this.
Commits
-------
e0bb891 [Security] Fix parent serialization of user object
This PR was merged into the 2.3 branch.
Discussion
----------
[DependencyInjection] fixed typo
Commits
-------
408d992 [DependencyInjection] fixed typo
This PR was merged into the 2.3 branch.
Discussion
----------
[Tests|WCM] add memcache, memcached, and mongodb extensions to run skipped tests
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | na
| License | MIT
| Doc PR | na
- [x] go over all skipped tests, take note and check they are reasonable
- [x] reenable memcache, mongodb, and memcached
We are keeping the icu intl related tests skipped because setting up icu 51.2 is totally time consuming in travis and it would require a custom distro box on travis because there are no ppa's available for the ubuntu version. I tried hard but it does not seem worth it. Same for plugging beta of memcached with pecl, it is just not reasonable to be running beta versions on travis. This then does not address #9797 but at least now we are aware.
This PR now can be merged as is as it improves tests that before were not ran. Not all but more than before. 👶
Commits
-------
47a822d add memcache, memcached, and mongodb extensions to run skipped tests
This PR was merged into the 2.3 branch.
Discussion
----------
[DependencyInjection] Fixed support for backslashes in service ids.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9801
| License | MIT
| Doc PR |
This change is needed for consistency with `camelize()` which is used in [`ProxyDumper`](https://github.com/symfony/symfony/blob/2.3/src/Symfony/Bridge/ProxyManager/LazyProxy/PhpDumper/ProxyDumper.php#L69) and [`PhpDumper`](https://github.com/symfony/DependencyInjection/blob/2.3/Dumper/PhpDumper.php#L1275).
Either this PR needs to be merged for consistency or #9610 rolled back (if we don't want to support backslashes in service ids).
Anyone could tell me why we're not using the `camelize()` method internally in the `Container`?
Commits
-------
c6f210b [DependencyInjection] Fixed support for backslashes in service ids.
This PR was submitted for the 2.2 branch but it was merged into the 2.3 branch instead (closes#9826).
Discussion
----------
fix#9356 [Security] Logger should manipulate the user reloaded from provider
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9356
| License | MIT
PR for well explained ticket #9356 by nikolajosipovic
Any feedback welcome, this is my first PR to symfony
Commits
-------
17b0b34 fix#9356 [Security] Logger should manipulate the user reloaded from provider
This PR was squashed before being merged into the 2.3 branch (closes#9769).
Discussion
----------
[BrowserKit] fixes#8311 CookieJar is totally ignorant of RFC 6265 edge cases
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8311
| License | MIT
| Doc PR |
Commits
-------
3132b04 [BrowserKit] fixes#8311 CookieJar is totally ignorant of RFC 6265 edge cases
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9697).
Discussion
----------
[Config] fix 5528 let ArrayNode::normalizeValue respect order of value array provided
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #5528
| License | MIT
| Doc PR | maybe a note @WouterJ ?
Commits
-------
019c553 [Config] fix 5528 let ArrayNode::normalizeValue respect order of value array provided
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9701).
Discussion
----------
[Config] fix#7243 allow 0 as arraynode name
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #7243
| License | MIT
| Doc PR | no need
Commits
-------
a49a5c8 [Config] fix#7243 allow 0 as arraynode name
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9795).
Discussion
----------
[Form] Fixed issue in BaseDateTimeTransformer when invalid timezone cause Trans...
...formation filed exception (closes#9403).
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | no
| Fixed tickets | #9403
| License | MIT
| Doc PR |
DateTimeZone object creation could rise an exception. So in BaseDateTimeTransformer constructor we need to check if timezone is valid. If this exception is catched and rethrowed as TransformationFailed exception we have an issue: user will see "Invalid value" error in form, but issue is actually with php configuration or form type configuration.
Replaces #9772.
Commits
-------
3ece630 Fixed issue in BaseDateTimeTransformer when invalid timezone cause Transformation filed exception (closes#9403).
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9714).
Discussion
----------
[HttpFoundation] BinaryFileResponse should also return 416 or 200 on some range-requets
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
I read around in the docs and tried something with BinaryFileResponse ... There are two things I missed in the implementation here:
* If the range, provided in the query, does exceed the file-position, return an 416 (or 200 - I decided to take 416 here)
* If the range is logical invalid (f.e. to request from byte 50 to byte 30 ..) return 200 - OK
One decision I took in addition, is to provide a 200 code if the full file is requested. For me, it doesn't make sense here to return a 206 for just the complete file.
What I'm quite unsure about: Do we need some additional fields for these two options? I can remember reading something about a Content-Range for 416 but I was quite unsure what it should be ...
Commits
-------
d5dc317 [HttpFoundation] BinaryFileResponse should also return 416 or 200 on some range-requets
This PR was merged into the 2.3 branch.
Discussion
----------
[Routing] Remove usage of deprecated _scheme requirement
**This is exact the same commit as it was in #9585, which was not merged due to my fault. Sorry for the noise.**
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #8898, #8176
| License | MIT
| Doc PR |
I removed all usages of the deprecated _scheme requirement inside the Routing Component.
Most parts were pretty easy and after multiple refactorings I came up with the solution to have a Route::hasScheme() method and check against this method.
I also checked for performance and after trying in_array, arra_flip+isset and foreach, the last one was clearly the winner.
https://gist.github.com/Danez/7609898#file-test_performance-php
I also adjusted all tests that test '_scheme' to also check the new schemes-requirement.
Commits
-------
557dfaa Remove usage of deprecated _scheme in Routing Component
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9489).
Discussion
----------
[DependencyInjection] Add normalization to tag options
Currently, when using tags in XML, the options aren't normalized. This means that the following code is wrong:
<tag name="sonata_admin" manager-type="doctrine_phpcr" ... />
It should be `manager_name` to remove errors, but that's not following the XML rules. The solution is to use the same normalization as the configuration: replacing - with _.
To be BC, both options (with and without normalization) are kept
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
06d64d8 Do normalization on tag options
This PR was merged into the 2.3 branch.
Discussion
----------
[Filesystem] Changed the mode for a target file in copy() to be write only
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9789
| License | MIT
| Doc PR | -
Stream wrappers like S3 [do not support w+](http://docs.aws.amazon.com/aws-sdk-php/latest/class-Aws.S3.StreamWrapper.html) and we don't read here anyway (as pointed out in #9789).
Commits
-------
10e43b7 [Filesystem] Changed the mode for a target file in copy() to be write only.
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#9758).
Discussion
----------
[Console] fixed TableHelper when cell value has new line
#9757
Commits
-------
2e14ba6 [Console] fixed TableHelper when cell value has new line
