Commit Graph

1314 Commits

Author SHA1 Message Date
Eric Clemmons
693d0cda15 Whitespace cleanup 2011-05-26 19:00:42 -07:00
Eric Clemmons
d380486756 Added test for grouped entity choice list
Refs #889
2011-05-26 18:58:50 -07:00
Fabien Potencier
6507eeff3c Merge remote branch 'CodeMeme/1058-fix-radio-input-listener'
* CodeMeme/1058-fix-radio-input-listener:
  Fix for RadioInputListener's empty value erroneously becoming extra data Refs #1058
  Added test for RadioInputListener bug treating no data as extra data
2011-05-26 17:31:09 +02:00
Fabien Potencier
eb90427e92 Merge remote branch 'danielholmes/cookie_fixes'
* danielholmes/cookie_fixes:
  [BrowserKit] fixed explicit cookie params being overriden by url
2011-05-26 17:07:13 +02:00
Fabien Potencier
1f369ed1ed Merge remote branch 'zerosanity/master'
* zerosanity/master:
  Added missing space.
  Fixed broken logic in Request::getHttpHost(). It was ignoring HTTP_HOST completely.
2011-05-26 15:01:53 +02:00
Fabien Potencier
699ecfcf90 Merge remote branch 'stloyd/validators_refactoring'
* stloyd/validators_refactoring:
  Refactor validators constraints: - remove need for defining "getTargets()" method as 95% of validators use same one - replace abstract "Constraint::getTargets()" with one that use 95% of validators - add additional tests for "Constraint::getTargets()" method - remove unused "use" statement in Constraint\Valid
2011-05-26 14:58:24 +02:00
Fabien Potencier
3bdb7c2b57 [DependencyInjection] fixed regression when a parameter contains an escaped %
Notice that this is still not perfect, but I don't see how to fix the remaining
potential problems.
2011-05-26 12:47:50 +02:00
Jordi Boggiano
af0bd8a136 Update Core and Security events to latest model
The main benefit is that in XML/YML files we have common syntax (i.e. core.controller, form.pre_bind) that properly namespaces event names (before: onCoreController was ok, preBind was not).
On the other hand in PHP land we also have namespaced events, CoreEvents::controller, FormEvents::preBind, before it was Events::onCoreController, Events::onPreBind, we now have more context.
2011-05-26 11:55:07 +02:00
Jordi Boggiano
1246503e55 [EventDispatcher] Allow registration of arbitrary callbacks
This in effect removes the direct link between event name and the method name on the handler.
Any callback can be given as a handler and the event name becomes an arbitrary string. Allowing for easier namespacing (see next commit)
2011-05-26 11:54:06 +02:00
Daniel Holmes
3c372d3773 [BrowserKit] fixed explicit cookie params being overriden by url 2011-05-26 15:28:51 +10:00
Eric Clemmons
a61e13303b Added test for RadioInputListener bug treating no data as extra data 2011-05-25 22:15:35 -07:00
Joshua Nye
f019541716 Fixed broken logic in Request::getHttpHost(). It was ignoring HTTP_HOST completely. 2011-05-25 16:02:16 -04:00
Fabien Potencier
ce19cc0698 Merge remote branch 'Seldaek/domcrawler'
* Seldaek/domcrawler:
  [DomCrawler] Uppercase http methods
2011-05-25 18:27:12 +02:00
Jordi Boggiano
08e7629fb4 [DomCrawler] Uppercase http methods 2011-05-25 15:45:23 +02:00
Fabien Potencier
dcd490e03f [Twig] added a way to use % in a trans string (closes #981) 2011-05-25 11:29:23 +02:00
stloyd
3ea2a32c53 Refactor validators constraints:
- remove need for defining "getTargets()" method as 95% of validators use same one
- replace abstract "Constraint::getTargets()" with one that use 95% of validators
- add additional tests for "Constraint::getTargets()" method
- remove unused "use" statement in Constraint\Valid
2011-05-25 10:51:35 +02:00
Fabien Potencier
462f222319 [DependencyInjection] changed \LogicException to RuntimeException to be more consistent 2011-05-25 09:59:38 +02:00
Fabien Potencier
2438a73c7b [DependencyInjection] added a check for circular references in parameter definitions 2011-05-25 09:57:38 +02:00
Fabien Potencier
456eb53eb8 [DependencyInjection] renamed CircularReferenceException to ServiceCircularReferenceException 2011-05-25 09:48:49 +02:00
Fabien Potencier
6c409cac84 [DependencyInjection] refactored parameter bag parameter replacements (removed duplicated code) 2011-05-25 09:35:51 +02:00
Joseph Bielawski
d65a56e13b [Locale] Prevent failing test when used with PHP 5.3.3+ 2011-05-24 16:08:09 -07:00
Fabien Potencier
8d7def4fae [BrowserKit] updated tests 2011-05-24 20:42:24 +02:00
Fabien Potencier
05778c719f [BrowserKit] fixed CS 2011-05-24 20:37:52 +02:00
Fabien Potencier
e0bf310b55 Merge remote branch 'hnw/cookie-raw-value'
* hnw/cookie-raw-value:
  added test for Cookie#getRawValue and CookieJar#AllRawValues
  fixed doc comment
  [BrowserKit] dealing with raw value for cookies
2011-05-24 20:20:57 +02:00
Fabien Potencier
aa356e7288 [BrowserKit] fixed cookie management (see RFC 2109) 2011-05-24 20:08:11 +02:00
everzet
98b0bdcb15 [DependencyInjection] added failing private service user test-case 2011-05-23 22:38:23 +03:00
Fabien Potencier
15bede5a63 [Console] refactored style management
The current code was broken when a style was defined inline:

  <bg=black>Foo</bg=black>

When creatin a new style formatter, it's better to let the formatter
apply the style to the text.
2011-05-23 16:54:36 +02:00
Yoshio HANAWA
6556f62e4f added test for Cookie#getRawValue and CookieJar#AllRawValues 2011-05-23 21:53:30 +09:00
Fabien Potencier
7ab3fdeb83 [Finder] added a way to ignore all 'hidden' files 2011-05-23 11:05:58 +02:00
Pascal Borreli
7f089c0b05 [Process] Fixed namespace typo and windows test 2011-05-22 14:57:37 +00:00
Fabien Potencier
a2a1a88291 Merge remote branch 'schmittjoh/annotations'
* schmittjoh/annotations:
  removed obsolete compiler pass
  fixed some more tests
  fixed tests
  removed unused vendor
  some cleanups
  updated to latest changes
  [WebProfilerBundle] removed @ignorePhpDoc annotations
  [FrameworkBundle] fixed default
  [FrameworkBundle] updated configuration
  [Validator] updated fixtures
  updated UPDATE file
  updated Annotations integration
  [Routing] updated to changes
  [FrameworkBundle] added framework-wide annotation reader, updated validator tests
  [WebProfilerBundle] fixed controllers
  fixed unit tests
  added Annotations library
2011-05-22 08:45:24 +02:00
Victor Berchet
e117613550 [Form] Fix for nested forms getting erroneously set as rendered 2011-05-20 15:48:55 +02:00
Johannes Schmitt
ddc00fa0f6 removed obsolete compiler pass 2011-05-20 06:59:30 +02:00
Johannes Schmitt
98ed7dd030 fixed some more tests 2011-05-19 23:15:41 +02:00
Johannes Schmitt
6c0b0449a6 Merge remote branch 'origin/master' into annotations
Conflicts:
	UPDATE.md
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Configuration.php
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
2011-05-19 22:49:59 +02:00
Johannes Schmitt
42fb34b647 fixed tests 2011-05-19 22:46:34 +02:00
Kris Wallsmith
ed8ecab7ea [HttpFoundation] fixed locale accessor after session clear 2011-05-19 11:45:12 -07:00
Fabien Potencier
9714524b39 fixed a unit test and CS 2011-05-19 17:38:16 +02:00
jsor
fd6c254b47 [HttpFoundation] changed checking for deleted cookie to be conform with setcookie() 2011-05-19 17:14:03 +02:00
jsor
f9b6c8b74a [HttpFoundation] included cookie headers in string representation 2011-05-19 17:14:01 +02:00
jsor
e6d929aa71 [HttpFoundation] added __toString() method 2011-05-19 17:13:58 +02:00
Fabien Potencier
9fe1c3ae0e Merge remote branch 'bschussek/form'
* bschussek/form: (22 commits)
  Fix merge error (function "guess" was in there twice)
  [Form] Added test case for bf2f9d2a02
  [Form] Form::isBound() and Form::isValid() work correctly now for read-only forms
  [Locale] Improved error reporting and added stubs for intl_is_failure(), intl_get_error_code() and intl_get_error_message()
  [Form] Implemented fix for 361c67f54f
  [Form] Add test for the handling of array values in the constraint violation
  [Form] Further simplified PropertyPath code
  [Form] Added test for 6c337d1cc0
  [Form] Removed unused option "pattern" of date and time type
  [Form] Renamed view variable "name" to "full_name"
  [Form] Renamed collection option "type_options" to "options" to be consistent with the repeated type
  [Form] CSRF documentation and a few CS changes
  [Form] Move CSRF options from types to the CSRF extension
  [Form] Added a search form field type
  [Form] Optimization of PropertyPath
  [Form] replace assertEquals by assertFalse, assertTrue, assertNull
  [Form] fix file permissions to 644 again ;)
  [Form] add tests for type_options in collectionType
  fix file permissions to 644
  [Form] add type_options for CollectionType to be abble to set options to type
  ...
2011-05-19 16:25:30 +02:00
Fabien Potencier
c4232b11fa Merge remote branch 'beberlei/DoctrineUniqueValidator'
* beberlei/DoctrineUniqueValidator:
  [Doctrine] Fix default value to null for entity manager to make fluent integration with Doctrine Registry work
  [Doctrine] Add fields as default option and allow strings to be passed.
  [Doctrine] Add DoctrineBundle integration (DI Container registration) for the UniqueEntityValidator
  [Doctrine] Implement suggested changes by Stof, added functional test to verify unique validator works.
  [Doctrine] Add Unique Validator
2011-05-19 15:38:20 +02:00
Miha Vrhovnik
2e286073a4 Removed ability to override method from GET request 2011-05-19 14:08:34 +02:00
Miha Vrhovnik
65ed6f7763 Added support for request method overriding via X-HTTP-Method-Override
This type of override is supported by MS MVC3 and is recommended by Google.
Also added ability to override request method via ?_method= when
request is made via GET.
2011-05-19 09:33:08 +02:00
Bernhard Schussek
c575432790 [Form] Added test case for bf2f9d2a02 2011-05-19 01:43:47 +02:00
Bernhard Schussek
13a964ae6d [Form] Form::isBound() and Form::isValid() work correctly now for read-only forms 2011-05-19 01:24:28 +02:00
Bernhard Schussek
829aa4dc0b [Locale] Improved error reporting and added stubs for intl_is_failure(), intl_get_error_code() and intl_get_error_message() 2011-05-19 01:15:37 +02:00
Dirk Pahl
361c67f54f [Form] Add test for the handling of array values in the constraint violation 2011-05-18 23:48:32 +02:00
Bernhard Schussek
af66beed76 [Form] Added test for 6c337d1cc0 2011-05-18 23:20:37 +02:00
Benjamin Eberlei
8ff1d09d36 [Doctrine] Implement suggested changes by Stof, added functional test to verify unique validator works. 2011-05-18 22:57:25 +02:00
Bernhard Schussek
f467317bab [Form] Renamed view variable "name" to "full_name"
The variable "name" now contains the local, short name (equivalent to $form->getName()).
2011-05-18 22:16:16 +02:00
Bernhard Schussek
b39a21fbaf [Form] Renamed collection option "type_options" to "options" to be consistent with the repeated type 2011-05-18 21:52:59 +02:00
Bernhard Schussek
2711fbc418 Merge remote branch 'jaugustin/fix_form' into jaugustin_merge
Conflicts:
	src/Symfony/Component/Form/Extension/Core/EventListener/ResizeFormListener.php
	src/Symfony/Component/Form/Extension/Core/Type/CollectionType.php
2011-05-18 21:40:20 +02:00
Johannes Schmitt
0eb7564f7d Merge remote branch 'origin/master' into security
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/Listener/RequestAttributeInitializingListener.php
2011-05-18 12:54:47 +02:00
Johannes Schmitt
53f5c23c8f [Security/Acl] small voter refactoring 2011-05-18 12:48:50 +02:00
Fabien Potencier
2cd04547fd [Routing] renamed some exceptions 2011-05-17 16:52:02 +02:00
Fabien Potencier
0168241014 [DependencyInjection] renamed NonExistentParameterException and NonExistentServiceException to ParameterNotFoundException and ServiceNotFoundException 2011-05-17 16:26:08 +02:00
Fabien Potencier
eb202bb7b7 merged kriswallsmith/form/csrf-intention 2011-05-17 15:25:50 +02:00
alexandresalome
1d6b94189b [Routing] Use routing exceptions in the dumper and add tests. 2011-05-17 11:31:47 +02:00
Martin Hason
b7c417feaa [Bridge][Twig] removed the possibility to pass a message to the transchoice tag 2011-05-17 10:33:48 +02:00
Fabien Potencier
02e77ec4e3 [Routing] moved Matcher exceptions 2011-05-17 10:11:27 +02:00
Fabien Potencier
51eb746925 Merge remote branch 'alexandresalome/feat-routing-exceptions'
* alexandresalome/feat-routing-exceptions:
  [Routing] Fix the exception inheritance + Add the LICENCE block in new files
  [Routing] Change the Exception namespacing + base class for every exception + update PHPDoc
  [Routing] Add specific exceptions for the UrlGenerator
2011-05-17 09:52:44 +02:00
Fabien Potencier
86a2d27da9 Merge remote branch 'stloyd/ipvalidator_fix'
* stloyd/ipvalidator_fix:
  Better comment about no test IP6 addresses for "FILTER_FLAG_NO_RES_RANGE"
  Refactoring of IpValidator to use native php filter extension, also adding additional flag support and test cover.
2011-05-17 09:25:04 +02:00
Fabien Potencier
0872813278 Merge remote branch 'Seldaek/test_fix'
* Seldaek/test_fix:
  [HttpFoundation] Windows test fixes
2011-05-17 09:16:46 +02:00
Kris Wallsmith
914620f948 [Form] renamed CSRF page_id to intention 2011-05-16 14:16:29 -07:00
Johannes Schmitt
796d9af0c4 some updates 2011-05-16 22:26:24 +02:00
Johannes Schmitt
fa0ef500ae [Tests] updated invalid use statement 2011-05-16 11:57:12 +02:00
Johannes Schmitt
8e5b11a226 Merge remote branch 'origin/master' into annotations 2011-05-15 18:35:25 +02:00
Fabien Potencier
0bfb260f44 Merge remote branch 'usefulthink/issue913-yaml-utf8-checking'
* usefulthink/issue913-yaml-utf8-checking:
  CS fixes in unit-test
  [Yaml] added exceptions when non-utf8 encoding is detected
2011-05-14 17:35:56 +02:00
Fabien Potencier
439f4c34f6 Merge remote branch 'stloyd/patch-5'
* stloyd/patch-5:
  Fix MimeTypeTest
2011-05-14 17:30:00 +02:00
Fabien Potencier
1e7108d624 Merge remote branch 'stloyd/tests_fix'
* stloyd/tests_fix:
  Skip tests if some vendor are not available (prevents fatal errors)
2011-05-14 17:27:52 +02:00
Fabien Potencier
e46e53daa0 Merge remote branch 'stof/graphviz'
* stof/graphviz:
  [DependencyInjection] Fixed a property visibility in GraphvizDumper and removed a useless instanciation in the test
2011-05-14 17:23:50 +02:00
Joseph Bielawski
25c25ab4b1 Fix MimeTypeTest 2011-05-14 05:21:07 -07:00
Johannes Schmitt
48dc85dc43 [Security/Acl] fixes #853 2011-05-14 14:19:55 +02:00
Johannes Schmitt
2d8afd8dd6 Merge remote branch 'origin/master' into annotations
Conflicts:
	src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
	src/Symfony/Bundle/FrameworkBundle/Resources/config/validator.xml
	src/Symfony/Bundle/FrameworkBundle/Tests/DependencyInjection/FrameworkExtensionTest.php
2011-05-14 12:51:05 +02:00
stloyd
039292bb94 Skip tests if some vendor are not available (prevents fatal errors) 2011-05-14 12:23:40 +02:00
Bernhard Schussek
e0ff61949e [Form] Renamed the value "text" of the "widget" option of the "date" type to "single-text" 2011-05-13 19:17:28 +02:00
Bernhard Schussek
da28f8e3b3 [Form] Added FormTypeInterface::getAllowedOptionValues() to better validate passed options 2011-05-13 18:44:03 +02:00
Bernhard Schussek
21013b930c [Form] Improved test coverage of FormFactory and improved error handling 2011-05-13 18:29:18 +02:00
alexandresalome
07b7dc0c86 [Routing] Change the Exception namespacing + base class for every exception + update PHPDoc 2011-05-13 17:46:31 +02:00
alexandresalome
05d9e74293 [Routing] Add specific exceptions for the UrlGenerator
When generating URL, thrown exceptions are InvalidArgumentException and
distinction of errors is quite difficult. This modification brings different
exceptions for different cases
2011-05-13 16:59:37 +02:00
Christophe Coevoet
c2f074b7d5 [DependencyInjection] Fixed a property visibility in GraphvizDumper and removed a useless instanciation in the test 2011-05-13 12:18:09 +02:00
Martin Schuhfuss
8340ac628d CS fixes in unit-test 2011-05-13 01:08:37 +02:00
Martin Schuhfuss
571768b9b9 [Yaml] added exceptions when non-utf8 encoding is detected
encoding is detected using the `mb_detect_encoding()`-function
in strict-mode. Checking is done before the parsing starts.
Without this patch, the calls to `preg_replace()` using the
'u'-modifier would cause the non-utf8-string being processed
to be empty when parsing starts which makes the parsing return
no result.
2011-05-12 22:02:56 +02:00
Joseph Bielawski
d43894b42e Remove invalid code-coverage annotions 2011-05-12 06:46:53 -07:00
Joseph Bielawski
bf87a35595 Better comment about no test IP6 addresses for "FILTER_FLAG_NO_RES_RANGE" 2011-05-11 14:18:45 -07:00
stloyd
5997b930a5 Refactoring of IpValidator to use native php filter extension, also adding additional flag support and test cover. 2011-05-11 13:19:03 +02:00
Jeremie Augustin
bea448339b [Form] replace assertEquals by assertFalse, assertTrue, assertNull 2011-05-11 11:19:21 +02:00
Jeremie Augustin
d3db844cfa [Form] fix file permissions to 644 again ;) 2011-05-11 11:19:21 +02:00
Jeremie Augustin
fb0a37f9ba [Form] add tests for type_options in collectionType 2011-05-11 11:19:21 +02:00
Fabien Potencier
1ae5ef6849 Merge remote branch 'vicb/form-padded-choice-list'
* vicb/form-padded-choice-list:
  [Form] Allow for arbitrary keys in PaddedChoiceList
2011-05-11 10:18:30 +02:00
Fabien Potencier
9abd53c2b4 merged Seldaek/serializer_fix 2011-05-11 10:16:15 +02:00
Fabien Potencier
a05b8fbb19 Merge remote branch 'schmittjoh/security'
* schmittjoh/security:
  [HttpFoundation] fixed php doc
  updated UPDATE file
  [Security] use deep flag when retrieving username + password
  [HttpFoundation] added $deep flag to Request::get()
  [HttpFoundation] removed getDeep(), added a boolean flag to get() instead
2011-05-11 10:14:15 +02:00
Fabien Potencier
9651175914 Merge remote branch 'vicb/form-transformers'
* vicb/form-transformers:
  [Form] Add argument type checking in BaseDateTimeTransformer
  [Form] Catch exceptions in DataTransformers
2011-05-11 10:12:23 +02:00
Victor Berchet
dac798c791 [Form] Catch exceptions in DataTransformers 2011-05-10 20:21:02 +02:00
Johannes Schmitt
89f60e04d1 [HttpFoundation] removed getDeep(), added a boolean flag to get() instead 2011-05-10 11:16:25 +02:00
Jordi Boggiano
99c67134fe [Serializer] Split decoder/encoder maps 2011-05-10 09:17:33 +02:00
digitalkaoz
5305454cc1 fixed code style 2011-05-09 23:36:56 +02:00
digitalkaoz
0ed7285828 [Process] added tests for Process and PhpExecutableFinder 2011-05-09 22:44:35 +02:00