Commit Graph

38569 Commits

Author SHA1 Message Date
Nicolas Grekas
c600de0715 Merge branch '3.4' into 4.1
* 3.4:
  [Validator] Added IBAN format for Vatican City State
  filter out invalid Intl values
  [Validator] Fixed grouped composite constraints
  [Form] Filter arrays out of scalar form types
2018-12-09 17:21:08 +00:00
Enrico Schultz
21c3030092 [Security] defer log message in guard authenticator
prevent an unneccessary log message if the guard authenticator does not support the current request
2018-12-09 17:00:22 +01:00
Fabien Potencier
02b3510a11 bug #29531 [Validator] Added IBAN format for Vatican City State (raulfraile)
This PR was squashed before being merged into the 3.4 branch (closes #29531).

Discussion
----------

[Validator] Added IBAN format for Vatican City State

IBAN for Vatican City State was added to [IBAN registry](https://www.swift.com/sites/default/files/resources/iban_registry.pdf) recently. This PR adds support for this new format in the `Iban` validator.

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| License       | MIT

Commits
-------

5f0261429a [Validator] Added IBAN format for Vatican City State
2018-12-09 11:02:06 +01:00
Raul Fraile
5f0261429a [Validator] Added IBAN format for Vatican City State 2018-12-09 11:01:50 +01:00
knuch
ceb7a68efa merge conflicts 2018-12-08 17:39:48 +00:00
Nicolas Grekas
bcee8d91ac bug #29501 [Form] filter out invalid language values (xabbuh)
This PR was merged into the 4.1 branch.

Discussion
----------

[Form] filter out invalid language values

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23679
| License       | MIT
| Doc PR        |

Commits
-------

ed97568b8a filter out invalid language values
2018-12-08 16:43:38 +00:00
Nicolas Grekas
aca0b84637 bug #29307 [Form] Filter arrays out of scalar form types (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Filter arrays out of scalar form types

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/4102
| License       | MIT
| Doc PR        | -

Replaces fix https://github.com/symfony/symfony/pull/20935

Commits
-------

000e4aab5e [Form] Filter arrays out of scalar form types
2018-12-08 16:42:09 +00:00
Nicolas Grekas
7a46c98f00 bug #29500 [Form] filter out invalid Intl values (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] filter out invalid Intl values

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23679
| License       | MIT
| Doc PR        |

Commits
-------

a2d694009f filter out invalid Intl values
2018-12-08 16:20:02 +00:00
Christophe Coevoet
fc8dc91d2d bug #29499 [Validator] Fixed grouped composite constraints (HeahDude)
This PR was merged into the 3.4 branch.

Discussion
----------

[Validator] Fixed grouped composite constraints

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #17675, #25888, #23480
| License       | MIT
| Doc PR        | ~

From Lisbon :). Thanks @stof, @xabbuh for your help to finally fix this old issue.

Commits
-------

b53d9112ca [Validator] Fixed grouped composite constraints
2018-12-08 16:29:49 +01:00
Christian Flothmann
a2d694009f filter out invalid Intl values 2018-12-08 12:28:29 +00:00
Christian Flothmann
23e5e45e78 Merge branch '3.4' into 4.1
* 3.4:
  change timezone to fix tests on Windows
  bumped Symfony version to 3.4.21
  updated VERSION for 3.4.20
  update CONTRIBUTORS for 3.4.20
  updated CHANGELOG for 3.4.20
2018-12-08 12:11:43 +00:00
Nicolas Grekas
6f5356c6fa minor #29502 [Serializer] change timezone to fix tests on Windows (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Serializer] change timezone to fix tests on Windows

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

As I understand the failing tests timezones have changed in Russia in 2016, but this is not reflected in the timezone database used on AppVeyor. Since the tests do not depend on a particular timezone (it's
only important for it to be different from UTC) we should safely be able to switch to another timezone.

Commits
-------

01a27e577c change timezone to fix tests on Windows
2018-12-08 12:07:26 +00:00
Christian Flothmann
01a27e577c change timezone to fix tests on Windows
As I understand the failing tests timezones have changed in Russia in
2016, but this is not reflected in the timezone database used on
AppVeyor. Since the tests do not depend on a particular timezone (it's
only important for it to be different from UTC) we should safely be able
to switch to another timezone.
2018-12-07 15:51:05 +00:00
Christian Flothmann
ed97568b8a filter out invalid language values 2018-12-07 15:34:22 +00:00
Jules Pietri
b53d9112ca [Validator] Fixed grouped composite constraints 2018-12-07 14:48:19 +00:00
Nicolas Grekas
000e4aab5e [Form] Filter arrays out of scalar form types 2018-12-07 08:49:47 +00:00
Fabien Potencier
9455c0b233 bumped Symfony version to 4.1.10 2018-12-06 17:39:00 +00:00
Fabien Potencier
9993cdc7e9
Merge pull request #29492 from fabpot/release-4.1.9
released v4.1.9
2018-12-06 17:35:17 +00:00
Fabien Potencier
c48d883794 updated VERSION for 4.1.9 2018-12-06 17:34:50 +00:00
Fabien Potencier
7e1a7b6426 updated CHANGELOG for 4.1.9 2018-12-06 17:34:44 +00:00
Fabien Potencier
9e84e0ff98 bumped Symfony version to 3.4.21 2018-12-06 15:57:52 +00:00
Fabien Potencier
f6b8ddc362
Merge pull request #29488 from fabpot/release-3.4.20
released v3.4.20
2018-12-06 15:24:36 +00:00
Fabien Potencier
b09cb1e8e6 updated VERSION for 3.4.20 2018-12-06 14:59:33 +00:00
Fabien Potencier
4386fb48b1 update CONTRIBUTORS for 3.4.20 2018-12-06 14:59:29 +00:00
Fabien Potencier
cf0583a2a0 updated CHANGELOG for 3.4.20 2018-12-06 14:59:19 +00:00
Nicolas Grekas
3d664a6a2f Merge branch '3.4' into 4.1
* 3.4:
  fix CI
2018-12-06 11:52:00 +00:00
Nicolas Grekas
ffe49fd160 Merge branch '2.8' into 3.4
* 2.8:
  fix CI
2018-12-06 11:51:10 +00:00
Nicolas Grekas
c8389f788d Merge branch '2.7' into 2.8
* 2.7:
  fix CI
2018-12-06 11:51:03 +00:00
Nicolas Grekas
9b10db2207 fix CI 2018-12-06 11:49:24 +00:00
Nicolas Grekas
34f6a4066d Merge branch '3.4' into 4.1
* 3.4:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:26:33 +00:00
Nicolas Grekas
3aaa5aba1b Merge branch '2.8' into 3.4
* 2.8:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:25:03 +00:00
Nicolas Grekas
410ed830c5 Merge branch '2.7' into 2.8
* 2.7:
  [Security\Http] detect bad redirect targets using backslashes
  [Form] Filter file uploads out of regular form types
  Fix CI
  minor #28258 [travis] fix composer.lock invalidation for deps=low (nicolas-grekas)
  [travis] fix composer.lock invalidation for PRs patching several components
  [travis] fix composer.lock invalidation for deps=low
  minor #28199 [travis][appveyor] use symfony/flex to accelerate builds (nicolas-grekas)
  [travis] ignore ordering when validating composer.lock files for deps=low
  minor #28146 [travis] cache composer.lock files for deps=low (nicolas-grekas)
  fix ci
  [travis] fix requiring mongodb/mongodb before composer up
  minor #28114 [travis] merge "same Symfony version" jobs in one (nicolas-grekas)
  [2.7] Make CI green
  updated VERSION for 2.7.49
  updated CHANGELOG for 2.7.49
  [HttpKernel] fix trusted headers management in HttpCache and InlineFragmentRenderer
  [HttpFoundation] Remove support for legacy and risky HTTP headers
  updated VERSION for 2.7.48
  update CONTRIBUTORS for 2.7.48
  updated CHANGELOG for 2.7.48
2018-12-06 11:12:46 +00:00
Nicolas Grekas
f27dd4b5be security #cve-2018-19790 [Security\Http] detect bad redirect targets using backslashes (xabbuh)
This PR was merged into the 2.7 branch.

Discussion
----------

[Security\Http] detect bad redirect targets using backslashes

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #76
| License       | MIT
| Doc PR        |

Commits
-------

99a0cec0a6 [Security\Http] detect bad redirect targets using backslashes
2018-12-06 11:09:35 +00:00
Nicolas Grekas
b65e6f1a47 security #cve-2018-19789 [Form] Filter file uploads out of regular form types (nicolas-grekas)
This PR was merged into the 2.7 branch.

Discussion
----------

[Form] Filter file uploads out of regular form types

| Q             | A
| ------------- | ---
| Branch?       | 2.7
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This PR filters uploaded files out of the data processed by any form type except `FileType`.

Commits
-------

205a44ea7d [Form] Filter file uploads out of regular form types
2018-12-06 11:08:15 +00:00
Nicolas Grekas
5fc7d5ec81 Merge branch '3.4' into 4.1
* 3.4:
  [Cache] Fixed Memcached adapter doClear()to call flush()
2018-12-06 10:58:36 +00:00
Nicolas Grekas
922e13c2b2 bug #29436 [Cache] Fixed Memcached adapter doClear()to call flush() (raitocz)
This PR was submitted for the master branch but it was squashed and merged into the 3.4 branch instead (closes #29436).

Discussion
----------

[Cache] Fixed Memcached adapter doClear()to call flush()

| Q             | A
| ------------- | ---
| Branch?       | 4.2
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29435
| License       | MIT
| Doc PR        | symfony/symfony-docs

MemcachedTrait now calls Memcached::flush via its client instead of just returning false.

Commits
-------

447baacbad [Cache] Fixed Memcached adapter doClear()to call flush()
2018-12-06 10:55:16 +00:00
Raito Akehanareru
447baacbad [Cache] Fixed Memcached adapter doClear()to call flush() 2018-12-06 10:54:02 +00:00
Nicolas Grekas
db2c64d580 Merge branch '3.4' into 4.1
* 3.4:
  [Routing] ignore trailing slash for non-GET requests
2018-12-03 22:38:57 +01:00
Nicolas Grekas
317a2f9787 bug #29441 [Routing] ignore trailing slash for non-GET requests (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[Routing] ignore trailing slash for non-GET requests

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29410
| License       | MIT
| Doc PR        | -

Another test case provided by @peterrehm in the linked issue - the dumped matcher already passes this test - but the non-dumped one doesn't (neither does the dumped one in 4.1 - I'll fix while merging up)

Commits
-------

7521af7ea0 [Routing] ignore trailing slash for non-GET requests
2018-12-03 22:36:45 +01:00
Nicolas Grekas
b8f87e185f bug #29444 [Workflow] Fixed BC break for Workflow metadata (lyrixx)
This PR was merged into the 4.1 branch.

Discussion
----------

[Workflow] Fixed BC break for Workflow metadata

| Q             | A
| ------------- | ---
| Branch?       | 4.1
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29427
| License       | MIT
| Doc PR        |

I used SplObjectStorage to store the transition metadata.
So we need to use the exact same PHP Object.

Commits
-------

5691818397 [Workflow] Fixed BC break for Workflow metadata
2018-12-03 22:25:56 +01:00
Grégoire Pineau
5691818397 [Workflow] Fixed BC break for Workflow metadata 2018-12-03 19:01:20 +01:00
Nicolas Grekas
7521af7ea0 [Routing] ignore trailing slash for non-GET requests 2018-12-03 14:20:34 +01:00
Jérôme Vasseur
5196dac7a8 Fix HeaderBag::get phpdoc
When setting $first to false, the default value is wrapped into an array
meaning you need to pass a string as the default value instead of an
array of strings.
2018-12-03 11:46:14 +01:00
Nicolas Grekas
a256c6914d Merge branch '3.4' into 4.1
* 3.4:
  [DI] dont inline when lazy edges are found
2018-12-02 16:58:55 +01:00
Nicolas Grekas
0ca1614aa2 bug #29432 [DI] dont inline when lazy edges are found (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] dont inline when lazy edges are found

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #29412, #29391
| License       | MIT
| Doc PR        | -

I'm not able to create a reproducer to hit this situation, but on 4.2, this check makes the difference.
I'm merging to fix the issue as that's still the proper fix.

Commits
-------

484c49edb3 [DI] dont inline when lazy edges are found
2018-12-02 16:55:40 +01:00
Nicolas Grekas
484c49edb3 [DI] dont inline when lazy edges are found 2018-12-02 16:50:25 +01:00
Nicolas Grekas
22795af29e Merge branch '3.4' into 4.1
* 3.4:
  [Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required
  [Routing] fix taking verb into account when redirecting
  [WebProfilerBundle] Split form field heading
2018-12-02 14:22:14 +01:00
Nicolas Grekas
c2d2f5bd16 bug #29413 [Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required (rvitaliy)
This PR was squashed before being merged into the 3.4 branch (closes #29413).

Discussion
----------

[Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required

| Q             | A
| ------------- | ---
| Branch?       | 3.4 up to 4.2 for bug fixes
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #
| License       | MIT
| Doc PR        | none

fixed `DateTimeNormalizer::normalizer()` when `$object` is mutated internally to change timezone we lost microseconds of origina `$object`

Commits
-------

2bf8a1cae6 [Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required
2018-12-02 14:20:28 +01:00
Vitaliy Ryaboy
2bf8a1cae6 [Serializer] fixed DateTimeNormalizer to maintain microseconds when a different timezone required 2018-12-02 14:20:19 +01:00
Nicolas Grekas
17874f6ef2 minor #29415 [WebProfilerBundle] Split form field heading (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[WebProfilerBundle] Split form field heading

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no     <!-- see https://symfony.com/bc -->
| Deprecations? | no
| Tests pass?   | yes    <!-- please add some, will be required by reviewers -->
| Fixed tickets | #...   <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!-- required for new features -->

By default the data class 9/10 breaks inline, making it harder to read. This fixes it.

Before

![image](https://user-images.githubusercontent.com/1047696/49332204-02cbf800-f5a9-11e8-8565-f0f084fa76dd.png)

After

![image](https://user-images.githubusercontent.com/1047696/49332202-f47ddc00-f5a8-11e8-8a97-80f002c9bfc2.png)

Commits
-------

3855d5af01 [WebProfilerBundle] Split form field heading
2018-12-02 14:17:24 +01:00