This PR was merged into the 2.5-dev branch.
Discussion
----------
[FrameworkBundle] Add posibility to specify method and host in router:match command
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Replaces #9340
Commits
-------
acc66b9 [FrameworkBundle] Add posibility to specify method and host in router:match command
* 2.3:
[Config] made a condition more explicit
convertDomElementToArray should handle zero values
prefixed http:// to url output on server:run command in order to make it clickable
Fixed data in pipe being truncated if not read before process termination
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Security] Add constants for access decision strategies
I suggest adding constants for the three access decision strategies (affirmative, consensus, unanimous).
They are difficult to spell, and without constants they are difficult to identify when reading the code.
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Commits
-------
5d6ef00 Add class constants for access decision strategies.
This PR was submitted for the 2.3-dev branch but it was merged into the 2.3 branch instead (closes#10423).
Discussion
----------
[Config] XmlUtils::convertDomElementToArray does not handle '0'
`XmlUtils::convertDomElementToArray` does not handle `0` as a value of a text node, and interprets it as `null`.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | maybe? (if someone is depending on the previous behaviour.)
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
Commits
-------
e56ac59 convertDomElementToArray should handle zero values
This PR was merged into the 2.3 branch.
Discussion
----------
adding http:// to server:run output to make it clickable
|Q |A |
|--- |---|
|Bug Fix? |yes |
|New Feature? |n |
|BC Breaks? |n |
|Deprecations?|n |
|Tests Pass? |n |
|Fixed Tickets| #10430 |
|License |MIT|
|Doc PR | no |
Commits
-------
6498518 prefixed http:// to url output on server:run command in order to make it clickable
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fixed data in pipe being truncated if not read before process termination
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9409
| License | MIT
| Doc PR | N/A
This is a repeat of the botched pull request #9630.
Commits
-------
7e51913 Fixed data in pipe being truncated if not read before process termination
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Process] Add Process::disableOutput and Process::enableOutput methods
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9007
| License | MIT
| Doc PR | https://github.com/symfony/symfony-docs/pull/3664
This is another implementation for #9007 that allows to disable the output/error-output storage in a Process in order to avoid using memory.
This is particularly useful when the process outputs large data and it's not read.
Commits
-------
a891e14 [Process] Add Process::disableOutput and Process::enableOutput methods
This PR was merged into the 2.4 branch.
Discussion
----------
[2.4][Process] Fix some unit tests that create the process object instead of delegate it to the implementation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
This follows #10421 in branch 2.4
Commits
-------
741a8c1 [Process] Fix some unit tests that create the process object instead of delegate it to the implementation
* 2.3:
[Process] Fix#9160 : escaping an argument with a trailing backslash on windows fails
[Process] Fix some unit tests that create the process object instead of delegate it to the implementation
[Process] Make process tests more accurate on exception messages
[Process] Fix process status in TTY mode
[Process] Use assertSame instead of assertEquals to avoid comparison against `null`
[HttpFoundation] added some unit tests
10158 get vary multiple
made Cookie stringification more robust
[Yaml] fix for a HHVM bug
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Fix#9160 : escaping an argument with a trailing backslash on windows fails
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #9160
| License | MIT
Commits
-------
10e903a [Process] Fix#9160 : escaping an argument with a trailing backslash on windows fails
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix some unit tests that create the process object instead of delegate it to the implementation
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
This is a minor error ; creating the process must be delegated to the implementation
Commits
-------
227b85b [Process] Fix some unit tests that create the process object instead of delegate it to the implementation
This PR was merged into the 2.3 branch.
Discussion
----------
[2.3][Process] Make process tests more accurate on exception messages
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
I need exception message to be checked more accurately in my upcoming PR about windows.
I decided to make a separated PR as the other one will probably take some time before being merged
Commits
-------
1b1768a [Process] Make process tests more accurate on exception messages
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Validator] Checked the constraint class in constraint validators
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
df56c23 [Validator] Checked the constraint class in constraint validators
This PR was merged into the 2.5-dev branch.
Discussion
----------
[Form] Changed Form::getErrors() to return an iterator and added two optional parameters $deep and $flatten
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | yes
| BC breaks? | yes
| Deprecations? | yes
| Tests pass? | yes
| Fixed tickets | #7205
| License | MIT
| Doc PR | -
See the changes in the UPGRADE files for more information.
Commits
-------
6b3fbb5 [Form] Changed the default value of $flatten in Form::getErrors() to true
a9268c4 [Form] Changed Form::getErrors() to return an iterator and added two optional parameters $deep and $flatten
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix process status in TTY mode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
When running a process with TTY mode, status in automatically set to `terminated`
once it's started.
It's wrong for two reasons :
- The status of the process is not yet terminated.
- The exitcode value is never caught
Commits
-------
51c70f8 [Process] Fix process status in TTY mode
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix comparisons against process exitcode
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| License | MIT
Use identical comparison instead of equal. In case the exitcode has not been caught, `Process::isSuccessful` returns true instead of false. It should not happen, but it's much more clean like that.
Commits
-------
d66f63f [Process] Use assertSame instead of assertEquals to avoid comparison against `null`
When running a process with TTY mode, status in automatically set to `terminated`
once it's started.
It's wrong for two reasons :
- The status of the process is not yet terminated.
- The exitcode value is never caught
This PR was submitted for the 2.4-dev branch but it was merged into the 2.4 branch instead (closes#10407).
Discussion
----------
[Security] Use more accurate variable name
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | N/A
| License | MIT
| Doc PR | N/A
Sorry for the noise, but everytime I open this class, I wonder what is `$exception`.
Commits
-------
f34e716 [Security] Use more accurate variable name
This PR was squashed before being merged into the 2.3 branch (closes#10382).
Discussion
----------
10158 get vary multiple
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | [#10158]
| License | MIT
| Doc PR | none
Commits
-------
3a4a3cb 10158 get vary multiple
This PR was merged into the 2.3 branch.
Discussion
----------
fixed some HHVM bugs
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | n/a
| License | MIT
| Doc PR | n/a
This is a workaround for facebook/hhvm#1161. I made the change as the workaround does the same thing and the eval is part of unit tests.
Commits
-------
d014dac made Cookie stringification more robust
fa24749 [Yaml] fix for a HHVM bug
This PR was merged into the 2.5-dev branch.
Discussion
----------
[FrameworkBundle] set a default value for gc_probability
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | refs #10349
| License | MIT
| Doc PR | n/a
This sets the `gc_probability` to 1 by default (which is the default value in PHP). That should help mitigate #10349.
Commits
-------
7e1bdd7 [FrameworkBundle] set a default value for gc_probability
