Commit Graph

32855 Commits

Author SHA1 Message Date
Nicolas Grekas
042328dc52 minor #24058 [FrameworkBundle] Fix Form conflict rule (chalasr)
This PR was merged into the 3.4 branch.

Discussion
----------

[FrameworkBundle] Fix Form conflict rule

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Fixes https://travis-ci.org/symfony/symfony/jobs/270430600#L2628.
/cc @ogizanagi @yceruto

Commits
-------

e1f9ff6 [FrameworkBundle] Fix form conflict rule
2017-09-01 13:44:30 +02:00
Dany Maillard
d817f98004 Remove old version check 2017-09-01 13:07:36 +02:00
Dany Maillard
86f2f25856 Mark SemaphoreStore::isSupported() as internal 2017-09-01 11:42:36 +02:00
Christian Flothmann
7b1715b078 [Yaml] use scalar type hints where possible 2017-09-01 07:53:57 +02:00
Fabien Potencier
0beb598a7b feature #23967 [VarDumper] add force-collapse/expand + use it for traces (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[VarDumper] add force-collapse/expand + use it for traces

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | not yet
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

This improves dumping stack traces by expanding only frames that are outside of vendor dirs.

Here the new CLI output (everything was expanded before):
![capture du 2017-08-24 15-24-01](https://user-images.githubusercontent.com/243674/29668407-614dfe32-88e0-11e7-85b3-8b4f774559a5.png)

And here is the HTML output, with toggle-able frames:
![capture du 2017-08-24 15-24-40](https://user-images.githubusercontent.com/243674/29668410-65170c16-88e0-11e7-9388-147475a76b9f.png)

Todo:
- [x] make tests pass :)

Commits
-------

0e2d2b8c08 [VarDumper] add force-collapse/expand + use it for traces
2017-08-31 14:57:46 -07:00
Fabien Potencier
4a0cc29ca1 bug #23969 [Cache] Use namespace versioning for backends that dont support clearing by keys (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[Cache] Use namespace versioning for backends that dont support clearing by keys

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #23960
| License       | MIT
| Doc PR        | -

Commits
-------

f8a75180e0 [Cache] Use namespace versioning for backends that dont support clearing by keys
2017-08-31 14:56:17 -07:00
Fabien Potencier
b641a76943 bug #24021 [DI] Don't track merged configs when the extension doesn't expose it (nicolas-grekas)
This PR was merged into the 3.3 branch.

Discussion
----------

[DI] Don't track merged configs when the extension doesn't expose it

| Q             | A
| ------------- | ---
| Branch?       | 3.3
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #24020
| License       | MIT
| Doc PR        | -

This is driving me crazy :)

Commits
-------

a8e6aac2f5 [DI] Don't track merged configs when the extension doesn't expose it
2017-08-31 14:54:33 -07:00
Fabien Potencier
4be4070aa2 feature #24033 [DI] Add ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Add ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

As spotted in #23984 and #18244, supporting php-pm and the likes requires us to have a way to reset services, typically on `kernel.terminate`. Yet, only actually instantiated services need to be resetted.

Knowing if a service is initialized or not is doable for public ones thanks to `Container::initialized()`. But for private ones, there is no way to achieve it.

I propose to add a new way to reference services via this new const. When a reference has this behavior, two things happens:
- at runtime, if the referenced service is not initialized, it behave the same as "ignore on invalid", pretending the service doesn't exist
- at compile time, such references are weak, meaning their referenced services *can* be removed, but *cannot* be inlined

Commits
-------

0db3358ddb [DI] Add ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE
2017-08-31 14:53:53 -07:00
Nicolas Grekas
0db3358ddb [DI] Add ContainerInterface::IGNORE_ON_UNINITIALIZED_REFERENCE 2017-08-31 23:26:27 +02:00
Robin Chalas
6ce70e4bf9 Add scalar typehints/return types on final/internal/private code 2017-08-31 22:46:21 +02:00
Nicolas Grekas
79cd7069a3 minor #24059 [Form] Fix Descriptor tests (ogizanagi)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Form] Fix Descriptor tests

| Q             | A
| ------------- | ---
| Branch?       | master <!-- see comment below -->
| Bug fix?      | no
| New feature?  | no <!-- don't forget updating src/**/CHANGELOG.md files -->
| BC breaks?    | no
| Deprecations? | no <!-- don't forget updating UPGRADE-*.md files -->
| Tests pass?   | yes
| Fixed tickets | https://travis-ci.org/symfony/symfony/jobs/270338064 <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | N/A

Commits
-------

64b3eee [Form] Fix Descriptor tests
2017-08-31 21:17:14 +02:00
Maxime Steinhausser
64b3eeef41 [Form] Fix Descriptor tests 2017-08-31 21:09:59 +02:00
Nicolas Grekas
086e457eeb fix merge 2017-08-31 20:43:21 +02:00
Robin Chalas
e1f9ff6cb5 [FrameworkBundle] Fix form conflict rule 2017-08-31 20:33:07 +02:00
Fabien Potencier
80ac529742 feature #24026 [Security] add impersonator_user to "User was reloaded" log message (gharlan)
This PR was squashed before being merged into the 3.4 branch (closes #24026).

Discussion
----------

[Security] add impersonator_user to "User was reloaded" log message

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

My main concern is this: I use the swift monolog handler to get emails for exceptions.
I would like to see the impersonator in these mails.

But I'm not sure, if this is a good place for the log message.

Commits
-------

fc44215e70 [Security] add impersonator_user to "User was reloaded" log message
2017-08-31 10:53:59 -07:00
Gregor Harlan
fc44215e70 [Security] add impersonator_user to "User was reloaded" log message 2017-08-31 10:53:58 -07:00
Fabien Potencier
bd1bf2c28d minor #24006 [PropertyAccess] Update NoSuchPropertyException message for writeProperty (ScullWM)
This PR was merged into the 3.3 branch.

Discussion
----------

[PropertyAccess] Update NoSuchPropertyException message for writeProperty

| Q             | A
| ------------- | ---
| Branch?       | 3.1
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | no
| License       | MIT

Hi,
I've get a NoSuchPropertyException error while creating REST API forms.
Having the property name in the exception is great, but in some case, this property is available in many objects. Having more information about the object that generate this exception is better.

I simply suggest to add a get_class of the current object in the error message.

Before:
`Could not determine access type for property "id".`

After (edit)
`Could not determine access type for property "id" in class "App\Command\UserUpdateCommand".`

Commits
-------

7855748c78 Update NoSuchPropertyException message for writeProperty
2017-08-31 10:41:28 -07:00
Nicolas Grekas
3ff0ff02ac feature #24014 [Translator] Remove deprecated feature (maidmaid)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[Translator] Remove deprecated feature

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | yes
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | /
| License       | MIT
| Doc PR        | /

Commits
-------

cce2dd1 Remove deprecated feature
2017-08-31 16:23:50 +02:00
Florent Mata
c8b65aeb8b [ExpressionLanguage] throws an exception on calling uncallable method 2017-08-31 16:22:01 +02:00
Nicolas Grekas
9cce236e29 feature #23603 [Cache] Add (pdo|chain) cache (adapter|simple) prune method (robfrawley)
This PR was merged into the 3.4 branch.

Discussion
----------

[Cache] Add (pdo|chain) cache (adapter|simple) prune method

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        | symfony/symfony-docs#8209

This is additional work toward making more cache implementations use the `PruneableInterface` contract. Specifically, this pull request focuses on `(Pdo|Chain)(Cache|Adapter)`, as suggested by @nicolas-grekas in https://github.com/symfony/symfony/pull/23451#issuecomment-316735763.

Commits
-------

b20a237 add (pdo|chain) cache (adapter|simple) prune method
2017-08-31 16:08:55 +02:00
Nicolas Grekas
d3630c1a8a minor #24034 [VarDumper] Prepare period caster for 4.0 (maidmaid)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[VarDumper] Prepare period caster for 4.0

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/pull/23668
| License       | MIT
| Doc PR        | /

Commits
-------

fd7352e Prepare period caster for 4.0
2017-08-31 16:07:16 +02:00
Roland Franssen
ed3df04da8 [DI] Remove case insensitive parameter names 2017-08-31 15:47:29 +02:00
Nicolas Grekas
89d85f3ea1 minor #24050 [DI] Add upgrade note about case insenstive params (ro0NL)
This PR was merged into the 3.4 branch.

Discussion
----------

[DI] Add upgrade note about case insenstive params

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #... <!-- #-prefixed issue number(s), if any -->
| License       | MIT
| Doc PR        | symfony/symfony-docs#... <!--highly recommended for new features-->

Forgotten in #23874 :)

PS: im working on a PR for 4.0 as well

Commits
-------

3890996 [DI] Add upgrade note about case insenstive params
2017-08-31 15:41:46 +02:00
Roland Franssen
3890996392 [DI] Add upgrade note about case insenstive params 2017-08-31 14:57:27 +02:00
Christian Flothmann
f41bdf19c1 Merge branch '3.4'
* 3.4:
  [HttpKernel] Fix loading legacy 3.3 containers in 3.4 context
  [TwigBundle] require twig-bridge ~3.4
  [Yaml] mark some classes as final
  Fixed the escaping of back slashes and << in console output
  Add debug:form command
  bumped Symfony version to 2.8.28
  updated VERSION for 2.8.27
  updated CHANGELOG for 2.8.27
  bumped Symfony version to 2.7.35
  updated VERSION for 2.7.34
  update CONTRIBUTORS for 2.7.34
  updated CHANGELOG for 2.7.34
2017-08-31 11:19:27 +02:00
Christian Flothmann
c708d02299 Merge branch '3.3' into 3.4
* 3.3:
  Fixed the escaping of back slashes and << in console output
  bumped Symfony version to 2.8.28
  updated VERSION for 2.8.27
  updated CHANGELOG for 2.8.27
  bumped Symfony version to 2.7.35
  updated VERSION for 2.7.34
  update CONTRIBUTORS for 2.7.34
  updated CHANGELOG for 2.7.34
2017-08-31 11:02:44 +02:00
Nicolas Grekas
fb82c3896c minor #24045 Remove php <7.1 code (chalasr)
This PR was merged into the 4.0-dev branch.

Discussion
----------

Remove php <7.1 code

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | n/a
| License       | MIT
| Doc PR        | n/a

Commits
-------

fa3ab1f Remove php <7.1 code
2017-08-31 10:50:32 +02:00
Christian Flothmann
ad78743f1a Merge branch '2.8' into 3.3
* 2.8:
  Fixed the escaping of back slashes and << in console output
  bumped Symfony version to 2.8.28
  updated VERSION for 2.8.27
  updated CHANGELOG for 2.8.27
  bumped Symfony version to 2.7.35
  updated VERSION for 2.7.34
  update CONTRIBUTORS for 2.7.34
  updated CHANGELOG for 2.7.34
2017-08-31 10:38:26 +02:00
Christian Flothmann
3956469e16 Merge branch '2.7' into 2.8
* 2.7:
  Fixed the escaping of back slashes and << in console output
  bumped Symfony version to 2.7.35
  updated VERSION for 2.7.34
  update CONTRIBUTORS for 2.7.34
  updated CHANGELOG for 2.7.34
2017-08-31 10:36:47 +02:00
Robin Chalas
fa3ab1fac8 Remove php <7.1 code 2017-08-31 00:11:00 +02:00
Maxime Steinhausser
dd3276c2e8 feature #23694 [Form] Add debug:form command (yceruto)
This PR was merged into the 3.4 branch.

Discussion
----------

[Form] Add debug:form command

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/23688
| License       | MIT
| Doc PR        | -

![debug-form](https://user-images.githubusercontent.com/2028198/29007125-c3508cd6-7aca-11e7-91e2-c2b509847db5.png)

A short class name (e.g. `DateType`) can be passed as `class` argument too (the command will try to resolve its FQCN if it's in known form type namespaces).

Commits
-------

4f040d78fe Add debug:form command
2017-08-30 18:21:48 +02:00
Rob Frawley 2nd
b20a2376b2
add (pdo|chain) cache (adapter|simple) prune method 2017-08-30 11:10:37 -04:00
Thomas Perez
7855748c78 Update NoSuchPropertyException message for writeProperty 2017-08-30 16:49:16 +02:00
Fabien Potencier
b3d31e9d80 bug #24040 [HttpKernel] Fix loading legacy 3.3 containers in 3.4 context (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[HttpKernel] Fix loading legacy 3.3 containers in 3.4 context

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | yes
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

When moving from 3.3 to 3.4, if a dumped container exists, an exception is triggered because "include" returns "1".
ping @umpirsky

Commits
-------

8264a9e398 [HttpKernel] Fix loading legacy 3.3 containers in 3.4 context
2017-08-30 07:45:04 -07:00
Nicolas Grekas
8264a9e398 [HttpKernel] Fix loading legacy 3.3 containers in 3.4 context 2017-08-30 16:25:32 +02:00
Nicolas Grekas
483c7bad3b minor #24039 [TwigBundle] require twig-bridge ~3.4 (nicolas-grekas)
This PR was merged into the 3.4 branch.

Discussion
----------

[TwigBundle] require twig-bridge ~3.4

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Injecting "twig" as first arg of the DebugCommand works only in ^3.4 - as of #23519.

Commits
-------

03816b7 [TwigBundle] require twig-bridge ~3.4
2017-08-30 16:01:33 +02:00
Nicolas Grekas
03816b7858 [TwigBundle] require twig-bridge ~3.4 2017-08-30 15:41:55 +02:00
Dany Maillard
fd7352eb37 Prepare period caster for 4.0 2017-08-30 10:17:18 +02:00
Christian Flothmann
2b4b224301 feature #24028 [Yaml] mark some classes as final (xabbuh)
This PR was merged into the 3.4 branch.

Discussion
----------

[Yaml] mark some classes as final

| Q             | A
| ------------- | ---
| Branch?       | 3.4
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets |
| License       | MIT
| Doc PR        |

Making these classes final unlocks more scalar type hint possibilities on top of the changes proposed in #23262.

Commits
-------

330c6bf [Yaml] mark some classes as final
2017-08-30 09:47:25 +02:00
Christian Flothmann
330c6bf53e [Yaml] mark some classes as final 2017-08-30 08:19:03 +02:00
Robin Chalas
edb8c33f35 Fix merge 2017-08-30 01:36:56 +02:00
Robin Chalas
a4021e6bb0 Remove deprecated TranslationLoader (fix merge) 2017-08-30 01:29:11 +02:00
Robin Chalas
af2b66b5b7 Remove deprecated translation.loader service (fix merge) 2017-08-30 01:26:44 +02:00
Robin Chalas
0537e03e72 Merge branch '3.4'
* 3.4: (38 commits)
  Fix merge
  [Lock] Expose an expiringDate and isExpired method in Lock
  [VarDumper] fix DateCasterTest
  [config] Add ability to deprecate a node
  feature #22382 [config] Add abbitily to deprecate a node (Nyholm, fabpot, sanpii)
  Fix segfault in period caster
  Create an interface for TranslationReader and moved TranslationLoader to Translation component
  Always require symfony/polyfill-apcu to provide APCuIterator everywhere
  [Lock] Fix some tests that require pcntl_sigwaitinfo() function
  bumped Symfony version to 3.3.9
  updated VERSION for 3.3.8
  updated CHANGELOG for 3.3.8
  [DI] Fix tracking env var placeholders nested in object graphs
  bumped Symfony version to 3.3.8
  updated VERSION for 3.3.7
  updated CHANGELOG for 3.3.7
  Add period caster
  [DI] improve psr4-based service discovery with namespace option
  [DI] Fix tracking env vars when merging configs (bis)
  removed obsolete comment
  ...
2017-08-30 01:06:25 +02:00
Fabien Potencier
00d959c933 [Routing] added the possibility to define a prefix for all routes of a controller 2017-08-29 15:38:20 -07:00
Robin Chalas
b9fc357d1c Fix merge 2017-08-29 23:15:51 +02:00
Fabien Potencier
2e111b3cca Merge branch '3.3' into 3.4
* 3.3: (27 commits)
  Always require symfony/polyfill-apcu to provide APCuIterator everywhere
  bumped Symfony version to 3.3.9
  updated VERSION for 3.3.8
  updated CHANGELOG for 3.3.8
  [DI] Fix tracking env var placeholders nested in object graphs
  bumped Symfony version to 3.3.8
  updated VERSION for 3.3.7
  updated CHANGELOG for 3.3.7
  [DI] Fix tracking env vars when merging configs (bis)
  removed obsolete comment
  install PHPUnit 6 on PHP 7.2
  [Cache] Use zend.detect_unicode instead of zend.multibyte
  Fix case sensitive typo in use class name
  [VarDumper] Enhance docblock to tell about AbstractDumper::dumpLine(-1)
  [Debug] Remove false-positive check in DebugClassLoader
  [Validator] Fix use of GroupSequenceProvider in child classes
  Change number PHPDoc type to int|float
  [Cache] Workaround zend.detect_unicode + zend.multibyte
  [VarDumper] Strengthen dumped JS
  [VarDumper] Strengthen dumped JS
  ...
2017-08-29 14:00:42 -07:00
Fabien Potencier
dda57e6e21 feature #22543 [Lock] Expose an expiringDate and isExpired method in Lock (jderusse)
This PR was squashed before being merged into the 3.4 branch (closes #22543).

Discussion
----------

[Lock] Expose an expiringDate and isExpired method in Lock

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | yes
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | #22452
| License       | MIT
| Doc PR        | NA

This PR store the expiration date of the lock in the key and exposes public method to let the user know the state of the Lock expiration.

Commits
-------

279430800e [Lock] Expose an expiringDate and isExpired method in Lock
2017-08-29 13:57:32 -07:00
Jérémy Derussé
279430800e [Lock] Expose an expiringDate and isExpired method in Lock 2017-08-29 13:57:28 -07:00
Fabien Potencier
84bde030b1 minor #23974 [VarDumper] Use spl_object_id() with php72 polyfill when needed (nicolas-grekas)
This PR was merged into the 4.0-dev branch.

Discussion
----------

[VarDumper] Use spl_object_id() with php72 polyfill when needed

| Q             | A
| ------------- | ---
| Branch?       | master
| Bug fix?      | no
| New feature?  | no
| BC breaks?    | no
| Deprecations? | no
| Tests pass?   | yes
| Fixed tickets | -
| License       | MIT
| Doc PR        | -

Not possible on lower branches because the polyfill doesn't support HHVM.

Commits
-------

6dd695e3bc [VarDumper] Use spl_object_id() with php72 polyfill when needed
2017-08-29 13:55:53 -07:00