This PR was merged into the 4.4 branch.
Discussion
----------
[FrameworkBundle][WebProfilerBundle] Don't pass null to string parameters
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
This should fix the remaining issues from our bundle tests
Commits
-------
5af6edae62 [FrameworkBundle][WebProfilerBundle] Don't pass null to string parameters
This PR was merged into the 4.4 branch.
Discussion
----------
[Translation] Don't pass null to strtoupper()
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
This error popped up on 5.3, but not on 4.4. That's why I missed it when fixing the other occurrence with #41240.
Commits
-------
3c8cf9a3d4 [Translation] Don't pass null to strtoupper()
This PR was merged into the 4.4 branch.
Discussion
----------
Fix incompatible implicit float-to-int conversions
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
PHP 8.1 is picky about implicit float-to-int casts if we lose precision because of that cast. This PR should fix all cases that bubbled up in our test suite.
Commits
-------
fc7447681c Fix incompatible implicit float-to-int conversions
This PR was merged into the 4.4 branch.
Discussion
----------
[Security] Added missing translations for Croatian (hr)
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | no
| New feature? | no
| Deprecations? | no
| Tickets | Fix#41039
| License | MIT
| Doc PR | -
<!--
Replace this notice by a short README for your feature/bugfix. This will help people
understand your PR and can be used as a start for the documentation.
Additionally (see https://symfony.com/releases):
- Always add tests and ensure they pass.
- Never break backward compatibility (see https://symfony.com/bc).
- Bug fixes must be submitted against the lowest maintained branch where they apply
(lowest branches are regularly merged to upper ones so they get the fixes too.)
- Features and deprecations must be submitted against branch 5.x.
- Changelog entry should follow https://symfony.com/doc/current/contributing/code/conventions.html#writing-a-changelog-entry
-->
Commits
-------
0bce1f6de1 Add missing security translations
This PR was merged into the 4.4 branch.
Discussion
----------
Fix Serializable deprecations triggered by token mocks
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
On 4.4, `TokenInterface` extends `Serializable` but does not enforce implementations to implement `__serialize()` as well. When creating a mock from this interface, PHPUnit will emit code that triggers a deprecation warning on PHP 8.1.
This PR introduces stricter versions of `TokenInterface` to work around that problem.
My goal was to keep the diff small and mergable. We can probably drop most of the changes when merging to 5.2 because the two methods have been added there.
Commits
-------
48e76fafc6 Fix Serializable deprecations triggered by token mocks
This PR was merged into the 4.4 branch.
Discussion
----------
Add return types to JsonSerializable implementations
| Q | A
| ------------- | ---
| Branch? | 4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
PHP 8.1 will trigger a deprecation warning if we implement `JsonSerializable` without a return type. I've added return types to the two mock implementations that were affected.
Commits
-------
9246b53f7c Add return types to JsonSerializable implementations
This PR was merged into the 5.2 branch.
Discussion
----------
[String] Fix implicit float-to-int casts
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Part of #41552
| License | MIT
| Doc PR | N/A
`str_repeat()` expects an integer, but the result of the division might be a float. PHP 8.1 will complain here, so I'm using an integer division instead.
Commits
-------
448a017fd1 [String] Fix implicit float-to-int casts
This PR was merged into the 5.2 branch.
Discussion
----------
[Messenger] Fix opcache preload with alias classes - for 5.2
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#39961, fix#40752
| License | MIT
| Doc PR | -
Same fix than #41549 for 5.2 branch
Commits
-------
3bd24c5e07 [Messenger] Fix opcache preload with alias classes
This PR was squashed before being merged into the 4.4 branch.
Discussion
----------
[Serializer] Do not allow to denormalize string with spaces only to valid a DateTime object
| Q | A
| ------------- | ---
| Branch? |4.4
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | N/A
| License | MIT
This PR fixes an issue when `$data` variable contains only spaces. In this case DateTimeNormalizer creates a DateTime object.
Commits
-------
21c0829a25 [Serializer] Do not allow to denormalize string with spaces only to valid a DateTime object
This PR was merged into the 5.2 branch.
Discussion
----------
[FrameworkBundle] fix KernelBrowser::loginUser with a stateless firewall
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no <!-- please update src/**/CHANGELOG.md files -->
| Deprecations? | no <!-- please update UPGRADE-*.md and src/**/CHANGELOG.md files -->
| Tickets | n/a
| License | MIT
| Doc PR | todo?
Currently, `KernelBrowser::loginUser()` doesn't work with stateless firewalls (Basic HTTP, JWT etc) and fails if the session is disabled (which is frequent when creating web APIs, and when using stateless firewalls). This PR fixes the problem.
Commits
-------
2bfe6f25a8 [FrameworkBundle] fix KernelBrowser::loginUser with a stateless firewall
This PR was merged into the 5.2 branch.
Discussion
----------
[SecurityBundle] Link UserProviderListener to correct firewall dispatcher
| Q | A
| ------------- | ---
| Branch? | 5.2
| Bug fix? | yes
| New feature? | no
| Deprecations? | no
| Tickets | Fix#40158 , Fix#41474
| License | MIT
| Doc PR | /
When using the new AuthenticationManager, an incorrect UserProvider could be attached to the UserBadge when having multiple providers defined in `security.yaml`.
The `UserProviderListener` was tagged to the global event dispatcher instead of the dispatcher for the specific firewall.
Commits
-------
46bdeb8507 [SecurityBundle] Link UserProviderListener to correct firewall dispatcher
