Commits
-------
957690c fixing WebTastCase when kernel is not found and improving exception message
Discussion
----------
fixing WebTastCase when kernel is not found and improving exception message
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
this time against 2.0 and with the link to the symfony book. replaces #2418
(i hope you merge 2.0 into master as well?)
---------------------------------------------------------------------------
by meonkeys at 2011/11/04 10:37:43 -0700
Why is this closed? (I was expecting to see it merged to 2.0)
---------------------------------------------------------------------------
by dbu at 2011/11/04 10:45:05 -0700
this request is not closed, only the referenced #2418
github could work a bit on the layout though, looks confusing...
---------------------------------------------------------------------------
by meonkeys at 2011/11/04 10:46:56 -0700
Whoops, yep. And I should have read that more closely.
Commits
-------
ffa537c replace occurences of "an UserInteface" with "a UserInterface"
Discussion
----------
replace occurences of "an UserInteface" with "a UserInterface"
Commits
-------
89cd64a Set error code when number cannot be parsed. Fixes#2389
Discussion
----------
Set error code when number cannot be parsed in StubNumberFormatter
The stub implementation of NumberFormatter never sets an error code and instead always returns the "no-error" code. This causes unexpected results when a transformer gives it bad arguments, such as transforming the input value to boolean false and causing exceptions further down the line, as in #2389.
Instead, it should set an error code when appropriate and return it when requested so that a TransformationFailedException can be raised and the input value left unaltered.
There may be other instances where an error should be set. This covers the common use case of non-numeric input.
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #2389
Commits
-------
c9d05d7 Let NumberFormatter handle integer type casting
Discussion
----------
Let NumberFormatter handle integer type casting
The integer to localised string transformer is currently casting everything it gets to an integer, even if it is not a number. This responsibility should be passed off to NumberFormatter.
Partially addresses #2389 by not mistakenly typecasting a boolean false into an integer 0
---------------------------------------------------------------------------
by mrtorrent at 2011/10/30 15:04:28 -0700
Apologies, forgot the template:
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #2389 (partial)
Commits
-------
eca414b Fixed incomplete EntityType tests
Discussion
----------
[Doctrine] [Form] (Re: #2472) Fixed incomplete EntityType tests
**Previously #2472, but rebased onto `symfony/2.0` per @fabpot's request. See #2472 for more info**
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: N/A
Commits
-------
dec1858 Fixed typo
Discussion
----------
Fixed typo
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
This PR is the 2.0 branch version of #2519
Commits
-------
80f0b98 [DependencyInjection] Fix DefinitionDecorator::getArgument() for replacements
4bbb685 [DependencyInjection] Test Definition and DefinitionDecorator exceptions
Discussion
----------
[DependencyInjection] Fix getArgument() for replaced definition arguments
I was implementing something that worked with DefinitionDecorators before the container was compiled and ran into some missing functionality. While I was tinkering, I also added some additional tests for exceptions in both Definition and DefinitionDecorator.
While Definition::getArgument() could be used to fetch replaced values, it relied upon bad comparison logic (e.g. "index_1" > 1). Additionally, storing original arguments and replacements in the same array makes Definition::getArguments()'s bounds check unreliable. A single argument and its replacement would count twice, allowing getArgument(2) to pass the bounds check and result in an array index error.
With this new method, fetching of replacement arguments is more straightforward and bounds checking functions as it should.
Commits
-------
454e602 [SecurityBundle] Skipped two tests in PHP <5.3.9 on Windows as these hang due to a known bug
Discussion
----------
[SecurityBundle] Skip tests that are known to hang
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: #2287
After finding the cause of the hanging tests on Windows (thanks!), @beberlei skipped one of the hanging tests from #2287 in #2478. This one fixes the other two so that #2287 can be closed.
