Fabien Potencier
17aa0ed0ed
changed the default httpOnly value for cookie for better security out of the box
2011-05-04 08:44:59 +02:00
Fabien Potencier
c7fddca891
replaced some url..code by rawurl..code
2011-05-03 23:06:55 +02:00
Fabien Potencier
d31c403bae
Merge remote branch 'pborreli/tests-fix-typos'
...
* pborreli/tests-fix-typos:
Various typos
[WebProfilerBundle] Fixed typo
[WebProfilerBundle] Adding unit tests
2011-04-30 21:53:15 +02:00
Pascal Borreli
391744719a
Various typos
2011-04-30 19:40:15 +00:00
Victor Berchet
dccac192d6
[HttpFoundation] Sanitize uploaded file original name
2011-04-29 19:27:53 +02:00
Stepan Tanasiychuk
411997dc59
fix wrong method name
2011-04-27 23:15:27 +03:00
Victor Berchet
d350e01e33
File & UploadedFile tweaks
2011-04-27 09:10:41 +02:00
Fabien Potencier
00bfd10ca9
[HttpFoundation] refactored File management to be safer
2011-04-27 08:50:33 +02:00
Fabien Potencier
b7cd7115d1
[HttpFoundation] removed protected methods that were not used
2011-04-27 08:04:10 +02:00
Fabien Potencier
5bb9da4b6d
[HttpFoundation] renamed getDefaultExtension() to guessExtension()
...
The renamed method now returns null if it cannot guess the extension. It allows
the developper to know whether the extension has been guessed or not.
2011-04-27 08:03:19 +02:00
Fabien Potencier
a26de5ba58
[HttpFoundation] fixed CS
2011-04-27 08:03:15 +02:00
Fabien Potencier
854fbd7f68
[HttpFoundation] use realpath to ensure that there is no .. in file path (to match phpdoc)
2011-04-27 07:58:54 +02:00
Fabien Potencier
aa3ec504ae
removed File::getWebPath()
...
This has been removed for several reasons:
* the framework does not know where the document root is and should not care
* as the document root was static, it was impossible to have several document roots depending on some business rules (see next one)
* sometimes, the document root is not under the web root directory (so the logic of getWebPath() is not always correct)
* the feature was not used anywhere in the core
2011-04-27 06:49:05 +02:00
Victor Berchet
f83e92bf44
Make casting scalar to array consistent
2011-04-26 12:16:35 +02:00
Fabien Potencier
889c422d6e
Merge remote branch 'igorw/ipv6'
...
* igorw/ipv6:
[HttpFoundation] minor optimization
minor adjustments suggested by vicb
[HttpFoundation] IPv6 support for RequestMatcher
[HttpFoundation] refactor RequestMatcherTest to use dataProvider
[Validator] use full iPv6 regex
[Validator] add IPv6 support to UrlValidator
[HttpFoundation] add IPv6 support to Request
[HttpFoundation] test Request::create with an IP as host name
[HttpFoundation] refactor Request::getClientIp test
2011-04-24 22:04:25 +02:00
Fabien Potencier
2f3ddb88ef
Merge remote branch 'bschussek/form'
...
* bschussek/form:
[Form] Automatically setting "data_class" option if objects are passed at the creation of a form
[Form] Improved the way passed data is handled in FormFactory
[Form] Simplified FileType code
[HttpFoundation] TemporaryStorage automatically creates the directory if it doesn't exist yet
[Form] Changed FormBuilder::build() to FormBuilder::create(). You hvae to pass the resulting builder to FormBuilder::add() manually now
[Form] Added FieldTypeValidatorExtension and fixed FQCN of DelegatingValidator
2011-04-24 21:53:24 +02:00
Fabien Potencier
08bf2af455
fixed email
2011-04-24 13:59:46 +02:00
Bernhard Schussek
19073ae655
[HttpFoundation] TemporaryStorage automatically creates the directory if it doesn't exist yet
2011-04-24 12:08:56 +02:00
Pascal Borreli
8c0beea677
[Phpdoc] Cleaning/fixing
2011-04-23 15:18:47 +00:00
Fabien Potencier
50d3c92e22
tweaked TemporaryStorage directory creation
2011-04-23 15:19:30 +02:00
Fabien Potencier
8cc5caf1f3
changed the default directory for the upload temp dir, made the dir mandatory
2011-04-23 15:09:55 +02:00
Fabien Potencier
02c66e658c
removed the nestingLevel configuration for file temporary storages
2011-04-23 15:06:07 +02:00
Pascal Borreli
b5769c52d6
Fixed various typo
2011-04-22 23:12:50 +00:00
Igor Wiedler
041a2e9d83
[HttpFoundation] minor optimization
2011-04-22 22:20:12 +02:00
Igor Wiedler
51d12758a0
minor adjustments suggested by vicb
2011-04-22 18:37:20 +02:00
Igor Wiedler
9ae5023a70
[HttpFoundation] IPv6 support for RequestMatcher
2011-04-22 17:37:22 +02:00
Igor Wiedler
82699c5a98
[HttpFoundation] add IPv6 support to Request
2011-04-22 17:07:44 +02:00
Fabien Potencier
417839345f
Merge remote branch 'lsmith77/request_format_tweaks'
...
* lsmith77/request_format_tweaks:
added text/html to default format mapping
return "q" from splitHttpAcceptHeader() to enable more complex accept header negotiations
added support for setting a custom default format in Request::getRequestFormat()
2011-04-22 15:33:01 +02:00
Fabien Potencier
fd05f02b23
[HttpFoundation] added logic to automatically add the charset when not present in the Content-Type for relevant Content-Types
2011-04-22 15:26:38 +02:00
Fabien Potencier
7644e86683
refactored session configuration
...
* made the options array only for "global" options that are valid for all session storages
* changed the PDO session storage constructor signature to accept an array of options for DB configuration
* changed the storage_id to be the full service id, instead of just part of it
* removed the class parameter for session as it can be changed via the .class parameter (it was the only example in the framework)
* removed the configuration for the PDO session storage for now
2011-04-22 13:34:57 +02:00
Eriksen Costa
589b0ab4ed
Merge branch 'master' into form-frameworkbundle-form-guessers-fix
...
Conflicts:
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/Compiler/AddFormGuessersPass.php
src/Symfony/Component/Form/MoneyField.php
2011-04-21 23:03:40 -03:00
Fabien Potencier
c5497c7c67
[HttpFoundation] fixed a potential security problem in Request
2011-04-21 20:00:27 +02:00
Fabien Potencier
a2ab05e9c2
Merge remote branch 'web-dev/master'
...
* web-dev/master:
Added 201 to the possible status codes that indicate a response is a redirect.
2011-04-21 19:51:30 +02:00
Josiah
98e46a23fa
Added 201 to the possible status codes that indicate a response is a redirect.
2011-04-21 10:36:25 -07:00
Fabien Potencier
071caeb0c8
Merge remote branch 'merk/file'
...
* merk/file:
[HttpFoundation\File] Removed realpath()
2011-04-20 23:13:55 +02:00
Kris Wallsmith
30511d2965
[HttpFoundation] fixed FilesystemSessionStorage
2011-04-20 13:20:21 -07:00
Tim Nagel
03bb3580a6
[HttpFoundation\File] Removed realpath()
2011-04-20 23:52:17 +10:00
Fabien Potencier
d993a9160a
[HttpFoundation] fixed getScheme() method
2011-04-20 10:49:08 +02:00
Lukas Kahwe Smith
c2ac8304b0
added text/html to default format mapping
2011-04-17 14:39:07 +02:00
Lukas Kahwe Smith
4c3c6cdabf
return "q" from splitHttpAcceptHeader() to enable more complex accept header negotiations
2011-04-17 14:38:33 +02:00
Lukas Kahwe Smith
53c7bcf3aa
added support for setting a custom default format in Request::getRequestFormat()
2011-04-17 14:37:35 +02:00
Brikou CARRE
e898445b94
removed empty lines/trailing spaces
2011-04-15 21:12:02 +02:00
hidenorigoto
1e78ec395c
[HttpFoundation] fixed wrong method name
2011-04-15 19:04:00 +09:00
Bernhard Schussek
44af72bbf4
Merge remote branch 'symfony/master' into experimental
2011-04-14 15:04:59 +02:00
Fabien Potencier
5316decd8c
Merge remote branch 'hhamon/shared_maxage_fix'
...
* hhamon/shared_maxage_fix:
[HttpFoundation] force Response to be "public" if setSharedMaxAge() is called.
2011-04-13 23:24:31 +02:00
Fabien Potencier
ea84bb025b
fixed session management in functional tests
2011-04-13 23:11:25 +02:00
Fabien Potencier
e2c9fdf2c7
[HttpFoundation] fixed expiration time for Cookie (PHP wants a Unix timestamp)
2011-04-13 20:12:14 +02:00
Fabien Potencier
66c4bc727c
[HttpFoundation] renamed Cookie::getExpire() to getExpiresTime() to be consistent with the DomCrawler component
2011-04-13 20:10:39 +02:00
Fabien Potencier
84dde4074a
[HttpFoundation] changed default value of Cookie httponly argument to match PHP defaults
2011-04-13 20:07:31 +02:00
hhamon
053d83f557
[HttpFoundation] force Response to be "public" if setSharedMaxAge() is called.
2011-04-13 15:58:48 +02:00
Fabien Potencier
227c87404f
Merge remote branch 'Funsational/master'
...
* Funsational/master:
Update PDO session storage to check if any rows are updated when doing a session write. If no rows are udpated when performing a session write it generally means that we have created a new session id somewhere and we have not inserted into the database. This is the case for when calling regenerate_session_id() from the native session storage class. It will update the session id then call sessionWrite() to save the session but since the new session id does not exist in the DB, no rows are updated and any new session attributes such as security tokens are lost.
2011-04-13 14:27:16 +02:00
Bernhard Schussek
2a18be1c9f
Merge remote branch 'symfony/master' into experimental
2011-04-13 13:53:20 +02:00
Johannes Schmitt
1ed73fb6e6
[HttpFoundation] allow to retrieve paths of arbitrary depths
2011-04-05 10:17:31 +02:00
michaelwilliams
46b711c4a8
Update PDO session storage to check if any rows are updated when doing a session write. If no rows are udpated when performing a session write it generally means that we have created a new session id somewhere and we have not inserted into the database. This is the case for when calling regenerate_session_id() from the native session storage class. It will update the session id then call sessionWrite() to save the session but since the new session id does not exist in the DB, no rows are updated and any new session attributes such as security tokens are lost.
...
See http://www.php.net/manual/en/function.session-set-save-handler.php#103055 for more details
2011-04-01 18:14:27 -07:00
Bernhard Schussek
bbeddf7789
Merge remote branch 'symfony/master' into experimental
2011-03-31 12:32:20 +02:00
Fabien Potencier
702e6587ad
Merge remote branch 'pborreli/windows-fix-mimetype'
...
* pborreli/windows-fix-mimetype:
[HttpFoundation][Windows] Fixed filebinary guesser method.
2011-03-30 19:52:56 +02:00
Pascal Borreli
44a6f84855
[HttpFoundation][Windows] Fixed filebinary guesser method.
2011-03-30 17:38:42 +00:00
Fabien Potencier
f77b94074f
[HttpFoundation] replaced the option argument of Session by defaultLocale
2011-03-30 17:26:13 +02:00
Bernhard Schussek
55c14680d3
Merge remote branch 'symfony/master' into experimental
2011-03-30 10:31:21 +02:00
Pascal Borreli
dbb18662d7
[HttpFoundation][Windows] Disabled FileBinaryMimeTypeGuesser for Windows OS
2011-03-29 14:32:20 +00:00
Bernhard Schussek
729438fdea
Merge branch 'rename-execute' into experimental
...
Conflicts:
src/Symfony/Component/Form/FileField.php
src/Symfony/Component/Form/Resources/config/validation.xml
2011-03-25 01:38:49 +01:00
Fabien Potencier
a6e6cbbb27
[HttpFoundation] removed the hardcoded ^ and $ from the RequestMatcher
2011-03-23 21:27:04 +01:00
Bernhard Schussek
89215d167d
Merge remote branch 'symfony/master' into experimental
2011-03-19 13:25:41 +01:00
ornicar
7440db7244
[HttpFoundation] Make sure Request::getLanguages always returns an array
2011-03-19 01:34:54 -07:00
Kris Wallsmith
73db141ce6
[HttpFoundation] stripped tags from native error messages in case html_errors is on
2011-03-18 11:11:42 -07:00
Bernhard Schussek
3f70f89339
Merge remote branch 'symfony/master' into experimental
...
Conflicts:
src/Symfony/Bundle/FrameworkBundle/Debug/TraceableEventDispatcher.php
src/Symfony/Bundle/FrameworkBundle/DependencyInjection/FrameworkExtension.php
src/Symfony/Component/HttpFoundation/File/UploadedFile.php
2011-03-18 10:39:40 +01:00
Kris Wallsmith
ab3b8ac364
[HttpFoundation] cleaned up comments and coding standards, added better exception messages when filesystem functions throw errors, added "moved" arg to UploadedFile constructor, added FileNotFoundException to UploadedFile per the parent constructor
2011-03-17 16:07:53 -07:00
Fabien Potencier
d5396f64de
[HttpFoundation] fixed a small bug on Windows
2011-03-17 12:28:29 +01:00
Bernhard Schussek
f64f55002b
Merge remote branch 'symfony/master' into experimental
...
Conflicts:
src/Symfony/Component/Security/Http/Firewall/AbstractAuthenticationListener.php
src/Symfony/Component/Security/Http/Firewall/AbstractPreAuthenticatedListener.php
2011-03-16 16:00:54 +01:00
Kris Wallsmith
a5d8770a54
[HttpFoundation] fixed ApacheRequest, added tests
2011-03-16 06:13:01 -07:00
Bernhard Schussek
0bf566310c
Merge branch 'event-manager' into experimental
...
Conflicts:
src/Symfony/Component/Form/BirthdayField.php
src/Symfony/Component/Form/CheckboxField.php
src/Symfony/Component/Form/ChoiceField.php
src/Symfony/Component/Form/ChoiceList/TimeZoneChoiceList.php
src/Symfony/Component/Form/CollectionField.php
src/Symfony/Component/Form/DateField.php
src/Symfony/Component/Form/DateTimeField.php
src/Symfony/Component/Form/EntityChoiceField.php
src/Symfony/Component/Form/Events.php
src/Symfony/Component/Form/FieldFactory/FieldFactory.php
src/Symfony/Component/Form/FieldFactory/FieldFactoryInterface.php
src/Symfony/Component/Form/FileField.php
src/Symfony/Component/Form/Filters.php
src/Symfony/Component/Form/FormContext.php
src/Symfony/Component/Form/FormContextInterface.php
src/Symfony/Component/Form/FormFactoryInterface.php
src/Symfony/Component/Form/HybridField.php
src/Symfony/Component/Form/IntegerField.php
src/Symfony/Component/Form/LanguageField.php
src/Symfony/Component/Form/LocaleField.php
src/Symfony/Component/Form/MoneyField.php
src/Symfony/Component/Form/NumberField.php
src/Symfony/Component/Form/PasswordField.php
src/Symfony/Component/Form/PercentField.php
src/Symfony/Component/Form/RepeatedField.php
src/Symfony/Component/Form/TextField.php
src/Symfony/Component/Form/TimeField.php
src/Symfony/Component/Form/ToggleField.php
src/Symfony/Component/Form/UrlField.php
src/Symfony/Component/HttpFoundation/File/UploadedFile.php
tests/Symfony/Tests/Component/Form/FileFieldTest.php
tests/Symfony/Tests/Component/Form/FormContextTest.php
tests/Symfony/Tests/Component/Form/HiddenFieldTest.php
2011-03-13 21:04:24 +01:00
Fabien Potencier
bc6ffeef83
[HttpFoundation] fixed flash management
2011-03-11 20:23:17 +01:00
Jordi Boggiano
991b1ed225
[HttpFoundation] UploadedFile::getOriginalName is now overriding getName
2011-03-09 17:26:08 +01:00
Jordi Boggiano
2a5fcdfb1a
[HttpFoundation] Minor optimization
2011-03-09 17:25:36 +01:00
Fabien Potencier
8c423edfef
replaced symfony-project.org by symfony.com
2011-03-06 12:40:06 +01:00
Fabien Potencier
a137d72351
Merge remote branch 'hhamon/cookie_path_fix'
...
* hhamon/cookie_path_fix:
[Security] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[HttpKernel] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[BrowserKit] renamed Cookie::isHttponly() to Cookie::isHttpOnly()
[HttpFoundation] fix cookie path default value to / and added some new unit tests to cover the class
2011-03-06 10:44:40 +01:00
Fabien Potencier
487cddcfee
Merge remote branch 'DuoSRX/code-coverage'
...
* DuoSRX/code-coverage:
[HttpFoundation] Fixed a typo in response->setLastModified()
[HttpFoundation] Added some more tests on response
[HttpFoundation] Added some tests on Response
[HttpFoundation] Replace a duplicated test with a method in Response
Fixed code coverage generation when resources folder are deeper
2011-03-06 10:44:13 +01:00
Fabien Potencier
51023eea86
[HttpFoundation] fixed CS
2011-03-06 10:39:33 +01:00
Fabien Potencier
c02ebbf2d8
Merge remote branch 'digitalkaoz/httpkernel-datacollector'
...
* digitalkaoz/httpkernel-datacollector:
[HttpKernel] added Tests for DataCollectors
[HttpFoundation] more sophisticated checks for valid expiration
2011-03-06 10:38:55 +01:00
Xavier Perez
19090d3fb7
[HttpFoundation] Fixed a typo in response->setLastModified()
2011-03-06 00:17:54 +01:00
Robert Schönthal
87e1359ebd
[HttpFoundation] more sophisticated checks for valid expiration
2011-03-06 00:13:47 +01:00
Xavier Perez
0d56ca5654
[HttpFoundation] Replace a duplicated test with a method in Response
2011-03-05 14:27:35 +01:00
Robert Schönthal
58db452e21
[HttpFoundation] added a check for array keys existence.
2011-03-05 13:30:54 +01:00
Hugo Hamon
ad56bd8e47
[HttpFoundation] fix cookie path default value to / and added some new unit tests to cover the class
2011-03-03 14:50:14 +01:00
Bernhard Schussek
68013f4db2
Merge remote branch 'symfony/master' into experimental
2011-03-02 12:27:30 +01:00
Pascal Borreli
ff44b0ff28
[HttpFoundation] Removed remove recurring test
2011-03-01 18:58:07 +01:00
Fabien Potencier
cdf6851eb3
fixed merge
2011-02-27 21:16:13 +01:00
Christophe Coevoet
92bfbf575c
Fixed CS
2011-02-27 20:56:29 +01:00
Pascal Borreli
fc42cc5066
[HttpFoundation] Removed useless else
2011-02-27 18:36:38 +01:00
Pascal Borreli
f7ab114d36
[HttpFoundation] Fixed missing curly brackets
2011-02-27 18:36:37 +01:00
Pascal Borreli
f3b9364eae
[HttpFoundation] Fixed typo
2011-02-26 20:02:06 +01:00
Bernhard Schussek
c6e9fd97b6
[Form] Fixed various bugs
2011-02-25 00:09:10 +01:00
Bernhard Schussek
e334c4734e
[Form] Registered FormFactory in the DIC
2011-02-24 21:27:44 +01:00
Bernhard Schussek
f2c1976da6
[Form] Refactored FileField to FormFactory and fixed file upload mechanism
2011-02-24 20:47:48 +01:00
Fabien Potencier
f54cedfe5e
added LICENSE files for the subtree repositories
2011-02-22 18:58:15 +01:00
Kris Wallsmith
a0bae94f88
[HttpFoundation] updated ResponseHeaderBag to compute Cache-Control whenever any of the headers it considers changes
2011-02-21 19:57:05 -08:00
Fabien Potencier
353177d1d6
replaced Response::createRedirect by a new RedirectResponse class
2011-02-21 18:10:53 +01:00
Fabien Potencier
d94acd85f9
remove response as a service
...
The Response is not available in the DIC anymore.
When you need to create a response, create an instance of
Symfony\Component\HttpFoundation\Response instead.
As a side effect, the Controller::createResponse() and Controller::redirect()
methods have been removed and can easily be replaced as follows:
return $this->createResponse('content', 200, array('foo' => 'bar'));
return new Response('content', 200, array('foo' => 'bar'));
return $this->redirect($url);
return Response::createRedirect($url);
2011-02-21 17:36:04 +01:00
Fabien Potencier
bf20238178
fixed a bug in Response content-type auto-detection
...
Without this patch, if you call __toString() on a Response,
the content-type auto-detection would never be trigerred
as __toString() changes the default content-type.
2011-02-21 16:57:25 +01:00
hhamon
f985da5a9c
[HttpFoundation] fix Cache-Control header when forcing the Response to have an Expires header field. The RFC2616 Bis indicates that if the Response has both max-age (or s-maxage) and Expires header field, the Cache-Control maxage wins over Expires. The previous code in ResponseHeaderBag always returned "private, max-age=0, must-revalidate" even if the Expires header field was forced.
...
This commit breaks functional tests in Symfony\Component\HttpKernel\HttpCache\HttpCacheTest.php. I tried to fix functional tests but I didn\'t manage to. For your information, the "try { } catch" block in the HttpKernel\HttpCache::lookup() method seems strange because I suspect line 274 to never leverage any exception...
2011-02-18 12:34:33 +01:00
