Jonathan Ingram
88ccb9b192
Added another corner case
2012-02-23 16:12:02 +11:00
Jonathan Ingram
7c4343fa29
Added 4 assertions related to simple URLs containing ? and #
2012-02-23 16:06:46 +11:00
Dariusz Górecki
d02f17268e
Code readability fixes, removed unneeded typecasts and checks
...
Bug fix: no
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
Todo: -
2012-02-02 11:43:31 +01:00
Fabien Potencier
3c8d300125
fixed CS
2012-02-02 11:21:34 +01:00
Bernhard Schussek
2e4ebe444f
[Validator] Renamed methods addViolationAtRelativePath() and getAbsolutePropertyPath() in ExecutionContext
2012-02-02 10:13:41 +01:00
Bernhard Schussek
9153f0e569
[Validator] Deprecated ConstraintValidator methods setMessage(), getMessageTemplate() and getMessageParameters()
...
Had to refactor the validation tests at the same time and fixed various small bugs while doing so.
2012-02-01 14:03:13 +01:00
Bernhard Schussek
a30a679135
[Validator] Made ExecutionContext immutable and introduced new class GlobalExecutionContext
...
A new ExecutionContext is now created everytime that GraphWalker::walkConstraint() is
launched. Because of this, a validator B launched from within a validator A can't break
A anymore by changing the context.
Because we have a new ExecutionContext for every constraint validation, there is no point
in modifying its state anymore. Because of this it is now immutable.
2012-01-31 21:35:48 +01:00
Bernhard Schussek
fe85bbdb06
[Validator] Simplified ExecutionContext::addViolation(), added ExecutionContext::addViolationAt()
2012-01-31 18:42:14 +01:00
Bernhard Schussek
a103c28b08
[Validator] The Collection constraint adds "missing" and "extra" errors to the individual fields now
2012-01-30 20:57:20 +01:00
Fabien Potencier
e8f9a55012
fixed CS
2012-01-17 11:23:46 +01:00
Bernhard Schussek
e6e3da5063
[Validator] Improved test coverage of CollectionValidator and reduced test code duplication
2012-01-16 13:03:38 +01:00
Bernhard Schussek
509c7bfb5b
[Validator] Moved Optional and Required constraints to dedicated sub namespace.
2012-01-16 11:30:56 +01:00
Bernhard Schussek
6641f3e231
[Validator] Added constraints Optional and Required for the CollectionValidator
2012-01-16 11:30:56 +01:00
Fabien Potencier
5fa0f2d92b
merged 2.0
2012-01-16 07:44:08 +01:00
Dariusz Górecki
7f7c2a7094
Add prof-of-concept test, this test will fail without changes in previous commit
2012-01-10 11:51:28 +01:00
Benjamin Dulau
05a4e9d386
[Validators][Type] Added support for ctype_* functions + tests
2011-11-01 13:01:54 +01:00
Fabien Potencier
d34d50f0b0
fixed CS
2011-10-29 12:05:45 +02:00
Hugo Hamon
73312ab5e9
[Validator] The Type constraint now accepts the "Boolean" type instead of "boolean".
...
Bug fix: yes
Feature addition: no
Backwards compatibility break: no
Symfony2 tests pass: yes
Fixes the following tickets: -
2011-10-11 12:27:45 +02:00
Fabien Potencier
a8faa83708
merged 2.0
2011-10-08 22:58:00 +02:00
Joseph Bielawski
d7c9644d29
[Validator] Extend and fix DateValidator & TimeValidator tests
2011-10-07 10:47:59 +02:00
Fabien Potencier
d6c4bfb001
added a Size validator
2011-09-29 15:56:37 +02:00
Fabien Potencier
b9ba117208
[Validator] added a SizeLength validator
2011-09-29 15:45:52 +02:00
H. Westphal
3e2f1a4b13
Removed executable bits from all php files
2011-09-09 15:16:17 +02:00
H. Westphal
a0a97c6a22
Removed executable bits from all php files
2011-09-07 22:51:20 +02:00
Benjamin Dulau
135531a2de
Replaced setExpectedException() methods by annotations
2011-09-04 17:45:31 +02:00
Benjamin Dulau
6ad83e7970
Updated according to PR review
2011-09-04 17:45:25 +02:00
Benjamin Dulau
2de243cf07
* Added Fixtures 2x2px test.gif image file
...
* Updated tests for using fixture image instead of imagecreate function
2011-09-04 17:28:52 +02:00
Benjamin Dulau
a5a2dfaaa6
[ImageValidator] Added dedicated ImageValidator class with min width, max width, min height and max height validations
2011-09-04 17:28:46 +02:00
Fabien Potencier
e7b2d2d659
merged 2.0 branch
2011-09-04 09:28:37 +02:00
Evan Kaufman
639513a67a
Per the [documentation][1], the NotBlank
constraint should be using the empty
language construct, otherwise it will not trigger on, for example, a boolean false from an unchecked checkbox field.
...
[1]: http://symfony.com/doc/2.0/reference/constraints/NotBlank.html
2011-09-02 09:37:48 +02:00
stealth35
5a470103f0
[Validator] FileValidator allow MIME with wildcard
2011-09-01 16:10:16 +02:00
Fabien Potencier
e42a2dede1
[Validator] fixed unit tests when intl is not installed
2011-07-20 14:45:35 +02:00
Deni
0f328d228b
[Validator] Fixed using the strict option in the choice validator.
2011-07-16 21:16:21 +04:00
Fabien Potencier
88d915d175
[Validator] fixed Min and Max validator when the input value is not a number (now return an error message instead of an exception which does not make sense in this context)
2011-07-12 17:40:02 +02:00
marc.weistroff
df57e0fe9a
[Validator] Added strict option to ChoiceConstraint.
2011-07-07 15:11:36 +02:00
Victor Berchet
d58ba34246
[Validator] Consider the ini directive 'upload_max_filesize' while validating an uploaded file (fixes GH-1441)
2011-07-05 20:05:50 +02:00
Fabien Potencier
f322a4a99d
fixed CS
2011-06-23 13:39:36 +02:00
Jordi Boggiano
159fc0edf0
[Validator] Added symbols to IDNs validation
2011-06-20 13:52:36 +02:00
Jordi Boggiano
c827faf694
[Validator] Add support for IDNs and custom TLDs
2011-06-20 12:57:46 +02:00
Fabien Potencier
0805c6f963
[Validator] removed MX test (tests should work with Internet down)
2011-06-16 15:22:16 +02:00
stloyd
edf4b87dcb
Add missing "tearDown" functions, and some missing variable declaration (this saves for me almost 20MB when run all tests)
...
Force AsseticBundle tests to use TestCase
Fix test for DoctrineBundle to use TestCase
2011-06-16 15:06:36 +02:00
stloyd
2b0c3526d8
Increase code coverage for: YamlParser, Validators, PhpEngine + Helpers, HttpFoundation
...
Revert failing asserts for UrlValidator
Mark as incomplete instead of commenting them out
2011-06-16 11:43:27 +02:00
stloyd
99f9337517
Additional tests for PhpEngine + Helpers
...
More tests for UrlValidator
2011-06-16 11:42:29 +02:00
stloyd
450ed85aa4
Additional tests for DateTimeValidator, EmailValidator and UrlValidator
2011-06-16 11:42:28 +02:00
Fabien Potencier
c7d5fd16e0
fixed CS
2011-06-15 13:46:46 +02:00
Fabien Potencier
c5223bbcd1
merged branch vicb/file (PR #1317 )
...
Commits
-------
9d6357c
[HttpFoundation] Document the changes to the File classes
136b80a
[HttFoundation] Add File::getExtension() as \SplFileInfo::getExtension() was introduced in PHP 5.3.6
38b3b74
[HttpKernel] Fix and test previous commit
ac0c00c
[HttpFoundation] Make File extends \SplFileInfo
Discussion
----------
[HttpFoundation] Make File extends \SplFileInfo
This is a rebased version of [PR 674](https://github.com/symfony/symfony/pull/674 ).
* File: The API has changed (now extends \SplFileInfo),
* File: move() creates the target directory when it does not exist
* UploadedFile: introduction of getClientXXX() methods (for Size, OriginalName, MimeType)
If this PR does not get merged UploadedFile should at least be fixed: [Client.php](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpKernel/Client.php#L124 ) relies on a last parameter which is no more defined and which is used to bypass [move_uploaded_file()](https://github.com/symfony/symfony/blob/master/src/Symfony/Component/HttpFoundation/File/UploadedFile.php#L155 ) in test mode.
If this could be merged, I'll detail the changes in UPDATE.md
---------------------------------------------------------------------------
by fabpot at 2011/06/14 08:20:59 -0700
I'll merge it. Can you update the UPDATE file?
---------------------------------------------------------------------------
by vicb at 2011/06/14 09:24:01 -0700
done
2011-06-15 08:57:16 +02:00
Victor Berchet
ac0c00c6e8
[HttpFoundation] Make File extends \SplFileInfo
2011-06-14 10:47:04 +02:00
Albert Jessurum
ca52a04f5e
[Validator] Allow DateTime objects as valid Times
2011-06-09 15:47:51 +02:00
Fabien Potencier
17cd08dc6c
fixed CS
2011-06-08 19:56:59 +02:00
Dirk Pahl
361c67f54f
[Form] Add test for the handling of array values in the constraint violation
2011-05-18 23:48:32 +02:00