This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes#16737).
Discussion
----------
[Yaml] minor CS cleaning
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
PHPStorm reported different types of coding style suggestions along the Symfony codebase. I've fixed some of them in the Yaml compontent and I have two questions:
1) What is the correct branch for such changes? Not all of them can be fixed in 2.3/2.8, for example `ParserTest`'s docblock is different there.
2) Should I create similar PRs for other components or is there a plan to do all such fixes at once someday in the future (e.g. after 2.8/3.0 is released)?
Commits
-------
613804d [Yaml] minor CS cleaning
This PR was merged into the 2.3 branch.
Discussion
----------
[Console] do not encode backslashes in console default description
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16420
| License | MIT
| Doc PR | -
Commits
-------
873a541 [Console] do not encode backslashes in console default description
This PR was squashed before being merged into the 2.3 branch (closes#16312).
Discussion
----------
[HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #15813
| License | MIT
| Doc PR | n/a
I've been trying to debug #15813 and modified the Store in a way to keep unique request IDs in the .lck file. That way, I was hoping to find out which request is blocking and/or if the request is actually still running.
It turned out that `is_file()` would claim that a lock file still exists, but a subsequent attempt to read the information from that file returned "file not found" errors.
So, my assumption is that the `is_file()` result is based on the fstat cache and wrong once a process has seen the lock file.
@jakzal said in https://github.com/symfony/symfony/issues/15813#issuecomment-149013691 that `unlink()`ing the lock file should clear the statcache, but I doubt this is true across PHP processes.
Commits
-------
982710f [HttpKernel] clearstatcache() so the Cache sees when a .lck file has been released
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Don't catch RuntimeException when it complicates tests debugging
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
See https://github.com/symfony/symfony/pull/16702/files?w=1
Commits
-------
8588a4f [Process] Don't catch RuntimeException when it complicates tests debugging
This PR was merged into the 2.3 branch.
Discussion
----------
[appveyor] Workaround transient segfault when APCu is enabled
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #15617
| License | MIT
| Doc PR | -
See e.g. https://ci.appveyor.com/project/nicolas-grekas/symfony/build/1.0.4#L1186
Commits
-------
12a152b [appveyor] Workaround transient segfault when APCu is enabled
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16700).
Discussion
----------
Fixed the wrong source name and the ja translation
Commits
-------
90f3b94 Fixed the wrong source name and the ja translation
This PR was merged into the 2.3 branch.
Discussion
----------
[SecurityBundle] disable the init:acl command if ACL is not used
| Q | A
| ------------- | ---
| Bug fix? | somewhat
| New feature? | somewhat
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR | -
Related to #16694 but this should go in 2.3 IMO because it was just forgotten. The other acl command already has this logic: https://github.com/symfony/symfony/blob/2.7/src/Symfony/Bundle/SecurityBundle/Command/SetAclCommand.php#L36
It ensures the command list is not flooded with unusable commands.
Commits
-------
55f84a3 [SecurityBundle] disable the init:acl command if ACL is not used
This PR was merged into the 2.3 branch.
Discussion
----------
Always enable clock-mock for HttpFoundation
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16660
| License | MIT
| Doc PR | -
Commits
-------
1712086 Always enable clock-mock for HttpFoundation
This PR was merged into the 2.3 branch.
Discussion
----------
[ClassLoader] Fix parsing namespace when token_get_all() is missing
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #14871
| License | MIT
| Doc PR | -
Commits
-------
4a17c9e [ClassLoader] Fix parsing namespace when token_get_all() is missing
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16386).
Discussion
----------
Bug #16343 [Router] Too many Routes ?
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | https://github.com/symfony/symfony/issues/16343
| License | MIT
| Doc PR | N/A
Seems there is an issue when you have more than 7265 routes declared,
The routes are generated into the cached appDevUrlGenerator.php but php only loads the last 7265 elements of the array.
Commits
-------
0113ac3 Bug #16343 [Router] Too many Routes ?
This PR was merged into the 2.3 branch.
Discussion
----------
[travis] Disable xdebug on PHP7
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
dfda5ce [travis] Disable xdebug on PHP7
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16588).
Discussion
----------
Sent out a status text for unknown HTTP headers.
* The HTTP RFC explains that header('HTTP/1.1 418 ') should be fine, see http://www.w3.org/Protocols/rfc2616/rfc2616-sec6.html#sec6.1
* Apache itself though is broken, see https://gist.github.com/anonymous/a863d7b493c4b09733ec
The fix is to sent out some status text, when we don't know a better text.
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
Commits
-------
eec6fbc Sent out a status text for unknown HTTP headers.
This PR was merged into the 2.3 branch.
Discussion
----------
[DependencyInjection] Unescape parameters for all types of injection
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
The parameters must be escaped when injected in the container.
But they are only unescaped when the container is dumped and when these parameters are used in the service constructor.
We need to unescape them every time their are injected (constructor, setter and property injection)
Commits
-------
331a046 [DependencyInjection] Unescape parameters for all types of injection
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix trailing space in PHP binary finder
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | #16598
| License | MIT
| Doc PR | -
Commits
-------
f15e6e0 [Process] Fix trailing space in PHP binary finder
This PR was merged into the 2.3 branch.
Discussion
----------
[Process] Fix PhpProcess with phpdbg runtime
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
With this PR, I'm able to successfully run the test suite of the Process component using
`phpdbg -qrr ./phpunit src/Symfony/Component/Process/`
Commits
-------
9669238 [Process] Fix PhpProcess with phpdbg runtime
This PR was merged into the 2.3 branch.
Discussion
----------
Add missing exclusions from phpunit.xml.dist
| Q | A
| ------------- | ---
| Bug fix? | no
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets | -
| License | MIT
| Doc PR | -
Commits
-------
d4880c4 Add missing exclusions from phpunit.xml.dist
This PR was submitted for the 2.8 branch but it was merged into the 2.3 branch instead (closes#16566).
Discussion
----------
[HttpFoundation] Fix undefined array $server
| Q | A
| ------------- | ---
| Bug fix? | yes
| New feature? | no
| BC breaks? | no
| Deprecations? | no
| Tests pass? | yes
| Fixed tickets |
| License | MIT
| Doc PR |
$server variable isn't defined in the test /src/Symfony/Component/HttpFoundation/Tests/RequestTest.php:RequestTest
Commits
-------
75aa6f6 Fix undefined array $server