Commit Graph

4210 Commits

Author SHA1 Message Date
Nicolas Grekas
7e28ffa6a1 Merge branch '5.1' into 5.2
* 5.1:
  Rename parameter of @method configureContainer
  [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass
  [DependencyInjection] Fix InvalidParameterTypeException for function parameters
  [Notifier] Cleanup changelog (5.1)
  [VarDumper] fix mutating $GLOBALS while cloning it
2021-01-07 15:52:12 +01:00
Nicolas Grekas
054e00c952 Merge branch '4.4' into 5.1
* 4.4:
  [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass
  [DependencyInjection] Fix InvalidParameterTypeException for function parameters
  [VarDumper] fix mutating $GLOBALS while cloning it
2021-01-07 15:52:02 +01:00
Nicolas Grekas
3ee310f20a bug #39747 [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | N/A
| License       | MIT
| Doc PR        | N/A

`CheckTypeDeclarationsPass` currently explodes if it encounters one of following the new builtin types of PHP 8:

* `false` (can only appear as part of a union)
* `mixed` (we don't need to check anything)

In either case, the pass will try to call a method `is_false()`/`is_mixed()` and fail.

This PR should fix both cases.

Commits
-------

f16230be5d [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass
2021-01-07 15:35:02 +01:00
Alexander M. Turek
f16230be5d [DependencyInjection] Support PHP 8 builtin types in CheckTypeDeclarationsPass 2021-01-07 03:15:41 +01:00
Alexander M. Turek
185454367a [DependencyInjection] Fix InvalidParameterTypeException for function parameters 2021-01-07 02:09:26 +01:00
Christian Flothmann
a7600370fa Merge branch '5.2' into 5.x
* 5.2:
  fix code style
  [Uid] Hardcode UuidV3 & UuidV5 TYPE conditional constants
  [Uid] Use the Uuid constructor when reconstructing an Ulid from its RFC-4122 version
  stop using void in test files
  parse cookie values containing the equal sign
  make some time dependent tests more resilient
  fix code style
  Remove full head content in HTML to text converter
  do not break when loading schemas from network paths on Windows
  apply the sort callback on the whole search result
2021-01-05 20:51:30 +01:00
Christian Flothmann
d3739d4482 Merge branch '5.1' into 5.2
* 5.1:
  parse cookie values containing the equal sign
  make some time dependent tests more resilient
  do not break when loading schemas from network paths on Windows
2021-01-05 20:50:41 +01:00
Christian Flothmann
cd1361b059 Merge branch '4.4' into 5.1
* 4.4:
  parse cookie values containing the equal sign
  make some time dependent tests more resilient
  do not break when loading schemas from network paths on Windows
2021-01-05 20:49:26 +01:00
Christian Flothmann
900cb0eece Merge branch '5.1' into 5.2
* 5.1:
  fix code style
  Remove full head content in HTML to text converter
  apply the sort callback on the whole search result
2021-01-05 16:30:03 +01:00
Christian Flothmann
d4620a7d51 minor #39714 fix code style (xabbuh)
This PR was merged into the 5.1 branch.

Discussion
----------

fix code style

| Q             | A
| ------------- | ---
| Branch?       | 5.1
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

08fb696dbc fix code style
2021-01-05 16:28:24 +01:00
Christian Flothmann
08fb696dbc fix code style 2021-01-05 08:52:01 +01:00
Christian Flothmann
acbafe889d do not break when loading schemas from network paths on Windows 2021-01-04 20:26:31 +01:00
Nicolas Grekas
17eaad20d1 Merge branch '5.2' into 5.x
* 5.2:
  Cleanup CI scripts
  use the clock mock to make test more resilient
  fix code style
  fix code style
  take query and request parameters into account when matching routes
  mistake
  throw type error when incompatible types are passed
  fix tests to run assertions on returned Crawler instances
  [FrameworkBundle] Fix UidNormalizer priority
  propagate groups to nested constraints
2021-01-04 19:20:06 +01:00
Nicolas Grekas
51d2da706e Merge branch '5.1' into 5.2
* 5.1:
  Cleanup CI scripts
  fix code style
  fix code style
  take query and request parameters into account when matching routes
  mistake
  fix tests to run assertions on returned Crawler instances
  propagate groups to nested constraints
2021-01-04 18:59:10 +01:00
Christian Flothmann
87b1e11ebb Merge branch '4.4' into 5.1
* 4.4:
  Cleanup CI scripts
  fix code style
  fix code style
  take query and request parameters into account when matching routes
  mistake
  fix tests to run assertions on returned Crawler instances
2021-01-04 18:34:17 +01:00
Christian Flothmann
89fedfa9e9 fix code style 2021-01-04 16:15:05 +01:00
Fabien Potencier
782ed1019f Merge branch '5.2' into 5.x
* 5.2:
  Bump license year
  Bump license year
  Bump license year
  [Form] fix passing null $pattern to IntlDateFormatter
  [Notifier] Add missing LICENSE file
  Add reference link
  [Validator] Update Isin message to match the translation files.
  Update README.md
  Add AuthenticationTokenCreatedEvent to be propagated
2021-01-01 10:27:20 +01:00
Fabien Potencier
2a1a4e7067 Merge branch '5.1' into 5.2
* 5.1:
  Bump license year
  Bump license year
  [Form] fix passing null $pattern to IntlDateFormatter
  Add reference link
  Update README.md
2021-01-01 10:26:45 +01:00
Fabien Potencier
f4ca745086 Merge branch '4.4' into 5.1
* 4.4:
  Bump license year
  [Form] fix passing null $pattern to IntlDateFormatter
  Update README.md
2021-01-01 10:25:51 +01:00
Fabien Potencier
2c4337ae5b Bump license year 2021-01-01 10:24:35 +01:00
Alexander M. Turek
4a053e5fed Merge branch '5.2' into 5.x
* 5.2:
  CS: Apply ternary_to_null_coalescing fixer
2020-12-27 14:21:48 +01:00
Alexander M. Turek
6bf07f2bc9 Merge branch '5.1' into 5.2
* 5.1:
  CS: Apply ternary_to_null_coalescing fixer
2020-12-27 14:15:00 +01:00
Alexander M. Turek
eb4b003bc1 Merge branch '4.4' into 5.1
* 4.4:
  CS: Apply ternary_to_null_coalescing fixer
2020-12-27 14:04:50 +01:00
Alexander M. Turek
07c4773d98 CS: Apply ternary_to_null_coalescing fixer 2020-12-27 00:49:32 +01:00
Nicolas Grekas
b3de641fd4 Merge branch '5.2' into 5.x
* 5.2:
  [Security] Fix event propagation for globally registered security events
  Add missing `@return` annotations to fix deprecations on PHP 8
  [ProxyManagerBridge] fix PHP notice, switch to "friendsofphp/proxy-manager-lts"
  allow null values in form helpers
  Add RememberMe Badge to LoginLinkAuthenticator
2020-12-23 16:46:09 +01:00
Nicolas Grekas
b53600d89b Merge branch '5.1' into 5.2
* 5.1:
  [Security] Fix event propagation for globally registered security events
  Add missing `@return` annotations to fix deprecations on PHP 8
  [ProxyManagerBridge] fix PHP notice, switch to "friendsofphp/proxy-manager-lts"
2020-12-23 16:38:30 +01:00
Nicolas Grekas
c1cb43e2c2 Merge branch '4.4' into 5.1
* 4.4:
  Add missing `@return` annotations to fix deprecations on PHP 8
  [ProxyManagerBridge] fix PHP notice, switch to "friendsofphp/proxy-manager-lts"
2020-12-23 16:26:14 +01:00
Nicolas Grekas
3ffe5573e9 Add missing @return annotations to fix deprecations on PHP 8 2020-12-23 16:11:26 +01:00
Fabien Potencier
e2fa4bf1f3 Merge branch '5.2' into 5.x
* 5.2:
  Remove :void in test function signatures
2020-12-18 09:03:24 +01:00
Fabien Potencier
9e87661911 Merge branch '5.1' into 5.2
* 5.1:
  Remove :void in test function signatures
2020-12-18 09:03:05 +01:00
Fabien Potencier
090b4256f0 Merge branch '4.4' into 5.1
* 4.4:
  Remove :void in test function signatures
2020-12-18 09:02:46 +01:00
Fabien Potencier
47fcf4ad5a Remove :void in test function signatures 2020-12-18 08:41:31 +01:00
Fabien Potencier
bcd79d1adb Merge branch '5.2' into 5.x
* 5.2:
  Remove void return type from test methods
  Added basque translations
  Updated Luxembourgish translations
  [Mailer] Fix parsing Dsn with empty user/password
  Normalize exceptions messages containing methods references
  [Ldap] Incorrect determination of RelativeDistinguishedName for the "move" operation
2020-12-18 08:32:43 +01:00
Fabien Potencier
7d5ddc756c Merge branch '5.1' into 5.2
* 5.1:
  Remove void return type from test methods
  Added basque translations
  Updated Luxembourgish translations
  [Mailer] Fix parsing Dsn with empty user/password
  Normalize exceptions messages containing methods references
  [Ldap] Incorrect determination of RelativeDistinguishedName for the "move" operation
2020-12-18 08:32:35 +01:00
Fabien Potencier
0dc2d55537 Merge branch '4.4' into 5.1
* 4.4:
  Remove void return type from test methods
  Added basque translations
  Updated Luxembourgish translations
  [Mailer] Fix parsing Dsn with empty user/password
  Normalize exceptions messages containing methods references
  [Ldap] Incorrect determination of RelativeDistinguishedName for the "move" operation
2020-12-18 08:32:24 +01:00
Maxime Steinhausser
e2da2acd6d Normalize exceptions messages containing methods references 2020-12-17 14:33:54 +01:00
Nicolas Grekas
e4febad057 Merge branch '5.2' into 5.x
* 5.2:
  Fix licence
  Fix CS in link binary
  [Cache] remove no-op
  Fix CS in Changelogs
  [Notifier][Sinch] Add tests
  [Notifier] [Nexmo] Add tests
  [Notifier][OvhCloud] Add tests
  [Notifier] [Free Mobile] Rename method to match other bridges
  [Cache] fix setting "read_timeout" when using Redis
  Fix CS in changelogs
  [Notifier] Streamline README files
2020-12-10 21:00:07 +01:00
Alexander M. Turek
e4f757d948 Merge branch '5.1' into 5.2
* 5.1:
  Fix licence
  Fix CS in link binary
  [Cache] remove no-op
  Fix CS in Changelogs
  [Notifier][Sinch] Add tests
  [Notifier] [Nexmo] Add tests
  [Notifier][OvhCloud] Add tests
  [Notifier] [Free Mobile] Rename method to match other bridges
  [Cache] fix setting "read_timeout" when using Redis
  Fix CS in changelogs
  [Notifier] Streamline README files
2020-12-10 20:16:15 +01:00
Nicolas Grekas
bec247dbc7 Merge branch '4.4' into 5.1
* 4.4:
  [Cache] fix setting "read_timeout" when using Redis
  Fix CS in changelogs
2020-12-10 18:44:54 +01:00
Jérémy Derussé
a46cff26c6
Fix CS in changelogs 2020-12-10 17:34:26 +01:00
Alexander M. Turek
19b20abf46 Merge branch '5.2' into 5.x
* 5.2:
  Fix content swallowed by AsyncClient initializer
  [Serializer][Validator] Mention annotation loaders handle PHP8 attributes
  [Notifier] [Twilio] Fix tests
  [Cache] Prevent notice on case matching metadata trick
  [Notifier][Slack] Remove :void from test methods
  Fix CS
  [Notifier][Discord] Make webhookId argument required
  [DoctrineBridge] no-op RegisterUidTypePass if DBAL types aren't loaded
  [Notifier] Remove @internal annotation from notifier transports
  [Notifier] Remove @internal annotation from notifier transports
  [Notifier][Twilio] Add tests
  [Notifier][Free Mobile] Tests
  [DI] The default index method wasn't used if the "index_by" attribute is missing
2020-12-10 15:19:48 +01:00
Alexander M. Turek
4f08a8a0dd Merge branch '5.1' into 5.2
* 5.1:
  [Notifier] [Twilio] Fix tests
  [Cache] Prevent notice on case matching metadata trick
  [Notifier][Slack] Remove :void from test methods
  [Notifier] Remove @internal annotation from notifier transports
  [Notifier][Twilio] Add tests
  [Notifier][Free Mobile] Tests
  [DI] The default index method wasn't used if the "index_by" attribute is missing
2020-12-10 15:02:11 +01:00
Alexander M. Turek
651bd12d75 Merge branch '4.4' into 5.1
* 4.4:
  [Cache] Prevent notice on case matching metadata trick
  [DI] The default index method wasn't used if the "index_by" attribute is missing
2020-12-10 14:41:20 +01:00
Fabien Potencier
2dd4561d3f bug #39203 [DI] Fix not working if only "default_index_method" used (malteschlueter)
This PR was merged into the 4.4 branch.

Discussion
----------

[DI] Fix not working if only "default_index_method" used

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #35349
| License       | MIT

The default index method wasn't used if the "index_by" attribute is missing. The documentation is showing an example, see https://symfony.com/doc/current/service_container/tags.html#tagged-services-with-index.

This problem also appears in symfony 5.

I created two example projects, the first in the current behaviour and the second with my bugfix branch.

Current 4.4: https://github.com/malteschlueter/symfony-reproducers/blob/bugfix/dependency-injection-default-index-method-not-working--not-fixed/tests/HandlerCollectionTest.php

This bugfix branch: https://github.com/malteschlueter/symfony-reproducers/blob/bugfix/dependency-injection-default-index-method-not-working--with-fix/tests/HandlerCollectionTest.php

Commits
-------

eb25d5c275 [DI] The default index method wasn't used if the "index_by" attribute is missing
2020-12-10 08:05:48 +01:00
Nicolas Grekas
e6f1136c2b Merge branch '5.2' into 5.x
* 5.2:
  Update .php_cs.dist
  Apply "visibility_required" CS rule to constants
2020-12-08 18:04:48 +01:00
Nicolas Grekas
555697df61 Merge branch '5.1' into 5.2
* 5.1:
  Update .php_cs.dist
  Apply "visibility_required" CS rule to constants
2020-12-08 18:03:37 +01:00
Nicolas Grekas
a8b992f8a2 Merge branch '4.4' into 5.1
* 4.4:
  Update .php_cs.dist
  Apply "visibility_required" CS rule to constants
2020-12-08 18:02:38 +01:00
Nicolas Grekas
ff22d30cb0 Apply "visibility_required" CS rule to constants
php-cs-fixer fix --rules='{"visibility_required": ["property", "method", "const"]}'
2020-12-08 17:59:59 +01:00
Nicolas Grekas
be5f6e52ca Merge branch '5.2' into 5.x
* 5.2:
  minor cs fix
  [Config][TwigBundle] Fixed syntax error in config
  [DI] Fix Xdebug 3.0 detection
  Use php8 stable
  [Notifier] Streamline changelogs of notifier bridges
  [Cache] Fixed incorrect usage of UNLINK with PHPRedis with Redis < 4.0
  fix lowest required HttpFoundation component
  [Cache] fix checking for redis_sentinel support
  [Messenger] Fixed wording in php doc
  fix LDAP-based HTTP Basic Auth entry point registration
  [Intl] Update the ICU data to 68.1
  [FrameworkBundle] acces public-deprecated services via the private container to remove false-positive deprecations
  Remove unused @throws tags and handling of never thrown exceptions
  [PhpUnitBridge] Fix disabling DeprecationErrorHandler from phpunit configuration file
2020-12-08 17:44:35 +01:00
Nicolas Grekas
f37f56c1bb Merge branch '5.1' into 5.2
* 5.1:
  minor cs fix
  [Config][TwigBundle] Fixed syntax error in config
  [DI] Fix Xdebug 3.0 detection
  Use php8 stable
  [Notifier] Streamline changelogs of notifier bridges
  [Cache] fix checking for redis_sentinel support
  [Messenger] Fixed wording in php doc
  [Intl] Update the ICU data to 68.1
  [FrameworkBundle] acces public-deprecated services via the private container to remove false-positive deprecations
  Remove unused @throws tags and handling of never thrown exceptions
  [PhpUnitBridge] Fix disabling DeprecationErrorHandler from phpunit configuration file
2020-12-08 17:43:38 +01:00
Nicolas Grekas
a2f073472f Merge branch '4.4' into 5.1
* 4.4:
  minor cs fix
  [Config][TwigBundle] Fixed syntax error in config
  [DI] Fix Xdebug 3.0 detection
  Use php8 stable
  [Cache] fix checking for redis_sentinel support
  [Intl] Update the ICU data to 68.1
  Remove unused @throws tags and handling of never thrown exceptions
  [PhpUnitBridge] Fix disabling DeprecationErrorHandler from phpunit configuration file
2020-12-08 17:43:25 +01:00
Malte Schlüter
eb25d5c275 [DI] The default index method wasn't used if the "index_by" attribute is missing 2020-12-08 17:11:59 +01:00
Nicolas Grekas
a7fcb0b84e minor cs fix 2020-12-08 15:13:31 +01:00
Nicolas Grekas
891e2afb64 bug #39196 [DI] Fix Xdebug 3.0 detection (vertexvaar)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[DI] Fix Xdebug 3.0 detection

| Q             | A
| ------------- | ---
| Branch?       | 4.4 (for bug fixes)
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39195
| License       | MIT
| Doc PR        | n/a

Xdebug 3.0 removed the function `xdebug_is_enabled()`. To detect if Xdebug 3.0 is installed (it doesn't even need to be enabled to reproduce the bug) i added `function_exists('xdebug_info')`. AFAIS `xdebug_info()` is available in Xdebug >= 3.0 only.

Commits
-------

38f8edddb1 [DI] Fix Xdebug 3.0 detection
2020-12-08 15:03:26 +01:00
Oliver Eglseder
38f8edddb1 [DI] Fix Xdebug 3.0 detection 2020-12-08 15:03:00 +01:00
Alexander M. Turek
ffab85c8c0 Merge branch '5.2' into 5.x
* 5.2:
  [Notifier] Fix tests with PHPUnit 9.5.
  Fix merge.
  Fix CS
  [Messenger] Test generated SQL
  [Config] YamlReferenceDumper: No default value required for VariableNode with array example
  Remove PHPUnit configuration files from components without tests.
  [DependencyInjection] Fix container linter for union types.
2020-12-05 20:10:20 +01:00
Alexander M. Turek
dbc1db21cd Merge branch '5.1' into 5.2
* 5.1:
  Fix merge.
  Fix CS
  [Messenger] Test generated SQL
  [Config] YamlReferenceDumper: No default value required for VariableNode with array example
  Remove PHPUnit configuration files from components without tests.
  [DependencyInjection] Fix container linter for union types.
2020-12-05 19:32:58 +01:00
Alexander M. Turek
7c31fa0537 Fix merge. 2020-12-05 19:20:45 +01:00
Alexander M. Turek
f13821e881 Merge branch '4.4' into 5.1 2020-12-05 18:55:33 +01:00
Fabien Potencier
bda2dcdf93 bug #39251 [DependencyInjection] Fix container linter for union types (derrabus)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Fix container linter for union types

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39233
| License       | MIT
| Doc PR        | N/A

Commits
-------

e26893b122 [DependencyInjection] Fix container linter for union types.
2020-12-05 18:12:03 +01:00
Alexander M. Turek
de0dbd88d2 [DependencyInjection] Add missing parameter type declarations to loader classes. 2020-12-05 12:11:23 +01:00
Alexander M. Turek
2b36487983 Merge branch '5.1' into 5.2
* 5.1:
  [DependencyInjection] Fixed incorrect report for private services if required service does not exist
  Remove Xdebug from php-extra runs.
2020-12-03 10:29:40 +01:00
Alexander M. Turek
2d062df845 Merge branch '4.4' into 5.1
* 4.4:
  [DependencyInjection] Fixed incorrect report for private services if required service does not exist
  Remove Xdebug from php-extra runs.
2020-12-03 10:18:36 +01:00
Islam Israfilov (Islam93)
39bd05c5bc [DependencyInjection] Fixed incorrect report for private services if required service does not exist 2020-12-03 02:30:23 +01:00
Alexander M. Turek
e26893b122 [DependencyInjection] Fix container linter for union types. 2020-11-30 22:45:46 +01:00
Alexander M. Turek
fd05da651b Merge branch '5.1' into 5.2
* 5.1:
  Fix parameter order
  [DependencyInjection] Fix circular in DI with lazy + byContruct loop
  adjust Client::getProfile() typehint
  adjust KernelBrowser::getProfile() typehint
  fix: resolving pt translation issues
  Update VERSION for 3.4.47
  Update CONTRIBUTORS for 3.4.47
  Update CHANGELOG for 3.4.47
  Add Romanian missing translations
  [DependencyInjection][Translator] Silent deprecation triggered by libxml_disable_entity_loader
  fix lexing strings containing escaped quotation characters
  prevent duplicated error message for file upload limits
  ignore the pattern attribute for textareas
  fix: solving pt-br translation issues
2020-11-28 12:24:18 +01:00
Alexander M. Turek
e70ccfe55d Merge branch '4.4' into 5.1
* 4.4:
  Fix parameter order
  [DependencyInjection] Fix circular in DI with lazy + byContruct loop
  adjust Client::getProfile() typehint
  fix: resolving pt translation issues
  Update VERSION for 3.4.47
  Update CONTRIBUTORS for 3.4.47
  Update CHANGELOG for 3.4.47
  Add Romanian missing translations
  [DependencyInjection][Translator] Silent deprecation triggered by libxml_disable_entity_loader
  fix lexing strings containing escaped quotation characters
  prevent duplicated error message for file upload limits
  ignore the pattern attribute for textareas
  fix: solving pt-br translation issues
2020-11-28 11:57:20 +01:00
Nicolas Grekas
7d7fa3e822 bug #39129 [DependencyInjection] Fix circular in DI with lazy + byContruct loop (jderusse)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] Fix circular in DI with lazy + byContruct loop

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39120
| License       | MIT
| Doc PR        | -

This fix another issue lazy service.
It partially revert #38980 and #39021

Initially, we trusted lazy services to be lazy and not beeing called while building the services graph
=> bug #38970 when lazy deps is injected in a factory, it may be consumed directly to build the object before the graph is fully built
Fixed by #38980 => lazy service are considered as "normal service"
=> bug #39015 some loop are not resolvable with "normal service", but it shouldn't be an issue when servie proxifyied
Fixed by #39021 => lazy service are considered as "normal service" except when proxyfied
=> bug #39120 some loop are not resolvable with "normal service", but it shouldn't be an issue because the lazy service is injected in the constructor and user

Fixed by this PR => that revert to the initial state. lazy service are trusted.
But now, The IterratorArgument injected in a factory (single exception) is not more considered as lazy

Commits
-------

54af139a4e [DependencyInjection] Fix circular in DI with lazy + byContruct loop
2020-11-27 16:54:06 +01:00
Jérémy Derussé
54af139a4e [DependencyInjection] Fix circular in DI with lazy + byContruct loop 2020-11-27 16:54:00 +01:00
Fabien Potencier
6db84b6ae9 bug #39068 [DependencyInjection][Translator] Silent deprecation triggered by libxml_disable_entity_loader (jderusse)
This PR was squashed before being merged into the 4.4 branch.

Discussion
----------

[DependencyInjection][Translator] Silent deprecation triggered by libxml_disable_entity_loader

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #39040
| License       | MIT
| Doc PR        | -

The XML entity loader is disabled by default since libxml 2.9
But, since PHP 8.0, calling the method `libxml_disable_entity_loader` triggers a deprecation which has been solved in symfony by calling `libxml_disable_entity_loader` only for libxml < 2.9

The issue is, some dependencies, enable the entity loader and does not restore the initial state afterward, leading to exceptions triggered by Symfony iteself.

In previous versions symfony was resilient by disabling the flag before working, which is not the case anymore to avoid the deprecation.

This PR restore the resiliency of Symfony for PHP < 8.0, which is not yet deprecated.

But we have no way to check the status of the entity loader without triggering a deprecation with Symfony 8.

Commits
-------

114b7a543a [DependencyInjection][Translator] Silent deprecation triggered by libxml_disable_entity_loader
2020-11-27 07:35:58 +01:00
Jérémy Derussé
114b7a543a [DependencyInjection][Translator] Silent deprecation triggered by libxml_disable_entity_loader 2020-11-27 07:35:49 +01:00
Christian Flothmann
cc130e1d9c Merge branch '5.1' into 5.2
* 5.1:
  prevent hash collisions caused by reused object hashes
  autoconfigure behavior describing tags on decorators
  [Validator][RecursiveContextualValidator] Prevent validated hash collisions
2020-11-13 10:44:33 +01:00
Christian Flothmann
355f18d34d Merge branch '4.4' into 5.1
* 4.4:
  prevent hash collisions caused by reused object hashes
  autoconfigure behavior describing tags on decorators
  [Validator][RecursiveContextualValidator] Prevent validated hash collisions
2020-11-13 10:37:26 +01:00
Christian Flothmann
3834d76e11 bug #38999 [DependencyInjection] autoconfigure behavior describing tags on decorators (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] autoconfigure behavior describing tags on decorators

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | yes
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

73a3b838b7 autoconfigure behavior describing tags on decorators
2020-11-13 10:27:22 +01:00
Christian Flothmann
73a3b838b7 autoconfigure behavior describing tags on decorators 2020-11-13 10:09:04 +01:00
Alexander M. Turek
873b0b4f53 Merge branch '5.1' into 5.2
* 5.1:
  Add tests on CacheDataCollector
  [ProxyManagerBridge] fix tests
  [ProxyManagerBridge] relax fixture in tests
  Fix circular detection with multiple paths
2020-11-12 23:35:35 +01:00
Alexander M. Turek
b8afc7cba3 Merge branch '4.4' into 5.1
* 4.4:
  Add tests on CacheDataCollector
  [ProxyManagerBridge] fix tests
  [ProxyManagerBridge] relax fixture in tests
  Fix circular detection with multiple paths
2020-11-12 23:25:33 +01:00
Jérémy Derussé
1c3721e8ad
Fix circular detection with multiple paths 2020-11-11 19:26:13 +01:00
Fabien Potencier
2994ef0e1a Merge branch '5.1' into 5.x
* 5.1:
  Optimize circular collection by removing flattening
2020-11-09 13:21:52 +01:00
Fabien Potencier
382d6fc696 Merge branch '4.4' into 5.1
* 4.4:
  Optimize circular collection by removing flattening
2020-11-09 13:21:43 +01:00
Jérémy Derussé
e649f47726
Optimize circular collection by removing flattening 2020-11-09 12:28:57 +01:00
Alexander M. Turek
5f25a6f980 Merge branch '5.1' into 5.x 2020-11-05 21:05:54 +01:00
Alexander M. Turek
2081035295 Merge branch '4.4' into 5.1 2020-11-05 20:04:46 +01:00
Jérémy Derussé
51ff060603
Fix circular referene with Factory and LazyIterator 2020-11-04 15:21:44 +01:00
Nicolas Grekas
5bf6bbe96c Merge branch '5.1' into 5.x
* 5.1:
  [Process] Dont test TTY if there is no TTY support
  Fixing some Mongolian
  translating the validators for european portuguese language
  Fix CI
  Update validators.he.xlf
  Update security.he.xlf
  Update validators.he.xlf
  Improve performances in CircualReference detection
  [PHPUnitBridge] Fixed crash on Windows with PHP 8
  Fix session called initized several time
2020-11-02 16:47:15 +01:00
Nicolas Grekas
aae9211e7c Merge branch '4.4' into 5.1
* 4.4:
  [Process] Dont test TTY if there is no TTY support
  Fixing some Mongolian
  translating the validators for european portuguese language
  Fix CI
  Update validators.he.xlf
  Update security.he.xlf
  Update validators.he.xlf
  Improve performances in CircualReference detection
  [PHPUnitBridge] Fixed crash on Windows with PHP 8
  Fix session called initized several time
2020-11-02 16:45:32 +01:00
Jérémy Derussé
d4db75692b
Improve performances in CircualReference detection 2020-10-31 17:09:50 +01:00
Alexander M. Turek
0fee41a617 Merge branch '5.1' into 5.x 2020-10-28 22:46:03 +01:00
Alexander M. Turek
53f7f5f27e Fix CS 2020-10-28 22:33:29 +01:00
Alexander M. Turek
294cffea25 Merge branch '4.4' into 5.1 2020-10-28 22:31:18 +01:00
Alexander M. Turek
659decf594 Use short array deconstruction syntax. 2020-10-28 21:42:29 +01:00
Nicolas Grekas
d5118933ed Merge branch '5.1' into 5.x
* 5.1:
  [DI] Fix Preloader exception when preloading a class with an unknown parent/interface
  [Translation] added missing Albanian translations
  [Form, Security, Validator] Add missing Turkish translations (tr)
  Display php info for extra versions in travis
  [ProxyManager] use "composer/package-versions-deprecated" instead of "ocramius/package-versions"
  38737 add missing dutch translation
  Fix transient tests
  [Validator] Add missing Slovak translations.
  [Form, Security, Validator] Add missing Persian translations (fa_IR)
  [Form] Fix wrong translations for Ukrainian (uk)
  [Validator] Add missing translations for Ukrainian (uk)
  [Security] Add missing translations for Ukrainian (uk)
  [Form] Add missing translations for Ukrainian (uk)
  [Security] Add missing Slovak translations.
  [Form] Added missing Spanish translations.
  Fix transient tests
2020-10-27 11:14:44 +01:00
Nicolas Grekas
8810d2da62 Merge branch '4.4' into 5.1
* 4.4:
  [DI] Fix Preloader exception when preloading a class with an unknown parent/interface
  [Translation] added missing Albanian translations
  [Form, Security, Validator] Add missing Turkish translations (tr)
  Display php info for extra versions in travis
  [ProxyManager] use "composer/package-versions-deprecated" instead of "ocramius/package-versions"
  38737 add missing dutch translation
  Fix transient tests
  [Validator] Add missing Slovak translations.
  [Form, Security, Validator] Add missing Persian translations (fa_IR)
  [Form] Fix wrong translations for Ukrainian (uk)
  [Validator] Add missing translations for Ukrainian (uk)
  [Security] Add missing translations for Ukrainian (uk)
  [Form] Add missing translations for Ukrainian (uk)
  [Security] Add missing Slovak translations.
  [Form] Added missing Spanish translations.
  Fix transient tests
2020-10-27 11:11:13 +01:00
Randy Geraads
b6ae4858b9 [DI] Fix Preloader exception when preloading a class with an unknown parent/interface 2020-10-27 11:05:40 +01:00
Nicolas Grekas
605a5674a8 Merge branch '5.1' into 5.x
* 5.1:
  fix merge
  fix merge
  Remove branch-version (keep them for contracts only)
  [HttpClient] relax auth bearer format requirements
  [PHPUnitBridge] Silence errors from mkdir()
  [DependencyInjection] Preload classes with union types correctly.
  [Serializer] fix decoding float XML attributes starting with 0
  add missing dutch translations
  [TwigBridge] Remove "transchoice" from the code base
  Support PHPUnit 8 and PHPUnit 9 in constraint compatibility trait
  Add expectDeprecation, expectNotice, expectWarning, and expectError to TestCase polyfill
  [String] fix before/after[Last]() returning the empty string instead of the original one on non-match
  Add missing exporter function for PHPUnit 7
  [Validator] Add missing romanian translations
  [String] fix slicing in UnicodeString
  [Cache] Use correct expiry in ChainAdapter
  do not translate null placeholders or titles
2020-10-24 14:08:07 +02:00
Nicolas Grekas
65f2620bc4 Merge branch '4.4' into 5.1
* 4.4:
  fix merge
  Remove branch-version (keep them for contracts only)
  [HttpClient] relax auth bearer format requirements
  [PHPUnitBridge] Silence errors from mkdir()
  [DependencyInjection] Preload classes with union types correctly.
  [Serializer] fix decoding float XML attributes starting with 0
  add missing dutch translations
  Support PHPUnit 8 and PHPUnit 9 in constraint compatibility trait
  Add expectDeprecation, expectNotice, expectWarning, and expectError to TestCase polyfill
  Add missing exporter function for PHPUnit 7
  [Validator] Add missing romanian translations
  [Cache] Use correct expiry in ChainAdapter
  do not translate null placeholders or titles
2020-10-24 14:01:57 +02:00
Nicolas Grekas
77aa17401d Merge branch '3.4' into 4.4
* 3.4:
  Remove branch-version (keep them for contracts only)
  [Serializer] fix decoding float XML attributes starting with 0
  add missing dutch translations
  [Validator] Add missing romanian translations
  do not translate null placeholders or titles
2020-10-24 13:50:19 +02:00
Nicolas Grekas
f8fe4bf9f5 Remove branch-version (keep them for contracts only) 2020-10-24 12:57:07 +02:00
Alexander M. Turek
a7b0f16a56 [DependencyInjection] Preload classes with union types correctly. 2020-10-23 19:57:28 +02:00
Alexander M. Turek
e6417384d2 Merge branch '5.1' into 5.x 2020-10-20 22:28:53 +02:00
Alexander M. Turek
1c6380f333 Merge branch '4.4' into 5.1 2020-10-20 22:28:16 +02:00
Nicolas Grekas
c8c227f43f Merge branch '3.4' into 4.4
* 3.4:
  [Form] Sync translations
  Added dutch translations for new invalid messages
  Don't skip Doctrine tests on php 8.
  Bump APCu to 5.1.19 on Travis.
  [WebProfilerBundle] Hide debug toolbar in print view
  indexBy does not refer to attributes, but to column names
  Fix Reflection file name with eval()\'d code
  [HttpFoundation] Fix Range Requests
2020-10-20 13:58:22 +02:00
Maxime Aknin
394a694856 Fix Reflection file name with eval()\'d code
remove eval()\'d code from lineage
2020-10-15 10:31:43 +02:00
Nyholm
efef41faa1
[CI] Silence errors when remove file/dir on test tearDown() 2020-10-14 09:00:24 +02:00
Nicolas Grekas
01b064d97a Merge branch '5.1' into 5.x
* 5.1:
  Fix branch-version
2020-10-13 15:22:54 +02:00
Nicolas Grekas
1a0ea4d2f7 Merge branch '4.4' into 5.1
* 4.4:
  Fix branch-version
2020-10-13 15:21:37 +02:00
Nicolas Grekas
58f803f356 Merge branch '3.4' into 4.4
* 3.4:
  Fix branch-version
2020-10-13 15:20:53 +02:00
Nicolas Grekas
44a7e3e920 Fix branch-version 2020-10-13 15:20:16 +02:00
Nicolas Grekas
7f0015ee35 Merge branch '5.1' into 5.x
* 5.1:
  Remove "version" from composer.json files, use "branch-version" instead
  [String] fix "is too large" ValueError on PHP 8
2020-10-13 14:43:06 +02:00
Nicolas Grekas
23ab908213 Merge branch '4.4' into 5.1
* 4.4:
  Remove "version" from composer.json files, use "branch-version" instead
2020-10-13 14:35:38 +02:00
Nicolas Grekas
e953dd3e0d Merge branch '3.4' into 4.4
* 3.4:
  Remove "version" from composer.json files, use "branch-version" instead
2020-10-13 14:30:56 +02:00
Nicolas Grekas
f9ed6940fd Remove "version" from composer.json files, use "branch-version" instead 2020-10-13 14:21:16 +02:00
Nicolas Grekas
5baa123aac Merge branch '5.1' into 5.x
* 5.1:
  [DI] fix dumping env vars
  [HttpClient] skip executing the multi handle when it's freed already
  [HttpClient] fix using freed curl resource at destruct time
  [HttpClient] shutdown verbose output from curl at destruction
  fix warning for preloading TranslatorTrait class
  [Typography] Remove unneeded description comments
2020-10-13 13:14:51 +02:00
Nicolas Grekas
63288a6e2e Merge branch '4.4' into 5.1
* 4.4:
  [DI] fix dumping env vars
  [HttpClient] skip executing the multi handle when it's freed already
  [HttpClient] fix using freed curl resource at destruct time
  [HttpClient] shutdown verbose output from curl at destruction
  fix warning for preloading TranslatorTrait class
  [Typography] Remove unneeded description comments
2020-10-13 13:14:18 +02:00
Nicolas Grekas
746a8d1a09 [DI] fix dumping env vars 2020-10-13 11:53:00 +02:00
Nicolas Grekas
6066462be2 Merge branch '5.1' into 5.x
* 5.1:
  Update versions in composer.json
  [Mime] Fix serialization of RawMessage
2020-10-06 17:53:16 +02:00
Nicolas Grekas
3e492d6e5d Merge branch '4.4' into 5.1
* 4.4:
  Update versions in composer.json
  [Mime] Fix serialization of RawMessage
2020-10-06 17:50:31 +02:00
Nicolas Grekas
55396f90a3 Merge branch '3.4' into 4.4
* 3.4:
  Update versions in composer.json
2020-10-06 17:45:41 +02:00
Nicolas Grekas
8f714a2fd6 Update versions in composer.json 2020-10-06 17:25:25 +02:00
Nicolas Grekas
11c4f28137 Merge branch '5.1' into 5.x
* 5.1:
  fix merge
  [appveyor] fix checking for the .x branch
  Remove "branch-alias", populate "version"
2020-10-06 14:00:29 +02:00
Nicolas Grekas
097c8c6f27 Merge branch '4.4' into 5.1
* 4.4:
  [appveyor] fix checking for the .x branch
  Remove "branch-alias", populate "version"
2020-10-06 13:49:34 +02:00
Nicolas Grekas
e553f424d0 Merge branch '3.4' into 4.4
* 3.4:
  Remove "branch-alias", populate "version"
2020-10-06 13:41:17 +02:00
Nicolas Grekas
9d40c796c4 Remove "branch-alias", populate "version" 2020-10-06 13:22:52 +02:00
Nicolas Grekas
73ca97c97a Merge branch '5.1'
* 5.1:
  [HttpClient] fix using proxies with NativeHttpClient
  [4.4] Ignore more deprecations for Mockery mocks
  [Routing] fix using !important and defaults/reqs in inline route definitions
  [ErrorHandler][DebugClassLoader] Do not check Mockery mocks classes
  [HttpClient] Fix using https with proxies
  [TwigBundle] Only remove kernel exception listener if twig is used
  [DI] Fix changelog
  Remove CHANGELOG files for 4.x
  Adjust expired range check
  Fix redis connection error message
  [DI] fix dumping non-shared lazy services
2020-10-02 10:56:13 +02:00
Roland Franssen
d784b50da3
[DI] Fix changelog 2020-10-01 14:14:45 +02:00
Nicolas Grekas
e33a0b0f94 [DI] fix dumping non-shared lazy services 2020-09-30 17:55:21 +02:00
Alexander M. Turek
14642fb6dd Added missing changelog entries. 2020-09-18 12:11:46 +02:00
Christian Flothmann
6d5617d08d Merge branch '5.1' into master
* 5.1:
  fix merge
  [Cache] fix previous PR
  add mising sr (latn & cyrl) translations
  [Cache] fix ProxyAdapter not persisting items with infinite expiration
  [HttpClient] fail properly when the server replies with HTTP/0.9
  Fix CS
  [Cache] Limit cache version character range
  [Mailer] Fixed Mailgun API bridge JsonException when API response is not applicaton/json
  [String] improve fix
  fix tests
  [DI] dump OS-indepent paths in the compiled container
  [DI] dump OS-indepent paths in the preload file
  Run postgres setup trigger in transaction
  allow consumers to mock all methods
2020-09-11 14:25:32 +02:00
Nicolas Grekas
da71a5d933 Merge branch '4.4' into 5.1
* 4.4:
  add mising sr (latn & cyrl) translations
  [Cache] fix ProxyAdapter not persisting items with infinite expiration
  [HttpClient] fail properly when the server replies with HTTP/0.9
  Fix CS
  [Cache] Limit cache version character range
  [DI] dump OS-indepent paths in the compiled container
  allow consumers to mock all methods
2020-09-11 13:43:06 +02:00
Fabien Potencier
cc9c48fe14 Fix tests 2020-09-11 07:35:08 +02:00
Nicolas Grekas
4dcf9e7d13 [DI] dump OS-indepent paths in the compiled container 2020-09-10 12:08:39 +02:00
Nicolas Grekas
e8feba5c36 [DI] dump OS-indepent paths in the preload file 2020-09-10 11:51:08 +02:00
Nicolas Grekas
d96c7a0f40 Merge branch '5.1'
* 5.1:
  [Debug] fix test
  consistently use same types for strict comparisons
  [PhpUnitBridge] Skip internal classes in CoverageListenerTrait
  [VarExporter] unserialize() might throw an Exception on php 8.
  [SecurityHttp] Don't call createMock() with multiple interfaces.
  [ErrorHandler] Parse "x not found" errors correctly on php 8.
  Prevent parsing invalid octal digits as octal numbers
  remove unnecessary check for  existing request
  [DI] fix ContainerBuilder on PHP8
  [Console] Make sure $maxAttempts is an int or null.
  [VarDumper] Fix caster for invalid SplFileInfo objects on php 8.
  [Intl] Skip test cases that produce a TypeError on php 8.
  [PhpUnitBridge] Adjust output parsing for PHPUnit 9.3.
  [PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x
  add bosnian (bs) translation
  [Debug] Parse "x not found" errors correctly on php 8.
2020-09-08 16:20:09 +02:00
Nicolas Grekas
62a4559619 Merge branch '4.4' into 5.1
* 4.4:
  [Debug] fix test
  consistently use same types for strict comparisons
  [PhpUnitBridge] Skip internal classes in CoverageListenerTrait
  [VarExporter] unserialize() might throw an Exception on php 8.
  [ErrorHandler] Parse "x not found" errors correctly on php 8.
  Prevent parsing invalid octal digits as octal numbers
  remove unnecessary check for  existing request
  [DI] fix ContainerBuilder on PHP8
  [Console] Make sure $maxAttempts is an int or null.
  [VarDumper] Fix caster for invalid SplFileInfo objects on php 8.
  [Intl] Skip test cases that produce a TypeError on php 8.
  [PhpUnitBridge] Adjust output parsing for PHPUnit 9.3.
  [PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x
  add bosnian (bs) translation
  [Debug] Parse "x not found" errors correctly on php 8.
2020-09-08 16:19:54 +02:00
Nicolas Grekas
638f9ecc15 minor #38107 [DependencyInjection] consistently use same types for strict comparisons (xabbuh)
This PR was merged into the 4.4 branch.

Discussion
----------

[DependencyInjection] consistently use same types for strict comparisons

| Q             | A
| ------------- | ---
| Branch?       | 4.4
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       |
| License       | MIT
| Doc PR        |

Commits
-------

afc11684e0 consistently use same types for strict comparisons
2020-09-08 15:02:55 +02:00
Christian Flothmann
261a939ea6 Merge branch '3.4' into 4.4
* 3.4:
  Prevent parsing invalid octal digits as octal numbers
  [DI] fix ContainerBuilder on PHP8
  [Console] Make sure $maxAttempts is an int or null.
  [VarDumper] Fix caster for invalid SplFileInfo objects on php 8.
  [Intl] Skip test cases that produce a TypeError on php 8.
  [PhpUnitBridge] Adjust output parsing for PHPUnit 9.3.
  [PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x
  add bosnian (bs) translation
  [Debug] Parse "x not found" errors correctly on php 8.
2020-09-08 13:16:46 +02:00
Christian Flothmann
afc11684e0 consistently use same types for strict comparisons 2020-09-08 10:26:11 +02:00
Nicolas Grekas
a3275a7be9 [DI] fix ContainerBuilder on PHP8 2020-09-07 14:07:49 +02:00
Alexander M. Turek
ea262441e7 [DependencyInjection] Add the Required attribute. 2020-09-07 13:33:47 +02:00
Fabien Potencier
b89b7474ca Merge branch '5.1'
* 5.1:
  Update UPGRADE-5.1.md
  [HttpKernel] Adjust tests to new "class not found" error message format.
  Don't call createMock with an array of interfaces.
  [FrameworkBundle] Fix Tests on PHPUnit 9.3.
  [WebProfilerBundle] Fix Tests on PHPUnit 9.3.
  esmtp error not being thrown properly
  [Yaml Parser] fixed Parser to skip comments when inlining sequences
  Update Connection.php
  [DI] fix generating preload file when cache_dir is outside project_dir
  Fix CacheCollectorPass with decorated cache pools
  [PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x
  Remove invalid instantiation declaration
  [PropertyInfo] Fix typed collections in PHP 7.4
2020-09-07 07:10:36 +02:00
Fabien Potencier
0bdef0a996 Merge branch '4.4' into 5.1
* 4.4:
  [HttpKernel] Adjust tests to new "class not found" error message format.
  Don't call createMock with an array of interfaces.
  [FrameworkBundle] Fix Tests on PHPUnit 9.3.
  [WebProfilerBundle] Fix Tests on PHPUnit 9.3.
  esmtp error not being thrown properly
  [Yaml Parser] fixed Parser to skip comments when inlining sequences
  [DI] fix generating preload file when cache_dir is outside project_dir
  Fix CacheCollectorPass with decorated cache pools
  [PhpUnitBridge] CoverageListenerTrait update for PHPUnit 8.5/9.x
  Remove invalid instantiation declaration
  [PropertyInfo] Fix typed collections in PHP 7.4
2020-09-07 07:10:28 +02:00
Nicolas Grekas
02db8e1523 [DI] fix generating preload file when cache_dir is outside project_dir 2020-09-04 16:11:41 +02:00
Nicolas Grekas
4ee85e8e3b Merge branch '5.1'
* 5.1:
  Enable "native_constant_invocation" CS rule
  Make AbstractPhpFileCacheWarmer public
  Fix CS
  Add a warning comment on ldap empty password
  Bump Symfony version to 4.4.14
  Update VERSION for 4.4.13
  Update CHANGELOG for 4.4.13
  [PhpunitBridge] Fix deprecation type detection
2020-09-02 18:27:44 +02:00
Nicolas Grekas
034602699e Merge branch '4.4' into 5.1
* 4.4:
  Enable "native_constant_invocation" CS rule
  Make AbstractPhpFileCacheWarmer public
2020-09-02 18:23:27 +02:00
Nicolas Grekas
6c2a1c9a57 Merge branch '3.4' into 4.4
* 3.4:
  Enable "native_constant_invocation" CS rule
  Make AbstractPhpFileCacheWarmer public
2020-09-02 18:08:58 +02:00
Nicolas Grekas
4351a70637 Enable "native_constant_invocation" CS rule 2020-09-02 18:06:40 +02:00
Nicolas Grekas
78eca9607a Merge branch '5.1'
* 5.1:
  [DI] fix inlining of non-shared services
2020-09-01 20:07:47 +02:00
Nicolas Grekas
117317c8e3 Merge branch '4.4' into 5.1
* 4.4:
  [DI] fix inlining of non-shared services
2020-09-01 20:07:16 +02:00
Nicolas Grekas
380cb10587 [DI] fix inlining of non-shared services 2020-09-01 19:42:15 +02:00
Zmey
b5a47dac52
Missed AbstractArgument 2020-09-01 15:23:56 +03:00